chiark / gitweb /
Michal Sekletar [Thu, 13 Dec 2012 13:59:39 +0000 (14:59 +0100)]
path-util: set pointer to null after calling free()
In cases where path_strv_canonicalize() returns NULL, strv_free() is
called afterwards and it will call free() on pointers which were freed
already in path_strv_canonicalize()
Sami Kerola [Mon, 17 Dec 2012 10:13:17 +0000 (11:13 +0100)]
sd-daemon: fix cppcheck warnings
Found with 'cppcheck --enable=all --inconclusive --std=posix' while
working with util-linux, which has a copy of this file.
[misc-utils/sd-daemon.c:363]: (style) Checking if unsigned variable \
'length' is less than zero.
[misc-utils/sd-daemon.c:366]: (style) Checking if unsigned variable \
'length' is less than zero.
References: http://www.spinics.net/lists/util-linux-ng/msg07031.html
Sami Kerola [Sun, 16 Dec 2012 22:23:23 +0000 (22:23 +0000)]
licence: remove references to old FSF address
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=57206
Zbigniew Jędrzejewski-Szmek [Mon, 17 Dec 2012 10:38:47 +0000 (11:38 +0100)]
journal: move _packed_ attribute to the end
GCC manual states that "For an enum, struct or union type, you may
specify attributes either between the enum, struct or union tag and
the name of the type, or just past the closing curly brace of the
definition. The former syntax is preferred." This means that the
attribute should not be located before 'struct'. Putting it between
'struct' and the name seems cluttered. Putting it at the end seems
most readable.
This avoids clang warnings.
Richard Yao [Sun, 18 Nov 2012 19:55:10 +0000 (14:55 -0500)]
Fix "attribute 'packed' is ignored" warnings when using Clang
Clang 3.1 warned that "attribute 'packed' is ignored". This stems from
placing "__attribute__ ((packed))" at the start of structure
declarations when common practice is to place it at the end.
Signed-off-by: Richard Yao <ryao@gentoo.org>
Kay Sievers [Fri, 14 Dec 2012 17:23:36 +0000 (18:23 +0100)]
hwdb: update comments and data
Michael Terry [Fri, 14 Dec 2012 14:02:13 +0000 (09:02 -0500)]
libudev: validate 'udev' argument to udev_enumerate_new()
https://bugs.freedesktop.org/show_bug.cgi?id=58289
Tollef Fog Heen [Fri, 14 Dec 2012 08:17:14 +0000 (09:17 +0100)]
Remove frugalware display-manager.service
Frugalware are shipping their own .service file now, so stop shipping
it here.
This effectively reverts
196e3fa74a88a04b0ecec7d3af648287dd088f8a
Michal Schmidt [Wed, 12 Dec 2012 21:24:04 +0000 (22:24 +0100)]
localectl: fix dbus call arguments in set_x11_keymap
Fixes an assertion failure in the dbus lib.
https://bugzilla.redhat.com/show_bug.cgi?id=882212
Eric Benoit [Tue, 11 Dec 2012 14:32:39 +0000 (15:32 +0100)]
libudev: hwdb: add missing endianess conversion
https://bugs.freedesktop.org/show_bug.cgi?id=58067
Kay Sievers [Sun, 9 Dec 2012 13:49:28 +0000 (14:49 +0100)]
udev: net_id: update comments
Kay Sievers [Sun, 9 Dec 2012 13:48:55 +0000 (14:48 +0100)]
hwdb: update
Michal Schmidt [Fri, 7 Dec 2012 17:02:43 +0000 (18:02 +0100)]
shutdown, umount: use verbs consistently
Mounts are "unmounted".
Swaps are "deactivated", not "turned off" nor "disabled".
Loop and DM devices are "detached", not "deleted".
Especially the deleting sounded a bit scary.
Michal Schmidt [Fri, 7 Dec 2012 16:44:50 +0000 (17:44 +0100)]
shutdown, umount: logging improvements
In bugreports about hangs during the late shutdown we are often missing
important information - what were we trying to unmount/detach when it hung.
Instead of printing what we successfully unmounted, print what we are
going to unmount/detach. And add messages to mark the completion of
categories (mount/swap/loop/DM).
Michal Schmidt [Fri, 7 Dec 2012 16:34:21 +0000 (17:34 +0100)]
umount: fix check for DM changed
delete_dm() returns 0 on success. The check for "r > 0" was likely
a copy&paste error from the loopback code where "r > 0" makes sense.
Michal Schmidt [Fri, 7 Dec 2012 16:28:30 +0000 (17:28 +0100)]
shutdown: downgrade a warning
All messages of the kind "not all done, %d left" are log_info, except
the one for DM devices. Make it info too.
Kay Sievers [Thu, 6 Dec 2012 21:46:22 +0000 (22:46 +0100)]
hwdb: update
Mantas Mikulėnas [Thu, 6 Dec 2012 21:34:25 +0000 (23:34 +0200)]
hwdb: ids-update: close the right file handles
The script was closing *INP and *OUTP, which never actually existed.
Also fix pci_vendor() opening usb.ids and immediately discarding the fh.
Kay Sievers [Thu, 6 Dec 2012 20:48:49 +0000 (21:48 +0100)]
rules: usb-hid-pm - remove AMI devices
On Thu, Dec 6, 2012 at 9:20 AM, Robert Milasan <rmilasan@suse.com> wrote:
> It seems that the added rules:
>
> ACTION=="add", SUBSYSTEM=="usb", ATTR{idVendor}=="046b",
> ATTR{idProduct}=="ff10", TEST=="power/control",
> ATTR{power/control}="auto"
>
> creates problems for people with Supermicro X8ST3 mb (and maybe
> other Supermicro mb's) and renders the KVM-over-IP unusable, at BIOS
> and GRUB the KVM works perfectly, but after that the device is unusable.
>
> Dropping the rule fixes the issue.
>
> Reference bug: https://bugzilla.novell.com/show_bug.cgi?id=792576
Kay Sievers [Thu, 6 Dec 2012 20:37:10 +0000 (21:37 +0100)]
udev: net_id - fix OUI handling
Kay Sievers [Thu, 6 Dec 2012 20:27:42 +0000 (21:27 +0100)]
udev: net_id - fix typos
Kay Sievers [Thu, 6 Dec 2012 20:25:39 +0000 (21:25 +0100)]
udev: net_id - update examples
Kay Sievers [Thu, 6 Dec 2012 20:09:30 +0000 (21:09 +0100)]
udev: net_id - update examples
Kay Sievers [Thu, 6 Dec 2012 19:42:49 +0000 (20:42 +0100)]
udev: net_id - provide path names for USB devices
Michal Schmidt [Thu, 6 Dec 2012 15:20:10 +0000 (16:20 +0100)]
systemctl: verbose message on missing [Install]
People still don't understand what the message implies.
We have to be more verbose (or more intelligent and detect some of the
cases automatically, but that's not so easy).
https://bugzilla.redhat.com/show_bug.cgi?id=884438
Zbigniew Jędrzejewski-Szmek [Wed, 5 Dec 2012 10:59:05 +0000 (11:59 +0100)]
core: add catalog entry and MESSAGE_ID for overmounting
Kay Sievers [Wed, 5 Dec 2012 01:08:49 +0000 (02:08 +0100)]
build-sys: add libsystemd-daemon.la to libsystemd-core.la
https://bugs.freedesktop.org/show_bug.cgi?id=57900
Philip Nilsson [Mon, 3 Dec 2012 17:26:52 +0000 (18:26 +0100)]
man: correct documented return type for sd_journal_close
Zbigniew Jędrzejewski-Szmek [Tue, 4 Dec 2012 12:57:53 +0000 (13:57 +0100)]
modules-load: fix memory leak when bailing out
Suggested-by: Mauro Dreissig <mukadr@gmail.com>
Tom Gundersen [Mon, 3 Dec 2012 19:15:22 +0000 (20:15 +0100)]
hwdb: add IAB to the OUI database
The individual address block is a poor man's organizationally unique
identifier.
Perhaps we should change the udev key from ID_OUI_FROM_DATABASE to
something like ID_IEEE_VENDOR_FROM_DATABASE?
Suggested-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>
Umut Tezduyar [Mon, 3 Dec 2012 14:45:53 +0000 (15:45 +0100)]
systemctl: fix typos in help text
Kay Sievers [Mon, 3 Dec 2012 14:47:18 +0000 (15:47 +0100)]
udev: net_id - clarify comments
Shawn Landden [Mon, 3 Dec 2012 00:50:55 +0000 (00:50 +0000)]
timedated: do not incorrectly close non-opened dbus connection
Fix the fallowing error when no system dbus available:
Failed to get system D-Bus connection: Failed to connect to socket /var/run/dbus/system_bus_socket: No such file or directory
process 14920: arguments to dbus_connection_close() were incorrect, assertion "connection != NULL" failed in file ../../dbus/dbus-connection.c line 2889.
This is normally a bug in some application using the D-Bus library.
process 14920: arguments to dbus_connection_unref() were incorrect, assertion "connection != NULL" failed in file ../../dbus/dbus-connection.c line 2776.
This is normally a bug in some application using the D-Bus library.
David Herrmann [Sun, 2 Dec 2012 17:06:35 +0000 (18:06 +0100)]
getty-generator: fix handling systems without a console
If the system does not have any active console, we should not try to
create an empty symlink. Instead, create no symlink at all.
Otherwise, on systems with CONFIG_VT=n and no serial console, we will
create a symlink with an empty template parameter.
Kay Sievers [Sun, 2 Dec 2012 14:16:20 +0000 (15:16 +0100)]
hwdb: fix upstream typo in PNP data
Kay Sievers [Sun, 2 Dec 2012 13:58:47 +0000 (14:58 +0100)]
hwdb: update PNP ids
David Strauss [Sun, 2 Dec 2012 03:48:42 +0000 (19:48 -0800)]
Grammar and spelling fixes to journal documentation.
Kay Sievers [Sun, 2 Dec 2012 01:10:40 +0000 (02:10 +0100)]
gitignore: ignore .trs files from tests
Kay Sievers [Sun, 2 Dec 2012 01:01:25 +0000 (02:01 +0100)]
hwdb: update data
Kay Sievers [Sun, 2 Dec 2012 01:00:57 +0000 (02:00 +0100)]
udev: hwdb - fix OUI lookup
Zbigniew Jędrzejewski-Szmek [Thu, 29 Nov 2012 19:26:12 +0000 (20:26 +0100)]
man: fix docbook in systemd-coredumpctl(1)
Zbigniew Jędrzejewski-Szmek [Wed, 28 Nov 2012 16:47:10 +0000 (17:47 +0100)]
man: document more URLs for journal-gatewayd
Eelco Dolstra [Fri, 30 Nov 2012 12:36:05 +0000 (13:36 +0100)]
man: fix some typos
Zbigniew Jędrzejewski-Szmek [Sat, 1 Dec 2012 09:37:52 +0000 (10:37 +0100)]
build-sys: use parallel tests driver
This saves test output to individual .log files.
The driver is only used in /Makefile.am, not in
/docs/*udev/Makefile.am because the latter don't seem to work with
this driver. They don't produce much output anyway.
.gitignore is alphabetized, and .log files are added to it.
Generated files from /build-aux are removed from the list.
Zbigniew Jędrzejewski-Szmek [Sat, 1 Dec 2012 09:13:30 +0000 (10:13 +0100)]
build-sys: color test results
Zbigniew Jędrzejewski-Szmek [Mon, 19 Nov 2012 19:19:39 +0000 (20:19 +0100)]
cgls: automatic cleanup
Kay Sievers [Fri, 30 Nov 2012 18:27:42 +0000 (19:27 +0100)]
udev: net_id - suppress function number for single-function devices
Ramkumar Ramachandra [Thu, 29 Nov 2012 19:06:57 +0000 (00:36 +0530)]
man: fix some spelling mistakes
Ramkumar Ramachandra [Thu, 29 Nov 2012 19:06:56 +0000 (00:36 +0530)]
DISTRO_PORTING: correct location of hostname-setup.c
f33d3ec1 (move more common files to shared/ and add them to shared.la,
2012-04-12) moved src/hostname-setup.c to src/shared/hostname-setup.c,
but did not update DISTRO_PORTING accordingly. Fix this.
Ramkumar Ramachandra [Thu, 29 Nov 2012 19:06:55 +0000 (00:36 +0530)]
LICENSE.LGPL2.1: update license
Update the license with the copy found on
http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt
Martin Pitt [Wed, 28 Nov 2012 20:33:26 +0000 (21:33 +0100)]
keymap: Add Samsung 700T
https://bugzilla.redhat.com/show_bug.cgi?id=879691
Alessandro Crismani [Wed, 8 Aug 2012 12:19:32 +0000 (14:19 +0200)]
keymap: Update the list of Samsung Series 9 models
Currently, keymaps are provided only for the NP90X3A laptop. Samsung
introduced updated models, codenamed 900X3B, 900X3C, 900X4B, 900X4C,
which are currently not matched by udev rules. This patch includes the
newer modules in udev rules and move the samsung-n90x3a file defining
keys to a more generic samsung-series-9 file.
The patch was tested on a 900X4C laptop, and other people reported
that the rules also work for 900X3B and 900X3C ones.
Hermann Gausterer [Wed, 28 Nov 2012 20:20:37 +0000 (21:20 +0100)]
shutdown: fix typo
Tom Gundersen [Wed, 28 Nov 2012 17:08:54 +0000 (18:08 +0100)]
shutdown: don't consider umounting of / and /usr failed
In the words of Homer: If you don't try, you can't fail.
This is a revert of
9279749b84cc87c7830280b7895a48bed03c9429.
It used to be necessary to consider the umounting failed to make sure /
and /usr were remounted read-only, but that is no longer necessary as
everything is now remounted read-only anyway.
Moreover, this avoids a warning at shutdown saying a filesystem was not
unmounted. As the umounting of / is never attempted there was no
corresponding warning message saying which fs that failed. This caused some
spurious bug-reports from concerned users.
Cc: Michael Biebl <biebl@debian.org>
Tom Gundersen [Wed, 28 Nov 2012 16:27:17 +0000 (17:27 +0100)]
shutdown: don't pivot to /run/initramfs if already there
This allows systemd-shutdown to be installed as /run/initramfs/shutdown
and take care of the proper teardown of the rootfs.
Kay Sievers [Tue, 27 Nov 2012 10:40:08 +0000 (11:40 +0100)]
man: systemd.exec - mention mount(2)
https://bugzilla.redhat.com/show_bug.cgi?id=880552
Tom Gundersen [Tue, 27 Nov 2012 00:09:28 +0000 (01:09 +0100)]
fstab-generator: make error more helpful in case of duplicates in fstab
Traditional sysvinit systems would not complain about duplicates in
fstab. Rather it (through monut -a) would mount one fs on top of another,
in effect the last entry taking precedent.
In systemd, the first entry takes precedent, all subsequent ones are
ignored and an error is printed.
The change of behavior and the source of this error message was causing
some confusion, so give a hint what migt be wrong.
Tom Gundersen [Mon, 26 Nov 2012 23:52:01 +0000 (00:52 +0100)]
fstab-generator: drop mount_is_bind
Do the check in-line instead, as the function is now a bit pointless.
Tom Gundersen [Mon, 26 Nov 2012 02:49:21 +0000 (03:49 +0100)]
fstab-generator: remove redundancy in mount_is_bind
Kay Sievers [Mon, 26 Nov 2012 18:04:13 +0000 (19:04 +0100)]
man: systemd.time - fix typo in fixed typo
Kay Sievers [Mon, 26 Nov 2012 17:47:33 +0000 (18:47 +0100)]
man: systemd.time - fix typo
Kay Sievers [Mon, 26 Nov 2012 14:03:06 +0000 (15:03 +0100)]
udev: net_id - merge properties into the correct device
Kay Sievers [Mon, 26 Nov 2012 13:07:16 +0000 (14:07 +0100)]
udev: net_id - export PCI hotplug slot names
Tom Gundersen [Sun, 25 Nov 2012 20:59:00 +0000 (21:59 +0100)]
README - dependencies: unify and add util-linux reference
Use '>=' everywhere for consistency and point out that new util-linux
provides sulogin.
Zbigniew Jędrzejewski-Szmek [Sun, 25 Nov 2012 20:34:10 +0000 (21:34 +0100)]
journal: fix warning about pointer arithmetic
../src/journal/journal-send.c: In function 'sd_journal_sendv':
../src/journal/journal-send.c:250:73: warning: pointer of type 'void *' used in arithmetic [-Wpointer-arith]
Lennart Poettering [Sun, 25 Nov 2012 18:43:48 +0000 (19:43 +0100)]
manager: fix build on 32bit systems
Zbigniew Jędrzejewski-Szmek [Sun, 25 Nov 2012 15:39:07 +0000 (16:39 +0100)]
man: add systemd-journal-gatewayd page
Zbigniew Jędrzejewski-Szmek [Sun, 25 Nov 2012 15:36:46 +0000 (16:36 +0100)]
journal-gatewayd: minor cleanup
Zbigniew Jędrzejewski-Szmek [Thu, 22 Nov 2012 14:30:50 +0000 (15:30 +0100)]
README: mention dependency on libpython
Lennart Poettering [Sat, 24 Nov 2012 23:33:38 +0000 (00:33 +0100)]
update TODO
Lennart Poettering [Sat, 24 Nov 2012 23:32:40 +0000 (00:32 +0100)]
timer: recalculate next elapse for calendar timer units when the system clock is changed
Kay Sievers [Sat, 24 Nov 2012 13:51:19 +0000 (14:51 +0100)]
shared: FORMAT_TIMESTAMP_MAX -- include space for unicode weekdays
$ LANG=el_GR.UTF-8 ./timedatectl
Local time: Σαβ 2012-11-24 14:53:05 CET
Universal time: Σαβ 2012-11-24 13:53:05 UTC
RTC time: Σαβ 2012-11-24 13:53:04
Timezone: Europe/Berlin (CET, +0100)
NTP enabled: yes
NTP synchronized: yes
RTC in local TZ: no
DST active: no
Last DST change: DST ended at
Κυρ 2012-10-28 02:59:59 CEST
Κυρ 2012-10-28 02:00:00 CET
Next DST change: DST begins (the clock jumps one hour forward) at
Κυρ 2013-03-31 01:59:59 CET
Κυρ 2013-03-31 03:00:00 CEST
https://bugs.freedesktop.org/show_bug.cgi?id=57470
Daniel Wallace [Sat, 24 Nov 2012 00:14:21 +0000 (19:14 -0500)]
fix --full for journalctl zsh completion
Lennart Poettering [Fri, 23 Nov 2012 23:24:30 +0000 (00:24 +0100)]
update TODO
Lennart Poettering [Fri, 23 Nov 2012 23:24:14 +0000 (00:24 +0100)]
man: document calendar timers
Lennart Poettering [Fri, 23 Nov 2012 21:55:38 +0000 (22:55 +0100)]
build-sys: drop TARGET_UBUNTU
TARGET_UBUNTU is effectively the same as TARGET_DEBIAN. Given the Ubuntu
is unlikely to use systemd anytime soon there's no point in keeping this
separate.
Lennart Poettering [Fri, 23 Nov 2012 21:52:46 +0000 (22:52 +0100)]
time-util: teach parse_timestamp to parse weekdays
Lennart Poettering [Fri, 23 Nov 2012 21:52:38 +0000 (22:52 +0100)]
path-util: when parsing a timestamp we don't know the timezone
Lennart Poettering [Fri, 23 Nov 2012 21:51:55 +0000 (22:51 +0100)]
time-util: also rename FORMAT_TIMESTAMP_PRETTY → _MAX
Lennart Poettering [Fri, 23 Nov 2012 21:20:15 +0000 (22:20 +0100)]
util: teach parse_timestamp() to parse results of format_timestamp_relative()
Lennart Poettering [Fri, 23 Nov 2012 21:12:59 +0000 (22:12 +0100)]
util: rename format_timestamp_pretty() to format_timestamp_relative() because that describes much better what it does
Lennart Poettering [Fri, 23 Nov 2012 21:07:24 +0000 (22:07 +0100)]
util: split off time related calls from util.[ch] into time-util.[ch]
Lennart Poettering [Fri, 23 Nov 2012 20:50:51 +0000 (21:50 +0100)]
test: extend calendarspec test a bit
Lennart Poettering [Fri, 23 Nov 2012 20:38:42 +0000 (21:38 +0100)]
timedatectl: improve english language DST change texts a bit
Lennart Poettering [Fri, 23 Nov 2012 20:38:15 +0000 (21:38 +0100)]
update TODO
Lennart Poettering [Fri, 23 Nov 2012 20:37:58 +0000 (21:37 +0100)]
timer: implement calendar time events
Lennart Poettering [Fri, 23 Nov 2012 17:44:49 +0000 (18:44 +0100)]
man: clarify why User=/Group= don't work with mount units
Lennart Poettering [Fri, 23 Nov 2012 17:35:24 +0000 (18:35 +0100)]
journal: fix SO_PASSSEC invocation
Spotted by Lukas Nykryn
Lennart Poettering [Fri, 23 Nov 2012 17:35:09 +0000 (18:35 +0100)]
update TODO
Lennart Poettering [Fri, 23 Nov 2012 15:33:39 +0000 (16:33 +0100)]
timedatectl: show both current actual timezone name and UTC distance in TImezone field
Lennart Poettering [Fri, 23 Nov 2012 15:29:35 +0000 (16:29 +0100)]
timedatctl: bring manual strftime in sync with format_timestamp()
Lennart Poettering [Fri, 23 Nov 2012 15:24:59 +0000 (16:24 +0100)]
util: drop "," between week day and date when formatting timestamps
The glibc default (as shown by the command line tool "date") doesn't put a comma there,
and so we shouldn't either.
Kay Sievers [Fri, 23 Nov 2012 14:01:43 +0000 (15:01 +0100)]
udev: net_id - read ACPI _SUN -- slot user number
Michal Schmidt [Fri, 23 Nov 2012 13:16:39 +0000 (14:16 +0100)]
cryptsetup-generator: state file name in error messages
Michal Schmidt [Fri, 23 Nov 2012 13:16:34 +0000 (14:16 +0100)]
cryptsetup-generator: use log_oom() everywhere
Hannes Reinecke [Fri, 23 Nov 2012 13:12:39 +0000 (14:12 +0100)]
udev: path_id - handle Hyper-V devices
Hyper-V has an abstract bus, which gets renumbered on guest
startup. So instead of the bus numbers we should be using
the device GUIDs, which can be retrieved from the 'device_id'
sysfs attribute.
David Strauss [Fri, 23 Nov 2012 09:51:41 +0000 (03:51 -0600)]
Update TODO to include splitting systemd-analyze.
The split should be into a lightweight collection tool that can run
with minimal dependencies and resources for server and embedded
systems. The analysis tool can pull in desktop-style dependencies
like Cairo and GTK.
Lennart Poettering [Thu, 22 Nov 2012 19:16:15 +0000 (20:16 +0100)]
update TODO
Lennart Poettering [Thu, 22 Nov 2012 00:56:24 +0000 (01:56 +0100)]
update TODO
Kay Sievers [Thu, 22 Nov 2012 17:50:55 +0000 (18:50 +0100)]
timedatectl: replace ",' with ':'