chiark / gitweb /
Zbigniew Jędrzejewski-Szmek [Fri, 1 Aug 2014 01:06:00 +0000 (21:06 -0400)]
resolved: MX records
Zbigniew Jędrzejewski-Szmek [Fri, 1 Aug 2014 00:06:30 +0000 (20:06 -0400)]
resolve-host: list types and classes
Also update systemctl to similar style.
Zbigniew Jędrzejewski-Szmek [Thu, 31 Jul 2014 08:15:29 +0000 (04:15 -0400)]
Always prefer our headers to system headers
In practice this shouldn't make much difference, but
sometimes our headers might be newer, and we want to
test them.
Zbigniew Jędrzejewski-Szmek [Wed, 30 Jul 2014 19:38:54 +0000 (15:38 -0400)]
Constify option table and add missing option
Zbigniew Jędrzejewski-Szmek [Thu, 31 Jul 2014 08:01:19 +0000 (04:01 -0400)]
man: add udev.conf(5)
We generally have separate man pages for all configuration files.
In this case udev.conf was already described in systemd-udevd.service(8),
but it was hard to find. Docbook makes it hard to add a .so link from
a different section, so describe udev.conf in its own page.
Zbigniew Jędrzejewski-Szmek [Thu, 31 Jul 2014 08:01:01 +0000 (04:01 -0400)]
man: add missing comma
Zbigniew Jędrzejewski-Szmek [Thu, 31 Jul 2014 07:45:05 +0000 (03:45 -0400)]
sysusers: split users for remote into separate file
This mirrors the setup for tmpfiles.d done in
ad95fd1d2b9.
Zbigniew Jędrzejewski-Szmek [Thu, 31 Jul 2014 07:42:19 +0000 (03:42 -0400)]
systemd-analyze verify: improve error message
There's little sense in telling the user to look at the logs...
Zbigniew Jędrzejewski-Szmek [Thu, 31 Jul 2014 07:38:05 +0000 (03:38 -0400)]
core/load-fragment.c: correct argument sign and split up long lines
With everything on one line they are just harder to read.
Zbigniew Jędrzejewski-Szmek [Thu, 31 Jul 2014 07:28:37 +0000 (03:28 -0400)]
Properly report invalid quoted strings
$ systemd-analyze verify trailing-g.service
[./trailing-g.service:2] Trailing garbage, ignoring.
trailing-g.service lacks ExecStart setting. Refusing.
Error: org.freedesktop.systemd1.LoadFailed: Unit trailing-g.service failed to load: Invalid argument.
Failed to create trailing-g.service/start: Invalid argument
Zbigniew Jędrzejewski-Szmek [Wed, 30 Jul 2014 02:01:36 +0000 (22:01 -0400)]
Reject invalid quoted strings
String which ended in an unfinished quote were accepted, potentially
with bad memory accesses.
Reject anything which ends in a unfished quote, or contains
non-whitespace characters right after the closing quote.
_FOREACH_WORD now returns the invalid character in *state. But this return
value is not checked anywhere yet.
Also, make 'word' and 'state' variables const pointers, and rename 'w'
to 'word' in various places. Things are easier to read if the same name
is used consistently.
mbiebl_> am I correct that something like this doesn't work
mbiebl_> ExecStart=/usr/bin/encfs --extpass='/bin/systemd-ask-passwd "Unlock EncFS"'
mbiebl_> systemd seems to strip of the quotes
mbiebl_> systemctl status shows
mbiebl_> ExecStart=/usr/bin/encfs --extpass='/bin/systemd-ask-password Unlock EncFS $RootDir $MountPoint
mbiebl_> which is pretty weird
Zbigniew Jędrzejewski-Szmek [Tue, 29 Jul 2014 00:01:56 +0000 (20:01 -0400)]
test-strv: add test which shows access to random memory
Tom Gundersen [Wed, 30 Jul 2014 19:29:34 +0000 (21:29 +0200)]
networkd: don't assume udev_device_new_from_device_id sets errno
This reverts
6f4d55a8ae04e344a41fc2adef12ad99c2bb2927, as we cannot rely on errno here.
Reported by David Herrmann.
Lennart Poettering [Wed, 30 Jul 2014 18:39:52 +0000 (20:39 +0200)]
resolved: when we got a successful DNS reply, then only wait for other transactions on the same scope, nowhere else
Lennart Poettering [Wed, 30 Jul 2014 17:34:55 +0000 (19:34 +0200)]
update TODO
Lennart Poettering [Wed, 30 Jul 2014 17:34:50 +0000 (19:34 +0200)]
resolved: properly set TTL in SOA records
Lennart Poettering [Wed, 30 Jul 2014 17:24:05 +0000 (19:24 +0200)]
resolved: don't attempt to order empty answer array
Lennart Poettering [Wed, 30 Jul 2014 17:23:50 +0000 (19:23 +0200)]
resolved: properly return start index when appending RR to packet
Lennart Poettering [Wed, 30 Jul 2014 17:23:27 +0000 (19:23 +0200)]
resolved: add API for resolving specific RRs
Tom Gundersen [Wed, 30 Jul 2014 16:16:09 +0000 (18:16 +0200)]
networkd: improve error message when udev device can not be found
Reported by Raimonds Cicans <ray@apollo.lv>
Hong Shick Pak [Mon, 28 Jul 2014 04:10:01 +0000 (00:10 -0400)]
man: fix outdated example in systemd.network
The docs for the DHCP= was updated, but not the example.
Lennart Poettering [Wed, 30 Jul 2014 15:52:58 +0000 (17:52 +0200)]
resolved: properly pass empty answers back to bus clients
Lennart Poettering [Wed, 30 Jul 2014 15:52:21 +0000 (17:52 +0200)]
resolve-host: add reverse lookup support
Lennart Poettering [Wed, 30 Jul 2014 15:11:21 +0000 (17:11 +0200)]
resolve-host: use the usual log message when encountering a dbus parse failure
Tom Gundersen [Thu, 24 Jul 2014 23:13:47 +0000 (01:13 +0200)]
networkd: ipv4ll - configure link-local address independently of DHCPv4
This changes the behavior when both DHCPv4 and IPv4LL are enabled. Before,
we would disable IPv4LL when we got a DHCPv4 lease and enable it if the
lease was lost.
Now we just always set up both, if both are enabled, but the DHCPv4
addresses and routes will always take precedence due to their metric
and scope.
Kay Sievers [Wed, 30 Jul 2014 15:28:04 +0000 (17:28 +0200)]
TODO: update resolved
Zbigniew Jędrzejewski-Szmek [Wed, 16 Jul 2014 20:55:23 +0000 (22:55 +0200)]
resolved: add tool to query resolved
Lennart Poettering [Wed, 30 Jul 2014 14:30:25 +0000 (16:30 +0200)]
resolved: include SOA records in LLMNR replies for non-existing RRs to allow negative caching
Tom Gundersen [Wed, 30 Jul 2014 10:48:25 +0000 (12:48 +0200)]
TODO
Kay Sievers [Wed, 30 Jul 2014 13:19:26 +0000 (15:19 +0200)]
factory: remove broken pam_limits
Stupid PAM, please just go away!
login[26]: pam_limits(login:session): error parsing the configuration file: '/etc/security/limits.conf'
login[26]: pam_unix(login:session): session opened for user root by LOGIN(uid=0)
login[26]: Error in service module
Lennart Poettering [Wed, 30 Jul 2014 12:46:40 +0000 (14:46 +0200)]
resolved: fix cname handling
Lennart Poettering [Wed, 30 Jul 2014 12:21:18 +0000 (14:21 +0200)]
resolved: properly handle adding empty replies to cache
Lennart Poettering [Wed, 30 Jul 2014 09:27:05 +0000 (11:27 +0200)]
update TODO
Lennart Poettering [Wed, 30 Jul 2014 09:26:49 +0000 (11:26 +0200)]
resolved: never cache ANY lookups
Hannes Reinecke [Wed, 30 Jul 2014 08:10:46 +0000 (10:10 +0200)]
Martin Pitt [Wed, 30 Jul 2014 08:54:23 +0000 (10:54 +0200)]
keymap: Annotate all micmute workarounds
Add a comment to all assignments to f20 that this actually should be "micmute"
in a future when we aren't limited by X.org's key code limiations any more.
Hui Wang [Wed, 30 Jul 2014 08:09:08 +0000 (16:09 +0800)]
keymap: Add microphone mute keymap for Dell Latitude
On the Dell Latitude, the mic mute key event is generated by wmi
driver, the keycode assigned to this hotkey from kernel is
KEY_MICMUTE (248), this keycode is too big for xorg to handle,
in the xorg, the XF86AudioMicMute is assigned to F20.
Please refer to
4e648ea0 of xkeyboard-config.
BugLink: https://bugs.launchpad.net/bugs/1326684
BugLink: https://bugs.launchpad.net/bugs/1339998
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
Lukas Nykryn [Wed, 23 Jul 2014 10:49:14 +0000 (12:49 +0200)]
sysv: order initscripts which provide $network before network.target
Due to recent changes where $network "maps" to network-online.target
it is not guaranteed that initscript which provides networking will
be terminated after network.target during shutdown which is against LSB.
Lennart Poettering [Wed, 30 Jul 2014 00:08:11 +0000 (02:08 +0200)]
update TODO
Lennart Poettering [Wed, 30 Jul 2014 00:06:09 +0000 (02:06 +0200)]
resolved: respond to ANY queries from our zone
Lennart Poettering [Wed, 30 Jul 2014 00:05:23 +0000 (02:05 +0200)]
resolved: don't accept messages with ANY RRs
Lennart Poettering [Wed, 30 Jul 2014 00:04:07 +0000 (02:04 +0200)]
resolved: don't allow adding of ANY class/type RRs to local zones
Lennart Poettering [Tue, 29 Jul 2014 23:48:34 +0000 (01:48 +0200)]
update TODO
Lennart Poettering [Tue, 29 Jul 2014 23:48:22 +0000 (01:48 +0200)]
resolved: don't do llmnr on interfaces lacking multicasting
Lennart Poettering [Tue, 29 Jul 2014 23:47:48 +0000 (01:47 +0200)]
resolved: follow more closely the recommend timeouts and TTLs from the LLMNR spec
Lennart Poettering [Tue, 29 Jul 2014 23:46:27 +0000 (01:46 +0200)]
resolved: only cache answer RRs, never additional or authoritative RRs of responses
Lennart Poettering [Tue, 29 Jul 2014 23:45:52 +0000 (01:45 +0200)]
resolved: never attempt negative caching of SOA records
Lennart Poettering [Tue, 29 Jul 2014 22:48:59 +0000 (00:48 +0200)]
resolved: when answer A or AAAA questions, order responses by whether addresses are link-local or not
Lennart Poettering [Tue, 29 Jul 2014 21:52:57 +0000 (23:52 +0200)]
resolved: the llmnr destination address check applies to queries, not to responses
Lennart Poettering [Tue, 29 Jul 2014 21:52:23 +0000 (23:52 +0200)]
resolved: add more debug logging
Lennart Poettering [Tue, 29 Jul 2014 21:51:34 +0000 (23:51 +0200)]
resolved: set LLMNR TCP and UDP TTLs to the values suggested by the RFC
Lennart Poettering [Tue, 29 Jul 2014 21:49:54 +0000 (23:49 +0200)]
sd-network: make socket filter programs static const where possible
(also, fix some whitespace/indentation issues, and avoid "index" as identifier in
order to not clash against libc's "index()" call)
Lennart Poettering [Tue, 29 Jul 2014 19:46:12 +0000 (21:46 +0200)]
resolved: we don't need the DNS server "source" concept anymore, remove it
Michael Marineau [Mon, 21 Jul 2014 23:23:42 +0000 (16:23 -0700)]
networkd: fix reporting errors from hostnamed
The return value may be -EINVAL or a positive errno from the dbus
message. Check both ranges, otherwise most errors are silently ignored.
Lennart Poettering [Tue, 29 Jul 2014 17:50:28 +0000 (19:50 +0200)]
resolved: discard more invalid llmnr messages
Lennart Poettering [Tue, 29 Jul 2014 17:50:19 +0000 (19:50 +0200)]
Update TODO
Lennart Poettering [Tue, 29 Jul 2014 17:49:45 +0000 (19:49 +0200)]
resolved: when resolving an address PTR record via llmnr, make a tcp connection by default
Lennart Poettering [Tue, 29 Jul 2014 12:24:02 +0000 (14:24 +0200)]
resolve: add llmnr responder side for UDP and TCP
Name defending is still missing.
David Herrmann [Tue, 29 Jul 2014 17:14:23 +0000 (19:14 +0200)]
barrier: fix race in test-code
The barrier_wait_next_twice* test-cases run:
Parent: Child:
set_alarm(10) sleep_for(1);
... set_alarm(1);
sleep_for(2) ...
Therefore, the parent exits after 2+ periods, the client's alarm fires
after 2+ periods. This race turns out to be lost by the child on other
machines, so avoid it by increasing the parent's sleep-interval to 4. This
way, the client has 2 periods to run the barrier test, which is far more
than enough.
Kay Sievers [Tue, 29 Jul 2014 15:54:57 +0000 (17:54 +0200)]
build-sys: add missing files for distcheck
Kay Sievers [Tue, 29 Jul 2014 15:07:27 +0000 (17:07 +0200)]
test: test_tables - fix missing symbols when --gc-sections are not available
Kay Sievers [Tue, 29 Jul 2014 14:44:04 +0000 (16:44 +0200)]
factory: install minimal PAM and nsswitch config
Kay Sievers [Tue, 29 Jul 2014 13:47:41 +0000 (15:47 +0200)]
udev: place opening { at the same line as the function declaration
Kay Sievers [Tue, 29 Jul 2014 13:20:42 +0000 (15:20 +0200)]
build-sys: remove systemd-coredumpctl symlink
Kay Sievers [Tue, 29 Jul 2014 13:18:27 +0000 (15:18 +0200)]
udev: unify event timeout handling
Hannes Reinecke [Tue, 29 Jul 2014 07:06:14 +0000 (09:06 +0200)]
udevd: add --event-timeout commandline option
Some events take longer than the default 30 seconds. Killing those
events will leave the machine halfway configured.
Add a commandline option '--event-timeout' to handle these cases.
Kay Sievers [Tue, 29 Jul 2014 11:01:51 +0000 (13:01 +0200)]
login: update systemd-user PAM configuration file
Kay Sievers [Tue, 29 Jul 2014 10:23:31 +0000 (12:23 +0200)]
time-util: add and use USEC/NSEC_INFINIY
David Herrmann [Tue, 29 Jul 2014 11:04:51 +0000 (13:04 +0200)]
barrier: convert msecs to usecs in test-code
Avoid using msecs in favor of usec_t. This is more consistent with the
other parts of systemd and avoids the confusion between msec and usec. We
always use usecs, end of story.
David Herrmann [Tue, 29 Jul 2014 11:00:35 +0000 (13:00 +0200)]
terminal/subterm: use usec_t instead of "unsigned long"
Avoid hard-coding "unsigned long" and use the usec_t type defined in
src/shared.
Tom Gundersen [Mon, 28 Jul 2014 10:21:51 +0000 (12:21 +0200)]
networkd: route/address - use trivial hash functions
Tom Gundersen [Mon, 28 Jul 2014 10:10:37 +0000 (12:10 +0200)]
networkd: unify handling of stacked netdevs
Tom Gundersen [Mon, 28 Jul 2014 09:39:37 +0000 (11:39 +0200)]
networkd: store ifindex as int
Tom Gundersen [Sat, 26 Jul 2014 17:12:24 +0000 (19:12 +0200)]
sd-dhcp-server: add forcerenew support
Tom Gundersen [Thu, 15 May 2014 22:50:44 +0000 (00:50 +0200)]
sd-dhcp-client: add support for FORCERENEW
This partially implements RFC3203. Note that we are not fully compliant as we do not
support authentication.
Tom Gundersen [Fri, 25 Jul 2014 12:44:12 +0000 (14:44 +0200)]
sd-dhcp-client: listen on UDP socket as soon as a lease is acquired
This is necessary in order to listen for FORCERENEW events.
Tom Gundersen [Fri, 25 Jul 2014 12:43:16 +0000 (14:43 +0200)]
dhcp-network: enable IP_FREEBIND for UDP sockets
This allows the sockets to be bound to a specific address before it is configured,
also enable SO_REUSEADDR to allow multiple DHCP clients to run at the same time.
Tom Gundersen [Sat, 17 May 2014 19:23:20 +0000 (21:23 +0200)]
sd-dhcp-client: drop event DHCP_EVENT_NO_LEASE
Keep this internal to the client and simply restart it when NAK is receieved, as
per the RFC.
Tom Gundersen [Sat, 26 Jul 2014 15:53:33 +0000 (17:53 +0200)]
sd-dhcp-client: only verify UDP messages
RAW messages are verified by the BPF in the kernel.
Michal Sekletar [Fri, 25 Jul 2014 12:38:22 +0000 (14:38 +0200)]
journald: always add syslog facility for messages coming from kmsg
Set SYSLOG_FACILITY field for kernel log messages too. Setting only
SYSLOG_IDENTIFIER="kernel" is not sufficient and tools reading journal
maybe confused by missing SYSLOG_FACILITY field for kernel log messages.
Eric Cook [Sun, 27 Jul 2014 19:07:03 +0000 (15:07 -0400)]
shell-completion: prevent mangling unit names (bash)
This fixes the issue noted by Zbigniew in most cases.
if a unit's name is enclosed in single quotes completion still
will not happen after the first `\'.
https://bugs.freedesktop.org/show_bug.cgi?id=78388
Ansgar Burchardt [Sun, 27 Jul 2014 14:32:13 +0000 (16:32 +0200)]
drop_duplicates: copy full BindMount struct
At least
t->ignore = f->ignore;
is missing here. Just copy the full struct to be sure.
Ansgar Burchardt [Sun, 27 Jul 2014 13:19:00 +0000 (15:19 +0200)]
parse_boolean: require exact matches
Require exact matches in all cases instead of treating strings
starting with 't' ('f') as true (false).
This is required for config_parse_protect_system to parse ProtectSystem=full
correctly: it uses parse_boolean and only tries a more specific parsing
function if that did not return a valid result. Thus "full" was treated as
"false" before.
Kay Sievers [Sun, 27 Jul 2014 12:53:21 +0000 (14:53 +0200)]
factory: nss - add generic config
Kay Sievers [Sun, 27 Jul 2014 12:08:11 +0000 (14:08 +0200)]
factory: PAM - add generic fallback config
Single PAM fallback config file to be used in /etc to allow
bootstrapping of a system with an empty /etc.
Kay Sievers [Sat, 26 Jul 2014 22:11:08 +0000 (00:11 +0200)]
core: only set the kernel's timezone when the RTC runs in local time
We can not reliably manage any notion of local time. Every daylight
saving time change or time zone change by traveling will make the
time jump, and the local time might jump backwards which creates
unsolvable problems with file timestamps.
We will no longer tell the kernel our local time zone and leave
everything set to UTC. This will effectively turn FAT timestamps
into UTC timestamps.
If and only if the machine is configured to read the RTC in local
time mode, the kernel's time zone will be configured, but
systemd-timesysnc will disable the kernel's system time to RTC
syncing. In this mode, the RTC will not be managed, and external
tools like Windows bootups are expected to manage the RTC's time.
https://bugs.freedesktop.org/show_bug.cgi?id=81538
Zbigniew Jędrzejewski-Szmek [Sun, 27 Jul 2014 00:11:58 +0000 (20:11 -0400)]
bash-completion: use list-unit-files to get "all" units
I think that it is better to return good results slightly more slowly,
than partial quickly. Also reading from disk seems fast enough. Even
the delay on first try with completely cold cache is acceptable.
This is just for bash, 'cause zsh was already doing this.
https://bugzilla.redhat.com/show_bug.cgi?id=790768
Zbigniew Jędrzejewski-Szmek [Sat, 26 Jul 2014 18:59:52 +0000 (14:59 -0400)]
Print kdbus path when opening fails
This makes it easier to debug what is going on.
Zbigniew Jędrzejewski-Szmek [Sat, 26 Jul 2014 19:01:49 +0000 (15:01 -0400)]
update-done: include a short description in .updated
People might be confused where the file comes from, since the name is not
at all specific.
https://bugzilla.redhat.com/show_bug.cgi?id=
1121301#c8
Zbigniew Jędrzejewski-Szmek [Sat, 26 Jul 2014 18:47:31 +0000 (14:47 -0400)]
Add utility function to append root to path
Zbigniew Jędrzejewski-Szmek [Sat, 26 Jul 2014 18:03:11 +0000 (14:03 -0400)]
systemctl: do not bother to mutate state on error
We will abort anyway.
Daniel Buch [Thu, 24 Jul 2014 21:29:40 +0000 (23:29 +0200)]
analyze: fix seg-fault with no cl-argument
We need to check if argv[1] is set before compare
Karel Zak [Fri, 25 Jul 2014 13:38:31 +0000 (15:38 +0200)]
Always check asprintf return code
There is a small number of the places in sources where we don't check
asprintf() return code and assume that after error the function
returns NULL pointer via the first argument. That's wrong, after
error the content of pointer is undefined.
Eric Cook [Sat, 26 Jul 2014 15:15:52 +0000 (11:15 -0400)]
shell-completion: prevent mangling unit names
Units with literal hex '\xFF' in their names has to be read
and printed properly.
dev-disk-byx2dlabel-root.device != dev-disk-by\x2dlabel-root.device
Tom Gundersen [Fri, 25 Jul 2014 09:08:23 +0000 (11:08 +0200)]
sysctl.d: enable promote_secondaries by default
Without this, secondary addresses would get deleted when the primary one is. This is not
the desired behavior when one would like to transition from one address to another in the
same subnet (such as when a new IP address is given over DHCP).
In networkd, when given a new IP over DHCP we will add it, without explicitly removing the
old one first (and hence never have a window without an IP address configured). Assuming the
addresses are in the same subnet, that means that the old address is the primary and the new
address is the secondary one. Once the old address expires, the kernel will drop it. With the
old behavior this means that both addresses would be lost, which is clearly not what we want.
With the new behavior, only the old address is lost, and the new one is promoted to primary.
Reported by Michael Olbrich <m.olbrich@pengutronix.de>
Lukas Nykryn [Fri, 25 Jul 2014 08:44:27 +0000 (10:44 +0200)]
busname: CLD_KILLED was used twice
Lukas Nykryn [Fri, 25 Jul 2014 08:25:06 +0000 (10:25 +0200)]
bus-proxyd: fix incorrect comparison
We should be interested in k variable.
Lukas Nykryn [Fri, 25 Jul 2014 07:58:52 +0000 (09:58 +0200)]
bus-proxyd: fix incorrect comparison
Err can't be bigger then zero. Rest of the code uses negative Exxxx values.
Tom Gundersen [Fri, 25 Jul 2014 00:09:29 +0000 (02:09 +0200)]
networkd: ipv4ll - default to setting up ipv4ll routes
This is necessary for non-ipv4ll hosts to communicate with ipv4ll-only hosts on the same link. Defaults
to being enabled, but can be opted out.
See: <http://avahi.org/wiki/AvahiAutoipd#Routes>
Tom Gundersen [Thu, 24 Jul 2014 23:28:39 +0000 (01:28 +0200)]
networkd: ipv4ll - drop unnecessary get_address()