chiark / gitweb /
8 years agosd-daemon: remove unnecessary memset calls
Jim Meyering [Thu, 16 Jun 2011 06:51:14 +0000 (08:51 +0200)]
sd-daemon: remove unnecessary memset calls

There is no point in clearing the bits of a "struct stat" when the very
next statement just calls stat or fstat to fill in that same memory.

[zj: two more places]

8 years agologind: fix operation precedence mix-up
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jul 2012 13:24:25 +0000 (15:24 +0200)]
logind: fix operation precedence mix-up

Since + has higher precedence than ?:, and u+b is unlikely to be exactly zero,
the timestamp would usually be set to IDLE_THRESHOLD_USEC. Fix it by
returning either 'last activity', or 'last activity+IDLE_THRESHOLD_USEC'.

8 years agotest: correct enum misassignment
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jul 2012 12:48:52 +0000 (14:48 +0200)]
test: correct enum misassignment

CC     src/test/test_job_type-test-job-type.o
../src/test/test-job-type.c:40:25: warning: implicit conversion from enumeration type
      'enum UnitType' to different enumeration type 'ServiceType' (aka 'enum ServiceType')
                .type = UNIT_SERVICE

8 years agocollect, keymap, systemctl: use _noreturn_
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jul 2012 12:42:09 +0000 (14:42 +0200)]
collect, keymap, systemctl: use _noreturn_

8 years agoman: typo
Shawn Landden [Fri, 22 Jun 2012 11:45:29 +0000 (04:45 -0700)]
man: typo

8 years agobuild-sys: distribute a few more man pages
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jul 2012 21:32:21 +0000 (23:32 +0200)]
build-sys: distribute a few more man pages

8 years agobuild-sys: hide error message from grep
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jul 2012 12:10:51 +0000 (14:10 +0200)]
build-sys: hide error message from grep

8 years agobuild-sys: fail early in
Zbyszek Jędrzejewski-Szmek [Wed, 18 Jul 2012 08:06:18 +0000 (10:06 +0200)]
build-sys: fail early in

When intltoolize is not installed, runs without error,
but is borked.

./configure: line 12001: syntax error near unexpected token `0.40.0'
./configure: line 12001: `IT_PROG_INTLTOOL(0.40.0)'

8 years agobuild-sys: fix (again) index generation in subdir
Zbigniew Jędrzejewski-Szmek [Wed, 18 Jul 2012 14:14:24 +0000 (16:14 +0200)]
build-sys: fix (again) index generation in subdir doesn't care about .html files, only .xml files, so
the source list was wrong. Also, $(XML_FILES) are specified without
prefix, so compilation in sepearate build-dir was broken:

  GEN    man/index.html
Traceback (most recent call last):
  File "../", line 24, in <module>
    t = parse(p)
  File "/usr/lib/python2.7/xml/etree/", line 1183, in parse
    tree.parse(source, parser)
  File "/usr/lib/python2.7/xml/etree/", line 647, in parse
    source = open(source, "rb")
IOError: [Errno 2] No such file or directory: 'man/systemd.xml'

8 years agoupdate TODO
Lennart Poettering [Fri, 20 Jul 2012 14:55:34 +0000 (16:55 +0200)]
update TODO

8 years agotmpfiles: also look in /lib/tmpfiles.d on split /usr systems
Lennart Poettering [Fri, 20 Jul 2012 14:24:55 +0000 (16:24 +0200)]
tmpfiles: also look in /lib/tmpfiles.d on split /usr systems

I don't think the usecase case in that bug makes much sense, but all the
other tools do honour /lib in the search path so we probably should do
that here, too.

8 years agoudev: path_id - export path for platform block devices
Kay Sievers [Fri, 20 Jul 2012 14:01:13 +0000 (16:01 +0200)]
udev: path_id - export path for platform block devices

Enrico Scholz <>
> E.g. I have a platform with two sdhci controllers with different purposes.
> First slot is an external slot while second one is internal with a
> non-removable card.
> When there is a card in the external slot at boot, the non-removable card is
> named 'mmcblk1'; without the external card it is 'mmcblk0'.  Vice versa for the
> external card.

8 years agobuild-sys: bump revision of libudev too v187
Lennart Poettering [Thu, 19 Jul 2012 22:40:32 +0000 (00:40 +0200)]
build-sys: bump revision of libudev too

8 years agobuild-sys: prepare 187
Lennart Poettering [Thu, 19 Jul 2012 22:38:02 +0000 (00:38 +0200)]
build-sys: prepare 187

8 years agojournalctl: fix assertion failure in ellipsize_mem()
Eelco Dolstra [Thu, 19 Jul 2012 21:12:16 +0000 (21:12 +0000)]
journalctl: fix assertion failure in ellipsize_mem()

When showing the journal through "journalctl --no-pager", if the
prefix of the log message (i.e. the date and syslog identifier) is
less than 3 characters shorter than the width of the terminal, you

Assertion 'new_length >= 3' failed at src/shared/util.c:3859, function ellipsize_mem(). Aborting.

because there is not enough space for the "...".  This patch add the
necessary check.

8 years agounits: apply default resource limits to socket/mount/swap processes too
Lennart Poettering [Thu, 19 Jul 2012 22:09:35 +0000 (00:09 +0200)]
units: apply default resource limits to socket/mount/swap processes too

8 years agocore: drop KillMode parameter from KillUnit() bus call
Lennart Poettering [Thu, 19 Jul 2012 22:00:04 +0000 (00:00 +0200)]
core: drop KillMode parameter from KillUnit() bus call

It made no sense, and since we are documenting the bus calls now and
want to include them in our stability promise we really should get it
cleaned up sooner, not later.

8 years agounit: split off KillContext from ExecContext containing only kill definitions
Lennart Poettering [Thu, 19 Jul 2012 21:47:10 +0000 (23:47 +0200)]
unit: split off KillContext from ExecContext containing only kill definitions

8 years agoman: add reference to export format spec to journalctl
Lennart Poettering [Thu, 19 Jul 2012 21:39:53 +0000 (23:39 +0200)]
man: add reference to export format spec to journalctl

8 years agobuild-sys: fix variable assignment
Kay Sievers [Thu, 19 Jul 2012 21:07:23 +0000 (23:07 +0200)]
build-sys: fix variable assignment

8 years agounits: fix section of man page link in systemd-logind.service
Lennart Poettering [Thu, 19 Jul 2012 10:46:55 +0000 (12:46 +0200)]
units: fix section of man page link in systemd-logind.service

8 years agojournald: upgrade signal reception message to INFO
Lennart Poettering [Thu, 19 Jul 2012 10:41:06 +0000 (12:41 +0200)]
journald: upgrade signal reception message to INFO

8 years agoman: fix sysctl.d(5) man page copy/paste mistake
Lennart Poettering [Thu, 19 Jul 2012 10:40:17 +0000 (12:40 +0200)]
man: fix sysctl.d(5) man page copy/paste mistake

8 years agoudev: firmware - do not cancel requests in the initrd
Kay Sievers [Thu, 19 Jul 2012 10:32:24 +0000 (12:32 +0200)]
udev: firmware - do not cancel requests in the initrd

8 years agouse #pragma once instead of foo*foo #define guards
Shawn Landden [Wed, 18 Jul 2012 17:07:51 +0000 (10:07 -0700)]
use #pragma once instead of foo*foo #define guards

 #pragma once has been "un-deprecated" in gcc since 3.3, and is widely supported
in other compilers.

I've been using and maintaining (rebasing) this patch for a while now, as
it annoyed me to see #ifndef fooblahfoo, etc all over the place,
almost arrogant about the annoyance of having to define all these names to
perform a commen but neccicary functionality, when a completely superior
alternative exists.

I havn't sent it till now, cause its kindof a style change, and it is bad
voodoo to mess with style that has been established by more established
editors. So feel free to lambast me as a crazy bafoon.

v2 - preserve externally used headers

8 years agojournal: allow watching symlinked journal dirs
Lennart Poettering [Thu, 19 Jul 2012 01:22:07 +0000 (03:22 +0200)]
journal: allow watching symlinked journal dirs

8 years agojournal: when watching directories actually watch the directories asked for
Lennart Poettering [Thu, 19 Jul 2012 01:21:49 +0000 (03:21 +0200)]
journal: when watching directories actually watch the directories asked for

8 years agojournal: rotate busy files away when we try to write to them
Lennart Poettering [Thu, 19 Jul 2012 01:21:04 +0000 (03:21 +0200)]
journal: rotate busy files away when we try to write to them

8 years agojournal: follow symlinks when enumerating journals
Lennart Poettering [Thu, 19 Jul 2012 00:35:17 +0000 (02:35 +0200)]
journal: follow symlinks when enumerating journals

8 years agomanager: use a private notify sockets in containers to avoid problems with shared...
Lennart Poettering [Thu, 19 Jul 2012 00:17:50 +0000 (02:17 +0200)]
manager: use a private notify sockets in containers to avoid problems with shared abstract socket namespaces

8 years agokillall: avoid gcc warning about wait name clash
Lennart Poettering [Thu, 19 Jul 2012 00:17:11 +0000 (02:17 +0200)]
killall: avoid gcc warning about wait name clash

8 years agonspawn: generate proper error messages in the child
Lennart Poettering [Thu, 19 Jul 2012 00:03:42 +0000 (02:03 +0200)]
nspawn: generate proper error messages in the child

8 years agojournald: don't choke on journal files with no cutoff date
Lennart Poettering [Thu, 19 Jul 2012 00:03:22 +0000 (02:03 +0200)]
journald: don't choke on journal files with no cutoff date

8 years agonspawn: introduce new --link-journal= switch to link container journals into host
Lennart Poettering [Thu, 19 Jul 2012 00:02:39 +0000 (02:02 +0200)]
nspawn: introduce new --link-journal= switch to link container journals into host

8 years agojournal: remove all of /run/log/journal when serializing, since the machine ID might...
Lennart Poettering [Wed, 18 Jul 2012 14:23:26 +0000 (16:23 +0200)]
journal: remove all of /run/log/journal when serializing, since the machine ID might deviate

8 years agojournal: don't complain if the syslog forwarder socket doesn't exist
Lennart Poettering [Wed, 18 Jul 2012 14:23:06 +0000 (16:23 +0200)]
journal: don't complain if the syslog forwarder socket doesn't exist

8 years agojournal: when we suggest a rotation, explain why
Lennart Poettering [Wed, 18 Jul 2012 14:22:40 +0000 (16:22 +0200)]
journal: when we suggest a rotation, explain why

8 years agojournal: estimate data hash table size a bit larger by default
Lennart Poettering [Wed, 18 Jul 2012 14:22:25 +0000 (16:22 +0200)]
journal: estimate data hash table size a bit larger by default

8 years agojournald: fix another bad memory access
Lennart Poettering [Wed, 18 Jul 2012 11:28:36 +0000 (13:28 +0200)]
journald: fix another bad memory access

If we rotate due to header out of date we need the new journal file
object, too.

8 years agoupdate TODO
Lennart Poettering [Wed, 18 Jul 2012 11:11:28 +0000 (13:11 +0200)]
update TODO

8 years agojournald: fix bad memory access
Lennart Poettering [Wed, 18 Jul 2012 11:10:09 +0000 (13:10 +0200)]
journald: fix bad memory access

After vacuuming we need to retrieve the journal file object again, since
it might have changed.

8 years agokeymap: Add Dell Latitude force-release quirk
Rex Tsai [Wed, 18 Jul 2012 09:47:13 +0000 (11:47 +0200)]
keymap: Add Dell Latitude force-release quirk

Signed-off-by: Martin Pitt <>
8 years agoservice: don't print a warning if we are in autorestart state, and can't start a...
Lennart Poettering [Wed, 18 Jul 2012 00:42:43 +0000 (02:42 +0200)]
service: don't print a warning if we are in autorestart state, and can't start a unit just yet

8 years agounits: don't enforce a holdoff time for journald, logind, udevd
Lennart Poettering [Wed, 18 Jul 2012 00:31:52 +0000 (02:31 +0200)]
units: don't enforce a holdoff time for journald, logind, udevd

These services should be restarted as quickly as possible if they fail,
and the extra safety net of the holdoff time is not necessary.

8 years agoservice: make start jobs wait, not fail, when an automatic restart is queued
Lennart Poettering [Wed, 18 Jul 2012 00:28:08 +0000 (02:28 +0200)]
service: make start jobs wait, not fail, when an automatic restart is queued

When an automatic restart is already queued, then make subsequent start
jobs wait until the restart can be handled (i.e. after the holdhoff
time), instead of simply fail.

8 years agounit: don't serialize job state, only unit state across switch-root
Lennart Poettering [Tue, 17 Jul 2012 23:46:52 +0000 (01:46 +0200)]
unit: don't serialize job state, only unit state across switch-root

8 years agoNEWS: correct NTP implementation data
Lennart Poettering [Tue, 17 Jul 2012 23:24:39 +0000 (01:24 +0200)]
NEWS: correct NTP implementation data

8 years agobuild-sys: put all BUILT_SOURCES in CLEANFILES
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 22:41:28 +0000 (00:41 +0200)]
build-sys: put all BUILT_SOURCES in CLEANFILES

Since currently all items in BUILT_SOURCES are also in CLEANFILES,
we can reduce clutter by appending BUILT_SOURCES directly.

8 years agobuild-sys: use .DELETE_ON_ERROR
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 15:58:14 +0000 (17:58 +0200)]
build-sys: use .DELETE_ON_ERROR

All instances of "|| rm $@" are replaced with .DELETE_ON_ERROR, which
has a similar effect. One difference is that the return code is not
masked by rm return code.

.DELETE_ON_ERROR is GNU-Make specific, but -Wno-portability is already
defined, and it's unlikely that anyone would build systemd with a
shell not supporting .DELETE_ON_ERROR. If they did, then
.DELETE_ON_ERROR would be silently ignored, i.e. in the worst case a
garbage file wouldn't be deleted, which is not very serious.

8 years agoman: html - cross-ref man page references and add Index link
Kay Sievers [Tue, 17 Jul 2012 21:04:48 +0000 (23:04 +0200)]
man: html - cross-ref man page references and add Index link

8 years fixed dependencies for man/index.html
Harald Hoyer [Tue, 17 Jul 2012 16:17:14 +0000 (18:17 +0200)] fixed dependencies for man/index.html

8 years agoswitch-root: don't wait for processes
Lennart Poettering [Tue, 17 Jul 2012 15:44:26 +0000 (17:44 +0200)]
switch-root: don't wait for processes

When we transition from the initrd to the main system, don't reap
processes, so that they can be handled normally after deserialization.

8 years agojournalctl: do not ellipsize when using pager
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 05:35:08 +0000 (07:35 +0200)]
journalctl: do not ellipsize when using pager

If a pager is used, ellipsization is redundant — the pager does
that better by hiding the part that cannot be shown. Pager's advantage
is that the user can press → to view the hidden part of a message,
and then ← to return.

8 years agologs: Adapt interface in log-show.c (show_journal_by_unit)
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 05:35:07 +0000 (07:35 +0200)]
logs: Adapt interface in log-show.c (show_journal_by_unit)

Convert more flag arguments into one flag variable.

8 years agologs: Adapt interface in log-show.c (output_journal)
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 05:35:06 +0000 (07:35 +0200)]
logs: Adapt interface in log-show.c (output_journal)

In preparation for adding more output switches, convert a series of
flags arguments into one flag variable.

8 years MKDIR_P man for man/index.html
Harald Hoyer [Tue, 17 Jul 2012 14:39:29 +0000 (16:39 +0200)] MKDIR_P man for man/index.html

8 years agoRevert "keymap: add --version option"
Kay Sievers [Tue, 17 Jul 2012 14:39:14 +0000 (16:39 +0200)]
Revert "keymap: add --version option"

This reverts commit d8f173fd2ee9ee60affa1a4d1a89f2501977fb0b.

8 years agokeymap: add --version option
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 05:31:48 +0000 (07:31 +0200)]
keymap: add --version option

8 years agosystemd: add --version option
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 05:31:47 +0000 (07:31 +0200)]
systemd: add --version option

systemd --version mirrors systemctl --version:

$ ./systemd --version
systemd 186

This information can be retrieved by other means (systemctl, etc.),
but it's easier for a newbie if 'systemd --version' says something
useful. And 'systemd --help' is already there, so let's complement
that with '--version'.

8 years agoupdate TODO
Lennart Poettering [Tue, 17 Jul 2012 14:29:40 +0000 (16:29 +0200)]
update TODO

8 years agobuild-sys: distcheck - add seccomp*.h to SOURCES
Kay Sievers [Tue, 17 Jul 2012 14:03:50 +0000 (16:03 +0200)]
build-sys: distcheck - add seccomp*.h to SOURCES

8 years agobuild-sys: use C preprocessor for key list, too
Lennart Poettering [Tue, 17 Jul 2012 13:55:53 +0000 (15:55 +0200)]
build-sys: use C preprocessor for key list, too

8 years agoexecute: free syscall filter array after use
Lennart Poettering [Tue, 17 Jul 2012 13:55:23 +0000 (15:55 +0200)]
execute: free syscall filter array after use

8 years agogitignore: tags files
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 06:30:58 +0000 (08:30 +0200)]
gitignore: tags files

8 years agobuild-sys: automake needs to know about generated files
Zbigniew Jędrzejewski-Szmek [Tue, 17 Jul 2012 06:30:38 +0000 (08:30 +0200)]
build-sys: automake needs to know about generated files

CC     src/core/libsystemd_core_la-syscall-list.lo
src/core/syscall-list.c:31:29: fatal error: syscall-to-name.h: No such file or directory

8 years agoexecute: support syscall filtering using seccomp filters
Lennart Poettering [Tue, 17 Jul 2012 02:17:53 +0000 (04:17 +0200)]
execute: support syscall filtering using seccomp filters

8 years agojournal: actually set archived files to archived state
Lennart Poettering [Mon, 16 Jul 2012 22:55:02 +0000 (00:55 +0200)]
journal: actually set archived files to archived state

8 years agojournalctl: decode more header files in --header
Lennart Poettering [Mon, 16 Jul 2012 22:52:43 +0000 (00:52 +0200)]
journalctl: decode more header files in --header

8 years agojournal: size journal data hash table based on maximum file size metrics
Lennart Poettering [Mon, 16 Jul 2012 22:36:15 +0000 (00:36 +0200)]
journal: size journal data hash table based on maximum file size metrics

The default of 2047 hash table entries turned out to result in way too
many collisions for bigger files, hence scale the hash table size by the
estimated maximum file size.

8 years agojournal: immediately rotate when the journal was previously not closed properly
Lennart Poettering [Mon, 16 Jul 2012 20:51:28 +0000 (22:51 +0200)]
journal: immediately rotate when the journal was previously not closed properly

8 years agojournal: automatically rotate journal files if the data hash table is full > 75%
Lennart Poettering [Mon, 16 Jul 2012 20:24:02 +0000 (22:24 +0200)]
journal: automatically rotate journal files if the data hash table is full > 75%

Previously, when the main data hash table grows too full the performance
simply started to decrease drastically. Instead, now simply rotate to a
new journal file as the hash table gets to full, so that we can start
with a new fresh empty hash table.

8 years pretty-print HTML
Kay Sievers [Mon, 16 Jul 2012 19:27:06 +0000 (21:27 +0200)] pretty-print HTML

8 years agojournal: use tail/head timestamps from header for cutoff logic
Lennart Poettering [Mon, 16 Jul 2012 17:28:05 +0000 (19:28 +0200)]
journal: use tail/head timestamps from header for cutoff logic

We have them, they are faster to use them, so use them...

8 years agojournald: don't enforce monotonicity of realtime clocks when copying entries
Lennart Poettering [Mon, 16 Jul 2012 17:26:54 +0000 (19:26 +0200)]
journald: don't enforce monotonicity of realtime clocks when copying entries

After all the point of the realtime clock (in contrast to the monotonic
clock) is that it does not have to be strictly monotonic, hence don't
enforce this when flushing the journal from /run to /var.

8 years agoman: actually generate h2 headers for letters in index as we meant to
Lennart Poettering [Mon, 16 Jul 2012 17:26:08 +0000 (19:26 +0200)]
man: actually generate h2 headers for letters in index as we meant to

8 years agocore: fix name of dbus call parameter
Lennart Poettering [Mon, 16 Jul 2012 17:11:27 +0000 (19:11 +0200)]
core: fix name of dbus call parameter

8 years agoman: include number of man pages in index page
Lennart Poettering [Mon, 16 Jul 2012 17:11:10 +0000 (19:11 +0200)]
man: include number of man pages in index page

8 years agobuild-sys: make building of index.html fail sensibly
Lennart Poettering [Mon, 16 Jul 2012 17:10:57 +0000 (19:10 +0200)]
build-sys: make building of index.html fail sensibly

8 years agoman: set description in italics in the index
Lennart Poettering [Mon, 16 Jul 2012 16:10:18 +0000 (18:10 +0200)]
man: set description in italics in the index

8 years agoman: reword man page titles
Lennart Poettering [Mon, 16 Jul 2012 16:08:25 +0000 (18:08 +0200)]
man: reword man page titles

Make sure the man page titles are similar in style and capitalization so
that our man page index looks pretty.

8 years agoman: show man page summary in index, too
Lennart Poettering [Mon, 16 Jul 2012 15:39:26 +0000 (17:39 +0200)]
man: show man page summary in index, too

8 years agomin: generate an index page for all man pages
Lennart Poettering [Mon, 16 Jul 2012 15:19:39 +0000 (17:19 +0200)]
min: generate an index page for all man pages

This makes use of python, if it is available

8 years agounit: set default working directory to the user's home directory when running in...
Lennart Poettering [Mon, 16 Jul 2012 10:44:42 +0000 (12:44 +0200)]
unit: set default working directory to the user's home directory when running in user mode

8 years agounit: introduce %s specifier for the user shell
Lennart Poettering [Mon, 16 Jul 2012 10:34:54 +0000 (12:34 +0200)]
unit: introduce %s specifier for the user shell

8 years agounit: printf specifiers %u and %h: $USER and $HOME.
Auke Kok [Sat, 14 Jul 2012 05:28:43 +0000 (22:28 -0700)]
unit: printf specifiers %u and %h: $USER and $HOME.

These printf specifiers allow us to refer to $HOME and $USER
in unit files. These are particularly helpful in instanced
units that have "User=" set, and in systemd --user domains.

The specifiers will return the pw_name and pw_dir fields
if the unit file has a User= field.

If the unit file does not have a User= field, the value
substituted is either $USER or $HOME from the environment,
or, if unset, the values from pw_name or pw_dir.

This patch is somewhat after Ran Benita's original patch,
which didn't get merged. I've split up the 2 specifiers
and extended them to do what is logically expected from
these specifiers.

Note that expansion is done at `start` time, not after
the units are parsed. Using `systemctl show` will just
show the specifiers.

8 years agoutil: add getusername_malloc(), get_shell(), get_home_dir()
Lennart Poettering [Mon, 16 Jul 2012 10:15:22 +0000 (12:15 +0200)]
util: add getusername_malloc(), get_shell(), get_home_dir()

8 years agoSpelling fixes.
Ville Skyttä [Sun, 15 Jul 2012 08:41:40 +0000 (11:41 +0300)]
Spelling fixes.

8 years agoudev: get rid of TEST_PREFIX and use unshare() to fake /sys, /dev, /run
Kay Sievers [Sun, 15 Jul 2012 20:10:46 +0000 (22:10 +0200)]
udev: get rid of TEST_PREFIX and use unshare() to fake /sys, /dev, /run

8 years agointltool: skip the intermediate file in case it remains, not the source file
Kay Sievers [Sun, 15 Jul 2012 17:28:21 +0000 (19:28 +0200)]
intltool: skip the intermediate file in case it remains, not the source file

8 years agoupdate TODO
Kay Sievers [Sun, 15 Jul 2012 13:55:47 +0000 (15:55 +0200)]
update TODO

8 years agounit: avoid re-definition of enum for older gcc versions
Kay Sievers [Sun, 15 Jul 2012 13:53:43 +0000 (15:53 +0200)]
unit: avoid re-definition of enum for older gcc versions

<koen> | ./src/shared/unit-name.h:29:23: error: redefinition of typedef 'UnitType'
<koen> | ./src/core/unit.h:30:23: note: previous declaration of 'UnitType' was here

8 years agobuild-sys: fix "make distcheck"
Kay Sievers [Sun, 15 Jul 2012 13:48:26 +0000 (15:48 +0200)]
build-sys: fix "make distcheck"

8 years agoaquire_terminal(): fix uninitialized variable
Kay Sievers [Sun, 15 Jul 2012 13:34:22 +0000 (15:34 +0200)]
aquire_terminal(): fix uninitialized variable

./src/shared/util.c:2457:45: warning: 'r' may be used uninitialized in this function [-Wmaybe-uninitialized]

8 years agojournal: align byte-buffer that gets cased to an object
Kay Sievers [Sun, 15 Jul 2012 12:58:29 +0000 (14:58 +0200)]
journal: align byte-buffer that gets cased to an object

On Sun, Jul 15, 2012 at 2:00 PM, Koen Kooi <> wrote:
> | src/journal/sd-journal.c: In function 'sd_journal_process':
> | src/journal/sd-journal.c:1891:21: warning: cast increases required alignment of target type [-Wcast-align]
> | src/journal/sd-journal.c:1900:29: warning: cast increases required alignment of target type [-Wcast-align]

8 years agojournal: avoid re-definition of enums for older gcc versions
Kay Sievers [Sun, 15 Jul 2012 12:56:57 +0000 (14:56 +0200)]
journal: avoid re-definition of enums for older gcc versions

On Sun, Jul 15, 2012 at 2:00 PM, Koen Kooi <> wrote:
> | In file included from src/journal/sd-journal.c:37:0:
> | src/journal/journal-internal.h:47:3: error: redefinition of typedef 'MatchType'
> | src/journal/journal-internal.h:36:24: note: previous declaration of 'MatchType' was here
> | src/journal/journal-internal.h:67:3: error: redefinition of typedef 'LocationType'
> | src/journal/journal-internal.h:37:27: note: previous declaration of 'LocationType' was here

8 years agorules: fix typo in 42-usb-hid-pm.rules
Kay Sievers [Fri, 13 Jul 2012 22:50:49 +0000 (00:50 +0200)]
rules: fix typo in 42-usb-hid-pm.rules

<arjan> can you open the 42-usb-hid-pm.rules file
<arjan> and go to line 46
<arjan> and tell me why ATTR{idProduct}="0002" only has one = and not two (e.g. == ) ?
<kay> arjan: yep
<kay> arjan: bug

8 years agoudev: avoid creating /dev/kmsg with fopen() to support CONFIG_PRINTK=n
Kay Sievers [Fri, 13 Jul 2012 22:32:47 +0000 (00:32 +0200)]
udev: avoid creating /dev/kmsg with fopen() to support CONFIG_PRINTK=n

8 years agobuild-sys: fix build
Lennart Poettering [Fri, 13 Jul 2012 21:38:32 +0000 (23:38 +0200)]
build-sys: fix build

8 years agounit: rename BindTo= to BindsTo=
Lennart Poettering [Fri, 13 Jul 2012 21:34:40 +0000 (23:34 +0200)]
unit: rename BindTo= to BindsTo=

all other dependencies are in 3rd person. Change BindTo= accordingly to

Of course, the dependency is widely used, hence we parse the old name
too for compatibility.

8 years agoman: add man page aliases for all macros/types too
Lennart Poettering [Fri, 13 Jul 2012 21:10:23 +0000 (23:10 +0200)]
man: add man page aliases for all macros/types too