chiark / gitweb /
elogind.git
7 years agojournalctl: various fixes to the access check logic
Lennart Poettering [Sat, 23 Mar 2013 00:12:22 +0000 (01:12 +0100)]
journalctl: various fixes to the access check logic

- Reword messages a bit

- Correct check whether EACCES is in the set of errors

- Don't complain if no journal files are found

- allocate Set object for errors lazily since in the best case we don't
  need it at all.

- don't consider it an error if /run/log/journal doesn't exist (because
  that's the usual case actually, if storage is enabled)

7 years agodbus: Do send out "replies" to signals
Colin Walters [Fri, 22 Mar 2013 13:36:22 +0000 (09:36 -0400)]
dbus: Do send out "replies" to signals

Some parts of systemd (at least the DBus activation codepath) "reply"
to signals, which of course have the no-reply flag set.  We will be
defensive here and still send out a reply if we're passed a signal.

Regression introduced by: c6a818c82035da91e

Reported-by: Mantas Mikulėnas <grawity@gmail.com>
Tested-by: Mantas Mikulėnas <grawity@gmail.com>
7 years agoupdate TODO
Lennart Poettering [Fri, 22 Mar 2013 22:28:36 +0000 (23:28 +0100)]
update TODO

7 years agoexec: Assigning the empty string to CapabilityBoundSet= should drop all caps
Lennart Poettering [Fri, 22 Mar 2013 22:25:54 +0000 (23:25 +0100)]
exec: Assigning the empty string to CapabilityBoundSet= should drop all caps

Previously, it would set all caps, but it should drop them all, anything
else makes little sense.

Also, document that this works as it does, and what to do in order to
assign all caps to the bounding set.

https://bugzilla.redhat.com/show_bug.cgi?id=914705

7 years agoDrop trailing whitespace
Tollef Fog Heen [Fri, 22 Mar 2013 21:51:52 +0000 (22:51 +0100)]
Drop trailing whitespace

7 years agotimedated: extra overflow safety check when doing relative time changes
Lennart Poettering [Fri, 22 Mar 2013 20:35:53 +0000 (21:35 +0100)]
timedated: extra overflow safety check when doing relative time changes

Ensure clients don't overflow usec_t when doing relative time changes.
This is mostly just paranoia and protection against accidents, after all
clients are already authenticated, and they can se the time to any
value they wish anyway, but better be safe than sorry.

https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1152187/comments/14

7 years agoupdate TODO
Lennart Poettering [Fri, 22 Mar 2013 20:17:53 +0000 (21:17 +0100)]
update TODO

7 years agotimedatectl: show CanNTP field
Lennart Poettering [Fri, 22 Mar 2013 20:17:45 +0000 (21:17 +0100)]
timedatectl: show CanNTP field

7 years agoudev: no need to output OOM, if we call log_oom() anyway
Lennart Poettering [Fri, 22 Mar 2013 20:05:42 +0000 (21:05 +0100)]
udev: no need to output OOM, if we call log_oom() anyway

7 years agomain: minor simplification
Lennart Poettering [Fri, 22 Mar 2013 14:05:51 +0000 (15:05 +0100)]
main: minor simplification

7 years agoudev/collect: avoid initalizing memory twice
Zbigniew Jędrzejewski-Szmek [Fri, 22 Mar 2013 00:05:42 +0000 (20:05 -0400)]
udev/collect: avoid initalizing memory twice

7 years agoutil: workaround two gcc warnings
Zbigniew Jędrzejewski-Szmek [Fri, 22 Mar 2013 03:24:30 +0000 (23:24 -0400)]
util: workaround two gcc warnings

gcc does not know that errno cannot be negative, and warns
about unitialized variables later on. Kill the warnings by
returning -errno only after checking that errno is positive.

7 years agojournalctl: be smarter about journal error checks
Zbigniew Jędrzejewski-Szmek [Mon, 11 Mar 2013 22:03:13 +0000 (18:03 -0400)]
journalctl: be smarter about journal error checks

There are many ways in which we can get those checks wrong, so it is
better to warn and then error out on a real access failure.

The error messages are wrapped to <80 lines, because their primary
use is to be displayed in the terminal, and it is easier to read them
this way. Reading them in the journal can be a bit trickier, but
this is a bug in logs-show.c.

7 years agobuild-sys: move acl searching code into libsystemd-acl
Zbigniew Jędrzejewski-Szmek [Fri, 22 Mar 2013 14:35:26 +0000 (14:35 +0000)]
build-sys: move acl searching code into libsystemd-acl

This loop over acls is a bit too much to keep inside
of another loop.

7 years agohostnamed: pretty_string_is_safe() already exists in string_has_cc(), so use that
Lennart Poettering [Fri, 22 Mar 2013 17:01:26 +0000 (18:01 +0100)]
hostnamed: pretty_string_is_safe() already exists in string_has_cc(), so use that

7 years agoutil: be more picky when validating hostnames
Lennart Poettering [Fri, 22 Mar 2013 16:59:49 +0000 (17:59 +0100)]
util: be more picky when validating hostnames

No longer allow dots at the beginning or end of host names, Or double
dots.

https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1152187/comments/14

7 years agojournalctl: give a nice hint about group membership based on ACLs of /var/log/journal
Lennart Poettering [Fri, 22 Mar 2013 16:44:15 +0000 (17:44 +0100)]
journalctl: give a nice hint about group membership based on ACLs of /var/log/journal

If we notice that we unprivileged and not in any of the groups which
have access to /var/log/journal, print a nice message about which groups
do.

This checks and prints all groups that are in the default ACL for
/var/log/journal, which is not necessarily correct for all journal
files, but pretty close.

7 years agocgroup: minor optimization
Lennart Poettering [Fri, 22 Mar 2013 05:01:04 +0000 (06:01 +0100)]
cgroup: minor optimization

7 years agobus: implement object handler registry
Lennart Poettering [Fri, 22 Mar 2013 04:58:47 +0000 (05:58 +0100)]
bus: implement object handler registry

7 years agomount: mount all cgroup controllers in containers, too
Lennart Poettering [Fri, 22 Mar 2013 03:42:48 +0000 (04:42 +0100)]
mount: mount all cgroup controllers in containers, too

7 years agomain: use strv_find() where we can
Lennart Poettering [Fri, 22 Mar 2013 03:42:26 +0000 (04:42 +0100)]
main: use strv_find() where we can

7 years agomain: don't mount cgroup controller unless PID == 1
Lennart Poettering [Fri, 22 Mar 2013 03:40:05 +0000 (04:40 +0100)]
main: don't mount cgroup controller unless PID == 1

This completes c1dae1b3c9729fb8ab749dd4e2dad07e0fad7ed8 in a way.

7 years agoFix vacuum logic error
Jan Alexander Steffens (heftig) [Wed, 20 Mar 2013 20:32:05 +0000 (21:32 +0100)]
Fix vacuum logic error

The vacuum code used to stop vacuuming after one deletion, even
when max_use was still exceeded.

Also make usage a uint64_t, as the code already pretends it is one.

Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
7 years agoman/shutdown: /etc/nologin is called /run/nologin now
Zbigniew Jędrzejewski-Szmek [Fri, 22 Mar 2013 02:47:32 +0000 (22:47 -0400)]
man/shutdown: /etc/nologin is called /run/nologin now

7 years agosystemd-python: allow retrieval of single fields
Zbigniew Jędrzejewski-Szmek [Thu, 21 Mar 2013 03:01:32 +0000 (23:01 -0400)]
systemd-python: allow retrieval of single fields

This can give huge efficiency gains, e.g. if only MESSAGE
is required and all other fields can be ignored.

7 years agosystemd-python: split out realtime and monotonic into separate functions
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 23:12:27 +0000 (19:12 -0400)]
systemd-python: split out realtime and monotonic into separate functions

This matches the C API more closely, and also enables the
user to get just partial information, should she desire to
do so.

Functions names in error messages are modified to not include
the class name, because Python uses just the function name
into functions declared as METH_NOARGS, and error messages
were inconsistent.

7 years agosystemd-python: implement _Reader.test_cursor
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 23:00:37 +0000 (19:00 -0400)]
systemd-python: implement _Reader.test_cursor

Getting the cursor is split out from .get_next() into
.get_cursor(). This mirrors the C API more closely, and
also makes things a bit faster if the cursor is not needed.

7 years agosystemd-python: cleanup up usec_t handling
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 22:40:05 +0000 (18:40 -0400)]
systemd-python: cleanup up usec_t handling

The behaviour wrt. seconds vs. microseconds was inconsistent.
Now _Reader always uses native units (us), while Reader always
uses seconds and accepts both floats and ints. This way the
conversion is always done in the Python layer, and the lower
level API allows access to the journal API without the potentially
lossy conversion between double and uint64_t.

7 years agosystemd-python: export sd_journal_get_usage
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 22:30:10 +0000 (18:30 -0400)]
systemd-python: export sd_journal_get_usage

7 years agoefivars: fix return code
Zbigniew Jędrzejewski-Szmek [Fri, 22 Mar 2013 00:55:17 +0000 (20:55 -0400)]
efivars: fix return code

Was returning 1 on read error.

7 years agoshutdownd: shut up bogus gcc warning
Zbigniew Jędrzejewski-Szmek [Thu, 21 Mar 2013 23:20:41 +0000 (19:20 -0400)]
shutdownd: shut up bogus gcc warning

This one is fake. But let's kill it, avoiding two condition checks
in the process.

src/shutdownd/shutdownd.c: In function 'when_wall':
src/shutdownd/shutdownd.c:182:44: warning: 'sub' may be used uninitialized in this function [-Wmaybe-uninitialized]
         return elapse > sub ? elapse - sub : 1;
                                            ^

7 years agobootchart: fix two unitialized memory frees
Zbigniew Jędrzejewski-Szmek [Thu, 21 Mar 2013 23:10:50 +0000 (19:10 -0400)]
bootchart: fix two unitialized memory frees

The new gcc isn't bad!

In file included from src/bootchart/svg.c:36:0:
src/bootchart/svg.c: In function 'svg_ps_bars':
./src/shared/util.h:524:13: warning: 'enc_name' may be used uninitialized in this function [-Wmaybe-uninitialized]
         free(*(void**) p);
             ^
src/bootchart/svg.c:821:37: note: 'enc_name' was declared here
                 char _cleanup_free_*enc_name;
                                     ^
  CC     src/udev/mtd_probe/mtd_probe-probe_smartmedia.o
  XSLT     man/systemd.unit.5
In file included from src/bootchart/svg.c:36:0:
src/bootchart/svg.c: In function 'svg_pss_graph':
./src/shared/util.h:524:13: warning: 'enc_name' may be used uninitialized in this function [-Wmaybe-uninitialized]
         free(*(void**) p);
             ^
src/bootchart/svg.c:395:37: note: 'enc_name' was declared here
                 char _cleanup_free_*enc_name;
                                     ^

7 years agoinitctl: fix return from unitialized memory in error path
Zbigniew Jędrzejewski-Szmek [Thu, 21 Mar 2013 23:06:55 +0000 (19:06 -0400)]
initctl: fix return from unitialized memory in error path

src/initctl/initctl.c: In function 'server_init':
src/initctl/initctl.c:282:13: warning: 'r' may be used uninitialized in this function [-Wmaybe-uninitialized]
         int r;
             ^

7 years agobuild-sys: use _FORTIFY_SOURCE with new gcc level -Og
Zbigniew Jędrzejewski-Szmek [Thu, 21 Mar 2013 18:53:12 +0000 (18:53 +0000)]
build-sys: use _FORTIFY_SOURCE with new gcc level -Og

7 years agobus: implicitly collect ucred/label information
Lennart Poettering [Fri, 22 Mar 2013 02:36:58 +0000 (03:36 +0100)]
bus: implicitly collect ucred/label information

7 years agobus: also finish connection before returning from sd_bus_get_unique_name()
Lennart Poettering [Fri, 22 Mar 2013 02:34:29 +0000 (03:34 +0100)]
bus: also finish connection before returning from sd_bus_get_unique_name()

7 years agobus: when parsing enforce maximum container depth
Lennart Poettering [Fri, 22 Mar 2013 01:32:34 +0000 (02:32 +0100)]
bus: when parsing enforce maximum container depth

7 years agobus: fix uninitialized variable
Lennart Poettering [Fri, 22 Mar 2013 01:20:39 +0000 (02:20 +0100)]
bus: fix uninitialized variable

7 years agobus: validate the hello response properly
Lennart Poettering [Fri, 22 Mar 2013 01:20:21 +0000 (02:20 +0100)]
bus: validate the hello response properly

7 years agobus: properly verify recursion depth of signatures
Lennart Poettering [Fri, 22 Mar 2013 01:19:49 +0000 (02:19 +0100)]
bus: properly verify recursion depth of signatures

7 years agobus: rework synchronization logic
Lennart Poettering [Fri, 22 Mar 2013 00:49:56 +0000 (01:49 +0100)]
bus: rework synchronization logic

Instead of allowing certain actions fail during authentication and
connection setup, implicitly synchronize on the connection to be set up
completely before returning.

7 years agobus: reuse more code
Lennart Poettering [Fri, 22 Mar 2013 00:49:13 +0000 (01:49 +0100)]
bus: reuse more code

7 years agobus: validate the entire header more closely
Lennart Poettering [Fri, 22 Mar 2013 00:15:20 +0000 (01:15 +0100)]
bus: validate the entire header more closely

7 years agobus: properly validate object path values
Lennart Poettering [Thu, 21 Mar 2013 23:42:53 +0000 (00:42 +0100)]
bus: properly validate object path values

7 years agobus: generate a nice error when attempting to add a NULL string
Lennart Poettering [Thu, 21 Mar 2013 23:24:21 +0000 (00:24 +0100)]
bus: generate a nice error when attempting to add a NULL string

7 years agobus: implicitly handle peer commands Ping() and GetMachineId()
Lennart Poettering [Thu, 21 Mar 2013 23:08:58 +0000 (00:08 +0100)]
bus: implicitly handle peer commands Ping() and GetMachineId()

7 years agobus: enforce limits on all client influenced data objects
Lennart Poettering [Thu, 21 Mar 2013 22:20:25 +0000 (23:20 +0100)]
bus: enforce limits on all client influenced data objects

7 years agobus: implicitly set no_reply flag on outgoing messages if the serial number is not...
Lennart Poettering [Thu, 21 Mar 2013 22:01:59 +0000 (23:01 +0100)]
bus: implicitly set no_reply flag on outgoing messages if the serial number is not kept

If nobody keeps the serial number of an outgoing message we know that
nobody expects an answer to it, so set the no_reply flag accordingly.

7 years agoudev: always set selinux label at "add" events
Kay Sievers [Thu, 21 Mar 2013 22:11:51 +0000 (23:11 +0100)]
udev: always set selinux label at "add" events

https://bugs.freedesktop.org/show_bug.cgi?id=62615

7 years agobus: implement full method call timeout logic
Lennart Poettering [Thu, 21 Mar 2013 21:50:25 +0000 (22:50 +0100)]
bus: implement full method call timeout logic

7 years agohwdb: update
Kay Sievers [Thu, 21 Mar 2013 21:17:13 +0000 (22:17 +0100)]
hwdb: update

7 years agoMAkefile.am: whitespace cleanup
Kay Sievers [Thu, 21 Mar 2013 21:16:55 +0000 (22:16 +0100)]
MAkefile.am: whitespace cleanup

7 years agodoc: disable gtk-doc test again - you are a really annoying piece of software
Kay Sievers [Thu, 21 Mar 2013 14:07:54 +0000 (15:07 +0100)]
doc: disable gtk-doc test again - you are a really annoying piece of software

make  check-TESTS
make[5]: Nothing to be done for `/usr/bin/gtkdoc-check.log'.
fatal: making test-suite.log: failed to create /usr/bin/gtkdoc-check.trs
fatal: making test-suite.log: failed to create /usr/bin/gtkdoc-check.log
make[4]: *** [test-suite.log] Error 1
make[3]: *** [check-TESTS] Error 2
make[2]: *** [check-am] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [check] Error 2

7 years agobuild-sys: include missing header in dist tarball
Michael Biebl [Thu, 21 Mar 2013 10:05:43 +0000 (11:05 +0100)]
build-sys: include missing header in dist tarball

7 years agoshared: add simple priority queue implementation
Lennart Poettering [Thu, 21 Mar 2013 01:42:28 +0000 (02:42 +0100)]
shared: add simple priority queue implementation

7 years agobus: compare to negative errno
Dave Reisner [Wed, 20 Mar 2013 23:25:37 +0000 (19:25 -0400)]
bus: compare to negative errno

7 years agoactivate: avoid warning from -Wshadow
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 22:30:31 +0000 (18:30 -0400)]
activate: avoid warning from -Wshadow

src/activate/activate.c:167:51: warning: declaration shadows a variable in the global scope [-Wshadow]
static int launch(char* name, char **argv, char **environ, int fds) {
                                                  ^
/usr/include/unistd.h:546:15: note: previous declaration is here
extern char **environ;
              ^

7 years agoMake two functions static
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 22:27:49 +0000 (18:27 -0400)]
Make two functions static

7 years agoRemove some unused variables
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 22:25:35 +0000 (18:25 -0400)]
Remove some unused variables

7 years agosystemd-analyze: do not format timestamp when not printing it
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 22:22:20 +0000 (18:22 -0400)]
systemd-analyze: do not format timestamp when not printing it

../src/analyze/systemd-analyze.c:530:88: warning: data argument not used by format string [-Wformat-extra-args]
  ...svg_text(false, u->ixt, y, u->time? "%s (%s)" : "%s", u->name, format_timespan(ts, sizeof(ts), u->time));
                                                     ~~~~           ^

7 years agocore: remove unnecessary goto in setup_namespace
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 22:12:37 +0000 (18:12 -0400)]
core: remove unnecessary goto in setup_namespace

7 years agobus-message: fix typo
Tom Gundersen [Wed, 20 Mar 2013 23:01:14 +0000 (00:01 +0100)]
bus-message: fix typo

7 years agoupdate TODO
Lennart Poettering [Wed, 20 Mar 2013 21:57:55 +0000 (22:57 +0100)]
update TODO

7 years agobus: hook up client with socket communication
Lennart Poettering [Wed, 20 Mar 2013 21:56:25 +0000 (22:56 +0100)]
bus: hook up client with socket communication

7 years agobus: introduce bus_error_is_dirty() independently of sd_bus_error_is_set()
Lennart Poettering [Wed, 20 Mar 2013 12:10:12 +0000 (13:10 +0100)]
bus: introduce bus_error_is_dirty() independently of sd_bus_error_is_set()

7 years agobus: demarshal header fields properly
Lennart Poettering [Wed, 20 Mar 2013 04:29:20 +0000 (05:29 +0100)]
bus: demarshal header fields properly

7 years agobus: implement demarshaller
Lennart Poettering [Wed, 20 Mar 2013 02:15:03 +0000 (03:15 +0100)]
bus: implement demarshaller

7 years agobus: suppress reply messages to method calls with no_reply set
Lennart Poettering [Tue, 19 Mar 2013 19:16:27 +0000 (20:16 +0100)]
bus: suppress reply messages to method calls with no_reply set

7 years agobus: add basic implementation of a native bus client library
Lennart Poettering [Tue, 19 Mar 2013 19:03:16 +0000 (20:03 +0100)]
bus: add basic implementation of a native bus client library

7 years agostdio-bridge: modernization
Lennart Poettering [Tue, 19 Mar 2013 19:01:35 +0000 (20:01 +0100)]
stdio-bridge: modernization

7 years agoutil: add hexmem() and strextend() calls
Lennart Poettering [Tue, 19 Mar 2013 19:01:18 +0000 (20:01 +0100)]
util: add hexmem() and strextend() calls

7 years agomacro: add CHAR_TO_STR macro to make a one character string from a char
Lennart Poettering [Tue, 19 Mar 2013 19:00:55 +0000 (20:00 +0100)]
macro: add CHAR_TO_STR macro to make a one character string from a char

7 years agomacro: don't redefine CLAMP if it is already defined by glib or some other library
Lennart Poettering [Tue, 19 Mar 2013 19:00:29 +0000 (20:00 +0100)]
macro: don't redefine CLAMP if it is already defined by glib or some other library

7 years agoMake PrivateTmp dirs also inaccessible from the outside
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 05:38:28 +0000 (01:38 -0400)]
Make PrivateTmp dirs also inaccessible from the outside

Currently, PrivateTmp=yes means that the service cannot see the /tmp
shared by rest of the system and is isolated from other services using
PrivateTmp, but users can access and modify /tmp as seen by the
service.

Move the private /tmp and /var/tmp directories into a 0077-mode
directory. This way unpriviledged users on the system cannot see (or
modify) /tmp as seen by the service.

7 years agobuild-sys: fix typo in human-readable output
Jan Engelhardt [Wed, 20 Mar 2013 14:23:30 +0000 (15:23 +0100)]
build-sys: fix typo in human-readable output

7 years agolibudev: avoid potential misaligned accesses
Jan Engelhardt [Wed, 20 Mar 2013 14:23:32 +0000 (15:23 +0100)]
libudev: avoid potential misaligned accesses

clang reports:
  src/libudev/libudev-util.c:665:35: warning: cast from
  "const unsigned char *" to "unsigned int *" increases required alignment
  from 1 to 4 [-Wcast-align]

7 years agolibude: remove special handling of "device" link, it should not be used
Kay Sievers [Wed, 20 Mar 2013 14:57:13 +0000 (15:57 +0100)]
libude: remove special handling of "device" link, it should not be used

7 years agozsh completion: udev - remove firmware builtin
Tom Gundersen [Wed, 20 Mar 2013 12:09:58 +0000 (13:09 +0100)]
zsh completion: udev - remove firmware builtin

7 years agoman/service: document behaviour on failure
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 02:13:48 +0000 (22:13 -0400)]
man/service: document behaviour on failure

https://bugs.freedesktop.org/show_bug.cgi?id=38355

7 years agocatalog: remove broken links to wiki
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 00:57:25 +0000 (20:57 -0400)]
catalog: remove broken links to wiki

https://bugs.freedesktop.org/show_bug.cgi?id=58359

7 years agojournalct: beef up entry listing
Zbigniew Jędrzejewski-Szmek [Wed, 20 Mar 2013 00:54:04 +0000 (20:54 -0400)]
journalct: beef up entry listing

The ability to dump catalog entries in full and by id is added.

7 years agosystemd-python: small cleanups
Zbigniew Jędrzejewski-Szmek [Fri, 15 Mar 2013 22:10:51 +0000 (18:10 -0400)]
systemd-python: small cleanups

- separate methods with two empty lines for clarity
- avoid malloc(0) by specyfing private data size as -1
- add method name in error messages

7 years agosystemd-python: add journal.get_catalog()
Zbigniew Jędrzejewski-Szmek [Fri, 15 Mar 2013 22:10:51 +0000 (18:10 -0400)]
systemd-python: add journal.get_catalog()

This one wraps sd_journal_get_catalog_from_message_id.
Thanks to Python namespacing, we can stick to a shorter name.

7 years agosystemd-python: add _Reader.get_catalog()
Zbigniew Jędrzejewski-Szmek [Fri, 15 Mar 2013 22:10:51 +0000 (18:10 -0400)]
systemd-python: add _Reader.get_catalog()

This one wraps sd_journaal_get_catalog.

7 years agoman/catalog: fix synopsis and remind to free
Zbigniew Jędrzejewski-Szmek [Fri, 15 Mar 2013 22:10:51 +0000 (18:10 -0400)]
man/catalog: fix synopsis and remind to free

7 years agosystemd-python: add _Reader.closed attribute
Zbigniew Jędrzejewski-Szmek [Fri, 15 Mar 2013 22:10:51 +0000 (18:10 -0400)]
systemd-python: add _Reader.closed attribute

This should make the file interface of _Reader complete.

7 years agojournalctl: use _cleanup_ in one function
Zbigniew Jędrzejewski-Szmek [Fri, 15 Mar 2013 22:00:57 +0000 (18:00 -0400)]
journalctl: use _cleanup_ in one function

7 years agorules: move builtin calls before the permissions section
Kay Sievers [Wed, 20 Mar 2013 00:26:17 +0000 (01:26 +0100)]
rules: move builtin calls before the permissions section

<heftig> kay: systemd commit 22582bb broke cups usb printing for me
<heftig> because the "lp" group isn't applied anymore
<heftig> SUBSYSTEM=="usb", ENV{DEVTYPE}=="usb_device", ENV{ID_USB_INTERFACES}=="*:0701??:*", GROUP="lp"
<heftig> moving this line to the end of 50-udev-default.rules restores correct behavior, as it's after usb_id

7 years agoshell-completion/bash/journalctl: suppress stderr
Harald Hoyer [Tue, 19 Mar 2013 13:55:50 +0000 (14:55 +0100)]
shell-completion/bash/journalctl: suppress stderr

7 years agokeymap: Remap microphone mute and touchpad toggle for Lenovo U300s
Ozan Çağlayan [Tue, 19 Mar 2013 13:49:30 +0000 (15:49 +0200)]
keymap: Remap microphone mute and touchpad toggle for Lenovo U300s

Separate out Ideapad U300s to its own line and add Microphone mute key.

Signed-off-by: Martin Pitt <martinpitt@gnome.org>
7 years agokeymaps: Use F20 for micmute keys to be friendly to X.org
Martin Pitt [Tue, 19 Mar 2013 12:10:29 +0000 (13:10 +0100)]
keymaps: Use F20 for micmute keys to be friendly to X.org

The "micmute" key code is outside of X.org's allowed range [1].
gnome-settings-daemon interprets F20 as "microphone mute" these days [2], so
use this until X.org either gets fixed or obsoleted.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=692071
[2] https://mail.gnome.org/archives/commits-list/2013-January/msg05822.html

7 years agokeymap: Fix touchpad toggling on Lenovo IdeaPad U300s
Ozan Çağlayan [Tue, 19 Mar 2013 09:34:57 +0000 (11:34 +0200)]
keymap: Fix touchpad toggling on Lenovo IdeaPad U300s

IdeaPad U300s needs mapping 0xf1 to f21 just like Lenovo V480.

Signed-off-by: Martin Pitt <martinpitt@gnome.org>
7 years agologind: exploit previous cleanups and simplify returns
Zbigniew Jędrzejewski-Szmek [Tue, 19 Mar 2013 00:31:21 +0000 (20:31 -0400)]
logind: exploit previous cleanups and simplify returns

7 years agologind: Make more use of cleanup macros
Colin Walters [Mon, 18 Mar 2013 18:38:48 +0000 (14:38 -0400)]
logind: Make more use of cleanup macros

7 years agoUse bus_maybe_send_reply() where applicable
Colin Walters [Mon, 18 Mar 2013 18:38:24 +0000 (14:38 -0400)]
Use bus_maybe_send_reply() where applicable

This is a followup to: commit 1a37b9b9043ef83e9900e460a9a1fccced3acf89

It will fix denial messages from dbus-daemon between gdm and
systemd-logind on logging into GNOME due to this.

See the previous commit for more details.

7 years agosd-journal: do not require path to be absolute
Zbigniew Jędrzejewski-Szmek [Sun, 4 Nov 2012 15:19:04 +0000 (16:19 +0100)]
sd-journal: do not require path to be absolute

Seems natural to be able to specify relative directory,
e.g. with journalctl -D. And even if, this should be checked
in front-end code, not in the library.

7 years agojournal,shared: add _cleanup_journal_close_
Zbigniew Jędrzejewski-Szmek [Mon, 18 Mar 2013 03:36:25 +0000 (23:36 -0400)]
journal,shared: add _cleanup_journal_close_

7 years agojournal: use _cleanup_
Zbigniew Jędrzejewski-Szmek [Mon, 18 Mar 2013 02:00:01 +0000 (22:00 -0400)]
journal: use _cleanup_

One log_debug() moved to match order in other functions.

7 years agojournal: use sd_journal_close on error in sd_journal_new
Zbigniew Jędrzejewski-Szmek [Mon, 18 Mar 2013 01:52:57 +0000 (21:52 -0400)]
journal: use sd_journal_close on error in sd_journal_new

7 years agosystemd-python: allow Reader to be used as a context manager
Zbigniew Jędrzejewski-Szmek [Mon, 18 Mar 2013 05:12:25 +0000 (01:12 -0400)]
systemd-python: allow Reader to be used as a context manager