chiark / gitweb /
7 years agosystemcl: add support for setting BlockIORead/WriteBandwidth for unit
Gao feng [Fri, 30 Aug 2013 02:56:02 +0000 (10:56 +0800)]
systemcl: add support for setting BlockIORead/WriteBandwidth for unit

This patch allows user to set up BlockIOReadBandwidth and BlockIOWriteBandwidth
for unit through systemctl. Such as

systemctl set-property sshd.service BlockIOReadBandwidth="/dev/sda 100000"
systemctl set-property sshd.service BlockIOWriteBandwidth="/dev/sda 200000"

7 years agocgroup: setup BlockIORead/WriteBandwidth in bus_cgroup_set_property
Gao feng [Tue, 10 Sep 2013 15:23:07 +0000 (17:23 +0200)]
cgroup: setup BlockIORead/WriteBandwidth in bus_cgroup_set_property

This patch adds the support for setting up BlockIORead/WriteBandwidth
in bus_cgroup_set_property.

7 years agoblkio bandwidth: don't clean up all of entries in blockio_device_bandwidths list
Gao feng [Fri, 30 Aug 2013 02:56:00 +0000 (10:56 +0800)]
blkio bandwidth: don't clean up all of entries in blockio_device_bandwidths list

if we get BlockIOReadBandwidth="", we should only remove the
read-bandwidth-entries in blockio_device_bandwidths list.

7 years agoman: split systemctl commands to sections
Lukas Nykryn [Wed, 28 Aug 2013 13:46:59 +0000 (15:46 +0200)]
man: split systemctl commands to sections

7 years agoservice: remove pidfile after exit of a service
Lukas Nykryn [Wed, 28 Aug 2013 17:27:44 +0000 (19:27 +0200)]
service: remove pidfile after exit of a service

7 years agoman: add not to not use -x in bug reports
Zbigniew Jędrzejewski-Szmek [Tue, 10 Sep 2013 12:27:15 +0000 (08:27 -0400)]
man: add not to not use -x in bug reports

7 years agojournald: be a bit more verbose when vacuuming
Zbigniew Jędrzejewski-Szmek [Tue, 10 Sep 2013 12:20:24 +0000 (08:20 -0400)]
journald: be a bit more verbose when vacuuming

Vacuuming behaviour is a bit confusing, and/or we have some bugs,
so those additional messages should help to find out what's going
on. Also, rotation of journal files shouldn't be happening too
often, so the level of the messages is bumped to info, so that
they'll be logged under normal operation.

7 years agokeymap: Add Asus WMI module
Martin Pitt [Mon, 9 Sep 2013 21:41:03 +0000 (17:41 -0400)]
keymap: Add Asus WMI module

We need to override the TOUCHPAD_TOGGLE to F21 to make it useful under X, as
for other models.

7 years agobuild-sys: gpt-auto-generator depends on HAVE_BLKID
Marcel Holtmann [Sat, 7 Sep 2013 16:25:07 +0000 (09:25 -0700)]
build-sys: gpt-auto-generator depends on HAVE_BLKID

7 years agoFix two compiler warnings
Zbigniew Jędrzejewski-Szmek [Mon, 9 Sep 2013 21:31:10 +0000 (17:31 -0400)]
Fix two compiler warnings

7 years agorun: allow non-absolute paths as command
Zbigniew Jędrzejewski-Szmek [Sun, 8 Sep 2013 11:51:39 +0000 (07:51 -0400)]
run: allow non-absolute paths as command

7 years agopath-util.c: small modernization
Zbigniew Jędrzejewski-Szmek [Sun, 8 Sep 2013 11:31:25 +0000 (07:31 -0400)]
path-util.c: small modernization

7 years agosystemd-run: properly escape arguments
Zbigniew Jędrzejewski-Szmek [Sat, 31 Aug 2013 18:28:09 +0000 (20:28 +0200)]
systemd-run: properly escape arguments

Spaces, quotes, and such, were not properly escaped. We should
write them like we read them.

7 years agoTODO: update todo
Dave Reisner [Fri, 6 Sep 2013 20:26:55 +0000 (16:26 -0400)]
TODO: update todo

7 years agoman: fix typo
Zbigniew Jędrzejewski-Szmek [Fri, 6 Sep 2013 11:14:26 +0000 (13:14 +0200)]
man: fix typo

7 years agosystemd-coredump: Log crashes without coredumps on failure
Andrew Cook [Wed, 4 Sep 2013 13:27:52 +0000 (23:27 +1000)]
systemd-coredump: Log crashes without coredumps on failure

Make a best-effort attempt to store information about crashes during
failure, currently if these are encountered the crash is completely

ideally coredumpctl would show if a coredump is available.

7 years agosystemd-coredump: Ignore coredumps larger than COREDUMP_MAX
Andrew Cook [Wed, 4 Sep 2013 13:27:40 +0000 (23:27 +1000)]
systemd-coredump: Ignore coredumps larger than COREDUMP_MAX

Currently this check happens when the coredump has been collected in
it's entirety and being received by journald. this is not ideal
behaviour when the crashing process is consuming significant percentage
of physical memory such as a large instance of firefox or a java

7 years agojournald: fix fd leak in journal_file_empty
George McCollister [Wed, 4 Sep 2013 12:12:44 +0000 (07:12 -0500)]
journald: fix fd leak in journal_file_empty

Before my previous patch, journal_file_empty wasn't be called with the
correct filename. Now that it's being called with the correct filename
it leaks file descriptors. This patch closes the file descriptors before

Signed-off-by: George McCollister <>
[Edit make use of _cleanup_close_ instead]

7 years agojournald: fix vacuuming of archived journals
George McCollister [Wed, 4 Sep 2013 12:12:43 +0000 (07:12 -0500)]
journald: fix vacuuming of archived journals

d_name is modified on line 227 so if the entire journal name is needed
again p must be used. Before this change when journal_file_empty was called
on archived journals it would always return with -2.

Signed-off-by: George McCollister <>
7 years agolibudev: enumerate - do not try to match against an empty subsystem
Kay Sievers [Wed, 4 Sep 2013 15:59:14 +0000 (17:59 +0200)]
libudev: enumerate - do not try to match against an empty subsystem

7 years agolibudev: enumerate: fix NULL-deref for subsystem-matches
David Herrmann [Fri, 30 Aug 2013 13:50:41 +0000 (15:50 +0200)]
libudev: enumerate: fix NULL-deref for subsystem-matches

udev_device_get_subsystem() may return NULL if no subsystem could be
figured out by libudev. This might be due to OOM or if the device
disconnected between the udev_device_new() call and
udev_device_get_subsystem(). Therefore, we need to handle subsystem==NULL

Instead of testing for it in each helper, we treat subsystem==NULL as
empty subsystem in match_subsystem().

Backtrace of udev_enumerate with an input-device disconnecting in exactly
this time-frame:
 (gdb) bt
 #0  0x00007ffff569dc24 in strnlen () from /usr/lib/
 #1  0x00007ffff56d9e04 in fnmatch@@GLIBC_2.2.5 () from /usr/lib/
 #2  0x00007ffff5beb83d in match_subsystem (udev_enumerate=0x7a05f0, subsystem=0x0) at src/libudev/libudev-enumerate.c:727
 #3  0x00007ffff5bebb30 in parent_add_child (enumerate=enumerate@entry=0x7a05f0, path=<optimized out>) at src/libudev/libudev-enumerate.c:834
 #4  0x00007ffff5bebc3f in parent_crawl_children (enumerate=enumerate@entry=0x7a05f0, path=0x7a56b0 "/sys/devices/<shortened>/input/input97", maxdepth=maxdepth@entry=254) at src/libudev/libudev-enumerate.c:866
 #5  0x00007ffff5bebc54 in parent_crawl_children (enumerate=enumerate@entry=0x7a05f0, path=0x79e8c0 "/sys/devices/<shortened>/input", maxdepth=maxdepth@entry=255) at src/libudev/libudev-enumerate.c:868
 #6  0x00007ffff5bebc54 in parent_crawl_children (enumerate=enumerate@entry=0x7a05f0, path=path@entry=0x753190 "/sys/devices/<shortened>", maxdepth=maxdepth@entry=256) at src/libudev/libudev-enumerate.c:868
 #7  0x00007ffff5bec7df in scan_devices_children (enumerate=0x7a05f0) at src/libudev/libudev-enumerate.c:882
 #8  udev_enumerate_scan_devices (udev_enumerate=udev_enumerate@entry=0x7a05f0) at src/libudev/libudev-enumerate.c:919
 #9  0x00007ffff5df8777 in <random_caller> () at some/file.c:181

7 years agocgtop: fixup the online help
Brandon Philips [Wed, 4 Sep 2013 04:34:02 +0000 (21:34 -0700)]
cgtop: fixup the online help

The online help shows the keys as uppercase but the code and manpage say
lower case. Make the online help follow reality.

7 years agolibudev: fix memleak when enumerating childs
David Herrmann [Wed, 4 Sep 2013 10:36:19 +0000 (12:36 +0200)]
libudev: fix memleak when enumerating childs

We need to free udev-devices again if they don't match. Funny that no-one
noticed it yet since valgrind is quite verbose about it.
Fix it and free non-matching devices.

7 years agokeymap: Explicitly match "any product name" for "all models from vendor" rules
Martin Pitt [Mon, 2 Sep 2013 06:11:07 +0000 (08:11 +0200)]
keymap: Explicitly match "any product name" for "all models from vendor" rules

Without this, the hwdb trie gets mis-sorted to match the more specific rules
first, as ":pvr" is lexicographically after ":pn". So ensure that all our
matches have some ":pn" match to avoid this trap.

7 years agokeymap: Fix typo in Latitude/Precision rules
Martin Pitt [Mon, 2 Sep 2013 05:36:34 +0000 (07:36 +0200)]
keymap: Fix typo in Latitude/Precision rules

We actually want to match the product name, "pn:" makes no sense.

7 years agomain: drop capabilities of userhelpers before ours
Harald Hoyer [Fri, 30 Aug 2013 08:23:50 +0000 (10:23 +0200)]
main: drop capabilities of userhelpers before ours

First drop the capabilities of the userhelpers before dropping our own,
otherwise we might not be allowed to drop the capabilities of the
userhelpers. Especially, if we want to drop CAP_SYS_MODULE.

Credits: Matteo Sasso

7 years agokeymap: Don't use spaces in DMI modalias matches
Martin Pitt [Fri, 30 Aug 2013 04:43:26 +0000 (06:43 +0200)]
keymap: Don't use spaces in DMI modalias matches

Spaces get dropped from DMI modaliases. Replace them with '*' to make them
robust against future changes in space escaping.

7 years agokeymap: Fix Dell vendor names
Martin Pitt [Fri, 30 Aug 2013 04:31:12 +0000 (06:31 +0200)]
keymap: Fix Dell vendor names

Spaces are dropped from vendor and product names in DMI modaliases, so a match
like "svnDell Inc.:" will never happen. Also, some machines use "Dell", some
"Dell Inc", some "Dell Inc.", so just match on "Dell*" to avoid all these

7 years agokeymap: Don't erase previous assignments
Martin Pitt [Thu, 29 Aug 2013 15:48:42 +0000 (17:48 +0200)]
keymap: Don't erase previous assignments

Don't use "KEYBOARD_KEY_xx=!" assignments (i. e. only enabling force-release)
if more general matches already explicitly set a key code before, to not
override the previously set value.

7 years agoDo not realloc strings, which are already in the hashmap as keys
Harald Hoyer [Wed, 28 Aug 2013 13:33:35 +0000 (15:33 +0200)]
Do not realloc strings, which are already in the hashmap as keys

This prevents corruption of the hashmap, because we would free() the
keys in the hashmap, if the unit is already in there, with the same
cgroup path.

7 years agoRevert "cgroup.c: check return value of unit_realize_cgroup_now()"
Harald Hoyer [Wed, 28 Aug 2013 14:02:39 +0000 (16:02 +0200)]
Revert "cgroup.c: check return value of unit_realize_cgroup_now()"

This reverts commit 1f11a0cdfe397cc404d61ee679fc12f58c0a885b.

7 years agocgroup: only check once when mode is UNIT_CHECK
Gao feng [Mon, 26 Aug 2013 02:36:45 +0000 (10:36 +0800)]
cgroup: only check once when mode is UNIT_CHECK

If the mode is UNIT_CHECK,it means we only want to check if
the paramaters are valid. the first round of cycle already
did this check, no need to check again.

7 years agodevice cgroup: don't create a new CGroupDeviceAllow when it already in the list
Gao feng [Wed, 28 Aug 2013 01:49:11 +0000 (09:49 +0800)]
device cgroup: don't create a new CGroupDeviceAllow when it already in the list

If a device node is already in the device_allow list of
CGroupContext, we should replace it instead of create a
new one and append this new one to the end of device_allow

change from v1: use streq to replace !strcmp

7 years agoblcokio bandwidth: add missing set of CGroupBlockIODeviceBandwidth's read
Gao feng [Wed, 28 Aug 2013 04:10:16 +0000 (12:10 +0800)]
blcokio bandwidth: add missing set of CGroupBlockIODeviceBandwidth's read

BlockIOReadBandwidth and BlockIOWriteBandwidth both use
config_parse_blockio_bandwidth to set up CGroupBlockIODeviceBandwidth,
We should set the read value based on the left values
in config files.

7 years agologind-session.c: use _cleanup_
Zbigniew Jędrzejewski-Szmek [Sun, 25 Aug 2013 03:48:34 +0000 (23:48 -0400)]
logind-session.c: use _cleanup_

7 years agologind: be more verbose on errors
Zbigniew Jędrzejewski-Szmek [Sat, 24 Aug 2013 14:52:23 +0000 (10:52 -0400)]
logind: be more verbose on errors

7 years agoDisallow invalid UTF-8 configuration
Zbigniew Jędrzejewski-Szmek [Sat, 24 Aug 2013 14:51:55 +0000 (10:51 -0400)]
Disallow invalid UTF-8 configuration

It is best to catch such errors early. If invalid UTF-8 ends up being
given to dbus methods, the program will crash:

process 20801: arguments to dbus_message_iter_append_basic() were incorrect, assertion "_dbus_check_is_valid_utf8 (*string_p)" failed in file dbus-message.c line 2598.

7 years agoshell-completions: systemd-analyze set-log-level
Zbigniew Jędrzejewski-Szmek [Fri, 23 Aug 2013 03:25:28 +0000 (23:25 -0400)]
shell-completions: systemd-analyze set-log-level

7 years agolog to kmsg when "debug" is used on the kernel command line
Kay Sievers [Tue, 27 Aug 2013 16:25:06 +0000 (18:25 +0200)]
log to kmsg when "debug" is used on the kernel command line

7 years agokeymap: Add Logitech Internet Navigator variant [PID C309]
Martin Pitt [Tue, 27 Aug 2013 10:57:01 +0000 (12:57 +0200)]
keymap: Add Logitech Internet Navigator variant [PID C309]

By Albrecht Kolthoff <> via linux-hotplug@.

7 years agokeymap: Add Samsung NP53U3C
Martin Pitt [Mon, 26 Aug 2013 14:49:10 +0000 (16:49 +0200)]
keymap: Add Samsung NP53U3C

7 years agozsh_completion: Fix --user-unit completion
William Giokas [Sat, 24 Aug 2013 12:23:27 +0000 (07:23 -0500)]
zsh_completion: Fix --user-unit completion

_SYSTEMD_USER_UNIT in the --user-unit flag argument should instead be
USER_UNIT. It should also have an optional `=` between the flag and the

7 years agoKeyboard map for Samsung NP700Z3C
Herczeg Zsolt [Fri, 23 Aug 2013 14:18:36 +0000 (16:18 +0200)]
Keyboard map for Samsung NP700Z3C

I'm using Ubuntu 13.04 on a Samsung Series 5 computer and found that that
Fn hotkeys does not work.

7 years agoman: Small grammar fix
Zbigniew Jędrzejewski-Szmek [Fri, 23 Aug 2013 17:13:12 +0000 (13:13 -0400)]
man: Small grammar fix

Use Oxford comma.

7 years agokeyboard: add eMachines E725
Zbigniew Jędrzejewski-Szmek [Fri, 23 Aug 2013 17:00:43 +0000 (13:00 -0400)]
keyboard: add eMachines E725

Information supplied by Ludvig <>.

7 years agozsh_completion: Fix single letter args
William Giokas [Wed, 21 Aug 2013 03:06:54 +0000 (22:06 -0500)]
zsh_completion: Fix single letter args

Things like -n to specify the lines to show with systemctl and
journalctl accepts syntax like:

  journalctl -n4
  systemctl -n14

Previously, typing `-nXX <tab>` where XX is a number, zsh would try to
complete an integer. Now it will see the XX and use the _journalctl_none
completion. This is also how any of the single letter options that take
arguments work as well.

7 years ago"-" prefix for InaccessibleDirectories and ReadOnlyDirectories
Maciej Wereski [Wed, 21 Aug 2013 14:43:55 +0000 (16:43 +0200)]
"-" prefix for InaccessibleDirectories and ReadOnlyDirectories

7 years agoman: make reference to bind(2) explicit
Shawn Landden [Wed, 21 Aug 2013 16:56:58 +0000 (09:56 -0700)]
man: make reference to bind(2) explicit

7 years agoudev: fix printf(3) type specifier
Shawn Landden [Fri, 23 Aug 2013 04:17:16 +0000 (21:17 -0700)]
udev: fix printf(3) type specifier

src/udev/udev-rules.c: In function 'add_rule':
src/udev/udev-rules.c:1078:33: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'int' [-Wformat=]
                                 log_error("invalid key/value pair in file %s on line %u,"

7 years agoblkio: fix incorrect setting of cpu_shares
Gao feng [Fri, 23 Aug 2013 09:53:23 +0000 (17:53 +0800)]
blkio: fix incorrect setting of cpu_shares

We should set up blockio_weight not cpu_shares.

7 years agonspawn: trivial simplification
Zbigniew Jędrzejewski-Szmek [Wed, 21 Aug 2013 23:35:32 +0000 (19:35 -0400)]
nspawn: trivial simplification

7 years agocgroup.c: check return value of unit_realize_cgroup_now()
Harald Hoyer [Fri, 23 Aug 2013 16:46:06 +0000 (18:46 +0200)]
cgroup.c: check return value of unit_realize_cgroup_now()

do not recurse further, if unit_realize_cgroup_now() failed

7 years agoRevert "udevd: simplify sigterm check"
Colin Walters [Thu, 22 Aug 2013 21:03:29 +0000 (17:03 -0400)]
Revert "udevd: simplify sigterm check"

This reverts commit 47e737dc13bf4251ae5a2249ec29b34503ed92e1 - it
introduced a use-after-free.  The only way the code would get simpler
is with a cleanup function, but eh, not worth it for just this one

Reviewed by kay on IRC.

7 years agoOptimize startswith() to macro
Kay Sievers [Wed, 21 Aug 2013 20:16:44 +0000 (22:16 +0200)]
Optimize startswith() to macro

I guess it's easier and cleaner anyway to use simple static inline
functions instead of defines.

7 years agoremove hasprefix(), use startswith()
Shawn Landden [Thu, 22 Aug 2013 01:20:55 +0000 (18:20 -0700)]
remove hasprefix(), use startswith()

7 years agouse CAP_MKNOD ConditionCapability
Khem Raj [Thu, 22 Aug 2013 03:35:44 +0000 (20:35 -0700)]
use CAP_MKNOD ConditionCapability

Fixes errors seen when booting VMs on QEMU like

systemd[1]: kmod-static-nodes.service: main process exited, code=exited, status=203/EXEC
systemd[1]: Failed to start Create list of required static device nodes for the current kernel.
systemd[1]: Unit kmod-static-nodes.service entered failed state.

Make sure that mknod capability is available

Signed-off-by: Khem Raj <>
7 years agoman: typo
Zbigniew Jędrzejewski-Szmek [Thu, 22 Aug 2013 03:02:46 +0000 (23:02 -0400)]
man: typo

ohsix> ooh theres a typo in the example

7 years agotest: Make testing work on systems without or old systemd
Holger Hans Peter Freyther [Thu, 18 Jul 2013 06:30:06 +0000 (08:30 +0200)]
test: Make testing work on systems without or old systemd

* Introduce a macro to conditionally execute tests. This avoids
  skipping the entire test if some parts require systemd
* Skip the journal tests when no /etc/machine-id is present
* Change test-catalog to load the catalog from the source directory
  of systemd.
* /proc/PID/comm got introduced in v2.6.33 but travis is still
  using v2.6.32.
* Enable make check and make distcheck on the travis build
* Use -D"CATALOG_DIR=STR($(abs_top_srcdir)/catalog)" as a STRINGIY
  would result in the path '/home/ich/source/linux' to be expanded
  to '/home/ich/source/1' as linux is defined to 1.

7 years agoremove freenode verification file
Kay Sievers [Wed, 21 Aug 2013 12:11:43 +0000 (14:11 +0200)]
remove freenode verification file

7 years agoadd freenode verification
Kay Sievers [Wed, 21 Aug 2013 11:09:50 +0000 (13:09 +0200)]
add freenode verification

7 years agologs-show: fix condition for ellipsizing multi-line messages
Zbigniew Jędrzejewski-Szmek [Wed, 21 Aug 2013 05:34:57 +0000 (01:34 -0400)]
logs-show: fix condition for ellipsizing multi-line messages

falconindy> the ellipsizing seems a bit wrong here....

I got a bit carried away with putting dots everywhere :)

7 years agologs-show: show source timestamp in verbose mode
Zbigniew Jędrzejewski-Szmek [Thu, 8 Aug 2013 02:55:29 +0000 (22:55 -0400)]
logs-show: show source timestamp in verbose mode

This makes verbose behave like short mode, i.e. try to show
the source timestamp, and fall back to journald timestamp
only if unavailable or unparsable. I think verbose should
be like short, only showing more fields, and showing different
timestamps would be confusing.

7 years agologs-show: add short-precise mode with us timestamps
Zbigniew Jędrzejewski-Szmek [Sun, 4 Aug 2013 13:04:20 +0000 (09:04 -0400)]
logs-show: add short-precise mode with us timestamps

Also, always show us timestamps in verbose mode.

7 years agoRename F_TYPE_CMP() to F_TYPE_EQUAL()
Zbigniew Jędrzejewski-Szmek [Fri, 16 Aug 2013 03:13:48 +0000 (23:13 -0400)]

7 years agokeymap: add Pavilion dv7 keys
Zbigniew Jędrzejewski-Szmek [Fri, 16 Aug 2013 01:40:56 +0000 (21:40 -0400)]
keymap: add Pavilion dv7 keys

7 years agoudev: when complaining about invalid characters, print them out
Zbigniew Jędrzejewski-Szmek [Fri, 16 Aug 2013 00:01:19 +0000 (20:01 -0400)]
udev: when complaining about invalid characters, print them out

systemd-udevd[6260]: invalid key/value pair in file /usr/lib/udev/rules.d/60-ffado.rules on line 46,starting at character 84 ('#')

7 years agogpt-auto-generator: do not show error for non-GPT disks
Zbigniew Jędrzejewski-Szmek [Thu, 15 Aug 2013 22:42:42 +0000 (18:42 -0400)]
gpt-auto-generator: do not show error for non-GPT disks

7 years agogpt-auto-generator: use _cleanup_ for blkid_free_probe
Zbigniew Jędrzejewski-Szmek [Thu, 15 Aug 2013 22:24:10 +0000 (18:24 -0400)]
gpt-auto-generator: use _cleanup_ for blkid_free_probe

7 years agogpt-auto-generator: include device name in error reports
Zbigniew Jędrzejewski-Szmek [Thu, 15 Aug 2013 22:05:04 +0000 (18:05 -0400)]
gpt-auto-generator: include device name in error reports

7 years agounits: disable kmod-static-nodes.service in containers
Zbigniew Jędrzejewski-Szmek [Mon, 19 Aug 2013 20:59:42 +0000 (16:59 -0400)]
units: disable kmod-static-nodes.service in containers


Note: upstream kmod has a patch [1] to exit with a warning if
modules.devname is missing. We could use new %v specifier to make this
service conditional on the existence of this file, but this could
mask a kernel installation error, hence we should let kmod run
even if the file doesn't exist.


7 years agoman: fix spacing issue in systemd-nspawn(1)
Zbigniew Jędrzejewski-Szmek [Mon, 19 Aug 2013 20:00:13 +0000 (16:00 -0400)]
man: fix spacing issue in systemd-nspawn(1)

Same as 1e158d273.

7 years agobuild-sys: use no-tmpl flavour of gtkdocization
Zbigniew Jędrzejewski-Szmek [Mon, 19 Aug 2013 23:24:01 +0000 (19:24 -0400)]
build-sys: use no-tmpl flavour of gtkdocization

"tmpl" flavour is deprecated. Also this way we avoid a warning during
installation with older gtkdoc.

7 years agojournal: fix parsing of facility in syslog messages
Zbigniew Jędrzejewski-Szmek [Fri, 26 Jul 2013 16:57:33 +0000 (12:57 -0400)]
journal: fix parsing of facility in syslog messages

In 49998b383 (journald: do not overwrite syslog facility when
parsing priority) journald started ignoring facility part when
reading service stderr to convert to syslog messages. In this
case it is fine, because only the priority is allowed.

But the same codepath is used for syslog messages, where the
facility should be used. Split the two codepaths by explicitly
specyfing whether the facility should be ignored or not.

7 years agolibudev-enumerate.c:udev_enumerate_get_list_entry() fixed possible stale pointer
Harald Hoyer [Mon, 19 Aug 2013 13:18:43 +0000 (15:18 +0200)]
libudev-enumerate.c:udev_enumerate_get_list_entry() fixed possible stale pointer

If a realloc() happens in syspath_add(), the move_later pointer could
point to an invalid memory region.

Let move_later store the array index, instead of the pointer to the

7 years agoudev: replace CAP_MKNOD by writable /sys condition
Kay Sievers [Sat, 17 Aug 2013 17:07:42 +0000 (19:07 +0200)]
udev: replace CAP_MKNOD by writable /sys condition

7 years agobuild-sys: Add configure check for linux/btrfs.h
Michael Marineau [Thu, 15 Aug 2013 15:50:57 +0000 (11:50 -0400)]
build-sys: Add configure check for linux/btrfs.h

btrfs.h was added to uapi in Linux 3.9. To fix building with older
header versions this adds a configure check for the header and re-adds
btrfs definitions to missing.h which was removed in bed2e820 along with
two other ioctls used by gpt-auto-generator.

[ Apparently, btrfs.h was only added recently:
  let's re-add it for now -- kay ]

7 years agounits: make fsck units remain after exit
Zbigniew Jędrzejewski-Szmek [Thu, 15 Aug 2013 19:07:57 +0000 (15:07 -0400)]
units: make fsck units remain after exit

Without this, fsck would be re-run if any other service which pulls
in a target requiring one of the mounts was started after fsck was done
but before the initial transaction was done.

7 years agotypo fixes in man and comments
Thomas Hindoe Paaboel Andersen [Thu, 15 Aug 2013 21:38:09 +0000 (23:38 +0200)]
typo fixes in man and comments

7 years agotests: fix indentation
Thomas Hindoe Paaboel Andersen [Thu, 15 Aug 2013 21:32:38 +0000 (23:32 +0200)]
tests: fix indentation

7 years agolibudev: fix hwdb validation to look for the *new* file
Kay Sievers [Thu, 15 Aug 2013 17:54:03 +0000 (19:54 +0200)]
libudev: fix hwdb validation to look for the *new* file

7 years agoudevd: simplify sigterm check
Kay Sievers [Thu, 15 Aug 2013 17:51:08 +0000 (19:51 +0200)]
udevd: simplify sigterm check

7 years agobuild-sys: add clean-python target
Zbigniew Jędrzejewski-Szmek [Thu, 15 Aug 2013 16:54:54 +0000 (12:54 -0400)]
build-sys: add clean-python target

Building for a different version of Python requires removing all
build products for the old version. There's no nice way to do it,
short of doing 'make clean'. The new 'clean-python' target is a
bit hacky, but seems to work:
  ./configure PYTHON=python2 && make && make install
  make clean-python
  ./configure PYTHON=python3 --disable-gtk-doc --disable-man-pages && make && make install
should install modules for both versions of Python.

7 years agosystemd-python: check for oom, give nicer error messages
Zbigniew Jędrzejewski-Szmek [Thu, 15 Aug 2013 16:51:20 +0000 (12:51 -0400)]
systemd-python: check for oom, give nicer error messages

7 years agosystemd-python: fix initialization of _Reader objects
Steven Hiscocks [Thu, 15 Aug 2013 16:50:32 +0000 (12:50 -0400)]
systemd-python: fix initialization of _Reader objects

7 years agosysctl: allow overwriting of values specified in "later" files
Kay Sievers [Thu, 15 Aug 2013 16:35:03 +0000 (18:35 +0200)]
sysctl: allow overwriting of values specified in "later" files

7 years agoman: remove "wine" from unrelated man pages
Kay Sievers [Thu, 15 Aug 2013 16:07:47 +0000 (18:07 +0200)]
man: remove "wine" from unrelated man pages

7 years agohwdb: keyboard - remove stray "
Kay Sievers [Thu, 15 Aug 2013 14:07:51 +0000 (16:07 +0200)]
hwdb: keyboard  - remove stray "

<dvdhrm> kay, hwdb/60-keyboard.hwdb line 147 it says KEYBOARD_KEY_ee=screenlock"
         with a " at the end. I guess that's a typo?

7 years agohashmap: remove empty lines
Kay Sievers [Thu, 15 Aug 2013 13:15:36 +0000 (15:15 +0200)]
hashmap: remove empty lines

7 years agozsh_completion: Remove ctls function from _systemd
William Giokas [Thu, 15 Aug 2013 03:09:16 +0000 (22:09 -0500)]
zsh_completion: Remove ctls function from _systemd

The _ctls function in the main _systemd file is not needed.

7 years agozsh_completion: machinectl properties can be stacked
William Giokas [Thu, 15 Aug 2013 03:09:15 +0000 (22:09 -0500)]
zsh_completion: machinectl properties can be stacked

7 years agozsh_completion: Allow specifying multiple arguments
William Giokas [Thu, 15 Aug 2013 03:09:14 +0000 (22:09 -0500)]
zsh_completion: Allow specifying multiple arguments

Some of the options in systemd can take multiple arguments, such as
systemctl's --type option. Previously, you would only be able to
complete a single type after the -t, but now zsh will continue to
complete the types, separating them by commas.

systemd-inhibit's --what command has colon (:), and that has been taken
into account.

7 years agosystemd-cryptsetup: makes “discard” a synonym for “allow-discards”
Ondrej Balaz [Fri, 9 Aug 2013 18:37:52 +0000 (20:37 +0200)]
systemd-cryptsetup: makes “discard” a synonym for “allow-discards”

systemd-cryptsetup recognizes option 'allow-discards' in /etc/crypttab
to enable TRIM passthrough to underlying encrypted device. In Debian
this option was changed to 'discard' to avoid hyphen in option name.
(see: #648868 and `man crypttab`).

[zj: update crypttab(5) too, making "discard" the default.]

7 years agozsh_completion: Move helper function to autoload
William Giokas [Mon, 12 Aug 2013 17:41:18 +0000 (12:41 -0500)]
zsh_completion: Move helper function to autoload

_hosts_or_user_at_host was used by 6 different completions, and
previously was in all 6 of those files. I moved it out to its own file,
_sd_hosts_or_user_at_host. This will be autoloaded for use in other
completion functions. It also allows external completions to use this
function by simply calling _sd_hosts_or_user_at_host as in the systemd

7 years agosystemd.unit(5): clarify the Description= contents
Michael Stapelberg [Mon, 12 Aug 2013 19:59:41 +0000 (21:59 +0200)]
systemd.unit(5): clarify the Description= contents

7 years agofstab-generator: log_oom() if automount_name is null
WANG Chao [Tue, 13 Aug 2013 08:38:19 +0000 (16:38 +0800)]
fstab-generator: log_oom() if automount_name is null

7 years agozsh_completion: Correctly display journal fields
William Giokas [Wed, 14 Aug 2013 18:29:58 +0000 (13:29 -0500)]
zsh_completion: Correctly display journal fields

Show equals and field values when used with _journal_none, don't show
anything if we're not using _journal_none.

7 years agobootchart: remove +x permissions on .c file
Zbigniew Jędrzejewski-Szmek [Thu, 15 Aug 2013 01:47:38 +0000 (21:47 -0400)]
bootchart: remove +x permissions on .c file

7 years agohostnamectl: show only specific hostname when requested
Zbigniew Jędrzejewski-Szmek [Wed, 14 Aug 2013 22:55:11 +0000 (18:55 -0400)]
hostnamectl: show only specific hostname when requested

Existing --pretty, --transient, --static options, used previously
for 'set-hostname' verb, are reused for the 'status' verb. If one
of them is given, only the specified hostname is printed. This
way there's no need to employ awk to get the hostname in a script.

7 years agoREADME: update list of used LICENSEs
Kay Sievers [Wed, 14 Aug 2013 20:58:21 +0000 (22:58 +0200)]
README: update list of used LICENSEs

7 years agotest: add licence header and switch to LGPL
Kay Sievers [Wed, 14 Aug 2013 20:55:40 +0000 (22:55 +0200)]
test: add licence header and switch to LGPL

Checked with and got OK from Martin.