chiark / gitweb /
elogind.git
5 years agojournald: remove a number of malloc()s from the syslog message handling
Lennart Poettering [Mon, 3 Nov 2014 19:24:43 +0000 (20:24 +0100)]
journald: remove a number of malloc()s from the syslog message handling

5 years agojournald: constify all things!
Lennart Poettering [Sun, 2 Nov 2014 20:46:42 +0000 (21:46 +0100)]
journald: constify all things!

5 years agoman: sd_event_add_post - fix typo
Tom Gundersen [Mon, 3 Nov 2014 14:58:30 +0000 (15:58 +0100)]
man: sd_event_add_post - fix typo

5 years agoman: glib-event-glue.c - remove unnecessary includes
Tom Gundersen [Mon, 3 Nov 2014 13:45:21 +0000 (14:45 +0100)]
man: glib-event-glue.c - remove unnecessary includes

This is just an example, so no error-handling is done here anyway.

5 years agosd-pppoe: include ppp_defs.h
Lukas Nykryn [Mon, 3 Nov 2014 11:31:58 +0000 (12:31 +0100)]
sd-pppoe: include ppp_defs.h

On older kernels before this patch:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e8b671460410c8fd996c8a1c228b718c547cc236
ppp-ioctl.h did not pull in ppp_defs.h which results in build errors

5 years agounits: order sd-journal-flush after sd-remount-fs
Zbigniew Jędrzejewski-Szmek [Mon, 3 Nov 2014 02:45:42 +0000 (21:45 -0500)]
units: order sd-journal-flush after sd-remount-fs

Otherwise we could attempt to flush the journal while /var/log/ was
still ro, and silently skip journal flushing.

The way that errors in flushing are handled should still be changed to
be more transparent and robust.

5 years agounit: do not order timers.target before basic.target
Zbigniew Jędrzejewski-Szmek [Sun, 2 Nov 2014 16:39:17 +0000 (11:39 -0500)]
unit: do not order timers.target before basic.target

Since commit 19f8d037833f2 'timer: order OnCalendar units after
timer-sync.target if DefaultDependencies=no' timers might get a
dependency on time-sync.target, which does not really belong in early
boot. If ntp is enabled, time-sync.target might be delayed until a
network connection is established.

It turns out that majority of timer units found in the wild do not
need to be started in early boot. Out of the timer units available in
Fedora 21, only systemd-readahead-done.timer and mdadm-last-resort@.timer
should be started early, but they both have DefaultDependencies=no,
so are not part of timers.target anyway. All the rest look like they
will be fine with being started a bit later (and the majority even
much later, since they run daily or weekly).

Let timers.target be pulled in by basic.target, but without the
temporal dependency. This means timer units are started on a "best
effort" schedule.

https://bugzilla.redhat.com/show_bug.cgi?id=1158206

5 years agomanager: do not print timing when running in test mode
Zbigniew Jędrzejewski-Szmek [Sun, 2 Nov 2014 17:19:38 +0000 (12:19 -0500)]
manager: do not print timing when running in test mode

5 years agoRaise level of 'Found dependency...' lines
Zbigniew Jędrzejewski-Szmek [Sun, 2 Nov 2014 17:10:42 +0000 (12:10 -0500)]
Raise level of 'Found dependency...' lines

This way they always show up together with 'Found ordering cycle...'.
Ordering cycles are a serious error and a major pain to debug. If
quiet is enabled, only the first and the last line of output are
shown:

systemd[1]: Found ordering cycle on basic.target/start
systemd[1]: Breaking ordering cycle by deleting job timers.target/start
systemd[1]: Job timers.target/start deleted to break ordering cycle starting with basic.target/start

which isn't particularly enlightening. So just show the whole message
at the same level.

https://bugzilla.redhat.com/show_bug.cgi?id=1158206

5 years agosd-pppoe: fix some leaks
Tom Gundersen [Sat, 1 Nov 2014 22:53:25 +0000 (23:53 +0100)]
sd-pppoe: fix some leaks

5 years agolibsystemd-networkd: introduce sd-pppoe library
Tom Gundersen [Thu, 30 Oct 2014 23:02:57 +0000 (00:02 +0100)]
libsystemd-networkd: introduce sd-pppoe library

This library negotiates a PPPoE channel. It handles the discovery stage and
leaves the session stage to the kernel. A further PPP library is needed to
actually set up a PPP unit (negotatie LCP, IPCP and do authentication), so in
isolation this is not yet very useful.

The test program has two modes:

  # ./test-pppoe

will create a veth tunnel in a new network namespace, start pppoe-server on one
end and this client library on the other. The pppd server will time out as no
LCP is performed, and the client will then shut down gracefully.

  # ./test-pppoe eth0

will run the client on eth0 (or any other netdev), and requires a PPPoE server
to be reachable on the local link.

5 years agolibudev: Use correct free function
Colin Walters [Sat, 1 Nov 2014 19:49:53 +0000 (15:49 -0400)]
libudev: Use correct free function

FILE * wants cleanup_fclose().

Spotted by udev hwdb segfaulting in gnome-continuous' buildroot
construction.

5 years agoscsi_id: fix usage spelling
Joe Lawrence [Sat, 1 Nov 2014 16:18:08 +0000 (12:18 -0400)]
scsi_id: fix usage spelling

s/threat/treat/g

5 years agoTODO
Zbigniew Jędrzejewski-Szmek [Sat, 1 Nov 2014 19:37:16 +0000 (15:37 -0400)]
TODO

5 years agokernel-install/90-loaderentry.install: fix cmdline parsing
Michael Chapman [Wed, 29 Oct 2014 00:54:07 +0000 (11:54 +1100)]
kernel-install/90-loaderentry.install: fix cmdline parsing

A recent commit (2f3a215) changed the parsing of /proc/cmdline to use a
shell array. Unfortunately, this introduced a bug: "read -ar line"
populates the shell variable $r, not $line. This breaks installation of
new loader entries:

  # kernel-install add 3.17.1-304.fc21.x86_64 \
      /boot/vmlinuz-3.17.1-304.fc21.x86_64
  Could not determine the kernel command line parameters.
  Please specify the kernel command line in /etc/kernel/cmdline!

This commit alters the read command to correctly populate the $line
array instead.

5 years agosystemd-journal-flush.service: remove "trigger" from description
Zbigniew Jędrzejewski-Szmek [Sat, 1 Nov 2014 17:52:14 +0000 (13:52 -0400)]
systemd-journal-flush.service: remove "trigger" from description

This service is now synchronous, so "trigger" is misleading.

5 years agoman: explain journalctl --flush correctly
Umut Tezduyar Lindskog [Wed, 29 Oct 2014 10:20:02 +0000 (11:20 +0100)]
man: explain journalctl --flush correctly

5 years agobus: use STR_IN_SET
WaLyong Cho [Thu, 30 Oct 2014 06:45:15 +0000 (15:45 +0900)]
bus: use STR_IN_SET

5 years agocore: improve error message when machine id is missing
Jan Synacek [Fri, 31 Oct 2014 09:16:45 +0000 (10:16 +0100)]
core: improve error message when machine id is missing

5 years agosd-dhcp6-client: fix off-by-two error in DUID length
Dan Williams [Fri, 31 Oct 2014 17:20:21 +0000 (12:20 -0500)]
sd-dhcp6-client: fix off-by-two error in DUID length

The duid data passed by the caller does not include the DUID type,
but sd_dhcp6_client_set_duid() was treating it like it did.

5 years agocalendarspec: add constant for weekdays_bits
Daniele Medri [Thu, 30 Oct 2014 11:19:14 +0000 (12:19 +0100)]
calendarspec: add constant for weekdays_bits

5 years agoman: describe all log levels in udevadm(8)
Zbigniew Jędrzejewski-Szmek [Sat, 1 Nov 2014 18:36:29 +0000 (14:36 -0400)]
man: describe all log levels in udevadm(8)

https://bugs.freedesktop.org/show_bug.cgi?id=85657

5 years agoUse log "level" instead of "priority"
Zbigniew Jędrzejewski-Szmek [Sat, 1 Nov 2014 18:33:01 +0000 (14:33 -0400)]
Use log "level" instead of "priority"

The term "priority" is misleading because higher levels have lower
priority. "Level" is clearer and shorter.

This commit touches only the textual descriptions, not function and variable
names themselves. "Priority" is used in various command-line switches and
protocol constants, so completly getting rid of "priority" is hard.

I also left "priority" in various places where the clarity suffered
when it was removed.

5 years agolibudev: do not accept invalid log levels
Zbigniew Jędrzejewski-Szmek [Sat, 1 Nov 2014 16:06:41 +0000 (12:06 -0400)]
libudev: do not accept invalid log levels

Invalid log levels lead to a assert failure later on.

https://bugs.freedesktop.org/show_bug.cgi?id=85657

5 years agolibudev: modernization
Zbigniew Jędrzejewski-Szmek [Sat, 1 Nov 2014 15:32:44 +0000 (11:32 -0400)]
libudev: modernization

This brings udev logging style a bit closer to normal systemd convention.

5 years agosd-dhcp-lease: use shared default prefixlen function
Tom Gundersen [Sat, 1 Nov 2014 18:02:44 +0000 (19:02 +0100)]
sd-dhcp-lease: use shared default prefixlen function

Also change the default prefixlen function to only access the first octet of the in_addr.

5 years agosd-dhcp-lease: use unaligned read helpers
Tom Gundersen [Sat, 1 Nov 2014 17:59:55 +0000 (18:59 +0100)]
sd-dhcp-lease: use unaligned read helpers

5 years agodhcp6: use unaligned read/write helpers
Tom Gundersen [Sat, 1 Nov 2014 13:32:28 +0000 (14:32 +0100)]
dhcp6: use unaligned read/write helpers

5 years agoresolved: dns-packet - use unaligned read/write helpers
Tom Gundersen [Sat, 1 Nov 2014 13:07:42 +0000 (14:07 +0100)]
resolved: dns-packet - use unaligned read/write helpers

5 years agoshared: add helpers for unaligend BE read/write
Tom Gundersen [Sat, 1 Nov 2014 13:04:17 +0000 (14:04 +0100)]
shared: add helpers for unaligend BE read/write

5 years agohwdb: Update database of Bluetooth company identifiers
Marcel Holtmann [Fri, 31 Oct 2014 19:37:59 +0000 (20:37 +0100)]
hwdb: Update database of Bluetooth company identifiers

5 years agoptyforward: rework PTY forwarder logic used by nspawn to utilize the normal event...
Lennart Poettering [Fri, 31 Oct 2014 15:54:11 +0000 (16:54 +0100)]
ptyforward: rework PTY forwarder logic used by nspawn to utilize the normal event loop

We really should not run manual event loops anymore, but standardize on
sd_event, so that we can run sd_bus connections from it eventually.

5 years agoMake bus errno mappings non-static
Zbigniew Jędrzejewski-Szmek [Fri, 31 Oct 2014 14:07:54 +0000 (10:07 -0400)]
Make bus errno mappings non-static

__attribute__((used)) is not enough to force static variables to
be carried over to a compiled program from a library. Mappings defined
in libsystemd-shared.a were not visible in the compiled binaries.
To ensure that the mappings are present in the final binary, the
tables are made non-static and are given a real unique name by which
they can be referenced.

To use a mapping defined not in the local compilation unit (e.g. in
a library) a reference to the mapping table is added. This is done
by including a declaration in the header file.

Expected values in test-engine are fixed to reflect the new mappings.

5 years agobus: do not segfault on zeros in errno mapping table
Zbigniew Jędrzejewski-Szmek [Fri, 31 Oct 2014 13:31:02 +0000 (09:31 -0400)]
bus: do not segfault on zeros in errno mapping table

Depending on the link order, holes might appear in the body of
the sd_bus_errnomap section. Ignore them.

Adds a simple test to print the table to help with debugging such
issues in the future.

5 years agounits: don't order journal flushing afte remote-fs.target
Lennart Poettering [Fri, 31 Oct 2014 15:22:36 +0000 (16:22 +0100)]
units: don't order journal flushing afte remote-fs.target

Instead, only depend on the actual file systems we need.

This should solve dep loops on setups where remote-fs.target is moved
into late boot.

5 years agonspawn: don't make up -1 as error code
Lennart Poettering [Thu, 30 Oct 2014 19:53:23 +0000 (20:53 +0100)]
nspawn: don't make up -1 as error code

5 years agoshared/install: avoid prematurely rejecting "missing" units
Dave Reisner [Fri, 31 Oct 2014 00:12:05 +0000 (20:12 -0400)]
shared/install: avoid prematurely rejecting "missing" units

f7101b7368df copied some logic to prevent enabling masked units, but
also added a check which causes attempts to enable templated units to
fail. Since we know the logic beyond this check will properly handle
units which truly do not exist, we can rely on the unit file state
comparison to suffice for expressing the intent of f7101b7368df.

ref: https://bugs.archlinux.org/task/42616

5 years agosd-bus: add missing include
Tom Gundersen [Fri, 31 Oct 2014 10:22:46 +0000 (11:22 +0100)]
sd-bus: add missing include

5 years agotests: add test-copy
Ronny Chevalier [Wed, 29 Oct 2014 21:28:50 +0000 (22:28 +0100)]
tests: add test-copy

5 years agotests: add tests for path_startswith
Ronny Chevalier [Tue, 21 Oct 2014 22:58:24 +0000 (00:58 +0200)]
tests: add tests for path_startswith

5 years agoshared: fix typo
Ronny Chevalier [Thu, 16 Oct 2014 21:22:06 +0000 (23:22 +0200)]
shared: fix typo

5 years agotests: add missing entry for LocalVariable to test-tables
Ronny Chevalier [Sun, 12 Oct 2014 16:11:15 +0000 (18:11 +0200)]
tests: add missing entry for LocalVariable to test-tables

5 years agotests: add test-locale-util
Ronny Chevalier [Sun, 12 Oct 2014 16:05:10 +0000 (18:05 +0200)]
tests: add test-locale-util

5 years agoshared: add missing includes
Ronny Chevalier [Sun, 12 Oct 2014 15:59:03 +0000 (17:59 +0200)]
shared: add missing includes

5 years agotests: add tests for strv.c
Ronny Chevalier [Sun, 12 Oct 2014 15:32:23 +0000 (17:32 +0200)]
tests: add tests for strv.c

add tests for:
- strv_find_startswith
- strv_push_prepend
- strv_consume_prepend

5 years agoremove references of readahead
Ronny Chevalier [Thu, 25 Sep 2014 20:46:37 +0000 (22:46 +0200)]
remove references of readahead

5 years agotests: add tests for fileio.c
Ronny Chevalier [Tue, 2 Sep 2014 16:55:31 +0000 (18:55 +0200)]
tests: add tests for fileio.c

add tests for the following functions:
- write_string_file_no_create
- load_env_file_pairs

5 years agosd-dhcp-client: clean up raw socket sd_event_source when creating new UDP socket
Dan Williams [Thu, 30 Oct 2014 19:23:00 +0000 (14:23 -0500)]
sd-dhcp-client: clean up raw socket sd_event_source when creating new UDP socket

The raw socket sd_event_source used for DHCP server solicitations
was simply dropped on the floor when creating the new UDP socket
after a lease has been acquired.  Clean it up properly so we're
not still listening and responding to events on it.

5 years agosnapshot: return error when snapshot exists
Zbigniew Jędrzejewski-Szmek [Tue, 28 Oct 2014 16:36:17 +0000 (12:36 -0400)]
snapshot: return error when snapshot exists

5 years agoConvert the rest to sd_bus_errnomap
Zbigniew Jędrzejewski-Szmek [Fri, 31 Oct 2014 00:32:17 +0000 (20:32 -0400)]
Convert the rest to sd_bus_errnomap

I tried to preserve most errno values, but in some cases they were
inconsistent (different errno values for the same error name) or just
mismatched.

5 years agobus: add sd_bus_errnomap section
Zbigniew Jędrzejewski-Szmek [Fri, 31 Oct 2014 00:31:48 +0000 (20:31 -0400)]
bus: add sd_bus_errnomap section

This allows custom "name" ↔ errno mappings to be registered.
Tables from all compilation units are concatenated.

5 years agotest: test a corner case in hashmap_remove_and_replace()
Michal Schmidt [Tue, 14 Oct 2014 23:35:40 +0000 (01:35 +0200)]
test: test a corner case in hashmap_remove_and_replace()

5 years agoconfigure.ac: add --enable-hashmap-debug option
Michal Schmidt [Tue, 14 Oct 2014 23:34:15 +0000 (01:34 +0200)]
configure.ac: add --enable-hashmap-debug option

The option simply enables hashmap debugging by defining
ENABLE_HASHMAP_DEBUG.

I suggest developing new code with it enabled, to have the iterator checks.

5 years agotools: add gdb command to dump hashmap information
Michal Schmidt [Tue, 14 Oct 2014 23:31:23 +0000 (01:31 +0200)]
tools: add gdb command to dump hashmap information

$ sudo gdb -p 1
...
(gdb) source gdb-sd_dump_hashmaps.py
(gdb) sd_dump_hashmaps
  ... lists allocated hashmaps ...
(gdb) sd_dump_hashmaps 1
  ... lists allocated hashmaps, their DIB histograms and contiguous
      blocks statistics ...

5 years agohashmap: rewrite the implementation
Michal Schmidt [Tue, 14 Oct 2014 23:27:16 +0000 (01:27 +0200)]
hashmap: rewrite the implementation

This is a rewrite of the hashmap implementation. Its advantage is lower
memory usage.

It uses open addressing (entries are stored in an array, as opposed to
linked lists). Hash collisions are resolved with linear probing and
Robin Hood displacement policy. See the references in hashmap.c.

Some fun empirical findings about hashmap usage in systemd on my laptop:
  - 98 % of allocated hashmaps are Sets.
  - Sets contain 78 % of all entries, plain Hashmaps 17 %, and
    OrderedHashmaps 5 %.
  - 60 % of allocated hashmaps contain only 1 entry.
  - 90 % of allocated hashmaps contain 5 or fewer entries.
  - 75 % of all entries are in hashmaps that use trivial_hash_ops.

Clearly it makes sense to:
  - store entries in distinct entry types. Especially for Sets - their
    entries are the most numerous and they require the least information
    to store an entry.
  - have a way to store small numbers of entries directly in the hashmap
    structs, and only allocate the usual entry arrays when the direct
    storage is full.

The implementation has an optional debugging feature (enabled by
defining the ENABLE_HASHMAP_DEBUG macro), where it:
  - tracks all allocated hashmaps in a linked list so that one can
    easily find them in gdb,
  - tracks which function/line allocated a given hashmap, and
  - checks for invalid mixing of hashmap iteration and modification.

Since entries are not allocated one-by-one anymore, mempools are not
used for entries. Originally I meant to drop mempools entirely, but it's
still worth it to use them for the hashmap structs. My testing indicates
that it makes loading of units about 5 % faster (a test with 10000 units
where more than 200000 hashmaps are allocated - pure malloc: 449±4 ms,
mempools: 427±7 ms).

Here are some memory usage numbers, taken on my laptop with a more or
less normal Fedora setup after booting with SELinux disabled (SELinux
increases systemd's memory usage significantly):

systemd (PID 1)                            Original   New    Change
dirty memory (from pmap -x 1) [KiB]            2152  1264     -41 %
total heap allocations (from gdb-heap) [KiB]   1623   756     -53 %

5 years agotest: adjust max load factor in test_hashmap_many()
Michal Schmidt [Wed, 15 Oct 2014 09:28:23 +0000 (11:28 +0200)]
test: adjust max load factor in test_hashmap_many()

A reimplementation of hashmaps will follow and it will use 0.8.

5 years agomempool: add a zeroing alloc function
Michal Schmidt [Fri, 24 Oct 2014 13:30:18 +0000 (15:30 +0200)]
mempool: add a zeroing alloc function

Add mempool_alloc0_tile(). It's like mempool_alloc_tile(), but it
initializes the allocated tile's memory to zero.

5 years agoutil: add log2u(), log2u_round_up()
Michal Schmidt [Tue, 14 Oct 2014 23:28:54 +0000 (01:28 +0200)]
util: add log2u(), log2u_round_up()

Two's logarithms for unsigned.

5 years agomemfd: rename memfd.h to memfd-util.h to avoid any confusion with any libc provided...
Lennart Poettering [Thu, 30 Oct 2014 17:32:37 +0000 (18:32 +0100)]
memfd: rename memfd.h to memfd-util.h to avoid any confusion with any libc provided headers

5 years agomemfd: always use our internal utility functions where we have them
Lennart Poettering [Thu, 30 Oct 2014 17:28:37 +0000 (18:28 +0100)]
memfd: always use our internal utility functions where we have them

5 years agomemfd: drop memfd_get_name() as it is unused
Lennart Poettering [Thu, 30 Oct 2014 17:28:01 +0000 (18:28 +0100)]
memfd: drop memfd_get_name() as it is unused

5 years agoupdate TODO
Lennart Poettering [Thu, 30 Oct 2014 16:39:29 +0000 (17:39 +0100)]
update TODO

5 years agojournal: when sending huge log messages prefer memfds over temporary files in /dev/shm
Lennart Poettering [Thu, 30 Oct 2014 16:36:02 +0000 (17:36 +0100)]
journal: when sending huge log messages prefer memfds over temporary files in /dev/shm

Previously when a log message grew beyond the maximum AF_UNIX/SOCK_DGRAM
datagram limit we'd send an fd to a deleted file in /dev/shm instead.
Because the sender could still modify the file after delivery we had to
immediately copy the data on the receiving side.

With memfds we can optimize this logic, and also remove the dependency
on /dev/shm: simply send a sealed memfd around, and if we detect the
seal memory map the fd and use it directly.

5 years agoCODING_STYLE: clarify that we really should use O_CLOEXEC everywhere
Lennart Poettering [Thu, 30 Oct 2014 16:05:25 +0000 (17:05 +0100)]
CODING_STYLE: clarify that we really should use O_CLOEXEC everywhere

5 years agomemfd: always create our memfds with CLOEXEC set
Lennart Poettering [Thu, 30 Oct 2014 15:23:34 +0000 (16:23 +0100)]
memfd: always create our memfds with CLOEXEC set

We really shouldn't create fds ever that have the flag unset.

5 years agoutil: unify how we see srand()
Lennart Poettering [Thu, 30 Oct 2014 14:35:37 +0000 (15:35 +0100)]
util: unify how we see srand()

5 years agoutil: don't block on getrandom()
Lennart Poettering [Thu, 30 Oct 2014 14:27:53 +0000 (15:27 +0100)]
util: don't block on getrandom()

5 years agosysusers: Preserve ownership and mode on /etc/passwd and friends
Colin Guthrie [Wed, 29 Oct 2014 14:03:41 +0000 (14:03 +0000)]
sysusers: Preserve ownership and mode on /etc/passwd and friends

When running sysusers we would clobber file ownership and permissions
on the files /etc/passwd, /etc/group and /etc/[g]shadow.

This simply preserves the ownership and mode if existing files are
found.

5 years agokeymap: Ignore brightness keys on Dell Inspiron 1520 to avoid double events
Hans de Goede [Thu, 30 Oct 2014 09:15:54 +0000 (10:15 +0100)]
keymap: Ignore brightness keys on Dell Inspiron 1520 to avoid double events

On the Dell Inspiron 1520 both the atkbd and acpi-video input devices report
an event for pressing the brightness up / down key-combos, resulting in user
space seeing double events and increasing / decreasing the brightness 2 steps
for each keypress.

This hwdb snippet suppresses the atkbd events, making the Inspiron 1520 work
like most modern laptops which emit brightness up / down events through
acpi-video only.

Reported by Pavel Malyshev <p.malishev@gmail.com>

https://bugzilla.redhat.com/show_bug.cgi?id=1141525

5 years agozsh-completion: update start/restart completions
Zbigniew Jędrzejewski-Szmek [Thu, 30 Oct 2014 03:47:55 +0000 (23:47 -0400)]
zsh-completion: update start/restart completions

Now zsh should behave the same for those two subcommands as bash.

5 years agobash-completion: use improved filtering to make things faster
Zbigniew Jędrzejewski-Szmek [Thu, 30 Oct 2014 03:06:58 +0000 (23:06 -0400)]
bash-completion: use improved filtering to make things faster

5 years agosystemctl: obey --state in list-unit-files
Zbigniew Jędrzejewski-Szmek [Thu, 30 Oct 2014 02:51:00 +0000 (22:51 -0400)]
systemctl: obey --state in list-unit-files

5 years agosystemctl: let list-{units,unit-files } honour --type
Zbigniew Jędrzejewski-Szmek [Thu, 30 Oct 2014 02:46:30 +0000 (22:46 -0400)]
systemctl: let list-{units,unit-files } honour --type

The docs don't clarify what is expected, but I don't see any reason
why --type should be ignored.

Also restucture the compund conditions into separate clauses for
easier reading.

5 years agobash-completion: rework startable/restartable units once more
Zbigniew Jędrzejewski-Szmek [Thu, 30 Oct 2014 02:25:33 +0000 (22:25 -0400)]
bash-completion: rework startable/restartable units once more

I tried to use 'systemctl --all list-units' to filter unit files, but
this always filters out unit files which are not loaded. We want to complete
systemctl start with those units too, so this approach is not going to work.

New version is rather slow, but hopefully correct.

5 years agomissing.h: fix wrong __NR_getrandom syscall def
Dave Reisner [Thu, 30 Oct 2014 00:30:25 +0000 (20:30 -0400)]
missing.h: fix wrong __NR_getrandom syscall def

278 is vmsplice on x86_64. 318 is what we want:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/x86/syscalls/syscall_64.tbl

5 years agoudev: path_id - update comments
Kay Sievers [Thu, 30 Oct 2014 00:18:34 +0000 (01:18 +0100)]
udev: path_id - update comments

5 years agobusctl: add new "capture" verb to record bus messages in libpcap compatible files...
Lennart Poettering [Thu, 30 Oct 2014 00:13:11 +0000 (01:13 +0100)]
busctl: add new "capture" verb to record bus messages in libpcap compatible files, for dissection with wireshark

5 years agonspawn: ignore EEXIST when creating mount point
Dave Reisner [Wed, 29 Oct 2014 17:32:43 +0000 (13:32 -0400)]
nspawn: ignore EEXIST when creating mount point

A combination of commits f3c80515c and 79d80fc14 cause nspawn to
silently fail with a commandline such as:

  # systemd-nspawn -D /build/extra-x86_64 --bind=/usr

strace shows the culprit:

  [pid 27868] writev(2, [{"Failed to create mount point /build/extra-x86_64/usr: File exists", 82}, {"\n", 1}], 2) = 83

5 years agosd-bus: properly handle removals of non-existing matches
Lennart Poettering [Wed, 29 Oct 2014 16:58:43 +0000 (17:58 +0100)]
sd-bus: properly handle removals of non-existing matches

5 years agomissing: no tabs please, we are british
Lennart Poettering [Wed, 29 Oct 2014 16:08:18 +0000 (17:08 +0100)]
missing: no tabs please, we are british

5 years agoupdate TODO
Lennart Poettering [Wed, 29 Oct 2014 16:08:00 +0000 (17:08 +0100)]
update TODO

5 years agomissing: simplify memfd ifdeffery
Lennart Poettering [Wed, 29 Oct 2014 16:07:47 +0000 (17:07 +0100)]
missing: simplify memfd ifdeffery

5 years agoutil: make use of the new getrandom() syscall if it is available when needing entropy
Lennart Poettering [Wed, 29 Oct 2014 16:06:32 +0000 (17:06 +0100)]
util: make use of the new getrandom() syscall if it is available when needing entropy

Doesn't require an fd, and could be a bit faster, so let's make use of
it, if it is available.

5 years agosd-rtnl: add bridge port rtnl attributes.
Susant Sahani [Mon, 21 Jul 2014 08:02:09 +0000 (13:32 +0530)]
sd-rtnl: add bridge port rtnl attributes.

Add bridge port attributes to sd-rtnl to configure
via networkd.

5 years agosd-rtnl: add support to set packet family type
Susant Sahani [Mon, 21 Jul 2014 07:45:38 +0000 (13:15 +0530)]
sd-rtnl: add support to set packet family type

This patch adds functionality to set family type
in the rtnl message for example PF_BRIDGE.

5 years agosd-rtnl: mark nested attributes with the NLA_F_NESTED flag
Tom Gundersen [Wed, 29 Oct 2014 09:52:07 +0000 (10:52 +0100)]
sd-rtnl: mark nested attributes with the NLA_F_NESTED flag

The kernel mostly does not check this, but let's be consisntent and allways set it anyway. Based
on patch from Susant Sahani.

5 years agosd-rtnl: fix reading of nla type
Tom Gundersen [Wed, 29 Oct 2014 09:50:33 +0000 (10:50 +0100)]
sd-rtnl: fix reading of nla type

We must filter out the 'network-byteorder' and 'nested' flags.

5 years agonetworkd: add Patch of MTU discovery for IPIP and GRE
Susant Sahani [Tue, 22 Jul 2014 11:21:53 +0000 (16:51 +0530)]
networkd: add Patch of MTU discovery for IPIP and GRE

Add path of MTU disovery for IPIP and GRE Kind of tunnels

5 years agonetworkd: add back path of MTU discovery for SIT
Susant Sahani [Tue, 22 Jul 2014 11:16:39 +0000 (16:46 +0530)]
networkd: add back path of MTU discovery for SIT

5 years agoNEWS: well, it's Options= now, not Discard=
Lennart Poettering [Tue, 28 Oct 2014 19:36:32 +0000 (20:36 +0100)]
NEWS: well, it's Options= now, not Discard=

5 years agobuild-sys: do not use "label" functions in libsystemd_shared v217
Kay Sievers [Tue, 28 Oct 2014 17:46:53 +0000 (18:46 +0100)]
build-sys: do not use "label" functions in libsystemd_shared

5 years agoupdate NEWS
Lennart Poettering [Tue, 28 Oct 2014 17:10:48 +0000 (18:10 +0100)]
update NEWS

5 years agotest: use assert_se() when testing tables so that we get a useful error when somethin...
Lennart Poettering [Tue, 28 Oct 2014 17:07:20 +0000 (18:07 +0100)]
test: use assert_se() when testing tables so that we get a useful error when something fails

5 years agoservice: add missing state table entry
Lennart Poettering [Tue, 28 Oct 2014 17:06:58 +0000 (18:06 +0100)]
service: add missing state table entry

5 years agocore: send sigabrt on watchdog timeout to get the stacktrace
Umut Tezduyar Lindskog [Tue, 28 Oct 2014 15:35:40 +0000 (16:35 +0100)]
core: send sigabrt on watchdog timeout to get the stacktrace

if sigabrt doesn't do the job, follow regular shutdown
routine, sigterm > sigkill.

5 years agoswap: don't add too many deps for swap files form /proc/swap
Lennart Poettering [Tue, 28 Oct 2014 16:27:38 +0000 (17:27 +0100)]
swap: don't add too many deps for swap files form /proc/swap

5 years agoudev: path_id - set supported_parent for well-known SCSI setups
Kay Sievers [Tue, 28 Oct 2014 15:50:24 +0000 (16:50 +0100)]
udev: path_id - set supported_parent for well-known SCSI setups

5 years agoNEWS: fix typos
Ronny Chevalier [Tue, 28 Oct 2014 15:04:21 +0000 (16:04 +0100)]
NEWS: fix typos

5 years agoNEWS: update
Kay Sievers [Tue, 28 Oct 2014 14:53:44 +0000 (15:53 +0100)]
NEWS: update

5 years agoNEWS
Tom Gundersen [Tue, 28 Oct 2014 14:42:57 +0000 (15:42 +0100)]
NEWS