chiark / gitweb /
8 years agosystemctl: remove empty line in case of no units
Zbigniew Jędrzejewski-Szmek [Thu, 15 Nov 2012 10:39:23 +0000 (11:39 +0100)]
systemctl: remove empty line in case of no units

8 years agobuild-sys: store journald code in a noinst library
Zbigniew Jędrzejewski-Szmek [Mon, 12 Nov 2012 16:29:07 +0000 (17:29 +0100)]
build-sys: store journald code in a noinst library

The point is to allow the use of journald functions by other binaries.
Before, journald code was split into multiple files (journald-*.[ch]),
but all those files all required functions from journald.c. And
journald.c has its own main(). Now, it is possible to link against
those functions, e.g. from test binaries.

This constitutes a fix for

The patch does the following:
1. rename journald.h to journald-server.h and move corresponding code
   to journald-server.c.
2. add journald-server.c and other journald-*.c parts to
3. remove journald-syslog.c from test_journal_syslog_SOURCES, since
   it is now contained in libsystemd-journal-internal.
There are no code changes, apart from the removal of a few static's,
to allow function calls between files.

8 years agoman: throw in an example of timedatectl output
Zbigniew Jędrzejewski-Szmek [Fri, 2 Nov 2012 09:55:59 +0000 (10:55 +0100)]
man: throw in an example of timedatectl output

timedatectl is too cool not to advertise it a bit.

8 years agotimedatectl: break line to not exceed 80 columns
Zbigniew Jędrzejewski-Szmek [Wed, 14 Nov 2012 15:38:34 +0000 (16:38 +0100)]
timedatectl: break line to not exceed 80 columns

8 years agolawyerese: add header to make-directive-index
Zbigniew Jędrzejewski-Szmek [Tue, 13 Nov 2012 17:39:18 +0000 (18:39 +0100)]
lawyerese: add header to make-directive-index

8 years agoupdate TODO
Lennart Poettering [Wed, 14 Nov 2012 21:20:51 +0000 (22:20 +0100)]
update TODO

8 years agoshared: add API for replacing @FOO@ style variables in strings
Lennart Poettering [Wed, 14 Nov 2012 21:20:17 +0000 (22:20 +0100)]
shared: add API for replacing @FOO@ style variables in strings

8 years agoutil: add strreplace() to replace a substring by another string
Lennart Poettering [Wed, 14 Nov 2012 21:16:23 +0000 (22:16 +0100)]
util: add strreplace() to replace a substring by another string

8 years agospecifier: minor modernizations
Lennart Poettering [Wed, 14 Nov 2012 21:15:35 +0000 (22:15 +0100)]
specifier: minor modernizations

8 years agopolkit: fix type on comparison
Lennart Poettering [Wed, 14 Nov 2012 21:14:53 +0000 (22:14 +0100)]
polkit: fix type on comparison

8 years agoTODO
Lennart Poettering [Wed, 14 Nov 2012 21:14:17 +0000 (22:14 +0100)]

8 years agoREADME: don't list libgcrypt twice as dep
Lennart Poettering [Wed, 14 Nov 2012 21:13:54 +0000 (22:13 +0100)]
README: don't list libgcrypt twice as dep

8 years fix FTBFS with new glibc
Michal Schmidt [Wed, 14 Nov 2012 13:44:05 +0000 (14:44 +0100)] fix FTBFS with new glibc

glibc moved clock_* functions from librt to the core libc. As a result,
clock_gettime is no more a suitable symbol to use when finding librt.
Look for mq_open instead.

Fixes a FTBFS in Fedora Rawhide.

8 years agodelta.c: fix option '-t'
Thomas Hindoe Paaboel Andersen [Tue, 13 Nov 2012 23:18:02 +0000 (00:18 +0100)]
delta.c: fix option '-t'

Both the help and man page claims that it accepts -t with an argument
so let's do that.

8 years agodelta.c: use _cleanup_
Thomas Hindoe Paaboel Andersen [Tue, 13 Nov 2012 22:45:41 +0000 (23:45 +0100)]
delta.c: use _cleanup_

8 years agopython: add journal backend for the logging framework
Marti Raudsepp [Tue, 9 Oct 2012 15:12:02 +0000 (18:12 +0300)]
python: add journal backend for the logging framework

Supports Python versions 2.6 through 3.3 (tested on 2.7 and 3.2).
See JournalHandler docstring for usage details.

[zj: - use send() instead of using sendv() directly
     - do exception handling like in the logging module
     - bumped min version to python2.6, since the module
       does not work with python2.5 anyway ]

8 years agosystemd-python: use python${PYTHON_VERSION}-config as python-config
Zbigniew Jędrzejewski-Szmek [Thu, 1 Nov 2012 07:58:13 +0000 (08:58 +0100)]
systemd-python: use python${PYTHON_VERSION}-config as python-config

This is the usual setup, where pythonX.Y and pythonX.Y-config go
together. Using python-config with python3 will only lead to

--libs is changed to --ldflags, since the latter also includes other
required flags like -L<dir>.

The tests for HAVE_PYTHON and HAVE_PYTHON_DEVEL are separated. It is
possible to have python development libraries installed without the
binary (or to want to build python modules without using python during
the build).

A line is added to the output, to show what flags will be used for

8 years agosystemd-analyze: use argparse instead of getopt
Zbigniew Jędrzejewski-Szmek [Sat, 3 Nov 2012 17:26:28 +0000 (18:26 +0100)]
systemd-analyze: use argparse instead of getopt

Makes the output way nicer with shorter code. Also brings
systemd-analyze behaviour more in line with other systemd-programs.

Argparse is in Python since 2.6, and is available as a package for
previous versions, if someone is stuck with very old Python.

8 years agosystemd-python: fix nesting of #ifs and #pragmas
Zbigniew Jędrzejewski-Szmek [Wed, 31 Oct 2012 23:10:47 +0000 (00:10 +0100)]
systemd-python: fix nesting of #ifs and #pragmas

8 years agoshared/socket-util: kill gcc warning about uninitialized variable
Zbigniew Jędrzejewski-Szmek [Wed, 31 Oct 2012 20:44:54 +0000 (21:44 +0100)]
shared/socket-util: kill gcc warning about uninitialized variable

The warning was invalid, but distracting.

8 years agoudev: properly handle symlink removal by 'change' event
Kay Sievers [Tue, 13 Nov 2012 01:05:06 +0000 (02:05 +0100)]
udev: properly handle symlink removal by 'change' event

If a 'change' event is supposed to remove created symlinks, we create
a new device structure from the sysfs device and fill it with the list
of links, to compute the delta of the old and new list of links to apply.
If the device is already 'remove'd by the kernel though, udev fails to
create the device structure, so the links are not removed properly.

> From: Neil Brown <>
> Date: Thu, 8 Nov 2012 10:39:06 +0100
> Subject: [PATCH] If a 'change' event does not get handled by udev until
> after the device has subsequently disappeared, udev mis-handles
> it. This can happen with 'md' devices which emit a change
> event and then a remove event when they are stopped. It is
> normally only noticed if udev is very busy (lots of arrays
> being stopped at once) or the machine is otherwise loaded
> and reponding slowly.
> There are two problems.
> 1/ udev_device_new_from_syspath() will refuse to create the device
>    structure if the device does not exist in /sys, and particularly if
>    the uevent file does not exist.
>    If a 'db' file does exist, that is sufficient evidence that the device
>    is genuine and should be created.  Equally if we have just received an
>    event from the kernel about the device, it must be real.
>    This patch just disabled the test for the 'uevent' file, it doesn't
>    try imposing any other tests - it isn't clear that they are really
>    needed.
> 2/ udev_event_execute_rules() calls udev_device_read_db() on a 'device'
>    structure that is largely uninitialised and in particular does not
>    have the 'subsystem' set.  udev_device_read_db() needs the subsystem
>    so it tries to read the 'subsystem' symlink out of sysfs.  If the
>    device is already deleted, this naturally fails.
>    udev_event_execute_rules() knows the subsystem (as it was in the
>    event message) so this patch simply sets the subsystem for the device
>    structure to be loaded to match the subsystem of the device structure
>    that is handling the event.
> With these two changes, deleted handling of change events will still
> correctly remove any symlinks that are not needed any more.

Use udev_device_new() instead of allowing udev_device_new_from_syspath()
to proceed without a sysfs device.

8 years agolibudev: avoid leak during realloc failure
Mauro Dreissig [Mon, 12 Nov 2012 00:07:51 +0000 (22:07 -0200)]
libudev: avoid leak during realloc failure

8 years agoremove duplicate semicolons
Thomas Hindoe Paaboel Andersen [Mon, 12 Nov 2012 21:37:20 +0000 (22:37 +0100)]
remove duplicate semicolons

8 years agosystemd-delta.xml: document default value for --diff
Thomas Hindoe Paaboel Andersen [Mon, 12 Nov 2012 21:34:47 +0000 (22:34 +0100)]
systemd-delta.xml: document default value for --diff

8 years agoutil: nicer tree drawings
Michal Schmidt [Mon, 12 Nov 2012 21:27:48 +0000 (22:27 +0100)]
util: nicer tree drawings

Draw trees more similar to pstree/findmnt/lsblk/...

8 years agoenable localization for common *ctl commands
Dave Reisner [Mon, 12 Nov 2012 19:16:07 +0000 (14:16 -0500)]
enable localization for common *ctl commands

8 years agouse the same email address everywhere
Kay Sievers [Mon, 12 Nov 2012 18:36:23 +0000 (19:36 +0100)]
use the same email address everywhere

8 years agolibudev: update copyright headers
Kay Sievers [Mon, 12 Nov 2012 16:50:33 +0000 (17:50 +0100)]
libudev: update copyright headers

8 years agoTODO: update
Kay Sievers [Sun, 11 Nov 2012 19:47:15 +0000 (20:47 +0100)]
TODO: update

8 years agoudev: use usec_t and now()
Kay Sievers [Sun, 11 Nov 2012 19:45:05 +0000 (20:45 +0100)]
udev: use usec_t and now()

8 years agoman/sd-id128.xml: typo fix
Holger Hans Peter Freyther [Sun, 11 Nov 2012 20:36:21 +0000 (21:36 +0100)]
man/sd-id128.xml: typo fix

8 years agotimedatectl: properly print 30 minutes DST transitions
Kay Sievers [Sun, 11 Nov 2012 15:55:25 +0000 (16:55 +0100)]
timedatectl: properly print 30 minutes DST transitions

8 years agocoredumpctl: add missing -F, --field option to help
Dave Reisner [Fri, 9 Nov 2012 19:14:53 +0000 (14:14 -0500)]
coredumpctl: add missing -F, --field option to help

8 years agobash-completion: add 'gdb' verb for coredumpctl
Dave Reisner [Fri, 9 Nov 2012 17:51:24 +0000 (12:51 -0500)]
bash-completion: add 'gdb' verb for coredumpctl

This also fixes value completion for journal fields, as the completion
for the RHS of the '=' was missing when it was borrowed from journalctl.

8 years agosystemd-coredumpctl: add 'gdb' to usage output
Dave Reisner [Thu, 8 Nov 2012 15:13:46 +0000 (10:13 -0500)]
systemd-coredumpctl: add 'gdb' to usage output

8 years agodbus: when verifying PK privs, bypass PK if uid=0 of client
Lennart Poettering [Fri, 9 Nov 2012 14:54:22 +0000 (15:54 +0100)]
dbus: when verifying PK privs, bypass PK if uid=0 of client

This reduces the number of roundtrips when the client is privileged and
makes the PK dep optional for root clients.

8 years agohwdb: change pci.ids location
Tom Gundersen [Fri, 9 Nov 2012 14:35:11 +0000 (15:35 +0100)]
hwdb: change pci.ids location

According to pciutils' TODO, the sourceforge location is scheduled for
removal, use the new one instead.

8 years agoudev: hwdb - update usb class descriptions
Kay Sievers [Fri, 9 Nov 2012 14:23:41 +0000 (15:23 +0100)]
udev: hwdb - update usb class descriptions

8 years agoudev: hwdb - add usb class descriptions
Kay Sievers [Fri, 9 Nov 2012 13:53:55 +0000 (14:53 +0100)]
udev: hwdb - add usb class descriptions

8 years agoudev: hwdb - add pci class descriptions
Kay Sievers [Fri, 9 Nov 2012 13:29:10 +0000 (14:29 +0100)]
udev: hwdb - add pci class descriptions

8 years agoudev: net_id - add builtin to retrieve data for network devices
Kay Sievers [Fri, 9 Nov 2012 11:37:40 +0000 (12:37 +0100)]
udev: net_id - add builtin to retrieve data for network devices

8 years agoudev: hwdb - search parents for 'modalias' and data
Kay Sievers [Fri, 9 Nov 2012 11:35:02 +0000 (12:35 +0100)]
udev: hwdb - search parents for 'modalias' and data

8 years agoudev: update file headers
Kay Sievers [Thu, 8 Nov 2012 21:20:36 +0000 (22:20 +0100)]
udev: update file headers

8 years agohwdb: OUI - use ID_OUI_FROM_DATABASE=
Kay Sievers [Thu, 8 Nov 2012 00:51:10 +0000 (01:51 +0100)]

8 years agofstab-generator: more specific error messages
Michal Schmidt [Fri, 9 Nov 2012 11:00:46 +0000 (12:00 +0100)]
fstab-generator: more specific error messages

8 years agohwdb: add IEEE OUI data
Kay Sievers [Wed, 7 Nov 2012 13:05:21 +0000 (14:05 +0100)]
hwdb: add IEEE OUI data

8 years agohwdb: update pci data
Kay Sievers [Wed, 7 Nov 2012 13:00:21 +0000 (14:00 +0100)]
hwdb: update pci data

8 years agoTODO: update
Kay Sievers [Wed, 7 Nov 2012 12:59:50 +0000 (13:59 +0100)]
TODO: update

8 years agoman: typo fixes for new files in 195
Thomas Hindoe Paaboel Andersen [Tue, 6 Nov 2012 19:27:38 +0000 (20:27 +0100)]
man: typo fixes for new files in 195

8 years agocryptsetup: fix inverted comparison in pass_volume_key
Dave Reisner [Tue, 6 Nov 2012 15:17:18 +0000 (10:17 -0500)]
cryptsetup: fix inverted comparison in pass_volume_key

8 years agoRevert "Implement SocketUser= and SocketGroup= for [Socket]"
Dave Reisner [Tue, 6 Nov 2012 14:54:17 +0000 (09:54 -0500)]
Revert "Implement SocketUser= and SocketGroup= for [Socket]"

This was never intended to be pushed.

This reverts commit aea54018a5e66a41318afb6c6be745b6aef48d9e.

8 years agocryptsetup: hash=plain means don't use a hash
Dave Reisner [Tue, 6 Nov 2012 14:49:27 +0000 (09:49 -0500)]
cryptsetup: hash=plain means don't use a hash

"plain" is a semantic value that cryptsetup(8) uses to describe a plain
dm-crypt volume that does not use a hash. Catch this value earlier and
ensure that a NULL params.hash is passed to crypt_format to avoid
passing an invalid hash type to the libcryptsetup backend.

FDO bug #56593.

8 years agoImplement SocketUser= and SocketGroup= for [Socket]
Dave Reisner [Mon, 5 Nov 2012 17:50:19 +0000 (12:50 -0500)]
Implement SocketUser= and SocketGroup= for [Socket]

Since we already allow defining the mode of AF_UNIX sockets and FIFO, it
makes sense to also allow specific user/group ownership of the socket
file for restricting access.

8 years agoREADME,TODO: typo fixes
Thomas Hindoe Paaboel Andersen [Mon, 5 Nov 2012 20:13:28 +0000 (21:13 +0100)]
README,TODO: typo fixes

8 years agosystemd.socket.xml: fix typo
Dave Reisner [Mon, 5 Nov 2012 13:32:44 +0000 (08:32 -0500)]
systemd.socket.xml: fix typo

8 years agoadd zsh completion for all the commands
Daniel Wallace [Mon, 5 Nov 2012 06:09:13 +0000 (01:09 -0500)]
add zsh completion for all the commands

Most of the completion for systemctl and loginctl provided by Foudil Brétel

8 years agoTODO: fix typo
Kay Sievers [Mon, 5 Nov 2012 01:17:23 +0000 (02:17 +0100)]
TODO: fix typo

8 years agomount-setup: try mounting 'efivarfs' only if the system bootet with EFI
Kay Sievers [Sun, 4 Nov 2012 16:03:48 +0000 (17:03 +0100)]
mount-setup: try mounting 'efivarfs' only if the system bootet with EFI

8 years agokmod-setup: mounting efivarfs, *after* we tried to mount it, is pointless
Kay Sievers [Sun, 4 Nov 2012 15:55:23 +0000 (16:55 +0100)]
kmod-setup: mounting efivarfs, *after* we tried to mount it, is pointless

The mount() system call, which we issue before loading modules, will trigger
a modprobe by the kernel and block until it returns. Trying to load it again
later, will have exactly the same result as the first time.

8 years agokmod-setup: add conditional module loading callback
Kay Sievers [Sun, 4 Nov 2012 15:54:19 +0000 (16:54 +0100)]
kmod-setup: add conditional module loading callback

8 years agoshared: add is_efiboot()
Kay Sievers [Sun, 4 Nov 2012 15:06:27 +0000 (16:06 +0100)]
shared: add is_efiboot()

8 years agoTODO: update RTC, DST stuff
Kay Sievers [Sun, 4 Nov 2012 14:47:08 +0000 (15:47 +0100)]
TODO: update RTC, DST stuff

8 years agoTODO: add efi check
Kay Sievers [Sun, 4 Nov 2012 11:17:05 +0000 (12:17 +0100)]
TODO: add efi check

8 years agodrop Arch Linux support for reading /etc/rc.conf
Dave Reisner [Sun, 4 Nov 2012 00:11:52 +0000 (20:11 -0400)]
drop Arch Linux support for reading /etc/rc.conf

8 years agodrop Arch Linux support for reading /etc/rc.conf
Dave Reisner [Sat, 3 Nov 2012 23:59:42 +0000 (19:59 -0400)]
drop Arch Linux support for reading /etc/rc.conf

8 years agobash-completion > shell-completion
Kay Sievers [Sat, 3 Nov 2012 21:10:32 +0000 (22:10 +0100)]
bash-completion > shell-completion

8 years agodocs: gtk-doc warnings are annoying
Kay Sievers [Sat, 3 Nov 2012 21:04:06 +0000 (22:04 +0100)]
docs: gtk-doc warnings are annoying

8 years agovconsole: remove Frugalware legacy file support
Miklos Vajna [Sat, 3 Nov 2012 15:23:00 +0000 (16:23 +0100)]
vconsole: remove Frugalware legacy file support

8 years agoutil : fallback to plain ASCII drawing if locale is not UTF-8
Michal Schmidt [Fri, 2 Nov 2012 16:35:30 +0000 (17:35 +0100)]
util : fallback to plain ASCII drawing if locale is not UTF-8

When printing cgroup and sysfs hierarchies, avoid using UTF-8 box drawing
characters if the locale is not UTF-8.

8 years agoutil: add is_locale_utf8()
Michal Schmidt [Fri, 2 Nov 2012 16:27:15 +0000 (17:27 +0100)]
util: add is_locale_utf8()

journalctl and vconsole-setup both implement utf8 locale detection.
Let's have a common function for it.
The next patch will add another use.

8 years agoanalyze: use GDBus instead of dbus-python
Cosimo Cecchi [Fri, 2 Nov 2012 15:29:02 +0000 (11:29 -0400)]
analyze: use GDBus instead of dbus-python

8 years agotimedatectl: show "DST active: n/a" if no DST data is available
Kay Sievers [Fri, 2 Nov 2012 15:45:02 +0000 (05:45 -1000)]
timedatectl: show "DST active: n/a" if no DST data is available

8 years agoTODO: update
Kay Sievers [Fri, 2 Nov 2012 14:18:29 +0000 (15:18 +0100)]
TODO: update

8 years agotimedatectl: explain everything nobody wants to know about DST
Kay Sievers [Fri, 2 Nov 2012 02:45:07 +0000 (03:45 +0100)]
timedatectl: explain everything nobody wants to know about DST

8 years agoshared: add timer_get_dst()
Kay Sievers [Thu, 1 Nov 2012 23:40:02 +0000 (00:40 +0100)]
shared: add timer_get_dst()

8 years agoTODO: update
Kay Sievers [Thu, 1 Nov 2012 23:34:07 +0000 (00:34 +0100)]
TODO: update

8 years agoudev: break over-long lines
Kay Sievers [Wed, 31 Oct 2012 00:55:51 +0000 (01:55 +0100)]
udev: break over-long lines

8 years agoman: typo fixes
Thomas Hindoe Paaboel Andersen [Thu, 1 Nov 2012 22:35:34 +0000 (23:35 +0100)]
man: typo fixes

Fixes a few more typos. Also changes a "Accept=no" to
"Accept=false" to be consistent with the previous examples
in the same man page.

8 years agoupdate TODO
Lennart Poettering [Wed, 31 Oct 2012 01:57:26 +0000 (02:57 +0100)]
update TODO

8 years agoservice: drop special HTTP server target, as it is a bad idea anf Fedora specific
Lennart Poettering [Wed, 31 Oct 2012 01:55:04 +0000 (02:55 +0100)]
service: drop special HTTP server target, as it is a bad idea anf Fedora specific

This was premarily intended to support the LSB facility $httpd which is
only known by Fedora, and a bad idea since it lacks any real-life

Similar, drop support for some other old Fedora-specific facilities.

Also, document the rules for introduction of new facilities, to clarify
the situation for the future.

8 years agoman: explain a bit more detailed what happens on suspend
Lennart Poettering [Tue, 30 Oct 2012 23:19:34 +0000 (00:19 +0100)]
man: explain a bit more detailed what happens on suspend

8 years agoman: document that Documentation= follows an order
Lennart Poettering [Tue, 30 Oct 2012 23:06:08 +0000 (00:06 +0100)]
man: document that Documentation= follows an order

8 years agoupdate TODO
Lennart Poettering [Tue, 30 Oct 2012 23:04:59 +0000 (00:04 +0100)]
update TODO

8 years agoupdate TODO: insserv belongs on the chopping block
Lennart Poettering [Tue, 30 Oct 2012 22:57:50 +0000 (23:57 +0100)]
update TODO: insserv belongs on the chopping block

8 years agostrv: cleanup error path loops
Lennart Poettering [Tue, 30 Oct 2012 17:29:45 +0000 (18:29 +0100)]
strv: cleanup error path loops

8 years agoupdate TODO
Lennart Poettering [Tue, 30 Oct 2012 17:29:35 +0000 (18:29 +0100)]
update TODO

8 years agoshared: "max" in the string->number conversion is meant to be inclusive
Michal Schmidt [Tue, 30 Oct 2012 14:45:50 +0000 (15:45 +0100)]
shared: "max" in the string->number conversion is meant to be inclusive

8 years agoshared, core: do not always accept numbers in string lookups
Michal Schmidt [Tue, 30 Oct 2012 13:29:38 +0000 (14:29 +0100)]
shared, core: do not always accept numbers in string lookups

The behaviour of the common name##_from_string conversion is surprising.
It accepts not only the strings from name##_table but also any number
that falls within the range of the table. The order of items in most of
our tables is an internal affair. It should not be visible to the user.

I know of a case where the surprising numeric conversion leads to a crash.

We will allow the direct numeric conversion only for the tables where the
mapping of strings to numeric values has an external meaning. This holds
for the following lookup tables:
 - netlink_family, ioprio_class, ip_tos, sched_policy - their numeric
   values are stable as they are defined by the Linux kernel interface.
 - log_level, log_facility_unshifted - the well-known syslog interface.

We allow the user to use numeric values whose string names systemd does
not know. For instance, the user may want to test a new kernel featuring
a scheduling policy that did not exist when his systemd version was
released. A slightly unpleasant effect of this is that the
name##_to_string conversion cannot return pointers to constant strings
anymore. The strings have to be allocated on demand and freed by the

8 years agobash-completion: add completion for coredumpctl
Zbigniew Jędrzejewski-Szmek [Tue, 30 Oct 2012 09:18:17 +0000 (10:18 +0100)]
bash-completion: add completion for coredumpctl

8 years agocoredumpctl: add --field/-F option
Zbigniew Jędrzejewski-Szmek [Tue, 30 Oct 2012 10:15:24 +0000 (10:15 +0000)]
coredumpctl: add --field/-F option

Useful for completion generation.

8 years agocoredumpctl: add --no-legend option
Zbigniew Jędrzejewski-Szmek [Tue, 30 Oct 2012 08:45:19 +0000 (09:45 +0100)]
coredumpctl: add --no-legend option

Useful for completion generation.

8 years agocoredumpctl: fix program return code
Zbigniew Jędrzejewski-Szmek [Tue, 30 Oct 2012 08:44:32 +0000 (09:44 +0100)]
coredumpctl: fix program return code

8 years agocoredumpctl: add guard to options table
Zbigniew Jędrzejewski-Szmek [Tue, 30 Oct 2012 08:35:53 +0000 (09:35 +0100)]
coredumpctl: add guard to options table

It is not nice to segfault on unknown options :(

8 years agolibsystemd-daemon: fix style
Michal Schmidt [Tue, 30 Oct 2012 09:30:44 +0000 (10:30 +0100)]
libsystemd-daemon: fix style

8 years agoshared, libsystemd-daemon: check for empty strings in strto*l conversions
Michal Schmidt [Tue, 30 Oct 2012 09:29:40 +0000 (10:29 +0100)]
shared, libsystemd-daemon: check for empty strings in strto*l conversions

strtol() and friends may set EINVAL if no conversion was performed, but
they are not required to do so. In practice they don't. We need to check
for it.

8 years agoSMACK: Add configuration options. (v3)
Auke Kok [Mon, 29 Oct 2012 22:30:05 +0000 (15:30 -0700)]
SMACK: Add configuration options. (v3)

This adds SMACK label configuration options to socket units.

SMACK labels should be applied to most objects on disk well before
execution time, but two items remain that are generated dynamically
at run time that require SMACK labels to be set in order to enforce
MAC on all objects.

Files on disk can be labelled using package management.

For device nodes, simple udev rules are sufficient to add SMACK labels
at boot/insertion time.

Sockets can be created at run time and systemd does just that for
several services. In order to protect FIFO's and UNIX domain sockets,
we must instruct systemd to apply SMACK labels at runtime.

This patch adds the following options:

Smack - applicable to FIFO's.
SmackIpIn/SmackIpOut - applicable to sockets.

No external dependencies are required to support SMACK, as setting
the labels is done using fsetxattr(). The labels can be set on a
kernel that does not have SMACK enabled either, so there is no need
to #ifdef any of this code out.

For more information about SMACK, please see Documentation/Smack.txt
in the kernel source code.

v3 of this patch changes the config options to be CamelCased.

8 years agologind: it's OK if a process on an pty requests a session for seat0
Lennart Poettering [Sun, 28 Oct 2012 16:37:16 +0000 (17:37 +0100)]
logind: it's OK if a process on an pty requests a session for seat0

After all, if a sudo/su inside an X terminal should get added to the
same session as the X session itself.

8 years agologind: unify all session lock loop
Lennart Poettering [Sun, 28 Oct 2012 16:25:23 +0000 (17:25 +0100)]
logind: unify all session lock loop

8 years agoupdate TODO
Lennart Poettering [Sun, 28 Oct 2012 12:55:47 +0000 (13:55 +0100)]
update TODO

8 years agosystemd: mount the EFI variable filesystem
Lee, Chun-Yi [Sat, 27 Oct 2012 03:23:22 +0000 (11:23 +0800)]
systemd: mount the EFI variable filesystem

Add efivarfs to the mount_table in mount-setup.c, so the EFI variable
filesystem will be mounted when systemd executed.

The EFI variable filesystem will merge in v3.7 or v3.8 linux kernel.

Cc: Kay Sievers <>
Cc: Lennart Poettering <>
Cc: Mantas Mikulėnas <>
Cc: Zbigniew Jędrzejewski-Szmek <>
Cc: Matt Fleming <>
Cc: Jeremy Kerr <>
Cc: Matthew Garrett <>
Signed-off-by: Lee, Chun-Yi <>