fix parenthesis in pager.c (#5798)

- result of dup2 should be compared against 0
- making parenthesis around comparisons just to be sure

diff --git a/src/shared/pager.c b/src/shared/pager.c
index f26a9c0cbee141a0eb0e22bd31ba6dbbafcd1ba8..e792381bbdbfbe474f365b9940e710d83e01d229 100644 (file)
--- a/src/shared/pager.c
+++ b/src/shared/pager.c
@@ -176,11 +176,11 @@ void pager_close(void) {
 
         /* Inform pager that we are done */
         (void) fflush(stdout);
 
         /* Inform pager that we are done */
         (void) fflush(stdout);

-        if (stdout_redirected && (stored_stdout < 0 || dup2(stored_stdout, STDOUT_FILENO)) < 0)
+        if (stdout_redirected && ((stored_stdout < 0) || (dup2(stored_stdout, STDOUT_FILENO) < 0)))

                 (void) close(STDOUT_FILENO);
         stored_stdout = safe_close(stored_stdout);
         (void) fflush(stderr);
                 (void) close(STDOUT_FILENO);
         stored_stdout = safe_close(stored_stdout);
         (void) fflush(stderr);

-        if (stderr_redirected && (stored_stderr < 0 || dup2(stored_stderr, STDERR_FILENO)) < 0)
+        if (stderr_redirected && ((stored_stderr < 0) || (dup2(stored_stderr, STDERR_FILENO) < 0)))

                 (void) close(STDERR_FILENO);
         stored_stderr = safe_close(stored_stderr);
         stdout_redirected = stderr_redirected = false;
                 (void) close(STDERR_FILENO);
         stored_stderr = safe_close(stored_stderr);
         stdout_redirected = stderr_redirected = false;