From: Matija Skala <mskala@gmx.com>
Date: Tue, 25 Apr 2017 12:44:29 +0000 (+0200)
Subject: fix parenthesis in pager.c (#5798)
X-Git-Tag: chiark/234.4-1+devuan1.1+iwj1~154
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=bd7bf6b86506e336cff7cc6c391c94306049782d;ds=sidebyside

fix parenthesis in pager.c (#5798)

- result of dup2 should be compared against 0
- making parenthesis around comparisons just to be sure
---

diff --git a/src/shared/pager.c b/src/shared/pager.c
index f26a9c0cb..e792381bb 100644
--- a/src/shared/pager.c
+++ b/src/shared/pager.c
@@ -176,11 +176,11 @@ void pager_close(void) {
 
         /* Inform pager that we are done */
         (void) fflush(stdout);
-        if (stdout_redirected && (stored_stdout < 0 || dup2(stored_stdout, STDOUT_FILENO)) < 0)
+        if (stdout_redirected && ((stored_stdout < 0) || (dup2(stored_stdout, STDOUT_FILENO) < 0)))
                 (void) close(STDOUT_FILENO);
         stored_stdout = safe_close(stored_stdout);
         (void) fflush(stderr);
-        if (stderr_redirected && (stored_stderr < 0 || dup2(stored_stderr, STDERR_FILENO)) < 0)
+        if (stderr_redirected && ((stored_stderr < 0) || (dup2(stored_stderr, STDERR_FILENO) < 0)))
                 (void) close(STDERR_FILENO);
         stored_stderr = safe_close(stored_stderr);
         stdout_redirected = stderr_redirected = false;