From bd7bf6b86506e336cff7cc6c391c94306049782d Mon Sep 17 00:00:00 2001 From: Matija Skala Date: Tue, 25 Apr 2017 14:44:29 +0200 Subject: [PATCH] fix parenthesis in pager.c (#5798) - result of dup2 should be compared against 0 - making parenthesis around comparisons just to be sure --- src/shared/pager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/pager.c b/src/shared/pager.c index f26a9c0cb..e792381bb 100644 --- a/src/shared/pager.c +++ b/src/shared/pager.c @@ -176,11 +176,11 @@ void pager_close(void) { /* Inform pager that we are done */ (void) fflush(stdout); - if (stdout_redirected && (stored_stdout < 0 || dup2(stored_stdout, STDOUT_FILENO)) < 0) + if (stdout_redirected && ((stored_stdout < 0) || (dup2(stored_stdout, STDOUT_FILENO) < 0))) (void) close(STDOUT_FILENO); stored_stdout = safe_close(stored_stdout); (void) fflush(stderr); - if (stderr_redirected && (stored_stderr < 0 || dup2(stored_stderr, STDERR_FILENO)) < 0) + if (stderr_redirected && ((stored_stderr < 0) || (dup2(stored_stderr, STDERR_FILENO) < 0))) (void) close(STDERR_FILENO); stored_stderr = safe_close(stored_stderr); stdout_redirected = stderr_redirected = false; -- 2.30.2