chiark / gitweb /
chiark-utils.git
2 months agofishdescriptor: cast __errno_location correctly
Ian Jackson [Mon, 8 Apr 2019 15:46:04 +0000 (16:46 +0100)]
fishdescriptor: cast __errno_location correctly

The return value from __errno_location() is an int*.  My syntax had
erroneously specified that it returned an int.  Nothing spotted this
bug because the expression is evaluated by gdb whose C interpreter is
very strange.  In particular, gdb lets you dereference an int, even on
a platform where ints are 32-bit and pointers are 64-bit.

If you are on a 32-bit platform, this does not matter.  Likewise if
you are on a 64-bit platform and the address of errno happens, by
luck, to be within the 32-bit addressable part of the space.

If you are mildly lucky the result of this is an error like this:
  gdb.MemoryError: Cannot access memory at address 0x2f24ef10
buried in stack traces from fishdescriptor.

If you are unlucky, fishdescriptor will successfully access some wrong
location.  This means it does not actually save and restore errno,
since it saves and restores somewhere else instead.  So fishdescriptor
will corrupt the errno value of the thread that it happens to
be (ab)using, overwriting it with the errno from fishdescriptor's own
calls, possibly causing the target program to become confused about
the error(s) from system call(s) it is making.

If you are very unlucky, fishdescriptor will successfully access some
wrong location which is actively in use by something outside the
target process (eg, direct IO, shared memory0.  fishdescriptor will
save the value (a single int) and then restore it a bit later.  This
might in principle cause any kind of arbitrary lossage.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
7 months agochangelog: finalise 6.0.3
Ian Jackson [Tue, 20 Nov 2018 18:25:59 +0000 (18:25 +0000)]
changelog: finalise 6.0.3

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
7 months agochangelog: make 6.0.3~citrix1 entry
Ian Jackson [Mon, 19 Nov 2018 16:11:59 +0000 (16:11 +0000)]
changelog: make 6.0.3~citrix1 entry

gbp dch, and edited details, version and trailer line

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
7 months agofishdescriptor: When looking for run_dir, look in target root
Ian Jackson [Tue, 20 Nov 2018 11:31:22 +0000 (11:31 +0000)]
fishdescriptor: When looking for run_dir, look in target root

This is correct, since we are operating in our environment but we are
going to use the path in the target's root.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
7 months agofishdescriptor: Calculate target_root earlier and pass to _sock_dir
Ian Jackson [Tue, 20 Nov 2018 11:30:33 +0000 (11:30 +0000)]
fishdescriptor: Calculate target_root earlier and pass to _sock_dir

No functional change.

We are going to use this in a moment.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
7 months agofishdescriptor: Cope if donor is in a chroot without /proc
Ian Jackson [Mon, 19 Nov 2018 16:08:57 +0000 (16:08 +0000)]
fishdescriptor: Cope if donor is in a chroot without /proc

`our_sockname' contains something like
  /proc/DONOR/root/run/user/UID/fishdescriptor/SOCKET

When I tested this I did it in a chroot where /proc was mounted.  In
such a chroot /proc/DONOR/root -> /.  So this works.

But if there is no /proc, it does not work.

Instead, we can can and should assume that the path in the donor is
relative to its own root.  Ie, we can just use `sockname'.

CC: George Dunlap <george.dunlap@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
7 months agogit-branchmove: Avoid transporting tags about
Ian Jackson [Thu, 8 Nov 2018 15:42:24 +0000 (15:42 +0000)]
git-branchmove: Avoid transporting tags about

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
12 months agochangelog: Prep for Rebuild with arch:all packages included in the upload.
Ian Jackson [Mon, 11 Jun 2018 13:35:22 +0000 (14:35 +0100)]
changelog: Prep for Rebuild with arch:all packages included in the upload.

12 months agochangelog: finalise 6.0.1
Ian Jackson [Mon, 11 Jun 2018 13:31:51 +0000 (14:31 +0100)]
changelog: finalise 6.0.1

12 months agochangelog: discuss fishdescriptor bugs
Ian Jackson [Thu, 7 Jun 2018 16:59:11 +0000 (17:59 +0100)]
changelog: discuss fishdescriptor bugs

12 months agofishdescriptor: Actually tidy up actual2intended when closing
Ian Jackson [Thu, 7 Jun 2018 16:43:42 +0000 (17:43 +0100)]
fishdescriptor: Actually tidy up actual2intended when closing

Otherwise we will probably try to move the new-defunct open-file
somewhere when we try to make the descriptor refer to the intended
open-file.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
12 months agofishdescriptor: Work if child is not running as root, but we are
Ian Jackson [Thu, 7 Jun 2018 16:33:34 +0000 (17:33 +0100)]
fishdescriptor: Work if child is not running as root, but we are

We make a socket, normally in /var/run/user for the victim process,
which is therefore accessible only to the victim uid (and to root).
If we are running as root, the socket will typically not be writeable
by the user, and this will fail.  We need to chmod it.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
12 months agofishdescriptor: Fix a tuple bug in fd permutation
Ian Jackson [Fri, 11 May 2018 15:59:05 +0000 (16:59 +0100)]
fishdescriptor: Fix a tuple bug in fd permutation

The fd permutation algorithm would fail in nontrivial cases because it
tries to update individual members of the tupes in the fdmap.  That is
not permitted in Python.  Make the tuples into lists.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
13 months agofishdescriptor: Fix a typo
Ian Jackson [Fri, 11 May 2018 15:55:19 +0000 (16:55 +0100)]
fishdescriptor: Fix a typo

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
13 months agostart 6.0.1~
Ian Jackson [Fri, 11 May 2018 15:54:24 +0000 (16:54 +0100)]
start 6.0.1~

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
14 months agofinalise 6.0.0
Ian Jackson [Fri, 20 Apr 2018 15:56:20 +0000 (16:56 +0100)]
finalise 6.0.0

Bumping version to 6 because of fishdescriptor

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
14 months agoMerge remote-tracking branch 'mariner/fishdescriptor'
Ian Jackson [Fri, 20 Apr 2018 15:55:14 +0000 (16:55 +0100)]
Merge remote-tracking branch 'mariner/fishdescriptor'

14 months agofishdescriptor: Re-finalise changelog
Ian Jackson [Fri, 20 Apr 2018 15:47:04 +0000 (16:47 +0100)]
fishdescriptor: Re-finalise changelog

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
14 months agofishdescriptor: Provide copyright notices and licence statements
Ian Jackson [Fri, 20 Apr 2018 15:46:45 +0000 (16:46 +0100)]
fishdescriptor: Provide copyright notices and licence statements

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
14 months agofishdescriptor: Minor control file improvement
Ian Jackson [Fri, 20 Apr 2018 15:43:05 +0000 (16:43 +0100)]
fishdescriptor: Minor control file improvement

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
14 months agofishdescriptor: Fix typo in help message
Ian Jackson [Fri, 20 Apr 2018 15:42:31 +0000 (16:42 +0100)]
fishdescriptor: Fix typo in help message

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
16 months agoxbatmon-simple: Minor improvements to the .txt doc.
Ian Jackson [Sun, 18 Feb 2018 22:05:01 +0000 (22:05 +0000)]
xbatmon-simple: Minor improvements to the .txt doc.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
20 months agofishdescriptor: build system (nugatory)
Ian Jackson [Tue, 24 Oct 2017 18:17:56 +0000 (19:17 +0100)]
fishdescriptor: build system (nugatory)

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agoRevert "fishdescriptor: for revert: attempt at setuptools"
Ian Jackson [Tue, 24 Oct 2017 17:52:20 +0000 (18:52 +0100)]
Revert "fishdescriptor: for revert: attempt at setuptools"

This reverts commit 15b1fbea6eaf22d148764b352f2d86b5fc7efb1c.

20 months agofishdescriptor: for revert: attempt at setuptools
Ian Jackson [Tue, 24 Oct 2017 17:52:18 +0000 (18:52 +0100)]
fishdescriptor: for revert: attempt at setuptools

This is too hard.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: mention in changelog
Ian Jackson [Tue, 24 Oct 2017 16:57:50 +0000 (17:57 +0100)]
fishdescriptor: mention in changelog

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: fix error handling
Ian Jackson [Tue, 24 Oct 2017 16:56:39 +0000 (17:56 +0100)]
fishdescriptor: fix error handling

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: sort out debugging output
Ian Jackson [Tue, 24 Oct 2017 16:44:11 +0000 (17:44 +0100)]
fishdescriptor: sort out debugging output

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: bugfixes
Ian Jackson [Tue, 24 Oct 2017 16:23:32 +0000 (17:23 +0100)]
fishdescriptor: bugfixes

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: bugfixes
Ian Jackson [Tue, 24 Oct 2017 16:22:15 +0000 (17:22 +0100)]
fishdescriptor: bugfixes

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: hideous errno workaround
Ian Jackson [Tue, 24 Oct 2017 16:19:27 +0000 (17:19 +0100)]
fishdescriptor: hideous errno workaround

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agoRevert "fishdescriptor: try parse_eval_via_print"
Ian Jackson [Tue, 24 Oct 2017 16:00:50 +0000 (17:00 +0100)]
Revert "fishdescriptor: try parse_eval_via_print"

This reverts commit 33545a21597767a50443a717b015fc9e3c8dd553.

20 months agofishdescriptor: try parse_eval_via_print
Ian Jackson [Tue, 24 Oct 2017 16:00:44 +0000 (17:00 +0100)]
fishdescriptor: try parse_eval_via_print

Actually this works for reading errno but not for setting it.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: wip utility, bugfixes
Ian Jackson [Tue, 24 Oct 2017 15:38:40 +0000 (16:38 +0100)]
fishdescriptor: wip utility, bugfixes

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: wip utility, bugfixes
Ian Jackson [Tue, 24 Oct 2017 15:28:48 +0000 (16:28 +0100)]
fishdescriptor: wip utility, bugfixes

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: wip utility
Ian Jackson [Tue, 24 Oct 2017 15:14:41 +0000 (16:14 +0100)]
fishdescriptor: wip utility

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: wip utility, before rename various variables
Ian Jackson [Tue, 24 Oct 2017 14:22:58 +0000 (15:22 +0100)]
fishdescriptor: wip utility, before rename various variables

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: wip utility
Ian Jackson [Mon, 23 Oct 2017 16:38:56 +0000 (17:38 +0100)]
fishdescriptor: wip utility

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: Make Donor.pid a public member
Ian Jackson [Mon, 23 Oct 2017 16:38:42 +0000 (17:38 +0100)]
fishdescriptor: Make Donor.pid a public member

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: before redo option parsing
Ian Jackson [Thu, 19 Oct 2017 18:59:50 +0000 (19:59 +0100)]
fishdescriptor: before redo option parsing

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: use lookup_type for the field list
Ian Jackson [Thu, 19 Oct 2017 00:52:56 +0000 (01:52 +0100)]
fishdescriptor: use lookup_type for the field list

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
20 months agofishdescriptor: bugfix
Ian Jackson [Thu, 19 Oct 2017 00:34:38 +0000 (01:34 +0100)]
fishdescriptor: bugfix

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
20 months agofishdescriptor: bugfixes, seems to get fds now!
Ian Jackson [Thu, 19 Oct 2017 00:32:56 +0000 (01:32 +0100)]
fishdescriptor: bugfixes, seems to get fds now!

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
20 months agofishdescriptor: bugfixes
Ian Jackson [Thu, 19 Oct 2017 00:23:18 +0000 (01:23 +0100)]
fishdescriptor: bugfixes

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
20 months agofishdescriptor: bugfixes
Ian Jackson [Wed, 18 Oct 2017 23:49:38 +0000 (00:49 +0100)]
fishdescriptor: bugfixes

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
20 months agofishdescriptor: debugging
Ian Jackson [Wed, 18 Oct 2017 17:25:57 +0000 (18:25 +0100)]
fishdescriptor: debugging

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: debugging
Ian Jackson [Wed, 18 Oct 2017 15:58:55 +0000 (16:58 +0100)]
fishdescriptor: debugging

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: new approach
Ian Jackson [Wed, 18 Oct 2017 15:49:45 +0000 (16:49 +0100)]
fishdescriptor: new approach

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: wip reconsider approach
Ian Jackson [Wed, 18 Oct 2017 14:18:36 +0000 (15:18 +0100)]
fishdescriptor: wip reconsider approach

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: wip, before reconsider approach
Ian Jackson [Wed, 18 Oct 2017 09:58:36 +0000 (10:58 +0100)]
fishdescriptor: wip, before reconsider approach

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: wip (found)
Ian Jackson [Tue, 17 Oct 2017 17:11:29 +0000 (18:11 +0100)]
fishdescriptor: wip (found)

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: reorg python libraries again
Ian Jackson [Fri, 13 Oct 2017 15:44:05 +0000 (16:44 +0100)]
fishdescriptor: reorg python libraries again

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: WIP fishing module, before move to own module
Ian Jackson [Fri, 13 Oct 2017 15:09:54 +0000 (16:09 +0100)]
fishdescriptor: WIP fishing module, before move to own module

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: Allow "preloaded"
Ian Jackson [Fri, 6 Oct 2017 18:12:30 +0000 (19:12 +0100)]
fishdescriptor: Allow "preloaded"

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: Use os or dl for RTLD_now
Ian Jackson [Fri, 6 Oct 2017 18:11:13 +0000 (19:11 +0100)]
fishdescriptor: Use os or dl for RTLD_now

Suggestion by Colin Watson.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agoRevert "fishdescriptor: Utility for RTLD_NOW"
Ian Jackson [Fri, 6 Oct 2017 18:05:15 +0000 (19:05 +0100)]
Revert "fishdescriptor: Utility for RTLD_NOW"

This reverts commit 22677ae542431ce09a8de83fecc3a22163a8d490.

20 months agofishdescriptor: Utility for RTLD_NOW
Ian Jackson [Fri, 6 Oct 2017 18:04:03 +0000 (19:04 +0100)]
fishdescriptor: Utility for RTLD_NOW

Actually we don't want to do this.  It is better to use the python dl
or os modules, so we will do that in a moment.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: work on python code
Ian Jackson [Fri, 6 Oct 2017 18:03:25 +0000 (19:03 +0100)]
fishdescriptor: work on python code

Still very incomplete

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: .so can be loaded
Ian Jackson [Thu, 5 Oct 2017 17:06:23 +0000 (18:06 +0100)]
fishdescriptor: .so can be loaded

(gdb) print (void*)dlopen("/u/iwj/things/chiark-utils.git/fishdescriptor/libfishdescriptor-donate.so.1.0",2)
$5 = (void *) 0x8f0d408
(gdb) print (void*)dlsym($5, "fishdescriptor_donate")
$6 = (void *) 0xf6953620 <fishdescriptor_donate>
(gdb) print (( int (*)(const char *, const int *) )$6)("/dev/enoent", (int[2]){0,-1})
$7 = 2
(gdb) print strerror(2)
$8 = 0xf74697e8 "No such file or directory"
(gdb)

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: donate: some bugfixes
Ian Jackson [Thu, 5 Oct 2017 16:21:11 +0000 (17:21 +0100)]
fishdescriptor: donate: some bugfixes

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: More work, before trying to compile it
Ian Jackson [Thu, 5 Oct 2017 16:10:00 +0000 (17:10 +0100)]
fishdescriptor: More work, before trying to compile it

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: reorganise to my taste
Ian Jackson [Thu, 5 Oct 2017 15:25:41 +0000 (16:25 +0100)]
fishdescriptor: reorganise to my taste

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: Upgrade licence of code from libxl
Ian Jackson [Wed, 4 Oct 2017 13:48:13 +0000 (14:48 +0100)]
fishdescriptor: Upgrade licence of code from libxl

See LGPL-2.1 s3.  This is necessary to preserve the copyright and
licence status of chiark-utils as a whole.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
20 months agofishdescriptor: Copy fd passing C sender code from libxl
Ian Jackson [Wed, 4 Oct 2017 13:38:56 +0000 (14:38 +0100)]
fishdescriptor: Copy fd passing C sender code from libxl

Copy int libxl__sendmsg_fds from libxl so we can clone and hack it.

Source was:
 xen.git#38ab259f559be5457f6866ba24185e013f27defb
 tools/libxl/libxl_utils.c

libxl is LGPL2.1-only.  We will upgrade this licence to be compatible
with the rest of chiark utils (GPL3+) in a moment.  This is permitted
by LGPL-2.1 section 3.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
2 years agochangelog: start ~iwj again
Ian Jackson [Mon, 8 May 2017 16:26:49 +0000 (17:26 +0100)]
changelog: start ~iwj again

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agochangelog: finalise 5.0.3~citrix2
Ian Jackson [Mon, 8 May 2017 16:22:04 +0000 (17:22 +0100)]
changelog: finalise 5.0.3~citrix2

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
2 years agogit-cache-proxy: Radically increase several timeouts.
Ian Jackson [Mon, 8 May 2017 16:21:12 +0000 (17:21 +0100)]
git-cache-proxy: Radically increase several timeouts.

Experience in the Xen Project Massachusetts test lab shows that these
are too low.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
2 years agogit-cache-proxy: New --serve-timeout option.
Ian Jackson [Mon, 8 May 2017 16:20:39 +0000 (17:20 +0100)]
git-cache-proxy: New --serve-timeout option.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
2 years agochangelog: Document -t option
Ian Jackson [Wed, 3 May 2017 20:39:59 +0000 (21:39 +0100)]
changelog: Document -t option

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agowith-lock-ex: Provide -t (timeout) option
Matthew Vernon [Wed, 3 May 2017 13:30:02 +0000 (14:30 +0100)]
with-lock-ex: Provide -t (timeout) option

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Matthew Vernon <mv3@sanger.ac.uk>
---
v4: Initial capital and final full-stop on sentences
    Remove code that attempted to reduce post-lock timeout race
    Move timer clearing to outside the retry loop

v3: split off from conversion to getopt

2 years agowith-lock-ex: Replace ad-hoc option parser with getopt.
Matthew Vernon [Wed, 3 May 2017 13:30:02 +0000 (14:30 +0100)]
with-lock-ex: Replace ad-hoc option parser with getopt.

Also, fix typo in usage message (missing -ex).

Signed-off-by: Matthew Vernon <mv3@sanger.ac.uk>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---
v5: Fix commit message.

v4: make coding style consistent
    fix typo in usage message (missing -ex)

v3: split off from timeout patch
    add copyright notice

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agowith-lock-ex: Convert to MIT
Ian Jackson [Wed, 3 May 2017 13:51:20 +0000 (14:51 +0100)]
with-lock-ex: Convert to MIT

Since the PD dedication is not effective in some jurisdictions.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agoAdd DEVELOPER-CERTIFICATE file and start using S-o-b practice.
Ian Jackson [Wed, 3 May 2017 13:50:00 +0000 (14:50 +0100)]
Add DEVELOPER-CERTIFICATE file and start using S-o-b practice.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agochangelog: start new entry
Ian Jackson [Wed, 3 May 2017 13:28:44 +0000 (14:28 +0100)]
changelog: start new entry

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agochangelog: finalise 5.0.3~citrix1
Ian Jackson [Wed, 26 Apr 2017 12:04:19 +0000 (13:04 +0100)]
changelog: finalise 5.0.3~citrix1

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
2 years agoMerge remote-tracking branch 'mariner/master'
Ian Jackson [Wed, 26 Apr 2017 12:03:14 +0000 (13:03 +0100)]
Merge remote-tracking branch 'mariner/master'

2 years agochangelog: finalise 5.0.1~citrix1
Ian Jackson [Wed, 26 Apr 2017 11:56:14 +0000 (12:56 +0100)]
changelog: finalise 5.0.1~citrix1

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
2 years agogit-cache-proxy: Add Citrix to copyright notices
Ian Jackson [Wed, 26 Apr 2017 11:09:33 +0000 (12:09 +0100)]
git-cache-proxy: Add Citrix to copyright notices

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
2 years agogit-cache-proxy: Do not spuriously timeout on too many simultaneous invocations
Ian Jackson [Wed, 26 Apr 2017 11:08:22 +0000 (12:08 +0100)]
git-cache-proxy: Do not spuriously timeout on too many simultaneous invocations

Specifically, do not timeout when reacquiring the lock before serving.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
2 years agoPortability fix: Fix on libcs where st_mtime is not a macro (ie, ones lacking st_mtim.)
Ian Jackson [Mon, 23 Jan 2017 18:13:05 +0000 (18:13 +0000)]
Portability fix: Fix on libcs where st_mtime is not a macro (ie, ones lacking st_mtim.)

2 years agofinalise 5.0.1
Ian Jackson [Mon, 23 Jan 2017 17:54:05 +0000 (17:54 +0000)]
finalise 5.0.1

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agowith-lock-ex: provide -l
Ian Jackson [Wed, 16 Nov 2016 15:21:51 +0000 (15:21 +0000)]
with-lock-ex: provide -l

2 years agochangelog: start 5.0.1~
Ian Jackson [Wed, 16 Nov 2016 15:20:19 +0000 (15:20 +0000)]
changelog: start 5.0.1~

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agochangelog: finalise 5.0.0
Ian Jackson [Sat, 5 Nov 2016 13:48:50 +0000 (13:48 +0000)]
changelog: finalise 5.0.0

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agoxduplic-copier: Use XkbKeycodeToKeysym instead of XKeycodeToKeysym.
Ian Jackson [Sat, 5 Nov 2016 13:30:50 +0000 (13:30 +0000)]
xduplic-copier: Use XkbKeycodeToKeysym instead of XKeycodeToKeysym.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agoxduplic-copier: Print error message, rather than segfaulting, if XOpenDisplay fails.
Ian Jackson [Sat, 5 Nov 2016 13:29:11 +0000 (13:29 +0000)]
xduplic-copier: Print error message, rather than segfaulting, if XOpenDisplay fails.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agoxduplic-copier: Drop obsolete variable "ts_last".
Ian Jackson [Sat, 5 Nov 2016 13:24:13 +0000 (13:24 +0000)]
xduplic-copier: Drop obsolete variable "ts_last".

ad24e88eee84 (from cvs) "abolish daft stream burst thing" left this
now-unused variable behind.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agorules: Drop seddery for libgmp3c2 C++ ABI transition.
Ian Jackson [Sat, 5 Nov 2016 12:52:54 +0000 (12:52 +0000)]
rules: Drop seddery for libgmp3c2 C++ ABI transition.

c1372c51e9a4 (was from CVS) "better treatment of dependencies" says

  * seddery libgmp3 dependencies to libgmp3 | libgmp3c2 since
    we are C and not C++ and care nothing for C++ ABI transitions.

That was in 2007.  We do not need this any more.  Current libgmp is
libgmp10.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agoFix build repro by using gzip -n. Closes:#777300. (Chris Lamb.)
Ian Jackson [Sat, 5 Nov 2016 12:39:28 +0000 (12:39 +0000)]
Fix build repro by using gzip -n.  Closes:#777300.  (Chris Lamb.)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agoFix tiny typo in long description. Closes:#819746. (Luke Faraone.)
Ian Jackson [Sat, 5 Nov 2016 12:32:08 +0000 (12:32 +0000)]
Fix tiny typo in long description.  Closes:#819746.  (Luke Faraone.)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agochangelog: Mention cgi-fcgi-interp argv fix
Ian Jackson [Sat, 5 Nov 2016 12:29:21 +0000 (12:29 +0000)]
changelog: Mention cgi-fcgi-interp argv fix

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agocvs-adjustroot: reinvoke oursevles via "$0" rather than our hardcoded name. Makes...
Ian Jackson [Sat, 5 Nov 2016 12:07:15 +0000 (12:07 +0000)]
cvs-adjustroot: reinvoke oursevles via "$0" rather than our hardcoded name.  Makes testing easier, etc.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agocvs-adjustroot: silently succeed for */CVS/Root entries which already match the new...
Ian Jackson [Sat, 5 Nov 2016 12:06:33 +0000 (12:06 +0000)]
cvs-adjustroot: silently succeed for */CVS/Root entries which already match the new value.  Closes:#839708 (second half).

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agocvs-adjustroot: properly exit nonzero in case of error. Fixes the first half of ...
Ian Jackson [Sat, 5 Nov 2016 11:56:19 +0000 (11:56 +0000)]
cvs-adjustroot: properly exit nonzero in case of error. Fixes the first half of #839708.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agochangelog: Mention that rebuild will close #811216
Ian Jackson [Sat, 5 Nov 2016 11:33:50 +0000 (11:33 +0000)]
changelog: Mention that rebuild will close #811216

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agonntpid: install in /usr/bin. Closes:#773651.
Ian Jackson [Sat, 5 Nov 2016 11:28:54 +0000 (11:28 +0000)]
nntpid: install in /usr/bin.  Closes:#773651.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agonntpid: Chiark::NNTP: spot if cat /etc/nntpserver fails
Ian Jackson [Sat, 5 Nov 2016 11:28:10 +0000 (11:28 +0000)]
nntpid: Chiark::NNTP: spot if cat /etc/nntpserver fails

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agonntpid: Rename ChiarkNNTP to Chiark::NNTP
Ian Jackson [Sat, 5 Nov 2016 11:27:50 +0000 (11:27 +0000)]
nntpid: Rename ChiarkNNTP to Chiark::NNTP

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agocgi-fcgi-interp: support CGI command line arguments
Tony Finch [Fri, 7 Oct 2016 12:57:57 +0000 (13:57 +0100)]
cgi-fcgi-interp: support CGI command line arguments

If the QUERY_STRING does not contain an = then it is also passed
on the command line.

See https://tools.ietf.org/html/rfc3875#section-4.4

2 years agocgi-fcgi-interp: correct the copyright header rubric.
Ian Jackson [Sat, 5 Nov 2016 12:23:58 +0000 (12:23 +0000)]
cgi-fcgi-interp: correct the copyright header rubric.

Reported-by: Tony Finch <dot@dotat.at>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>