chiark / gitweb /
6 years agodbus: return non-zero return value in the case that prefix won't match
Lukas Nykryn [Thu, 20 Nov 2014 15:06:18 +0000 (16:06 +0100)]
dbus: return non-zero return value in the case that prefix won't match

strv_extend returns 0 in the case of success which means that
else if (bus_track_deserialize_item(&m->deserialized_subscribed, l) == 0)
        log_warning("Unknown serialization item '%s'", l);
will be printed when value is added correctly.

6 years agotest: support empty environment variables in unit files
Iago López Galeiras [Thu, 20 Nov 2014 20:18:23 +0000 (21:18 +0100)]
test: support empty environment variables in unit files

Also update TODO, empty environment variables in Environment= and
EnvironmentFile= options work.

6 years agoman: reword list-dependencies description
Zbigniew Jędrzejewski-Szmek [Sun, 23 Nov 2014 16:07:15 +0000 (11:07 -0500)]
man: reword list-dependencies description

The previous version was a bit too vague. It is better
to simply list all dependency types that are followed.

Previous version also made an emphasis on dependencies introduced by
configuration.  But this command (or systemd) don't care about this
distinction between configured and automatically added dependencies at
all. This distinctionis removed from the main description, and an
explanatory paragraph is added to remind the user that all
dependencies are shown, no matter where they come from.

6 years agosystemctl: show BindsTo/BoundBy in list-dependencies
Zbigniew Jędrzejewski-Szmek [Sun, 23 Nov 2014 01:21:56 +0000 (20:21 -0500)]
systemctl: show BindsTo/BoundBy in list-dependencies

Suggested-by: Peter Mattern <>

6 years agonspawn: ignore EEXIST when mounting tmpfs
Richard Schütz [Fri, 21 Nov 2014 20:44:48 +0000 (21:44 +0100)]
nspawn: ignore EEXIST when mounting tmpfs

commit 79d80fc1466512d0ca211f4bfcd9de5f2f816a5a introduced a regression that
prevents mounting a tmpfs if the mount point already exits in the container's
root file system. This commit fixes the problem by ignoring EEXIST.

6 years agoman/logind.conf.xml: make consistent with default logind.conf
Chris Atkinson [Sat, 22 Nov 2014 20:58:47 +0000 (15:58 -0500)]
man/logind.conf.xml: make consistent with default logind.conf

6 years agoDo not check for existence of remote binaries
Zbigniew Jędrzejewski-Szmek [Sat, 22 Nov 2014 23:00:07 +0000 (18:00 -0500)]
Do not check for existence of remote binaries

systemd-run would fail when run with -M or -H and an absolute path,
if this path did not exists locally. Allow it to continue, since we
don't have a nice way of checking if the binary exists remotely.

The case where -M or -H is used and a local path is unchanged, and we
still iterate over $PATH to find the binary. We need to convert to an
absolute path, and we don't have a nice mechanism to check remotely,
so we assume that the binary will be located in the same place locally
and remotely.

6 years agomissing: add IFLA_BRPORT_LEARNING and friends
Zbigniew Jędrzejewski-Szmek [Sat, 22 Nov 2014 22:12:44 +0000 (17:12 -0500)]
missing: add IFLA_BRPORT_LEARNING and friends

IFLA_BRPORT_LEARNING was added in v3.10-rc4-583-g9ba18891f7,
and IFLA_BRPORT_UNICAST_FLOOD in v3.10-rc4-584-g867a59436f.

6 years agomissing: add __NR_getrandom for a few more archs
Zbigniew Jędrzejewski-Szmek [Sat, 22 Nov 2014 17:04:50 +0000 (12:04 -0500)]
missing: add __NR_getrandom for a few more archs

Mips has getrandom() too, but there's just too many variants
for me too care. Either someone who cares does it, or they get
compile-time warnings with old kernel headers.

6 years agoselinux-access: fix broken ternary operator
Lukas Nykryn [Fri, 21 Nov 2014 16:02:15 +0000 (17:02 +0100)]
selinux-access: fix broken ternary operator

it seems to be a typo introduced by ebcf1f97de4f6b1580ae55eb56b1a3939fe6b602
-                _r = selinux_access_check(_b, _m, _u->source_path ?:_u->fragment_path, (permission), &_error); \
+        ({ Unit *_unit = (unit); selinux_generic_access_check(bus,message, _unit->fragment_path ?: _unit->fragment_path, permission,error); })

6 years agoman: don't mix 2ch and 8ch indentation in busctl.xml
Lennart Poettering [Fri, 21 Nov 2014 19:46:01 +0000 (20:46 +0100)]
man: don't mix 2ch and 8ch indentation in busctl.xml

6 years agoman: add emacs header to get correct indention in nxml-mode for the manpage XML files...
Lennart Poettering [Fri, 21 Nov 2014 19:44:48 +0000 (20:44 +0100)]
man: add emacs header to get correct indention in nxml-mode for the manpage XML files that use 2ch indenting

In the long run we really should figure out if we want to stick with 8ch
or 2ch indenting, and not continue with half-and-half. For now, just
make emacs aware of the files that use 2ch indenting.

6 years agobusctl: add --timeout= option to specify method call timeout
Lennart Poettering [Fri, 21 Nov 2014 19:31:50 +0000 (20:31 +0100)]
busctl: add --timeout= option to specify method call timeout

6 years agobusctl: add options to control message header flags when invoking methods
Lennart Poettering [Fri, 21 Nov 2014 19:13:26 +0000 (20:13 +0100)]
busctl: add options to control message header flags when invoking methods

6 years agonspawn: Add try-{host,guest} journal link modes
Martin Pitt [Thu, 20 Nov 2014 13:30:52 +0000 (14:30 +0100)]
nspawn: Add try-{host,guest} journal link modes

--link-journal={host,guest} fail if the host does not have persistent
journalling enabled and /var/log/journal/ does not exist. Even worse, as there
is no stdout/err any more, there is no error message to point that out.

Introduce two new modes "try-host" and "try-guest" which don't fail in this
case, and instead just silently skip the guest journal setup.

Change -j to mean "try-guest" instead of "guest", and fix the wrong --help
output for it (it said "host" before).

Change to use "try-guest" so that this unit works
with both persistent and non-persistent journals on the host without failing.

6 years agounits: make sure rfkill service is bount to the actual hardware
Lennart Poettering [Fri, 21 Nov 2014 00:20:57 +0000 (01:20 +0100)]
units: make sure rfkill service is bount to the actual hardware

6 years agoRevert "systemd-logind.service: set Type=notify"
Lennart Poettering [Fri, 21 Nov 2014 00:17:52 +0000 (01:17 +0100)]
Revert "systemd-logind.service: set Type=notify"

This reverts commit a4962513c555fe3ac4b5bebf97a71701361a45b0.

logind.service is a D-Bus service, hence we should use the dbus name as
indication that we are up. Type=dbus is implied if BusName= is
specified, as it is in this case.

This removes a warning that is printed because a BusName= is specified
for a Type=notify unit.

6 years agotmpfiles.d: Create /var/lib/containers
Martin Pitt [Thu, 20 Nov 2014 13:37:08 +0000 (14:37 +0100)]
tmpfiles.d: Create /var/lib/containers

Create /var/lib/containers so that it exists with an appropriate mode. We want
0700 by default so that users on the host aren't able to call suid root
binaries in the container. This becomes a security issue if a user can enter a
container as root, create a suid root binary, and call that from the host.
(This assumes that containers are caged by mandatory access control or are
started as user).

6 years agobusctl: show property values in "introspect" output, add "set-property" command,...
Lennart Poettering [Thu, 20 Nov 2014 22:12:29 +0000 (23:12 +0100)]
busctl: show property values in "introspect" output, add "set-property" command, and support both a terse and a verbose output format

6 years agobusctl: when --address is specified do not assume we connect to a full bus
Lennart Poettering [Thu, 20 Nov 2014 20:01:06 +0000 (21:01 +0100)]
busctl: when --address is specified do not assume we connect to a full bus

6 years agobusctl: use canned error message on parse failure
Lennart Poettering [Thu, 20 Nov 2014 19:59:57 +0000 (20:59 +0100)]
busctl: use canned error message on parse failure

6 years agosd-bus: create clean error when a property Set() call with incorrect signature is...
Lennart Poettering [Thu, 20 Nov 2014 19:58:39 +0000 (20:58 +0100)]
sd-bus: create clean error when a property Set() call with incorrect signature is passed in

6 years agobuild: avoid trailing whitespace in feature string
Lennart Poettering [Thu, 20 Nov 2014 19:58:02 +0000 (20:58 +0100)]
build: avoid trailing whitespace in feature string

6 years agoutil: add functions getting proc cwd and root
Jakub Filak [Wed, 19 Nov 2014 10:01:19 +0000 (11:01 +0100)]
util: add functions getting proc cwd and root

/proc/[pid]/cwd and /proc/[pid]/root are symliks to corresponding

The added functions returns values of that symlinks.

6 years agosd-dhcp-lease: fix copy-paste error asserting wrong function argument
Thomas Haller [Wed, 19 Nov 2014 12:57:08 +0000 (13:57 +0100)]
sd-dhcp-lease: fix copy-paste error asserting wrong function argument

6 years agobusctl: pass error output to stdout (rather than stderr) when generate tree for all...
Lennart Poettering [Wed, 19 Nov 2014 23:00:22 +0000 (00:00 +0100)]
busctl: pass error output to stdout (rather than stderr) when generate tree for all objects

This is a ton more useful when some services fail, since we continue
crawling then and output everything to a pager.

6 years agobusctl: improve output of service creds
Lennart Poettering [Wed, 19 Nov 2014 22:59:26 +0000 (23:59 +0100)]
busctl: improve output of service creds

6 years agobusctl: add new "introspect" verb for introspecting objects
Lennart Poettering [Wed, 19 Nov 2014 20:12:54 +0000 (21:12 +0100)]
busctl: add new "introspect" verb for introspecting objects

6 years agosd-bus: refuse properties that claim to be both writable and constant at the same...
Lennart Poettering [Wed, 19 Nov 2014 19:52:47 +0000 (20:52 +0100)]
sd-bus: refuse properties that claim to be both writable and constant at the same time

6 years agocore: watchdog bus properties cannot be both writable and constant
Lennart Poettering [Wed, 19 Nov 2014 19:52:23 +0000 (20:52 +0100)]
core: watchdog bus properties cannot be both writable and constant

6 years agotests: fix minor memory leak
Lennart Poettering [Wed, 19 Nov 2014 15:43:41 +0000 (16:43 +0100)]
tests: fix minor memory leak

6 years agoset: make set_consume() actually free the allocated string if the string already...
Lennart Poettering [Wed, 19 Nov 2014 15:43:03 +0000 (16:43 +0100)]
set: make set_consume() actually free the allocated string if the string already is in the set

6 years agobusctl: split out introspection parser from tree logic so that we can reuse it for...
Lennart Poettering [Wed, 19 Nov 2014 15:42:21 +0000 (16:42 +0100)]
busctl: split out introspection parser from tree logic so that we can reuse it for a future "busctl introspect" command

6 years agosystemd-logind.service: set Type=notify
Dave Reisner [Wed, 19 Nov 2014 13:13:34 +0000 (08:13 -0500)]
systemd-logind.service: set Type=notify

The code already calls sd_notify("READY=1"), so we may as well take
advantage of the startup behavior in the unit. The same was done for
the journal in a87a38c20.

6 years agosd-dhcp-lease: load/save client ID
Dan Williams [Tue, 18 Nov 2014 23:13:12 +0000 (17:13 -0600)]
sd-dhcp-lease: load/save client ID

The lease is usually tied to the client ID, so users of the
lease may want to know what client ID it was acquired with.

6 years agosd-dhcp-client: allow getting/setting the client ID
Dan Williams [Tue, 18 Nov 2014 23:01:20 +0000 (17:01 -0600)]
sd-dhcp-client: allow getting/setting the client ID

The client identifier can be in many different formats, not just
the one that systemd creates from the Ethernet MAC address.  Non-
ethernet interfaces may have different client IDs formats.  Users
may also have custom client IDs that the wish to use to preserve
lease options delivered by servers configured with the existing
client ID.

6 years agoupdate TODO
Lennart Poettering [Tue, 18 Nov 2014 22:35:46 +0000 (23:35 +0100)]
update TODO

6 years agosd-dhcp-lease: expose load/save functions
Tom Gundersen [Tue, 18 Nov 2014 18:10:37 +0000 (19:10 +0100)]
sd-dhcp-lease: expose load/save functions

Based on patch by Dan Williams.

6 years agosd-dhcp-client: fix REBOOT state handling
Dan Williams [Tue, 4 Nov 2014 17:20:43 +0000 (11:20 -0600)]
sd-dhcp-client: fix REBOOT state handling

client->secs wasn't getting set in the REBOOT state, causing
an assertion.  REBOOT should work the same way as INIT, per
RFC 2131:

 secs   2  Filled in by client, seconds elapsed since client
           began address acquisition or renewal process.

REBOOT is necessary because some DHCP servers (eg on
home routers) do not hand back the same IP address unless the
'ciaddr' field is filled with that address, which DISCOVER
cannot do per the RFCs.  This leads to multiple leases
on machine reboot or DHCP client restart.

6 years agonamespace: unchecked return value from library
Susant Sahani [Mon, 17 Nov 2014 10:58:57 +0000 (16:28 +0530)]
namespace: unchecked return value from library


CID 1237553 (#1 of 6): Unchecked return value from library

CID 1237553 (#3 of 6): Unchecked return value from library

CID 1237553 (#4 of 6): Unchecked return value from library

CID 1237553 (#5 of 6): Unchecked return value from library

CID 1237553 (#6 of 6): Unchecked return value from library

6 years agobus-socket: fix CID#996290 Unchecked return value
Susant Sahani [Tue, 11 Nov 2014 08:06:33 +0000 (13:36 +0530)]
bus-socket: fix CID#996290 Unchecked return value

6 years agoresolve: fix CID#1237549 Unchecked return value
Susant Sahani [Tue, 11 Nov 2014 08:06:32 +0000 (13:36 +0530)]
resolve: fix CID#1237549 Unchecked return value

6 years agolog: unchecked return value from library
Susant Sahani [Tue, 11 Nov 2014 08:06:31 +0000 (13:36 +0530)]
log: unchecked return value from library

fix 1237557 Unchecked return value from library

6 years agoudev: silence TOCTOU warning when creating a directory
Ronny Chevalier [Sun, 9 Nov 2014 14:42:23 +0000 (15:42 +0100)]
udev: silence TOCTOU warning when creating a directory

CID#979416. There is no real race here to fix, but lets make coverity
happy and rework the code.

Note that we still fail if the directory is removed _after_ we ran
mkdir(), so the same race is still there. Coverity is complaining, though.
Rewrite the code to make it happy.

(David: rewrote the commit-message to note that this is not a race. If I'm
        wrong, blame me, not Ronny!)

6 years agopam_systemd: remove unused null check
Thomas Hindoe Paaboel Andersen [Sat, 15 Nov 2014 22:43:09 +0000 (23:43 +0100)]
pam_systemd: remove unused null check

username was already checked with isempty() and cannot be null at
this point.


6 years agoautogen: drop unnecessary -Wno-gnu for the clang shortcut
Thomas Hindoe Paaboel Andersen [Sat, 15 Nov 2014 20:32:59 +0000 (21:32 +0100)]
autogen: drop unnecessary -Wno-gnu for the clang shortcut

It is no longer necessary after 65e3a2cf7c3b399853dd309f702ca5078b7d16ea
where -Wno-gnu-variable-sized-type-not-at-end is added if we detect
that the compiler is clang.

6 years agobus-proxy: avoid redundant name validity checks
Lennart Poettering [Fri, 14 Nov 2014 19:06:20 +0000 (20:06 +0100)]
bus-proxy: avoid redundant name validity checks

Our API calls check the validity of bus names anyway, hence we don't
have to do this before calling them...

6 years agobus-proxy: properly check for bus name prefixes when enforcing policy
Lennart Poettering [Fri, 14 Nov 2014 19:06:01 +0000 (20:06 +0100)]
bus-proxy: properly check for bus name prefixes when enforcing policy

6 years agobus-proxy: drop broken access check in driver
Lennart Poettering [Fri, 14 Nov 2014 17:47:54 +0000 (18:47 +0100)]
bus-proxy: drop broken access check in driver

The access check call was broken (as it tried to read a service name
from the UpdateActivationEnvironment() method call which doesn't carry
any). Also, it's unnecessary to make any access checks here, as we just
forward the call to PID 1 which should do the access checks necessary.

6 years agokmod-setup: improve for "kdbus" word on the kernel cmdline
Lennart Poettering [Fri, 14 Nov 2014 17:02:30 +0000 (18:02 +0100)]
kmod-setup: improve for "kdbus" word on the kernel cmdline

We really shouldn't check for words with "strstr()"...

6 years agokmod: move #ifdef checks for kmod-setup out of main.c into kmod-setup.c
Lennart Poettering [Fri, 14 Nov 2014 16:58:32 +0000 (17:58 +0100)]
kmod: move #ifdef checks for kmod-setup out of main.c into kmod-setup.c

6 years agoupdate TODO
Lennart Poettering [Fri, 14 Nov 2014 16:55:19 +0000 (17:55 +0100)]
update TODO

6 years agobusctl: introduce busctl "get-property" command for reading and dumping object properties
Lennart Poettering [Fri, 14 Nov 2014 16:20:04 +0000 (17:20 +0100)]
busctl: introduce busctl "get-property" command for reading and dumping object properties

6 years agomount-setup: remove mount_setup_late()
Daniel Mack [Fri, 14 Nov 2014 14:18:56 +0000 (15:18 +0100)]
mount-setup: remove mount_setup_late()

Turns out we can just do kmod_setup() earlier, before we do mount_setup(),
so there's no need for mount_setup_late() anymore. Instead, put kdbusfs in

6 years agobusctl: various tweaks to "busctl tree" output
Lennart Poettering [Fri, 14 Nov 2014 12:18:33 +0000 (13:18 +0100)]
busctl: various tweaks to "busctl tree" output

6 years agoman: various tweaks for busctl(1) man page
Lennart Poettering [Fri, 14 Nov 2014 12:11:45 +0000 (13:11 +0100)]
man: various tweaks for busctl(1) man page

6 years agobusctl: add new "call" command to invoke methods on a service
Lennart Poettering [Fri, 14 Nov 2014 12:11:10 +0000 (13:11 +0100)]
busctl: add new "call" command to invoke methods on a service

6 years agosd-bus: add sd_bus_message_is_empty() for checking whether a message carries any...
Lennart Poettering [Fri, 14 Nov 2014 12:05:01 +0000 (13:05 +0100)]
sd-bus: add sd_bus_message_is_empty() for checking whether a message carries any body

6 years agoman: hostnamectl understands -M too
Lennart Poettering [Fri, 14 Nov 2014 11:55:18 +0000 (12:55 +0100)]
man: hostnamectl understands -M too

6 years agosd-bus: sync with kdbus upstream (ABI break)
Daniel Mack [Thu, 13 Nov 2014 19:33:03 +0000 (20:33 +0100)]
sd-bus: sync with kdbus upstream (ABI break)

kdbus has seen a larger update than expected lately, most notably with
kdbusfs, a file system to expose the kdbus control files:

 * Each time a file system of this type is mounted, a new kdbus
   domain is created.

 * The layout inside each mount point is the same as before, except
   that domains are not hierarchically nested anymore.

 * Domains are therefore also unnamed now.

 * Unmounting a kdbusfs will automatically also detroy the
   associated domain.

 * Hence, the action of creating a kdbus domain is now as
   privileged as mounting a filesystem.

 * This way, we can get around creating dev nodes for everything,
   which is last but not least something that is not limited by
   20-bit minor numbers.

The kdbus specific bits in nspawn have all been dropped now, as nspawn
can rely on the container OS to set up its own kdbus domain, simply by
mounting a new instance.

A new set of mounts has been added to mount things *after* the kernel
modules have been loaded. For now, only kdbus is in this set, which is
invoked with mount_setup_late().

6 years agobus-proxyd: temporarily disable policy checks again
Daniel Mack [Thu, 13 Nov 2014 10:59:29 +0000 (11:59 +0100)]
bus-proxyd: temporarily disable policy checks again

There are issues to investigate on with policies shipped by some
packages, which we'll address later. Move that topic out of the
way for now to bring sd-bus in sync with upstream kdbus.

6 years agoudev: support ENV{}=="" global property matches
Kay Sievers [Thu, 13 Nov 2014 19:35:06 +0000 (20:35 +0100)]
udev: support ENV{}=="" global property matches

6 years agoudev: move global property handling from libudev to udevd
Kay Sievers [Thu, 13 Nov 2014 12:50:01 +0000 (13:50 +0100)]
udev: move global property handling from libudev to udevd

6 years agoudev: switch to systemd logging functions
Kay Sievers [Thu, 13 Nov 2014 12:11:04 +0000 (13:11 +0100)]
udev: switch to systemd logging functions

6 years agolibudev: we do not log errors from libraries
Kay Sievers [Thu, 13 Nov 2014 10:42:24 +0000 (11:42 +0100)]
libudev: we do not log errors from libraries

6 years agotests: add test-execute
Ronny Chevalier [Tue, 11 Nov 2014 19:05:40 +0000 (20:05 +0100)]
tests: add test-execute

add tests for the following directives:
- WorkingDirectory
- Personality
- PrivateTmp
- SystemCallFilter: It makes test/TEST-04-SECCOMP obsolete, so it has
  been removed.
- SystemCallErrorNumber
- User
- Group
- Environment

6 years agomanager: allow test run to catch SIGCHLD events
Ronny Chevalier [Tue, 11 Nov 2014 18:48:27 +0000 (19:48 +0100)]
manager: allow test run to catch SIGCHLD events

Otherwise we cannot know when a service exited

6 years agokeymap: Fix special keys on ThinkPad X60/X61 Tablet
Bastien Nocera [Wed, 12 Nov 2014 22:31:08 +0000 (23:31 +0100)]
keymap: Fix special keys on ThinkPad X60/X61 Tablet

KEY_DIRECTION is mapped to XF86RotateWindows, to rotate the display:

And F13 is mapped to XF86Tools, which is closest to the original toolbox

6 years agokeymap: Add support for IBM ThinkPad X41 Tablet
Bastien Nocera [Wed, 12 Nov 2014 22:30:46 +0000 (23:30 +0100)]
keymap: Add support for IBM ThinkPad X41 Tablet

Scancode taken from:

William Jon McCann provided the DMI match. IBM seems to have
swapped the version and model of the system:
        Manufacturer: IBM
        Product Name: 18666TU
        Version: ThinkPad X41 Tablet

6 years agoman: fix typo
Lennart Poettering [Wed, 12 Nov 2014 22:44:21 +0000 (23:44 +0100)]
man: fix typo

6 years agoUpdate TODO
Lennart Poettering [Wed, 12 Nov 2014 22:44:14 +0000 (23:44 +0100)]
Update TODO

6 years agoudev: use properly the systemd logging functions
Ronny Chevalier [Wed, 12 Nov 2014 20:42:38 +0000 (21:42 +0100)]
udev: use properly the systemd logging functions

6 years agoudev: use the systemd logging functions in udev tools
Kay Sievers [Wed, 12 Nov 2014 17:35:18 +0000 (18:35 +0100)]
udev: use the systemd logging functions in udev tools

6 years agosd-bus: pass attach flags to BUS_CREATOR_INFO
Daniel Mack [Tue, 11 Nov 2014 17:31:11 +0000 (18:31 +0100)]
sd-bus: pass attach flags to BUS_CREATOR_INFO

kdbus learned parsing the attach flags for the KDBUS_CMD_BUS_CREATOR_INFO
ioctl. Bits not set in this mask will not be exported. Set that field to

Signed-off-by: Daniel Mack <>
6 years agoupdate TODO
Lennart Poettering [Tue, 11 Nov 2014 17:12:48 +0000 (18:12 +0100)]
update TODO

6 years agosysuser: simplify access mode syncing by introducing helper function for it
Lennart Poettering [Tue, 11 Nov 2014 17:12:40 +0000 (18:12 +0100)]
sysuser: simplify access mode syncing by introducing helper function for it

6 years agobus-proxyd: explicitly address messages to unique and well-known name
Daniel Mack [Thu, 23 Oct 2014 11:06:38 +0000 (13:06 +0200)]
bus-proxyd: explicitly address messages to unique and well-known name

In order to check for matching policy entries at message transfers, we
have to consider the following:

* check the currently owned names of both the sending and the receiving
peer. If the sending peer is connected via kdbus, the currently owned
names are already attached to the message. If it was originated by the
connection we're proxying for, we store the owned names in our own strv
so we can check against them.

* Walk the list of names to check which name would allow the message to
pass, and explicitly use that name as destination of the message. If the
destination is on kdbus, store both the connection's unique name and the
chosen well-known-name in the message. That way, the kernel will make sure
the supplied name is owned by the supplied unique name, at the time of
sending, and return -EREMCHG otherwise.

* Make the policy checks optional by retrieving the bus owner creds, and
when the uid matches the current user's uid and is non-null, don't check
the bus policy.

6 years agobuild-sys: move libsystemd-capability into libsystemd-shared
Kay Sievers [Tue, 11 Nov 2014 15:13:59 +0000 (16:13 +0100)]
build-sys: move libsystemd-capability into libsystemd-shared

6 years agoRevert "bus-proxyd: make policy checks optional"
Michal Schmidt [Tue, 11 Nov 2014 14:36:00 +0000 (15:36 +0100)]
Revert "bus-proxyd: make policy checks optional"

This reverts commit 5bb24cccbce846c0d77e71b70a3be7f4b2ba6c0e.

It does not even compile (unbalanced {)

6 years agobus-proxyd: make policy checks optional
Daniel Mack [Thu, 23 Oct 2014 11:06:38 +0000 (13:06 +0200)]
bus-proxyd: make policy checks optional

Retrieve the bus owner creds, and when the uid matches the current user's
uid and is non-null, don't check the bus policy.

6 years agobus-proxyd: move name list iteration to policy users
Daniel Mack [Thu, 9 Oct 2014 11:26:53 +0000 (13:26 +0200)]
bus-proxyd: move name list iteration to policy users

We need to figure out which of the possible names satisfied the policy,
so we cannot do the iteration in check_policy_item() but have to leave it
to the users.

Test cases amended accordingly.

6 years agobus-proxyd: enforce policy for method calls
Daniel Mack [Wed, 24 Sep 2014 15:50:31 +0000 (17:50 +0200)]
bus-proxyd: enforce policy for method calls

6 years agobus-proxyd: enforce policy for name ownership
Daniel Mack [Wed, 24 Sep 2014 15:24:20 +0000 (17:24 +0200)]
bus-proxyd: enforce policy for name ownership

6 years agobus-proxyd: enforce policy for Hello messages
Daniel Mack [Wed, 24 Sep 2014 15:18:35 +0000 (17:18 +0200)]
bus-proxyd: enforce policy for Hello messages

6 years agobus-proxyd: keep track of names acquired by legacy client
Daniel Mack [Wed, 24 Sep 2014 15:10:31 +0000 (17:10 +0200)]
bus-proxyd: keep track of names acquired by legacy client

Store names successfully acquired by the legacy client into a hashmap.
We need to take these names into account when checking for send policies.

6 years agosd-bus: add sd_bus_message.verify_destination_id and .destination_ptr
Daniel Mack [Wed, 22 Oct 2014 12:41:53 +0000 (14:41 +0200)]
sd-bus: add sd_bus_message.verify_destination_id and .destination_ptr

kdbus learned to accept both a numerical destination ID as well as a
well-known-name. In that case, kdbus makes sure that the numerical ID is in
fact the owner of the provided name and fails otherwise.

This allows for race-free assertion of a bus name owner while sending a
message, which is a requirement for bus-proxyd.

Add two new fields to sd_bus_message, and set the numerical ID to
verify_destination_id if bus_message_setup_kmsg() is called for a
message with a well-known name.

Also, set the destination's name in the kdbus item to .destination_ptr
if it is non-NULL.

Normal users should not touch these fields, and they're not publicy

6 years agoupdate TODO
Lennart Poettering [Mon, 10 Nov 2014 22:45:31 +0000 (23:45 +0100)]
update TODO

6 years agostrv: rework strv_split_quoted() to use unquote_first_word()
Lennart Poettering [Mon, 10 Nov 2014 22:44:34 +0000 (23:44 +0100)]
strv: rework strv_split_quoted() to use unquote_first_word()

This should make the unquoting scheme a bit less naive.

6 years agobus: when dumping string property values escape the chars we use as end-of-line and...
Lennart Poettering [Mon, 10 Nov 2014 19:54:45 +0000 (20:54 +0100)]
bus: when dumping string property values escape the chars we use as end-of-line and end-of-item marks

6 years agoshared: explicitly ignore the return value of wait_for_terminate
Ronny Chevalier [Sun, 9 Nov 2014 14:51:04 +0000 (15:51 +0100)]
shared: explicitly ignore the return value of wait_for_terminate


6 years agoman: improve documentation for "indirect" unit file state a bit
Lennart Poettering [Mon, 10 Nov 2014 19:16:16 +0000 (20:16 +0100)]
man: improve documentation for "indirect" unit file state a bit

Also, correct mentions of "units" instead of "unit files" in the table,
and terminate all sentences with a full stop.

6 years agoshared/install: when unit contains only Also=, report 'indirect'
Jan Synacek [Fri, 7 Nov 2014 20:21:05 +0000 (21:21 +0100)]
shared/install: when unit contains only Also=, report 'indirect'

If a unit contains only Also=, with no Alias= or WantedBy=, it shouldn't
be reported as static. New 'indirect' status shall be introduced.

6 years agoupdate TODO
Lennart Poettering [Mon, 10 Nov 2014 18:25:16 +0000 (19:25 +0100)]
update TODO

6 years agobusctl: add "tree" command to explore object trees
Lennart Poettering [Mon, 10 Nov 2014 18:24:48 +0000 (19:24 +0100)]
busctl: add "tree" command to explore object trees

6 years agoinhibit: allow filtering --list by mode
Mantas Mikulėnas [Fri, 7 Nov 2014 14:45:53 +0000 (16:45 +0200)]
inhibit: allow filtering --list by mode

Usually there are a few delay inhibitors all the time (NetworkManager,
Telepathy, etc.), but I'm only interested in the block ones.

6 years agobuild-sys: do not use "label" functions in libsystemd-shared
Kay Sievers [Mon, 10 Nov 2014 17:59:03 +0000 (18:59 +0100)]
build-sys: do not use "label" functions in libsystemd-shared

6 years agobuild-sys: test-fdset - add libsystemd-internal
Kay Sievers [Mon, 10 Nov 2014 17:22:44 +0000 (18:22 +0100)]
build-sys: test-fdset - add libsystemd-internal

6 years agobuild-sys: add libcap to libsystemd-shared
Kay Sievers [Mon, 10 Nov 2014 16:32:29 +0000 (17:32 +0100)]
build-sys: add libcap to libsystemd-shared

6 years agoman: don't refer to undocumented option '--failed'
Michal Schmidt [Mon, 10 Nov 2014 13:54:57 +0000 (14:54 +0100)]
man: don't refer to undocumented option '--failed'

6 years agoman: don't document systemctl --failed
Lennart Poettering [Mon, 10 Nov 2014 13:44:35 +0000 (14:44 +0100)]
man: don't document systemctl --failed

This effectively reverts 599b6322f19ec619ddc294d0e7880b669040cf66, which
in turn partially reverted 4dc5b821ae737914499119e29811fc3346e3d97c.

The --failed switch is not documented on purpose, since it is redundant
due to --state=failed, which it predates. Due to that it's not
documented in --help either.

We generally try to avoid redundant interfaces, but if we need to keep
them for compatibility we do so, however remove them from documentation
to ensure they are not used in future.

The man page is now changed to include a comment about the fact that
--failed is not documented on purpose. Also, explicitly mention
--state=failed as example for --state.