chiark / gitweb /
6 years agoman: we don't have 'Wanted' dependency
Lukas Nykryn [Wed, 15 Oct 2014 07:28:31 +0000 (09:28 +0200)]
man: we don't have 'Wanted' dependency

6 years agobus-proxyd: add missing flag translation for RequestName
Lukasz Skalski [Tue, 14 Oct 2014 14:13:05 +0000 (16:13 +0200)]
bus-proxyd: add missing flag translation for RequestName

6 years agoshell-completion: propose templates for disable/[re]enable/[re]start
Zbigniew Jędrzejewski-Szmek [Wed, 15 Oct 2014 01:10:02 +0000 (21:10 -0400)]
shell-completion: propose templates for disable/[re]enable/[re]start

Templates can be [re]enabled, on their own if the have DefaultInstance set,
and with an instance suffix in all cases. Propose just the template name
ending in @, to underline the instance suffix may have to be appended.

Likewise for start/restart.

This means that sometimes superflous units that one will not really
want to operate on will be proposed, but this seems better than
proposing a very incomplete set of names.

6 years agoshell-completion: fix completion of inactive units
Zbigniew Jędrzejewski-Szmek [Wed, 15 Oct 2014 00:20:07 +0000 (20:20 -0400)]
shell-completion: fix completion of inactive units

Units which not loaded were not proposed properly. OTOH, we should
filter units from get-unit-files by their state if they are currently
loaded. Bring zsh completions in line with bash completion, the same
logic should be used in both implementations.

6 years agojournal-remote: fix mem leak on error
Zbigniew Jędrzejewski-Szmek [Mon, 13 Oct 2014 02:27:20 +0000 (22:27 -0400)]
journal-remote: fix mem leak on error

6 years agosd-bus: sync kdbus.h (ABI break)
Daniel Mack [Tue, 14 Oct 2014 18:03:06 +0000 (20:03 +0200)]
sd-bus: sync kdbus.h (ABI break)

kdbus learned KDBUS_HELLO_ACCEPT_MEMFD as new connection negotiation
flag. Set it by default in systemd for now.

6 years agobus-proxyd: improve compatibility with dbus-1
Lukasz Skalski [Mon, 13 Oct 2014 13:29:57 +0000 (15:29 +0200)]
bus-proxyd: improve compatibility with dbus-1

'GetConnectionUnixProcessID', 'GetConnectionUnixUser' and
'GetConnectionSELinuxSecurityContext' methods should return
'NameHasNoOwner' error (if chosen name is not available on bus)
with more detailed description - like dbus-1:

Could not get PID of name 'org.freedesktop.test': no such name.
Could not get UID of name 'org.freedesktop.test': no such name.
Could not get security context of name 'org.freedesktop.test': no such name.

Otherwise we have only laconic message without proper dbus error:

Error System.Error.ENXIO: No such device or address

6 years agopython-systemd: avoid hitting assert in __exit__
Dave Reisner [Tue, 14 Oct 2014 11:54:56 +0000 (07:54 -0400)]
python-systemd: avoid hitting assert in __exit__

Reader_close() asserts that 'args' is always NULL, but the __exit__
function forwards a non-NULL args.

6 years agoresolved: apply label to /run/systemd/resolve/resolv.conf
Zbigniew Jędrzejewski-Szmek [Tue, 14 Oct 2014 02:27:43 +0000 (22:27 -0400)]
resolved: apply label to /run/systemd/resolve/resolv.conf

Under an SELinux system, we want the file that is created to
have a proper context, different from the default for files in /run.
This is so that the policy can give access to almost everyone to
this file.

6 years agoresolved: split out writing of resolv.conf
Zbigniew Jędrzejewski-Szmek [Tue, 14 Oct 2014 01:28:32 +0000 (21:28 -0400)]
resolved: split out writing of resolv.conf

manager_write_resolv_conf() is quite long anyway.

6 years agobus: check allow-interactive-auhtorization flag when doing polkit
Lennart Poettering [Mon, 13 Oct 2014 15:17:48 +0000 (17:17 +0200)]
bus: check allow-interactive-auhtorization flag when doing polkit

6 years agosd-bus: add support for new allow-interactive-authorization message header flag
Lennart Poettering [Mon, 13 Oct 2014 15:16:56 +0000 (17:16 +0200)]
sd-bus: add support for new allow-interactive-authorization message header flag

6 years agopolkit: as we dropped support for the polkit bus transport, also drop its polkit...
Lennart Poettering [Mon, 13 Oct 2014 15:16:12 +0000 (17:16 +0200)]
polkit: as we dropped support for the polkit bus transport, also drop its polkit policy

6 years agoupdate TODO
Lennart Poettering [Mon, 13 Oct 2014 13:45:56 +0000 (15:45 +0200)]
update TODO

6 years agosystemctl: when mangle unit names for the "isolate", suffix with ".target" rather...
Lennart Poettering [Mon, 13 Oct 2014 13:43:09 +0000 (15:43 +0200)]
systemctl: when mangle unit names for the "isolate", suffix with ".target" rather than ".service" by default

After all, we set AllowIsolate exclusively for target units so far, and
this is more or less the only thing tht makes sense, hence also use
".target" as completion suffix by default.

6 years agosystemctl: move unit action table closer to the functions that use them
Lennart Poettering [Mon, 13 Oct 2014 13:41:42 +0000 (15:41 +0200)]
systemctl: move unit action table closer to the functions that use them

All other static tables we placed next to the functions that access
them, so let's do this for the unit action table too.

6 years agofi-latin1 console keymap is no more
Marko Myllynen [Mon, 13 Oct 2014 07:45:00 +0000 (10:45 +0300)]
fi-latin1 console keymap is no more;a=commitdiff;h=a88711232f3216debbb02d0171187442863ccedb

6 years agotest-dhcp-client: add more asserts
Tom Gundersen [Mon, 13 Oct 2014 08:07:05 +0000 (10:07 +0200)]
test-dhcp-client: add more asserts

6 years agotmpfiles: compare return against correct errno
Dave Reisner [Sun, 12 Oct 2014 00:35:06 +0000 (20:35 -0400)]
tmpfiles: compare return against correct errno

name_to_handle_at returns -EOPNOTSUPP, not -ENOTSUP.

6 years agoman: join tables in systemd-detect-virt(1)
Zbigniew Jędrzejewski-Szmek [Sun, 12 Oct 2014 22:27:53 +0000 (17:27 -0500)]
man: join tables in systemd-detect-virt(1)

I think it is more readable and nicer if everything is in
one table.

Also, describe what the return value, since it seems awkward to
describe the change in behaviour with --quiet before describing
what the default is.

6 years agotests: fix some tests to pass in koji
Zbigniew Jędrzejewski-Szmek [Sun, 12 Oct 2014 20:05:49 +0000 (16:05 -0400)]
tests: fix some tests to pass in koji

FAIL: test-engine
Cannot find cgroup mount point: No such file or directory
Assertion 'r >= 0' failed at ../src/test/test-engine.c:46, function main(). Aborting.

FAIL: test-sched-prio
Cannot find cgroup mount point: No such file or directory
Assertion 'r >= 0' failed at ../src/test/test-sched-prio.c:42, function main(). Aborting.

FAIL: test-bus-cleanup
Assertion 'sd_bus_open_system(&bus) >= 0' failed at ../src/libsystemd/sd-bus/test-bus-cleanup.c:40, function test_bus_open(). Aborting.
after new: refcount 1

6 years agoSet $NOTIFY_SOCKET for control procs if NotifyAccess=all
Brandon L Black [Sat, 11 Oct 2014 23:36:06 +0000 (23:36 +0000)]
Set $NOTIFY_SOCKET for control procs if NotifyAccess=all

6 years agoModernization
Zbigniew Jędrzejewski-Szmek [Sat, 11 Oct 2014 15:37:37 +0000 (11:37 -0400)]

6 years agoNEWS: don't mention noinst_* debug programs
David Herrmann [Sat, 11 Oct 2014 16:53:26 +0000 (18:53 +0200)]
NEWS: don't mention noinst_* debug programs

systemd-evcat and systemd-modeset are not installed systemd wide and
should really just be used by developers to test the libsystemd-terminal
features. No reason to mention it in NEWS.. despite the undulating

6 years agoterminal/grdrm: force deep modeset on enter
David Herrmann [Sat, 11 Oct 2014 16:49:20 +0000 (18:49 +0200)]
terminal/grdrm: force deep modeset on enter

Usually, when our session is activated (or re-configurated) we should be
able to try a page-flip to our buffer. The kernel driver should reject it
if it is incompatible. As it turns out, drivers don't do this. Therefore,
we now force a deep modeset if we're not sure what mode is set.

This has the side-effect that we might get glitches on session-switches
(depending on driver behavior). However, there's no way around this and it
is what everyone does so far. Most drivers still detect if we keep the
mode and so don't touch the clocks. Therefore, we just get a regular async

6 years agosd-dhcp-client: support non-Ethernet hardware addresses
Dan Williams [Wed, 8 Oct 2014 19:15:45 +0000 (14:15 -0500)]
sd-dhcp-client: support non-Ethernet hardware addresses

Like Infiniband.  See RFC 4390 section 2.1 for details on DHCP
and Infiniband; chaddr is zeroed, hlen is set to 0, and htype
is set to ARPHRD_INFINIBAND because IB hardware addresses
are 20 bytes in length.

6 years agoReport aa_change_onexec error code
Michael Scherer [Sat, 11 Oct 2014 08:13:43 +0000 (04:13 -0400)]
Report aa_change_onexec error code

Since aa_change_onexec return the error code in errno, and return
-1, the current code do not give any useful information when
something fail. This make apparmor easier to debug, as seen on

6 years agobus-proxyd: fix compatibility with old dbus-1
Lukasz Skalski [Fri, 10 Oct 2014 14:42:19 +0000 (16:42 +0200)]
bus-proxyd: fix compatibility with old dbus-1

'ListQueuedOwners' method should return 'NameHasNoOwner' error
if chosen name is not available on bus.

6 years agomount-setup: skip relabelling when SELinux and SMACK not supported
Emil Renner Berthing [Thu, 18 Sep 2014 13:24:55 +0000 (15:24 +0200)]
mount-setup: skip relabelling when SELinux and SMACK not supported

This is also the only place where FTW_ACTIONRETVAL is used, so
this makes systemd compile without SELinux or SMACK support
when the standard library doesn't support this extension.

6 years agofstab-generator: Honor mount.usr*= on kernel command line
Tobias Hunger [Thu, 9 Oct 2014 19:37:17 +0000 (21:37 +0200)]
fstab-generator: Honor mount.usr*= on kernel command line

This allows to configure boot loader entries for systems where the
root and usr filesystems are in different subvolumes (or even on
different drives).

6 years agokdbus: fix buffer overflow in bus_get_owner_kdbus() function
Lukasz Skalski [Fri, 10 Oct 2014 10:29:04 +0000 (12:29 +0200)]
kdbus: fix buffer overflow in bus_get_owner_kdbus() function

Commit 710fc9779b7c (kdbus repo) introduced attaching items[]
instead of name[] in kdbus_cmd_conn_info struct. Commit 581fe6c81
(systemd repo) caught up with this change, but item size was not
properly calculated.

6 years agoman: reference table in systemd-detect-virt(1) from ConditionVirtualization= document...
Lennart Poettering [Fri, 10 Oct 2014 10:37:21 +0000 (12:37 +0200)]
man: reference table in systemd-detect-virt(1) from ConditionVirtualization= documentation

6 years agoman: include zVM in systemd-detect-virt list
Lennart Poettering [Fri, 10 Oct 2014 10:36:57 +0000 (12:36 +0200)]
man: include zVM in systemd-detect-virt list

6 years agoman: rework VM/container identifier list into a table, and include descriptions for...
Lennart Poettering [Fri, 10 Oct 2014 10:29:08 +0000 (12:29 +0200)]
man: rework VM/container identifier list into a table, and include descriptions for all entries

(also remove chroot from the list, we don't detect that anymore)

6 years agonspawn: actually allow access to /dev/net/tun in the container
Lennart Poettering [Fri, 10 Oct 2014 09:11:25 +0000 (11:11 +0200)]
nspawn: actually allow access to /dev/net/tun in the container

It's not sufficient to just copy the device node over, we need to update
the policy for it too.

6 years agosystemd-hibernate-resume@.service: remove unnecessary ordering
Ivan Shapovalov [Fri, 10 Oct 2014 03:52:26 +0000 (23:52 -0400)]
systemd-hibernate-resume@.service: remove unnecessary ordering

They were left from an early review iteration, when hibernate-resume
functionality was intended to work also outside of initramfs.
Now this is not the case, and these dependencies became redundant
as systemd-fsck-root.service can never be part of initramfs, and
systemd-remount-fs.service makes little sense in it.

6 years agobuild-sys: use -Wno-gnu-variable-sized-type-not-at-end under clang
Zbigniew Jędrzejewski-Szmek [Fri, 10 Oct 2014 03:30:45 +0000 (22:30 -0500)]
build-sys: use -Wno-gnu-variable-sized-type-not-at-end under clang

Otherwise we get useless warnings about journal code.

6 years agobuild-sys: use -Wno-typedef-redefinition only for clang
Zbigniew Jędrzejewski-Szmek [Fri, 10 Oct 2014 03:25:01 +0000 (22:25 -0500)]
build-sys: use -Wno-typedef-redefinition only for clang

Our checks for -Wno-xxx switches do not work with gcc [1].


6 years agoUpdate TODO
Zbigniew Jędrzejewski-Szmek [Wed, 8 Oct 2014 00:01:02 +0000 (20:01 -0400)]
Update TODO

6 years agoman: clarify what "microsoft" and "oracle" stand for
Rahul Sundaram [Fri, 10 Oct 2014 02:14:36 +0000 (22:14 -0400)]
man: clarify what "microsoft" and "oracle" stand for

6 years agosystemctl: remove casts in formatting
Zbigniew Jędrzejewski-Szmek [Fri, 10 Oct 2014 02:57:56 +0000 (22:57 -0400)]
systemctl: remove casts in formatting

6 years agojournalctl: use pager for --list-boots
Zbigniew Jędrzejewski-Szmek [Thu, 9 Oct 2014 23:52:31 +0000 (19:52 -0400)]
journalctl: use pager for --list-boots

6 years agosd-journal: fix sd_journal_enumerate_unique skipping values
Jan Janssen [Sat, 6 Sep 2014 08:36:34 +0000 (10:36 +0200)]
sd-journal: fix sd_journal_enumerate_unique skipping values

sd_journal_enumerate_unique will lock its mmap window to prevent it
from being released by calling mmap_cache_get with keep_always=true.
This call may return windows that are wider, but compatible with the
parameters provided to it.

This can result in a mismatch where the window to be released cannot
properly be selected, because we have more than one window matching the
parameters of mmap_cache_release. Therefore, introduce a release_cookie
to be used when releasing the window.

6 years agosd-journal: change check to assert
Zbigniew Jędrzejewski-Szmek [Fri, 10 Oct 2014 02:51:35 +0000 (22:51 -0400)]
sd-journal: change check to assert

As of 0f99f74a14 'sd-journal: verify that object start with the field
name' this condition should never happen.

6 years agosd-journal: do not reset sd_j_enumerate_unique position on error
Zbigniew Jędrzejewski-Szmek [Fri, 10 Oct 2014 02:44:29 +0000 (22:44 -0400)]
sd-journal: do not reset sd_j_enumerate_unique position on error

systemctl would call sd_j_enumerate_unique() interleaved with
sd_j_next(). But the latter can remove a file if it detects an
error in it. In those circumstances sd_j_enumerate_unique would
restart with the first file in hashmap. With many corrupted files
sd_j_enumerate_unique might iterate over the list multiple times.

Avoid this by jumping to the next file in unique list if possible,
or setting a flag that tells sd_j_enumerate_unique that it is done

6 years agoman: document the new "rescue" kernel command line option
Lennart Poettering [Thu, 9 Oct 2014 16:26:47 +0000 (18:26 +0200)]
man: document the new "rescue" kernel command line option

6 years agoservice: enter SERVICE_STOP_SIGTERM state after getting "STOPPING=1"
Michal Schmidt [Thu, 9 Oct 2014 15:27:57 +0000 (17:27 +0200)]
service: enter SERVICE_STOP_SIGTERM state after getting "STOPPING=1"

SERVICE_STOP would mean we're running the ExecStop command. That's not
the case with "STOPPING=1".
Instead we should enter the same state as if we just told the service

This fixes a bug where voluntarily exiting services would hang around in
deactivating state until timeout.

6 years agoupdate TODO
Lennart Poettering [Thu, 9 Oct 2014 14:51:31 +0000 (16:51 +0200)]
update TODO

6 years agobus-proxy: allow getpeersec() to fail
Daniel Mack [Thu, 9 Oct 2014 13:40:17 +0000 (15:40 +0200)]
bus-proxy: allow getpeersec() to fail

getpeersec() will fail for non-SELinux enabled machines, so don't make that
a hard error.

6 years agosocket-proxyd: Unchecked return value from library
Susant Sahani [Thu, 9 Oct 2014 13:31:11 +0000 (19:01 +0530)]
socket-proxyd: Unchecked return value from library

CID 1237543 (#1 of 1): Unchecked return value from library

6 years agosd-dhcp6-lease: Name the structure containing IAADDR data
Patrik Flykt [Wed, 8 Oct 2014 08:00:07 +0000 (11:00 +0300)]
sd-dhcp6-lease: Name the structure containing IAADDR data

With this change the DHCP6_OPTION_IAADDR_LEN define can be removed in
favor of using sizeof(). Using the name of the struct and sizeof()
makes it clearer how much and what data is being copied from the
DHCPv6 message.

6 years agobus-policy: move name list iteration to policy users
Daniel Mack [Thu, 9 Oct 2014 11:26:53 +0000 (13:26 +0200)]
bus-policy: move name list iteration to policy users

We need to figure out which of the possible names satisfied the policy,
so we cannot do the iteration in check_policy_item() but have to leave it
to the users.

Test cases amended accordingly.

6 years agologind: mount per-user tmpfs with 'smackfsroot=*' for smack enabled systems
Lukasz Skalski [Thu, 9 Oct 2014 09:02:47 +0000 (11:02 +0200)]
logind: mount per-user tmpfs with 'smackfsroot=*' for smack enabled systems

6 years agoman: SyslogIdentifier= has an effect on journal logging too
Lennart Poettering [Thu, 9 Oct 2014 09:36:34 +0000 (11:36 +0200)]
man: SyslogIdentifier= has an effect on journal logging too

6 years agosd-bus: check return value of asprintf()
Daniel Mack [Thu, 9 Oct 2014 09:26:09 +0000 (11:26 +0200)]
sd-bus: check return value of asprintf()

Check for OOM conditions of asprintf() in bus_set_address_user().

6 years agosystemctl: suggest -xe not -xn
Zbigniew Jędrzejewski-Szmek [Thu, 9 Oct 2014 00:22:51 +0000 (20:22 -0400)]
systemctl: suggest -xe not -xn

6 years agoupdate TODO
Lennart Poettering [Wed, 8 Oct 2014 23:46:31 +0000 (01:46 +0200)]
update TODO

6 years agosd-event: also update signal mask when disconnecting sources
Zbigniew Jędrzejewski-Szmek [Sun, 5 Oct 2014 03:17:45 +0000 (23:17 -0400)]
sd-event: also update signal mask when disconnecting sources

6 years agosd-event: be more careful when enabling/disabling signals
Zbigniew Jędrzejewski-Szmek [Sun, 5 Oct 2014 02:57:43 +0000 (22:57 -0400)]
sd-event: be more careful when enabling/disabling signals

When a child event is disabled (in order to be freed) and there is no
SIGCHLD signal event, sd_event_source_set_enabled will disable SIGCHLD
even if there are other child events.

Also remove some unneeded signalfd updates.

Based-on-a-patch-by: Hristo Venev <>
6 years agoman/systemctl: document enable on masked units
Jan Synacek [Wed, 8 Oct 2014 06:04:52 +0000 (08:04 +0200)]
man/systemctl: document enable on masked units

6 years agoutil: avoid double close of fd
Thomas Hindoe Paaboel Andersen [Wed, 8 Oct 2014 21:57:32 +0000 (23:57 +0200)]
util: avoid double close of fd

We could end with a double close if we close the fd loop and flush_fd
fails. That would make us goto fail and there we close the fd once
again. This patch sets the fd to the return value for safe_close: -1
A fd with negative value will be ignored by the next call to


6 years agotime: functions named "internal" really shouldn't be exported
Lennart Poettering [Wed, 8 Oct 2014 20:37:45 +0000 (22:37 +0200)]
time: functions named "internal" really shouldn't be exported

Also, let's try to make function names descriptive, instead of using
bools for flags.

6 years agocore: map the 'rescue' argument to
Mantas Mikulėnas [Tue, 7 Oct 2014 11:55:21 +0000 (14:55 +0300)]
core: map the 'rescue' argument to

Even though the 'emergency' and 'single' aliases come from sysvinit, the
lack of 'rescue' is still quite confusing (caught me by surprise for the
9th time yet) and inconsistent with `systemctl rescue` as well.

6 years agoUpdate TODO
Lennart Poettering [Wed, 8 Oct 2014 19:32:30 +0000 (21:32 +0200)]
Update TODO

6 years agosd-bus: sync kdbus.h (ABI break)
Daniel Mack [Wed, 8 Oct 2014 13:32:41 +0000 (15:32 +0200)]
sd-bus: sync kdbus.h (ABI break)

Sync kdbus.h once again. Two thing have changed:

 a) KDBUS_CMD_EP_* was renamed to KDBUS_CMD_ENDPOINT_*
 b) struct kdbus_cmd_hello and struct kdbus_cmd_make gained a
    'features' bitfield (which is currently unused)

6 years agonspawn: copy /dev/net/tun from host
Tom Gundersen [Wed, 8 Oct 2014 13:01:07 +0000 (15:01 +0200)]
nspawn: copy /dev/net/tun from host

This enables tuntap support in the container (assumning the necessary capabilities are in place).

6 years agonote on relative symlink in os-release
Rahul Sundaram [Wed, 8 Oct 2014 05:42:59 +0000 (01:42 -0400)]
note on relative symlink in os-release

6 years agosystemctl: add add-wants and add-requires verbs
Lukas Nykryn [Wed, 8 Oct 2014 09:59:46 +0000 (11:59 +0200)]
systemctl: add add-wants and add-requires verbs

6 years agounit: move UnitDependency to unit-name
Lukas Nykryn [Wed, 8 Oct 2014 09:58:57 +0000 (11:58 +0200)]
unit: move UnitDependency to unit-name

6 years agoNEWS: update for 217
Zbigniew Jędrzejewski-Szmek [Wed, 8 Oct 2014 02:01:37 +0000 (22:01 -0400)]
NEWS: update for 217

6 years agoman: mention docker as type of virtualization
Zbigniew Jędrzejewski-Szmek [Wed, 8 Oct 2014 01:41:14 +0000 (21:41 -0400)]
man: mention docker as type of virtualization

6 years agocore: don't allow enabling if unit is masked
Jan Synacek [Tue, 7 Oct 2014 11:35:41 +0000 (13:35 +0200)]
core: don't allow enabling if unit is masked

6 years agobus-proxyd: assorted cleanups and fixes
Daniel Mack [Tue, 7 Oct 2014 15:58:29 +0000 (17:58 +0200)]
bus-proxyd: assorted cleanups and fixes

Just some cleanups around policy checks that came up during review.
The code is still not productive.

6 years ago/proc/sys prefixes are not necessary for sysctl anymore
Zbigniew Jędrzejewski-Szmek [Tue, 7 Oct 2014 06:02:59 +0000 (02:02 -0400)]
/proc/sys prefixes are not necessary for sysctl anymore

6 years agoUpdate TODO
Zbigniew Jędrzejewski-Szmek [Tue, 7 Oct 2014 13:11:03 +0000 (09:11 -0400)]
Update TODO

6 years agoman: document stripping of quotes
Zbigniew Jędrzejewski-Szmek [Tue, 7 Oct 2014 13:19:41 +0000 (09:19 -0400)]
man: document stripping of quotes

6 years agoman: move commandline parsing to a separate section
Zbigniew Jędrzejewski-Szmek [Tue, 7 Oct 2014 13:19:24 +0000 (09:19 -0400)]
man: move commandline parsing to a separate section

It is very long already, and obscures the description of
ExecStart, and it is about to get longer.

6 years agobus-proxyd: check return values of getpeercred() and getpeersec()
Daniel Mack [Tue, 7 Oct 2014 10:36:09 +0000 (12:36 +0200)]
bus-proxyd: check return values of getpeercred() and getpeersec()

If we can't get the remote peer or security creds, bail out.

Spotted by coverity.

6 years agosd-bus: check return value of vasprintf
Daniel Mack [Tue, 7 Oct 2014 10:10:06 +0000 (12:10 +0200)]
sd-bus: check return value of vasprintf

Check for OOM situations when vasprintf() returns < 0 in bus_error_setfv().

Spotted by coverity.

6 years agosd-bus: fix KDBUS_CMD_FREE user
Daniel Mack [Tue, 7 Oct 2014 10:02:04 +0000 (12:02 +0200)]
sd-bus: fix KDBUS_CMD_FREE user

Fix a user of the KDBUS_CMD_FREE ioctl that was missed in the transition.

6 years agosd-bus: fix use-after-free in close_kdbus_msg()
Daniel Mack [Tue, 7 Oct 2014 09:32:07 +0000 (11:32 +0200)]
sd-bus: fix use-after-free in close_kdbus_msg()

Walk the items first, then free the memory of the message.

Also, while at it, make coverity happy with an explicit (void) prefix.
We intentionally ignore the return value here.

6 years agokeymap: Fix touchpad toggle key on Asus laptops
Martin Pitt [Tue, 7 Oct 2014 09:22:31 +0000 (11:22 +0200)]
keymap: Fix touchpad toggle key on Asus laptops

6 years agokeymap: Fix touchpad toggle on Toshiba Satellite P75-A7200
Martin Pitt [Tue, 7 Oct 2014 09:20:04 +0000 (11:20 +0200)]
keymap: Fix touchpad toggle on Toshiba Satellite P75-A7200

Just like everywhere else we use KEY_F21 instead of KEY_TOUCHPAD_TOGGLE for X

6 years agosd-bus: remove unused variable
Thomas Hindoe Paaboel Andersen [Mon, 6 Oct 2014 21:58:46 +0000 (23:58 +0200)]
sd-bus: remove unused variable

It is no longer used after d663f1b1a92a778bcdc68f29b8c08cb49431b4f7

6 years agosd-bus: sync kdbus.h (ABI break)
Daniel Mack [Mon, 6 Oct 2014 16:36:16 +0000 (18:36 +0200)]
sd-bus: sync kdbus.h (ABI break)

The KDBUS_CMD_FREE ioctl now uses a struct rather than a direct pointer
to the offset to free.

The KDBUS_CMD_MSG_CANCEL ioctl has also changes, but there's no user of
it yet in systemd.

6 years agobuild-sys: use linux/memfd.h if available
Zbigniew Jędrzejewski-Szmek [Sun, 5 Oct 2014 22:41:31 +0000 (18:41 -0400)]
build-sys: use linux/memfd.h if available

linux/memfd.h was added linux 3.17, so it might not be widely
available for a while.

Also, check if memfd_create is defined, for the HAVE_LINUX_MEMFD_H
check to have a chance of succeeding.

Also, collapse all ifdefs for memfd-related stuff, because they
were all added together so there's no need to check separately.

6 years agoterminal: remove an unused initialization
Thomas Hindoe Paaboel Andersen [Sun, 5 Oct 2014 20:33:20 +0000 (22:33 +0200)]
terminal: remove an unused initialization

6 years agoUpdate TODO
Zbigniew Jędrzejewski-Szmek [Sun, 5 Oct 2014 19:29:20 +0000 (15:29 -0400)]
Update TODO

6 years agoask-password: Add --echo to enable echoing the user input
David Sommerseth [Fri, 3 Oct 2014 13:53:45 +0000 (15:53 +0200)]
ask-password: Add --echo to enable echoing the user input

Programs such as OpenVPN may use ask-password for not only retrieving
passwords, but also usernames.  Masking usernames with * seems just silly.

 v2 - Don't mess with termios flags, instead print the input
      instead of an asterix.  Resolves issues with backspace
      and TAB input.

 v3 - Renamed 'do_echo' variables and argument to 'echo'.  Also
      modified the ask_password_{tty,agent,auto} API instead of
      additional wrapper functions.

[zj: undo changes to ask_password_auto, since no callers were using
     the new argument.]

6 years agobus: add assert to check that we're not freeing a static structure
Zbigniew Jędrzejewski-Szmek [Sun, 5 Oct 2014 18:04:02 +0000 (14:04 -0400)]
bus: add assert to check that we're not freeing a static structure

CID #996315.

6 years agoterminal/idev: don't remove consumed-mods from kbd-matches
David Herrmann [Sun, 5 Oct 2014 15:44:09 +0000 (17:44 +0200)]
terminal/idev: don't remove consumed-mods from kbd-matches

XKB consumed mods include modifiers that *didn't* affect the translation,
but might affect it if used. This is very misleading, given that we are
usually not interested in that information. Therefore, keep them in real
mods to behave like X11 does. Maybe at some point, XKB introduces proper
shortcut matching...

Also make evcat display consumed modifiers so we can better debug those

6 years agoterminal/screen: perform bold->light conversion only on foreground
David Herrmann [Sun, 5 Oct 2014 13:49:26 +0000 (15:49 +0200)]
terminal/screen: perform bold->light conversion only on foreground

Bold glyphs always use light colors. However, this color conversion is
limited to the foreground color, so skip it for backgrounds.

6 years agoterminal/subterm: leave bold-light conversion to parent
David Herrmann [Sun, 5 Oct 2014 13:48:32 +0000 (15:48 +0200)]
terminal/subterm: leave bold-light conversion to parent

We rely on the parent terminal to do color conversion, so also leave
bold->light conversion to the parent. Otherwise, it will be performed
twice and we might apply it on the wrong color.

6 years agoterminal/screen: add support for alternate screen buffers
Tom Gundersen [Sun, 5 Oct 2014 13:26:54 +0000 (15:26 +0200)]
terminal/screen: add support for alternate screen buffers

Hook up SM/RM 47/1047-1049 and enable alternate screen buffers for term

(David: rebased on top of -git, renamed helpers and added docs)

6 years agoterminal/screen: save state in separate object
David Herrmann [Sun, 5 Oct 2014 12:53:18 +0000 (14:53 +0200)]
terminal/screen: save state in separate object

Terminal state can be saved/restored by applications. To simplify our
internal handling, put all affected state into a separate object.
Especially with alternate screen buffers, this will simplify our code

6 years agoterminal/subterm: skip setting parent's cursor
David Herrmann [Sun, 5 Oct 2014 12:47:57 +0000 (14:47 +0200)]
terminal/subterm: skip setting parent's cursor

We draw our own cursor in subterm now, so there's no reason to update the
cursor-position of the parent terminal on each frame. The parent's cursor
is hidden, anyway.

6 years agoterminal: fix TERM_FLAG_* comment
David Herrmann [Sun, 5 Oct 2014 12:45:33 +0000 (14:45 +0200)]
terminal: fix TERM_FLAG_* comment

7BIT mode is enabled by default. Fix the comment to state this correctly.

6 years agoterminal: fix restoring of screen flags
Tom Gundersen [Sat, 4 Oct 2014 21:03:15 +0000 (23:03 +0200)]
terminal: fix restoring of screen flags

6 years agotest: only use assert_se
Thomas Hindoe Paaboel Andersen [Sat, 4 Oct 2014 21:51:45 +0000 (23:51 +0200)]
test: only use assert_se

The asserts used in the tests should never be allowed to be
optimized away

6 years agoconsoled: add a unit file
Tom Gundersen [Sat, 4 Oct 2014 11:10:41 +0000 (13:10 +0200)]
consoled: add a unit file

The unit file is statically enabled, but still requires --enable-terminal
to actually get installed.