shared/mkdir: do not set errno in addition to return value

All callers look at the return value anyway.

diff --git a/src/shared/mkdir.c b/src/shared/mkdir.c
index b280618a977bbdbab9551459b9ff8c2e370382b7..7ee4546988b353aef2f1fb4f95dcda635e49bdf1 100644 (file)
--- a/src/shared/mkdir.c
+++ b/src/shared/mkdir.c
@@ -41,10 +41,8 @@ int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t gid, mkd
             (st.st_mode & 0700) > (mode & 0700) ||
             (uid != UID_INVALID && st.st_uid != uid) ||
             (gid != GID_INVALID && st.st_gid != gid) ||
-            !S_ISDIR(st.st_mode)) {
-                errno = EEXIST;
-                return -errno;
-        }
+            !S_ISDIR(st.st_mode))
+                return -EEXIST;
 
         return 0;
 }