From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Mon, 16 Mar 2015 15:34:39 +0000 (-0400)
Subject: shared/mkdir: do not set errno in addition to return value
X-Git-Tag: v219.0~257
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=2e6534a9a5ad5f02a37e7dca878c521f38df8456;ds=inline

shared/mkdir: do not set errno in addition to return value

All callers look at the return value anyway.
---

diff --git a/src/shared/mkdir.c b/src/shared/mkdir.c
index b280618a9..7ee454698 100644
--- a/src/shared/mkdir.c
+++ b/src/shared/mkdir.c
@@ -41,10 +41,8 @@ int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t gid, mkd
             (st.st_mode & 0700) > (mode & 0700) ||
             (uid != UID_INVALID && st.st_uid != uid) ||
             (gid != GID_INVALID && st.st_gid != gid) ||
-            !S_ISDIR(st.st_mode)) {
-                errno = EEXIST;
-                return -errno;
-        }
+            !S_ISDIR(st.st_mode))
+                return -EEXIST;
 
         return 0;
 }