chiark / gitweb /
Kay Sievers [Wed, 26 Nov 2008 03:36:25 +0000 (04:36 +0100)]
release 134
Kay Sievers [Tue, 25 Nov 2008 16:25:14 +0000 (17:25 +0100)]
rules: exclude "btibm" devices from vol_id calls
Matthias Schwarzott [Tue, 25 Nov 2008 16:13:07 +0000 (17:13 +0100)]
rules: Gentoo update
Kay Sievers [Mon, 24 Nov 2008 20:24:04 +0000 (21:24 +0100)]
silence PHYSDEV* warning for WAIT_FOR* rules
Kay Sievers [Mon, 24 Nov 2008 01:21:12 +0000 (02:21 +0100)]
fix handling of swapping node name with symlink name
Kay Sievers [Sun, 23 Nov 2008 16:29:37 +0000 (17:29 +0100)]
floppy: use ARRAY_SIZE()
Peter Breitenlohner [Sun, 23 Nov 2008 16:22:32 +0000 (17:22 +0100)]
floppy: fix array bounds check and minor calculation
Fix off-by-4 bug in floppy minors for fd[4-7].
Avoid segmentation fault for bad CMOS type.
Print mode in human readable, i.e., octal form.
Kay Sievers [Fri, 21 Nov 2008 23:34:42 +0000 (00:34 +0100)]
update NEWS TODO
Kay Sievers [Fri, 21 Nov 2008 19:48:24 +0000 (20:48 +0100)]
path_id: fix fibre channel handling
Peter Breitenlohner [Fri, 21 Nov 2008 09:50:12 +0000 (10:50 +0100)]
man: fix typos
Kay Sievers [Fri, 21 Nov 2008 06:26:44 +0000 (07:26 +0100)]
volume_id: clear probing result before probing and do not probe a second time, if not needed
On Thu, Nov 20, 2008 at 14:17, Karel Zak <kzak@redhat.com> wrote:
> I see the patch (volume_id_probe_filesystem()) and a few things come
> to mind:
>
> - shouldn't be the relevant parts (label, uuid, version, ...) of
> the "struct volume_id" zeroized when you found a signature and
> before you call the next probing function?
>
> - it seems as overkill to use two for()s and probe two times for all
> filesystems. What about to store the first result and re-use it?
>
> - .. or at least never use the second for() when the fist for() found
> nothing ;-)
Kay Sievers [Fri, 21 Nov 2008 06:26:09 +0000 (07:26 +0100)]
volume_id: update btrfs
Kay Sievers [Fri, 21 Nov 2008 04:02:02 +0000 (05:02 +0100)]
vol_id: if regular files are probed, use stat() for the size value
Kay Sievers [Fri, 21 Nov 2008 03:22:04 +0000 (04:22 +0100)]
volume_id: remove unused usage types
Gabor Z. Papp [Fri, 21 Nov 2008 03:19:11 +0000 (04:19 +0100)]
include errno.h in sysdeps.h
Kay Sievers [Thu, 20 Nov 2008 06:57:17 +0000 (07:57 +0100)]
scsi_id: make sure, we do not have slashes in values
Kay Sievers [Thu, 20 Nov 2008 06:52:33 +0000 (07:52 +0100)]
ata_id: make sure, we do not have slashes in values
Kay Sievers [Thu, 20 Nov 2008 01:44:08 +0000 (02:44 +0100)]
usb_id: replace chars in returned strings
Slashes are not funny in device names:
|-- input
| |-- by-id
| | `-- usb-Logitech_USB-PS
| | |-- 2_Optical_Mouse-event-mouse -> ../../event2
| | `-- 2_Optical_Mouse-mouse -> ../../mouse1
Kay Sievers [Thu, 20 Nov 2008 01:43:34 +0000 (02:43 +0100)]
libudev: accept NULL whitelist in util_replace_chars()
Kay Sievers [Thu, 20 Nov 2008 01:26:13 +0000 (02:26 +0100)]
rules: v4l - add by-id/ links for USB devices
/dev/v4l
|-- by-id
| |-- usb-046d_09a4_C4B15020-video-index0 -> ../../video0
| `-- usb-05a9_a511-video-index0 -> ../../video1
`-- by-path
|-- pci-0000:00:1d.0-usb-0:1:1.0-video-index0 -> ../../video1
`-- pci-0000:00:1d.7-usb-0:2:1.0-video-index0 -> ../../video0
Kay Sievers [Wed, 19 Nov 2008 20:47:07 +0000 (21:47 +0100)]
rules: merge group "video" into default rules
Harald Hoyer [Wed, 19 Nov 2008 10:24:03 +0000 (11:24 +0100)]
rules: add persistent rules for memory stick block devices
commit
5a9aed145ac0ffb3e29b1c8e0f19b34e277f9117
Author: Harald Hoyer <harald@redhat.com>
Date: Wed Nov 19 11:22:30 2008 +0100
added persistent rules for memory stick block devices
Kay Sievers [Tue, 18 Nov 2008 18:16:42 +0000 (19:16 +0100)]
bump version
Kay Sievers [Tue, 18 Nov 2008 18:14:37 +0000 (19:14 +0100)]
volume_id: update btrfs magic
Kay Sievers [Tue, 18 Nov 2008 02:52:05 +0000 (03:52 +0100)]
autogen.sh: fix -print-multi-os-directory usage
Kay Sievers [Tue, 18 Nov 2008 01:50:58 +0000 (02:50 +0100)]
release 133
Kay Sievers [Tue, 18 Nov 2008 01:49:08 +0000 (02:49 +0100)]
update NEWS
Kay Sievers [Mon, 17 Nov 2008 14:24:47 +0000 (15:24 +0100)]
fix $links substitution for devices without any link
Reported-by: Michel Hermier <michel.hermier@gmail.com>
Kay Sievers [Mon, 17 Nov 2008 13:43:58 +0000 (14:43 +0100)]
udevd: fix cleanup of /dev/.udev/uevent_seqnum
Kay Sievers [Mon, 17 Nov 2008 01:01:37 +0000 (02:01 +0100)]
limit $attr(<symlink>) magic to well-known links only
Sergey Vlasov [Fri, 14 Nov 2008 21:34:43 +0000 (00:34 +0300)]
udevadm: fix option parsing breakage with klibc
The klibc implementation of getopt_long() behaves slightly different
from the glibc one - in particular, it treats the change of the option
string argument between invocations as start of parsing a different
command line, and resets its state. However, the udevadm code
expected getopt_long() invocations in subcommands to continue parsing
the rest of command line after initial options has been parsed at the
top level; with klibc this broke, causing all udevadm subcommands to
stop recognizing their options.
Instead of relying on the glibc behavior, reset the getopt_long()
state properly before invoking the subcommand handler: move argv to
point to the subcommand name, decrease argc appropriately, and set
optind = 0. This also fixes a minor bug visible with glibc - without
setting optind = 0 all getopt_long() calls in subcommand handlers were
behaving as if "+" was specified as the first character of the option
string (which disables option reordering), because that state was set
by the first getopt_long() call at the top level, and was not reset
when parsing subcommand options.
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Kay Sievers [Fri, 14 Nov 2008 17:26:49 +0000 (18:26 +0100)]
libudev: device - handle disk "device" link for partitions in deprecated sysfs layout
Thanks to Mikhail Kolesnik <mike@openbunker.org> for finding this.
Kay Sievers [Thu, 13 Nov 2008 23:57:34 +0000 (00:57 +0100)]
vol_id: clarify error message
Kay Sievers [Thu, 13 Nov 2008 20:44:28 +0000 (21:44 +0100)]
volume_id: ntfs - mark as no other fs must match
Kay Sievers [Thu, 13 Nov 2008 19:46:25 +0000 (20:46 +0100)]
fix spelling in comment
Kay Sievers [Thu, 13 Nov 2008 18:40:24 +0000 (19:40 +0100)]
volume_id: fat - accept empty FAT32 fsinfo signature
Kay Sievers [Thu, 13 Nov 2008 18:34:41 +0000 (19:34 +0100)]
volume_id: always check for all filesystem types and skip conflicting results
We probe for all known filesystems to find conflicting signatures. If
we find multiple matching signatures and one of the detected filesystem
types claims that it can not co-exist with any other filesystem type,
we do not return a probing result.
We can not afford to mount a volume with the wrong filesystem code and
possibly corrupt it. Linux ssytems have the problem of dozens of possible
filesystem types, and volumes with left-over signatures from former
filesystem types. Invalid signature need to be removed from the volume
to make the filesystem detection successful.
We do not want to read that many bytes from probed floppies, skip volumes
smaller than a usual floppy disk.
Kay Sievers [Thu, 13 Nov 2008 17:22:39 +0000 (18:22 +0100)]
volume_id: bump revision
Kay Sievers [Thu, 13 Nov 2008 17:21:28 +0000 (18:21 +0100)]
remove len == 0 check, the index root is always '\0'
Karel Zak [Thu, 13 Nov 2008 16:32:14 +0000 (17:32 +0100)]
volume_id: fat - move check for msdos signature (0x55 0xaa)
Make the msdos signature (0x55 0xaa) at 510 and 511 optional when
the standard FAT magic string is present.
Kay Sievers [Thu, 13 Nov 2008 07:16:55 +0000 (08:16 +0100)]
configure: add linux-hotplug mail address
Kay Sievers [Thu, 13 Nov 2008 07:03:49 +0000 (08:03 +0100)]
update NEWS
Kay Sievers [Thu, 13 Nov 2008 06:47:16 +0000 (07:47 +0100)]
rules: remove pnp shell script, acpi loads these modules properly
Kay Sievers [Thu, 13 Nov 2008 06:45:58 +0000 (07:45 +0100)]
rules: remove DEVTYPE disk/partition
Kay Sievers [Thu, 13 Nov 2008 06:31:04 +0000 (07:31 +0100)]
udevadm: info - unify -V and --version
Kay Sievers [Thu, 13 Nov 2008 00:52:33 +0000 (01:52 +0100)]
set errno = ENOSYS in inotify stub
Alan Jenkins [Wed, 12 Nov 2008 16:23:17 +0000 (16:23 +0000)]
scsi_id: we don't use DEVPATH env var anymore, update man page
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Kay Sievers [Wed, 12 Nov 2008 23:52:12 +0000 (00:52 +0100)]
merge trie nodes, childs and root into a single array
Kay Sievers [Wed, 12 Nov 2008 14:01:20 +0000 (15:01 +0100)]
reserve child slot 0
Kay Sievers [Wed, 12 Nov 2008 04:50:05 +0000 (05:50 +0100)]
string index - split nodes and childs to allow and unlimited number of childs
Kay Sievers [Tue, 11 Nov 2008 22:47:01 +0000 (23:47 +0100)]
silence "comparison between signed and unsigned"
Alan Jenkins [Tue, 11 Nov 2008 20:20:11 +0000 (20:20 +0000)]
udevd: de-duplicate strings in rules
On my Ubuntu installation this removes 15k of duplicate strings,
using a temporary index of about 25k.
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Kay Sievers [Fri, 7 Nov 2008 15:08:58 +0000 (16:08 +0100)]
release 132
Kay Sievers [Fri, 7 Nov 2008 14:59:58 +0000 (15:59 +0100)]
convert debug string arrays to functions
On Fri, Nov 7, 2008 at 13:07, Matthias Schwarzott <zzam@gentoo.org> wrote:
> I managed to let udev-131 segfault at startup.
>
> I configured it like this:
> CFLAGS="-Wall -ggdb" ./configure --prefix=/usr --sysconfdir=/etc --exec-prefix=
>
> Running it in gdb shows it segfaults at udev-rules.c:831
>
> (gdb) run
> Starting program: /tmp/udev-131/udev/udevd
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x0804ea06 in get_key (udev=0x9175008, line=0xafcdc8f0, key=0xafcdc5d8,
> op=0xafcdc5d0, value=0xafcdc5d4)
> at udev-rules.c:831
> 831 dbg(udev, "%s '%s'-'%s'\n", operation_str[*op], *key, *value);
If compiled without optimization, the dbg() macro dereferences variables
which are not available. Convert the string array to a function, which just
returns NULL if compiled without DEBUG.
Kay Sievers [Fri, 7 Nov 2008 01:58:54 +0000 (02:58 +0100)]
fix size_t compiler warning on 32 bit platforms
Kay Sievers [Fri, 7 Nov 2008 01:36:20 +0000 (02:36 +0100)]
release 131
Kay Sievers [Thu, 6 Nov 2008 18:41:58 +0000 (19:41 +0100)]
udevadm: settle - exit if udevd exits
Kay Sievers [Thu, 6 Nov 2008 16:43:12 +0000 (17:43 +0100)]
cleanup /dev/.udev/queue on startup and exit
Kay Sievers [Thu, 6 Nov 2008 07:17:33 +0000 (08:17 +0100)]
rules: md - add mdadm 3 device naming
Kay Sievers [Thu, 6 Nov 2008 01:56:45 +0000 (02:56 +0100)]
fix indentation
Alan Jenkins [Wed, 5 Nov 2008 21:28:52 +0000 (22:28 +0100)]
udevd: shrink struct token to 12 bytes
Kay Sievers [Wed, 5 Nov 2008 21:13:49 +0000 (22:13 +0100)]
$links should be relative
Kay Sievers [Wed, 5 Nov 2008 20:49:52 +0000 (21:49 +0100)]
unify string replacement
Kay Sievers [Wed, 5 Nov 2008 18:02:56 +0000 (19:02 +0100)]
usb_id: MassStorage SubClass 6 is "scsi" not "disk"
Kay Sievers [Wed, 5 Nov 2008 11:23:06 +0000 (12:23 +0100)]
do not import the "uevent" file when we only read the db to get old symlinks
Kay Sievers [Wed, 5 Nov 2008 03:45:23 +0000 (04:45 +0100)]
fix cleanup of possible left-over symlinks
Kay Sievers [Wed, 5 Nov 2008 03:08:44 +0000 (04:08 +0100)]
fix $links substitution
Kay Sievers [Wed, 5 Nov 2008 03:05:17 +0000 (04:05 +0100)]
info() PROGRAM and IMPORT execution
Kay Sievers [Wed, 5 Nov 2008 01:22:07 +0000 (02:22 +0100)]
volume_id: btrfs update
Kay Sievers [Tue, 4 Nov 2008 19:19:01 +0000 (20:19 +0100)]
fix list handling in enumerate and rules file sorting
Kay Sievers [Tue, 4 Nov 2008 17:38:06 +0000 (18:38 +0100)]
firmware.sh: record missing files in /dev/.udev/firmware-missing/
Kay Sievers [Sat, 1 Nov 2008 20:05:25 +0000 (21:05 +0100)]
move debugging strings inside #ifdef DEBUG
Kay Sievers [Sat, 1 Nov 2008 19:57:22 +0000 (20:57 +0100)]
add "devel" and "install" switches to autogen.sh
Kay Sievers [Sat, 1 Nov 2008 19:16:24 +0000 (20:16 +0100)]
move some info() to dbg()
Kay Sievers [Sat, 1 Nov 2008 19:05:41 +0000 (20:05 +0100)]
fix udev_node_update_old_links() logic
No need to check if links that still belong to us, need to be updated.
Kay Sievers [Sat, 1 Nov 2008 18:12:20 +0000 (19:12 +0100)]
skip entire rule containing device naming keys, if no device can be named
If rules set NAME, SYMLINK, OWNER, GROUP, MODE, events without a device node
and remove events will skip the entire rule. The old parser did the same.
Kay Sievers [Sat, 1 Nov 2008 17:34:54 +0000 (18:34 +0100)]
log rules file and line number when NAME, SYMLINK, OWNER, GROUP, MODE, RUN is applied
Alan Jenkins [Sat, 1 Nov 2008 16:32:16 +0000 (17:32 +0100)]
udevd: be more careful when matching against parents
I'm worried about what will happen with things like
KERNELS=="*" # pointless rule
KERNELS=="doesnt-match" # another pointless rule
Since TK_RULE < TK_M_PARENTS_MAX, we will try to match all three tokens
against parents of the current device. I can't think of a bad case,
but it's not exactly good either.
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Alan Jenkins [Sat, 1 Nov 2008 16:09:16 +0000 (16:09 +0000)]
udevd: fix termination of rule execution
LAST_RULE was broken, and I broke TK_END by making it do the same.
It used a "break" which exited the switch statement, but not the loop!
==2953== Invalid read of size 4
==2953== at 0x4081EE: dump_token (udev-rules.c:859)
==2953== by 0x40BADB: udev_rules_apply_to_event (udev-rules.c:1849)
==2953== by 0x403F17: udev_event_execute_rules (udev-event.c:554)
==2953== by 0x418626: main (test-udev.c:100)
==2953== Address 0x55ab1f8 is 0 bytes after a block of size 80 alloc'd
==2953== at 0x4C23082: realloc (vg_replace_malloc.c:429)
==2953== by 0x40B13B: udev_rules_new (udev-rules.c:1670)
==2953== by 0x418536: main (test-udev.c:84)
...
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Kay Sievers [Fri, 31 Oct 2008 15:22:55 +0000 (16:22 +0100)]
write trace log to stderr
Kay Sievers [Thu, 30 Oct 2008 15:41:47 +0000 (16:41 +0100)]
fstab_import: add "change" event match
Kay Sievers [Thu, 30 Oct 2008 15:41:27 +0000 (16:41 +0100)]
edd_id: add "change" event match
Kay Sievers [Thu, 30 Oct 2008 15:11:49 +0000 (16:11 +0100)]
rules: remove "add" match from usb device node rule
Kay Sievers [Thu, 30 Oct 2008 08:20:03 +0000 (09:20 +0100)]
rules: remove SCSI timeouts
On Thu, Oct 30, 2008 at 03:55, Tejun Heo <tj@kernel.org> wrote:
The appropriate default timeout differs depending on the transport and
the type of the attached device, so the above two rules harm more than
help. The affect of the above two rules weren't visible for some
reason but with recent block layer timeout update, they actually work
and cause problems.
Kay Sievers [Wed, 29 Oct 2008 21:22:12 +0000 (22:22 +0100)]
ATTR{}== always fails if the attribute does not exist
Kay Sievers [Wed, 29 Oct 2008 16:32:13 +0000 (17:32 +0100)]
udevd: merge exec and run queue to minimize devpath string compares
Alan Jenkins [Tue, 28 Oct 2008 08:58:18 +0000 (08:58 +0000)]
udevd: simplify rules execution loop
cur can't become NULL, and the check for TK_END
can be folded into the switch statement.
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Kay Sievers [Tue, 28 Oct 2008 01:26:35 +0000 (02:26 +0100)]
update NEWS
Alan Jenkins [Sun, 26 Oct 2008 14:48:48 +0000 (14:48 +0000)]
kerneldoc comment fixes
s/ressources/resources/
Also reduce commas per sentence and add a possessive apostrophe.
Kay Sievers [Sun, 26 Oct 2008 13:31:46 +0000 (14:31 +0100)]
libudev: device - allocate envp array only once
Kay Sievers [Sun, 26 Oct 2008 03:35:32 +0000 (04:35 +0100)]
test: add RUN+="socket: ..." to a test to run monitor code
Kay Sievers [Sun, 26 Oct 2008 02:39:41 +0000 (03:39 +0100)]
libudev: device - fill envp array while composing monitor buffer
Thanks to Alan Jenkins, for the idea.
Kay Sievers [Sun, 26 Oct 2008 01:48:14 +0000 (02:48 +0100)]
fix $attr{[<subsystem>/<sysname>]<attribute>} substitution
Kay Sievers [Sun, 26 Oct 2008 01:31:54 +0000 (02:31 +0100)]
do not init string arrays, just clear first byte
Kay Sievers [Sun, 26 Oct 2008 01:16:54 +0000 (02:16 +0100)]
match_attr() - copy attr value only when needed
Alan Jenkins [Sat, 25 Oct 2008 14:51:19 +0000 (15:51 +0100)]
udevd: avoid implicit memset in match_attr()
Initializing a char array to "" is equivalent to a memset()
call - which is exactly what it gets compiled to.
Fixing this one callsite reduced memset() _user_ cpu cycles
from 2-4% to 0.05% on the EeePC.
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Alan Jenkins [Sat, 25 Oct 2008 16:01:21 +0000 (17:01 +0100)]
udevd: use a tighter loop for compare_devpath()
This crops up in my threaded udevd profiles from time to time.
It's not consistent - probably due to variations in the number
of concurrent events - but it can hit 4% user time and higher.
The change halves the user time spent in compare_devpath().
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Alan Jenkins [Sat, 25 Oct 2008 13:19:48 +0000 (15:19 +0200)]
fix handling of string_escape option
Kay Sievers [Sat, 25 Oct 2008 01:00:03 +0000 (03:00 +0200)]
match KEY="A|B" without temporary string copy
Kay Sievers [Fri, 24 Oct 2008 16:09:13 +0000 (18:09 +0200)]
remove debug printf