Bug#926896: sysvinit-utils: pidof is unreliable

[Thorsten Glaser]

On Fri, 22 Oct 2021, Jesse Smith wrote:

> Hurd systems because there is explicitly a check for that and, if it's
> not defined, PATH_MAX is declared in the code. So this code is GNU Hurd
> safe.

To what value? (Spoiler: 1024 is wrong. All other values are also wrong.)

PATH_MAX does not exist on the Hurd because it has no limits.

You should do things like check for get_current_dir_name(3) in libc
and use it if it is present, and dynamically allocate all pathname
storage instead of hardcoding the maximum length.

bye,
//mirabilos
-- 
Infrastrukturexperte • tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn • http://www.tarent.de/
Telephon +49 228 54881-393 • Fax: +49 228 54881-235
HRB AG Bonn 5168 • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/⁀\ The UTF-8 Ribbon
╲ ╱ Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
 ╳  HTML eMail! Also,     https://www.tarent.de/newsletter
╱ ╲ header encryption!
                        ****************************************************