Bug#926896: sysvinit-utils: pidof is unreliable

Jesse Smith jsmith at resonatingmedia.com
Sat Oct 23 01:32:33 BST 2021


On 2021-10-22 6:52 p.m., Svante Signell wrote:
> Hi Jesse,
>
> On Thu, 2021-10-21 at 14:51 -0300, Jesse Smith wrote:
>> Please give the attached patch a try and confirm it's working.  It's
>> working here for normal and zombie processes and it seems to be okay
>> for uninterruptable sleep processes too, but I'd like to have someone
>> else confirm everything looks right before I push this upstream.
> Please don't use PATH_MAX in your code, that will eventually cause
> problems. Especially using PATH_MAX will make builds for GNU/Hurd to
> FTBFS.

I inherited it that way. Though in this case it doesn't break for GNU
Hurd systems because there is explicitly a check for that and, if it's
not defined, PATH_MAX is declared in the code. So this code is GNU Hurd
safe.

Jesse



More information about the Debian-init-diversity mailing list