chiark / gitweb /
modbot-ulm.git
3 months agoUpdate Blocklist message (per Todal email) master mcvdevel/master
Matthew Vernon [Tue, 18 Dec 2018 16:11:33 +0000 (16:11 +0000)]
Update Blocklist message (per Todal email)

3 months agoRe-instate the blocklist of banned posters
Matthew Vernon [Sun, 16 Dec 2018 19:00:36 +0000 (19:00 +0000)]
Re-instate the blocklist of banned posters

This is largely a revert of f74ee06e256c2470ad5ed264b090486856258b7f
but doesn't add the "add poster to ban-list" button, per Todal request.

6 months agotruncation: adjust limit, and fix handling so we can do that in one place
Ian Jackson [Wed, 5 Sep 2018 13:42:37 +0000 (14:42 +0100)]
truncation: adjust limit, and fix handling so we can do that in one place

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
(cherry picked from commit 2ef67fd3aed1de70f7271ebccdd4c478f63bcf92)

6 months agotruncation: include header name in warning header
Ian Jackson [Wed, 5 Sep 2018 13:40:47 +0000 (14:40 +0100)]
truncation: include header name in warning header

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
(cherry picked from commit 8ef141149699a8e07868a9110583763f6c1aa7b0)

6 months agounfolding: do not introduce additional lwsp
Ian Jackson [Wed, 5 Sep 2018 13:27:12 +0000 (14:27 +0100)]
unfolding: do not introduce additional lwsp

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
(cherry picked from commit 8f597404afd9b075dc98b134a4734b2b18d065d7)

6 months agounfolding: exempt References
Ian Jackson [Wed, 5 Sep 2018 13:26:39 +0000 (14:26 +0100)]
unfolding: exempt References

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
(cherry picked from commit 4cae2550adca858ce289d060a3afc68ad23ac8a7)

6 months agostrip out some system headers, caused trouble during my testing
Ian Jackson [Mon, 27 Aug 2018 11:26:15 +0000 (12:26 +0100)]
strip out some system headers, caused trouble during my testing

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
6 months agoheader unfolding
Ian Jackson [Mon, 27 Aug 2018 11:26:03 +0000 (12:26 +0100)]
header unfolding

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
2 years agoinews: Add %ABBREV% to "lost" messages
Ian Jackson [Fri, 1 Apr 2016 15:50:29 +0000 (16:50 +0100)]
inews: Add %ABBREV% to "lost" messages

4 years agoMerge branch 'master' of /u/webstump/live-mtm
Matthew Vernon [Thu, 9 Oct 2014 16:34:20 +0000 (17:34 +0100)]
Merge branch 'master' of /u/webstump/live-mtm

4 years agobodge decodeBase64 origin/testing
Owen Dunn [Thu, 9 Oct 2014 12:34:44 +0000 (13:34 +0100)]
bodge decodeBase64

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
4 years agoMerge branch 'master' of /u/webstump/live-mtm
WebSTUMP [Mon, 6 Oct 2014 15:45:47 +0000 (16:45 +0100)]
Merge branch 'master' of /u/webstump/live-mtm

4 years agoinstall-substitutions: insist on webstump 022
Ian Jackson [Mon, 6 Oct 2014 14:10:06 +0000 (15:10 +0100)]
install-substitutions: insist on webstump 022

4 years agoMerge remote branch 'origin/master'
Ian Jackson [Mon, 6 Oct 2014 13:25:52 +0000 (14:25 +0100)]
Merge remote branch 'origin/master'

4 years agoremove save-* from index only
Ian Jackson [Mon, 6 Oct 2014 13:25:50 +0000 (14:25 +0100)]
remove save-* from index only

4 years agostump/etc/procmail/save-approved,-rejected: substitute $HOME/live-%ABBREV%
Ian Jackson [Mon, 6 Oct 2014 13:16:02 +0000 (14:16 +0100)]
stump/etc/procmail/save-approved,-rejected: substitute $HOME/live-%ABBREV%

4 years agostump/etc/procmail/save-approved,-rejected: add to .gitignore
Ian Jackson [Mon, 6 Oct 2014 13:21:56 +0000 (14:21 +0100)]
stump/etc/procmail/save-approved,-rejected: add to .gitignore

4 years agostump/etc/procmail/save-approved,-rejected: remove from git - cherry pick with care!
Ian Jackson [Mon, 6 Oct 2014 13:17:09 +0000 (14:17 +0100)]
stump/etc/procmail/save-approved,-rejected: remove from git - cherry pick with care!

4 years agostump/etc/procmail/save-approved,-rejected: substitute $HOME/live-%ABBREV%
Ian Jackson [Mon, 6 Oct 2014 13:16:02 +0000 (14:16 +0100)]
stump/etc/procmail/save-approved,-rejected: substitute $HOME/live-%ABBREV%

4 years agoCorrect regexp
Matthew Vernon [Tue, 15 Apr 2014 17:21:07 +0000 (18:21 +0100)]
Correct regexp

We want to make the trailing .gz optional, so errs.0 gets matched

4 years agocorrect regexp
Matthew Vernon [Tue, 15 Apr 2014 17:19:21 +0000 (18:19 +0100)]
correct regexp

we want ?$, so the .gz is an optional match.

4 years agoMerge remote branch 'origin/master'
Matthew Vernon [Tue, 15 Apr 2014 17:00:54 +0000 (18:00 +0100)]
Merge remote branch 'origin/master'

4 years agoReverse the contents of log files
Matthew Vernon [Tue, 15 Apr 2014 15:53:15 +0000 (16:53 +0100)]
Reverse the contents of log files

Use "tac" to reverse files, meaning the logs are now output neatly in
reverse-chronological order.

The existing code tried to read everything in $webstump_home/.. ; we
now only try and open errs files; this involves changing the guard
condition to 0 from undef (since forwards * undef isn't undef).

4 years agoLine-wrap articles in the moderation screen
Matthew Vernon [Wed, 2 Apr 2014 21:00:53 +0000 (22:00 +0100)]
Line-wrap articles in the moderation screen

The ULM mods asked for the <pre> tags in the single-article moderation
screen to be modified to line-wrap long lines in posts (e.g. from
google groups).

5 years agoMerge remote branch 'origin/master'
Matthew Vernon [Thu, 20 Mar 2014 12:28:54 +0000 (12:28 +0000)]
Merge remote branch 'origin/master'

5 years agoLeave "Date" header alone.
Matthew Vernon [Thu, 20 Mar 2014 12:26:42 +0000 (12:26 +0000)]
Leave "Date" header alone.

Prior to this change, Stump removed the supplied Date: header, and
replaced it with one of its own, which reflected the time at which the
article was approved. Following discussion in unnm, it seemed clear
that people would like the Date: header to be unmolested.

Signed-off-by: Matthew Vernon <matthewv@chiark.greenend.org.uk>
5 years agoRevert to drop-down for single article page (largely reversion of f21bfd
Matthew Vernon [Wed, 19 Feb 2014 15:18:02 +0000 (15:18 +0000)]
Revert to drop-down for single article page (largely reversion of f21bfd

5 years agoMerge branch 'master' of /u/webstump/live-mtm
Matthew Vernon [Mon, 27 Jan 2014 17:38:21 +0000 (17:38 +0000)]
Merge branch 'master' of /u/webstump/live-mtm

5 years agoMerge remote branch 'origin/master'
Matthew Vernon [Mon, 27 Jan 2014 17:19:09 +0000 (17:19 +0000)]
Merge remote branch 'origin/master'

5 years agoAdd -type f to crontab.part.IN0
Matthew Vernon [Mon, 27 Jan 2014 17:08:28 +0000 (17:08 +0000)]
Add -type f to crontab.part.IN0

Previously, this cron job would complain that
xlog/log/[newsgroup/public is a directory. Fix that by telling find to
only return files.

Signed-off-by: Matthew Vernon <matthewv@chiark.greenend.org.uk>
5 years agoAdd link to the summary of rejection reasons
Matthew Vernon [Sun, 26 Jan 2014 13:19:28 +0000 (13:19 +0000)]
Add link to the summary of rejection reasons

5 years agoinstall-rejectionreasons: new script
Ian Jackson [Tue, 21 Jan 2014 17:12:42 +0000 (17:12 +0000)]
install-rejectionreasons: new script

5 years agoAlso remove acks when posts accepted
Matthew Vernon [Sun, 12 Jan 2014 23:33:16 +0000 (23:33 +0000)]
Also remove acks when posts accepted

5 years agoDisable auto-acks
Matthew Vernon [Sun, 12 Jan 2014 10:30:50 +0000 (10:30 +0000)]
Disable auto-acks

ULM mods decided that the auto-acks (of receipt and acceptance) were
more annoying than they were worth, even though they were
opt-out-able. So disable this functionality (by the slightly cheeky
approach of adjusting the "does this poster want an auto-ack" function
to always say no).

5 years agoremove block-capitals from autoack emails [Todal request]
Matthew Vernon [Sun, 5 Jan 2014 19:02:24 +0000 (19:02 +0000)]
remove block-capitals from autoack emails [Todal request]

5 years agoShow 8 lines of posts, rather than 5 [Todal request]
Matthew Vernon [Sun, 5 Jan 2014 18:58:47 +0000 (18:58 +0000)]
Show 8 lines of posts, rather than 5 [Todal request]

5 years agoAdd a link to the management page from the single-article page
Matthew Vernon [Sun, 5 Jan 2014 13:33:19 +0000 (13:33 +0000)]
Add a link to the management page from the single-article page

5 years agoRemove the blacklist of posters
Matthew Vernon [Sun, 5 Jan 2014 13:28:25 +0000 (13:28 +0000)]
Remove the blacklist of posters

The ULM mods want a watchlist for posters, not a blacklist. So remove
the blacklisted posters list, and replace the option to blacklist a
poster with the option to add them to the watch list.

5 years agoRestore the suspicious posters list
Matthew Vernon [Sun, 5 Jan 2014 13:21:17 +0000 (13:21 +0000)]
Restore the suspicious posters list

ULM mods have decided they'd rather have a watch list for posters than
a ban list. The first part of making that change is reverting the bits
of the remove_steps branch that removed the watched posters list.

5 years agoAdd more whitespace (formatting improvement)
Matthew Vernon [Sun, 5 Jan 2014 07:39:12 +0000 (07:39 +0000)]
Add more whitespace (formatting improvement)

5 years agoReplace drop-down with radio buttons
Matthew Vernon [Sun, 5 Jan 2014 07:36:09 +0000 (07:36 +0000)]
Replace drop-down with radio buttons

Todal wanted a simpler UI for the single-article screen, rather more
like the version in the multiple-article screen. This does that, by
stripping out the old drop-down (and the thread status button), and
replacing it with radio buttons for all the approve/hold/reject
options.

Also, make it clearer that the "Comment" field is to go with the
rejection email to the poster.

5 years agoAdd comments to make the two mod-screen functions more obvious
Matthew Vernon [Sun, 5 Jan 2014 07:27:57 +0000 (07:27 +0000)]
Add comments to make the two mod-screen functions more obvious

Previously they were just main moderation screen, and main moderation
screen - old version, which isn't very helpful. In fact, one is the
single-article version (shows the entire post), and one the
multiple-articles version (shows a few lines of up to 40 posts).

5 years agoadd an HTML rejection reason
Matthew Vernon [Sat, 4 Jan 2014 16:19:17 +0000 (16:19 +0000)]
add an HTML rejection reason

5 years agoAdd a link to the moderation screen from the admin screen (Todal request)
Matthew Vernon [Sat, 4 Jan 2014 14:21:04 +0000 (14:21 +0000)]
Add a link to the moderation screen from the admin screen (Todal request)

5 years agoAdd buttons to the top of the multi-post screen
Matthew Vernon [Fri, 3 Jan 2014 17:39:55 +0000 (17:39 +0000)]
Add buttons to the top of the multi-post screen

The Todal asked for Submit/Reset buttons at the top as well as the
bottom of the multiple-message moderation screen. This patch provides
those; it'll look a bit ugly if there are no posts in the queue, but
we don't know that there aren't at the point we need to print the
buttons.

5 years agonew rejection messages from The Todal
Matthew Vernon [Fri, 3 Jan 2014 17:34:09 +0000 (17:34 +0000)]
new rejection messages from The Todal

5 years agoRemove references to spam-trap problems with mod contact
Matthew Vernon [Thu, 2 Jan 2014 11:06:07 +0000 (11:06 +0000)]
Remove references to spam-trap problems with mod contact

The ulm mods don't have a SAUCE'd email address, so the suggestion of
talking to postmaster@chiark about any problems emailing them isn't
relevant.

Signed-off-by: Matthew Vernon <matthewv@chiark.greenend.org.uk>
5 years agodocument the simplified processing used for ULM mcvdevel/remove_steps
Matthew Vernon [Thu, 2 Jan 2014 10:51:58 +0000 (10:51 +0000)]
document the simplified processing used for ULM

5 years agoRemove options to add subjects, words, posters to any of the following
Matthew Vernon [Thu, 2 Jan 2014 10:49:52 +0000 (10:49 +0000)]
Remove options to add subjects, words, posters to any of the following
lists:
bad.subjects.list
bad.words.list
watch.posters.list
watch.subjects.list
good.subjects.list

This is part of the process of simplifying the ulm mods interface

5 years agoOnly allow the bad.posters, watch.words, and good.posters lists to be
Matthew Vernon [Thu, 2 Jan 2014 10:42:51 +0000 (10:42 +0000)]
Only allow the bad.posters, watch.words, and good.posters lists to be
edited.

This is part of the process of simplifying the UI for the ulm mods

5 years agoNo longer consider the bad.subjects, bad.words, watch.posters,
Matthew Vernon [Thu, 2 Jan 2014 10:38:22 +0000 (10:38 +0000)]
No longer consider the bad.subjects, bad.words, watch.posters,
watch.subjects, good.subjects lists.

This part of the process of simplifying the UI for the ulm mods.

5 years agoUI change: say 'white-list poster' rather than Preapprove
Matthew Vernon [Wed, 1 Jan 2014 19:20:41 +0000 (19:20 +0000)]
UI change: say 'white-list poster' rather than Preapprove

5 years agonew rejection reasons for ulm
Matthew Vernon [Wed, 1 Jan 2014 19:08:05 +0000 (19:08 +0000)]
new rejection reasons for ulm

5 years agoCreate a 'defamatory' rejection message
Matthew Vernon [Sun, 10 Nov 2013 16:51:51 +0000 (16:51 +0000)]
Create a 'defamatory' rejection message

5 years agoinstall-newsgroup: use ". get-settings" rather than open-coding it; that makes sure...
Ian Jackson [Sun, 10 Nov 2013 13:58:20 +0000 (13:58 +0000)]
install-newsgroup: use ". get-settings" rather than open-coding it; that makes sure we create persistent-autosettings, amongst other things

6 years agoMerge branch 'master' of /u/webstump/live/
Ian Jackson [Fri, 23 Nov 2012 19:36:18 +0000 (19:36 +0000)]
Merge branch 'master' of /u/webstump/live/

6 years agoAllow suppressing publication of posted messages according to rejection reason
Ian Jackson [Fri, 23 Nov 2012 17:50:02 +0000 (17:50 +0000)]
Allow suppressing publication of posted messages according to rejection reason

This is done by creating
  BASEDIR/settings.publish-rejection-kinds
with a series of lines of the form
  [!]<glob-pattern>
where <glob-pattern> may contain * and ? and matches the short
rejection reason keyword.  First match wins; ! means do not publish;
if file does not exist or we run off the end, we do publish.

All of this depends on PUBLISHREJECTIONS=true in settings.

6 years agowebstump: do not alter the moderator's post disposition when it differs from the...
WebSTUMP [Thu, 22 Nov 2012 15:06:34 +0000 (15:06 +0000)]
webstump: do not alter the moderator's post disposition when it differs from the poster disposition.  For a poster being banned, we can reject with any reason.  For a poster being passlisted, bomb out with an internal error if the post decision wasn't approve (bad UI but it will do)

6 years agowebstump: use "reject blocklist" for the hardcoded blocklist-related rejection reason
WebSTUMP [Thu, 22 Nov 2012 14:53:43 +0000 (14:53 +0000)]
webstump: use "reject blocklist" for the hardcoded blocklist-related rejection reason

6 years agocrontab.part.INO: rotate xlog event log weekly, not twice a week
WebSTUMP [Wed, 21 Nov 2012 12:04:17 +0000 (12:04 +0000)]
crontab.part.INO: rotate xlog event log weekly, not twice a week

8 years agofix up moderator removal to not print a pointless message
Ian Jackson [Tue, 8 Feb 2011 14:17:41 +0000 (14:17 +0000)]
fix up moderator removal to not print a pointless message

8 years agoMake noack honoured for approvals too
Ian Jackson [Wed, 2 Feb 2011 23:49:47 +0000 (23:49 +0000)]
Make noack honoured for approvals too

8 years agofix noack function: store whole From line contents (not just the email address) in...
WebSTUMP [Wed, 2 Feb 2011 18:33:44 +0000 (18:33 +0000)]
fix noack function: store whole From line contents (not just the email address) in the noack list, and when matching look only for the contents (not also the header name From:)

8 years agostump: fix hideous bug where passlisting someone puts their whole From: line in the...
Ian Jackson [Wed, 26 Jan 2011 16:27:09 +0000 (16:27 +0000)]
stump: fix hideous bug where passlisting someone puts their whole From: line in the passlist, but this is later interpreted as a regexp

8 years agoSplit nameIsInList into nameIsInListRegexp (for most things) and nameIsInListExactly...
Ian Jackson [Wed, 5 Jan 2011 18:24:22 +0000 (18:24 +0000)]
Split nameIsInList into nameIsInListRegexp (for most things) and nameIsInListExactly (good posters and noack lists)

8 years agosend voting url to admin not to voters
Ian Jackson [Tue, 16 Nov 2010 12:19:42 +0000 (12:19 +0000)]
send voting url to admin not to voters

8 years agosuppress seconds and minutes units
Ian Jackson [Wed, 13 Oct 2010 10:59:50 +0000 (11:59 +0100)]
suppress seconds and minutes units

8 years agodefault option on one-article screen is back of queue
Ian Jackson [Wed, 30 Jun 2010 11:57:18 +0000 (12:57 +0100)]
default option on one-article screen is back of queue

8 years agoX-prefix (not strip, previous comments are wrong) Injection-Info too
Ian Jackson [Wed, 2 Jun 2010 11:17:04 +0000 (12:17 +0100)]
X-prefix (not strip, previous comments are wrong) Injection-Info too

8 years agoStrip X-Complaints-To too
Ian Jackson [Wed, 2 Jun 2010 10:54:25 +0000 (11:54 +0100)]
Strip X-Complaints-To too

8 years agofilter out some system headers in inews
Ian Jackson [Wed, 2 Jun 2010 01:22:57 +0000 (02:22 +0100)]
filter out some system headers in inews

8 years agoNew "blocklist" rejection reason
Ian Jackson [Thu, 20 May 2010 23:40:07 +0000 (00:40 +0100)]
New "blocklist" rejection reason

8 years agoFix secret ballot stuff
Ian Jackson [Tue, 4 May 2010 16:01:40 +0000 (17:01 +0100)]
Fix secret ballot stuff

8 years agoGenerate newsgroups.lst
Ian Jackson [Wed, 21 Apr 2010 14:10:40 +0000 (15:10 +0100)]
Generate newsgroups.lst

8 years agoGet dates right in log lookup
Ian Jackson [Wed, 21 Apr 2010 14:05:47 +0000 (15:05 +0100)]
Get dates right in log lookup

8 years agoMerge ../live-mtm
WebSTUMP [Wed, 21 Apr 2010 12:02:02 +0000 (13:02 +0100)]
Merge ../live-mtm

8 years agoAdd webstump.cfg
Ian Jackson [Wed, 21 Apr 2010 12:01:49 +0000 (13:01 +0100)]
Add webstump.cfg

8 years agoMerge ../live-mtm
WebSTUMP [Wed, 21 Apr 2010 11:59:18 +0000 (12:59 +0100)]
Merge ../live-mtm

8 years agoChange defaults for log access to "true"
Ian Jackson [Wed, 21 Apr 2010 11:58:32 +0000 (12:58 +0100)]
Change defaults for log access to "true"

8 years agoUse umask 007; preserve perms on logfiles
Ian Jackson [Tue, 20 Apr 2010 17:36:21 +0000 (18:36 +0100)]
Use umask 007; preserve perms on logfiles

8 years agoShow dates of DECISIONs
Ian Jackson [Tue, 20 Apr 2010 17:10:24 +0000 (18:10 +0100)]
Show dates of DECISIONs

8 years agoMerge branch 'master' of ../live-urcm
Ian Jackson [Tue, 20 Apr 2010 17:00:38 +0000 (18:00 +0100)]
Merge branch 'master' of ../live-urcm

8 years agoDon't mind spaces in ref supplied for log lookup
Ian Jackson [Tue, 20 Apr 2010 17:00:11 +0000 (18:00 +0100)]
Don't mind spaces in ref supplied for log lookup

8 years agoUse message number for reject publish filename if available
Ian Jackson [Tue, 20 Apr 2010 16:58:26 +0000 (17:58 +0100)]
Use message number for reject publish filename if available

8 years agoSupport querying and downloading of decision reasons by moderators
Ian Jackson [Tue, 20 Apr 2010 16:54:30 +0000 (17:54 +0100)]
Support querying and downloading of decision reasons by moderators

8 years agoSend webstump CGI logs to "errs" too to capture all of the decisions
Ian Jackson [Tue, 20 Apr 2010 16:53:59 +0000 (17:53 +0100)]
Send webstump CGI logs to "errs" too to capture all of the decisions

8 years agoDECISION: log lines are more parseable and include an explanation of how the decision...
Ian Jackson [Tue, 20 Apr 2010 16:53:30 +0000 (17:53 +0100)]
DECISION: log lines are more parseable and include an explanation of how the decision was made

8 years agoInclude the message number in X-Webstump-Event
Ian Jackson [Tue, 20 Apr 2010 16:51:09 +0000 (17:51 +0100)]
Include the message number in X-Webstump-Event

8 years agoSubstitute the message number for [REFERENCE] in added-headers, if present
Ian Jackson [Tue, 20 Apr 2010 16:49:33 +0000 (17:49 +0100)]
Substitute the message number for [REFERENCE] in added-headers, if present

8 years agoPlumb messagenumber through in an env var to our sub-scripts
Ian Jackson [Tue, 20 Apr 2010 16:48:49 +0000 (17:48 +0100)]
Plumb messagenumber through in an env var to our sub-scripts

8 years agoSend approval notify thingies to correct log
Ian Jackson [Tue, 20 Apr 2010 16:27:59 +0000 (17:27 +0100)]
Send approval notify thingies to correct log

8 years agoCan show diff from install-substitutions
Ian Jackson [Tue, 20 Apr 2010 16:27:45 +0000 (17:27 +0100)]
Can show diff from install-substitutions

8 years agoAdd procmail files for various archiving, of which we only use save-approved
Ian Jackson [Tue, 20 Apr 2010 14:23:42 +0000 (15:23 +0100)]
Add procmail files for various archiving, of which we only use save-approved

8 years agoDo not suggest unnm for inflammatory
Ian Jackson [Tue, 20 Apr 2010 14:15:04 +0000 (15:15 +0100)]
Do not suggest unnm for inflammatory

9 years agoMerge branch 'master' of /u/webstump/live-urcm
Ian Jackson [Fri, 19 Mar 2010 11:54:53 +0000 (11:54 +0000)]
Merge branch 'master' of /u/webstump/live-urcm

9 years agoRemove useless use of cat causing pipefail problems
Ian Jackson [Fri, 19 Mar 2010 11:54:37 +0000 (11:54 +0000)]
Remove useless use of cat causing pipefail problems

9 years agoBetter diversion arrangements
Ian Jackson [Fri, 19 Mar 2010 11:54:19 +0000 (11:54 +0000)]
Better diversion arrangements

9 years agoDebugging of modack.approved pipe failures
Ian Jackson [Fri, 19 Mar 2010 11:38:44 +0000 (11:38 +0000)]
Debugging of modack.approved pipe failures

9 years agoDeal more sensibly with various combinations of input format
Ian Jackson [Thu, 4 Mar 2010 17:23:17 +0000 (17:23 +0000)]
Deal more sensibly with various combinations of input format

9 years agoSome stylistic fixups; get rid of warning when processing pre-publish-rejection log...
Ian Jackson [Thu, 4 Mar 2010 16:13:34 +0000 (16:13 +0000)]
Some stylistic fixups; get rid of warning when processing pre-publish-rejection log lines