chiark
/
gitweb
/
~mdw
/
tripe
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cf035d9
)
server/chal.c: Don't load sequence number twice.
author
Mark Wooding
<mdw@distorted.org.uk>
Tue, 11 Mar 2014 14:32:12 +0000
(14:32 +0000)
committer
Mark Wooding
<mdw@distorted.org.uk>
Tue, 11 Mar 2014 15:30:39 +0000
(15:30 +0000)
This is especially embarrassing because the only other reason the
sequence number is loaded is for a trace message. This was discovered
from compiler warning about `seq' being unused when tracing is disabled.
server/chal.c
patch
|
blob
|
blame
|
history
diff --git
a/server/chal.c
b/server/chal.c
index e282f08548967e5cd8d4cd7722948a0cb5e4c01f..387f0db1fb29e182d36b28d9df979d7ebce21082 100644
(file)
--- a/
server/chal.c
+++ b/
server/chal.c
@@
-124,7
+124,7
@@
int c_check(buf *b)
goto fail;
}
seq = LOAD32(p);
- if (seq_check(&iseq,
LOAD32(p)
, "CHAL"))
+ if (seq_check(&iseq,
seq
, "CHAL"))
goto fail;
T( trace(T_CHAL, "chal: checked challenge %lu", (unsigned long)seq); )
return (0);