From 4416b2ef7d2258f2e864b94b84ef2d22468239ce Mon Sep 17 00:00:00 2001 Message-Id: <4416b2ef7d2258f2e864b94b84ef2d22468239ce.1715562159.git.mdw@distorted.org.uk> From: Mark Wooding Date: Tue, 11 Mar 2014 14:32:12 +0000 Subject: [PATCH] server/chal.c: Don't load sequence number twice. Organization: Straylight/Edgeware From: Mark Wooding This is especially embarrassing because the only other reason the sequence number is loaded is for a trace message. This was discovered from compiler warning about `seq' being unused when tracing is disabled. --- server/chal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/chal.c b/server/chal.c index e282f085..387f0db1 100644 --- a/server/chal.c +++ b/server/chal.c @@ -124,7 +124,7 @@ int c_check(buf *b) goto fail; } seq = LOAD32(p); - if (seq_check(&iseq, LOAD32(p), "CHAL")) + if (seq_check(&iseq, seq, "CHAL")) goto fail; T( trace(T_CHAL, "chal: checked challenge %lu", (unsigned long)seq); ) return (0); -- [mdw]