chiark / gitweb /
2 years agoVersion 228.2 Release v228.2
Sven Eden [Wed, 17 May 2017 06:02:27 +0000 (08:02 +0200)]
Version 228.2 Release

2 years agoReset pending actions after returning from possible suspend/sleep actions.
Sven Eden [Wed, 17 May 2017 05:56:39 +0000 (07:56 +0200)]
Reset pending actions after returning from possible suspend/sleep actions.

This should fix any "suspension loops".

2 years agofix musl libc build errors
Enno Boland [Tue, 16 May 2017 08:21:17 +0000 (10:21 +0200)]
fix musl libc build errors

2 years agoVersion 228.1 Release v228.1
Sven Eden [Sun, 14 May 2017 08:16:46 +0000 (10:16 +0200)]
Version 228.1 Release

2 years agoMerge pull request #7 from elogind/dev_v228-r1
Sven Eden [Thu, 4 May 2017 11:46:18 +0000 (13:46 +0200)]
Merge pull request #7 from elogind/dev_v228-r1

Candidate for v228.1 release

2 years agoPrep v228: Ignore local Code::Blocks Layout files
Sven Eden [Mon, 24 Apr 2017 08:43:15 +0000 (10:43 +0200)]
Prep v228: Ignore local Code::Blocks Layout files

2 years agoPrep v228: Silence uninitialized usage warnings.
Sven Eden [Thu, 13 Apr 2017 11:47:48 +0000 (13:47 +0200)]
Prep v228: Silence uninitialized usage warnings.

2 years agoPrep v228: Full diff to master revealed more functions that are unused.
Sven Eden [Thu, 13 Apr 2017 05:44:02 +0000 (07:44 +0200)]
Prep v228: Full diff to master revealed more functions that are unused.

2 years agoPrep v228: With most functions split out, clean up the enormous includes list in...
Sven Eden [Thu, 13 Apr 2017 05:43:39 +0000 (07:43 +0200)]
Prep v228: With most functions split out, clean up the enormous includes list in util.c

2 years agoPrep v228: Remove left-over BTRFS bits.
Sven Eden [Thu, 13 Apr 2017 05:42:15 +0000 (07:42 +0200)]
Prep v228: Remove left-over BTRFS bits.

2 years agoPrep v228: Revert d882e06 on
Sven Eden [Wed, 12 Apr 2017 13:30:50 +0000 (15:30 +0200)]
Prep v228: Revert d882e06 on

2 years agoPrep v228: Condense elogind source masks (5/5)
Sven Eden [Tue, 11 Apr 2017 15:28:25 +0000 (17:28 +0200)]
Prep v228: Condense elogind source masks (5/5)

2 years agoPrep v228: Condense elogind source masks (4/5)
Sven Eden [Tue, 11 Apr 2017 15:28:18 +0000 (17:28 +0200)]
Prep v228: Condense elogind source masks (4/5)

2 years agoPrep v228: Condense elogind source masks (3/5)
Sven Eden [Tue, 11 Apr 2017 15:28:14 +0000 (17:28 +0200)]
Prep v228: Condense elogind source masks (3/5)

2 years agoPrep v228: Condense elogind source masks (2/5)
Sven Eden [Tue, 11 Apr 2017 15:28:10 +0000 (17:28 +0200)]
Prep v228: Condense elogind source masks (2/5)

2 years agoPrep v228: Condense elogind source masks (1/5)
Sven Eden [Tue, 11 Apr 2017 15:26:30 +0000 (17:26 +0200)]
Prep v228: Condense elogind source masks (1/5)

Although having a two line mask like

  /// UNNEEDED by elogind
  #if 0

it is much more easier to read (and patch!) if those two lines were
condense into a one-line mask start like

  #if 0 /// UNNEEDED by elogind

2 years agoPrep v228: Substitute declaration masks (4/4)
Sven Eden [Tue, 11 Apr 2017 15:08:00 +0000 (17:08 +0200)]
Prep v228: Substitute declaration masks (4/4)

2 years agoPrep v228: Substitute declaration masks (3/4)
Sven Eden [Tue, 11 Apr 2017 15:07:51 +0000 (17:07 +0200)]
Prep v228: Substitute declaration masks (3/4)

2 years agoPrep v228: Substitute declaration masks (2/4)
Sven Eden [Tue, 11 Apr 2017 15:07:47 +0000 (17:07 +0200)]
Prep v228: Substitute declaration masks (2/4)

2 years agoPrep v228: Substitute declaration masks (1/4)
Sven Eden [Tue, 11 Apr 2017 15:05:07 +0000 (17:05 +0200)]
Prep v228: Substitute declaration masks (1/4)

Although it looks very ugly, substitute all declaration masks of the

  // UNNEEDED type foo(...);


  /// UNNEEDED by elogind
  #if 0
  type foo(...);
  #endif // 0

to make future merging of upstream pathes easier, as the relevant
lines themselves are not changed any more.

2 years agoPrep v228: Removed EFI bits. elogind can not support EFI at all.
Sven Eden [Mon, 10 Apr 2017 10:06:50 +0000 (12:06 +0200)]
Prep v228: Removed EFI bits. elogind can not support EFI at all.

Rebooting to firmware and such things are official init system stuff.
The added system commands to loginctl like poweroff and reboot are
a convenience, as any user can do it anyway using 'sudo shutdown' and
similar commands.

2 years agoPrep v228: Removed utmp bits. elogind does not support utmp-wtmp.
Sven Eden [Mon, 10 Apr 2017 09:57:04 +0000 (11:57 +0200)]
Prep v228: Removed utmp bits. elogind does not support utmp-wtmp.

2 years agoPrep v228: Update Code::Blocks Project file to dev_v228 branch contents.
Sven Eden [Sun, 9 Apr 2017 12:10:44 +0000 (14:10 +0200)]
Prep v228: Update Code::Blocks Project file to dev_v228 branch contents.

2 years agoPrep v228: src/shared/cgroup-show.[hc] is no longer needed.
Sven Eden [Sat, 8 Apr 2017 12:50:54 +0000 (14:50 +0200)]
Prep v228: src/shared/cgroup-show.[hc] is no longer needed.

2 years agoPrep v228: Clean up the new src/basic/*-util-[hc] files:
Sven Eden [Fri, 7 Apr 2017 07:40:54 +0000 (09:40 +0200)]
Prep v228: Clean up the new src/basic/*-util-[hc] files:

- src/basic/capability-util.[hc]
- src/basic/cgroup-util.[hc]
- src/basic/fd-util.[hc]
- src/basic/fs-util.[hc]
- src/basic/memfd-util.[hc]
- src/basic/path-util.[hc]
- src/basic/socket-util.[hc]
- src/basic/terminal-util.[hc]
- src/basic/user-util.[hc]
- src/basic/xattr-util.[hc]

2 years agoPrep v228: Apply more cosmetic changes found in upstream.
Sven Eden [Thu, 6 Apr 2017 13:07:20 +0000 (15:07 +0200)]
Prep v228: Apply more cosmetic changes found in upstream.

2 years agoPrep v228: Add remaining updates from upstream (3/3)
Sven Eden [Thu, 6 Apr 2017 12:56:03 +0000 (14:56 +0200)]
Prep v228: Add remaining updates from upstream (3/3)

Apply remaining fixes and the performed move of utility functions
into their own foo-util.[hc] files on the rest of elogind.

2 years agoPrep v228: Add remaining updates from upstream (2/3)
Sven Eden [Thu, 6 Apr 2017 12:55:07 +0000 (14:55 +0200)]
Prep v228: Add remaining updates from upstream (2/3)

Apply remaining fixes and the performed move of utility functions
into their own foo-util.[hc] files on libbasic.

2 years agoPrep v228: Add remaining updates from upstream (1/3)
Sven Eden [Thu, 6 Apr 2017 12:52:36 +0000 (14:52 +0200)]
Prep v228: Add remaining updates from upstream (1/3)

The util.[hc] files have been stripped of a lot of functions, that
got sorted into various new files representing the type of

This commit adds the missing files.

2 years agoPrep v228: Added missing src/basic/unaligned.h from upstream
Sven Eden [Tue, 4 Apr 2017 09:32:42 +0000 (11:32 +0200)]
Prep v228: Added missing src/basic/unaligned.h from upstream

2 years agoPrep v228: Update po/ko.po to upstream version.
Sven Eden [Tue, 4 Apr 2017 08:41:43 +0000 (10:41 +0200)]
Prep v228: Update po/ko.po to upstream version.

2 years agoPrep v228: Update base files to upstream version.
Sven Eden [Tue, 4 Apr 2017 08:58:20 +0000 (10:58 +0200)]
Prep v228: Update base files to upstream version.

2 years agocore: don't generate warnings when write access to the cgroup fs fails in --user...
Lennart Poettering [Mon, 16 Nov 2015 23:01:00 +0000 (00:01 +0100)]
core: don't generate warnings when write access to the cgroup fs fails in --user due to EACCES

After all, in the classic hierarchy that's pretty much the default case.

2 years agotree-wide: add missing includes
Thomas Hindoe Paaboel Andersen [Mon, 16 Nov 2015 19:13:09 +0000 (20:13 +0100)]
tree-wide: add missing includes

Add a few includes that we rely on to be include already.

2 years agologin: ignore JobRemoved of old jobs
David Herrmann [Mon, 16 Nov 2015 14:45:02 +0000 (15:45 +0100)]
login: ignore JobRemoved of old jobs

If we requeue jobs, we are no longer interested in old jobs. Hence, we
better ignore any JobRemoved signals for old jobs and concentrate on our

2 years agologin: make sure to replace existing units
David Herrmann [Mon, 16 Nov 2015 14:43:18 +0000 (15:43 +0100)]
login: make sure to replace existing units

When queuing unit jobs, we should rather replace existing units than
fail. This is especially important when we queued a user-shutdown and a
new login is encountered. In this case, we better raplce the shutdown
jobs. elogind takes care of everything else.

2 years agosiphash24: fix memory alignment
Daniel Mack [Mon, 16 Nov 2015 12:08:34 +0000 (13:08 +0100)]
siphash24: fix memory alignment

Use unaligned_read_le64() to access input buffer when reading complete
64-bit words.

This should fix memory traps on platforms with strict aliasing.

2 years agologind: don't assert if the slice is missing
Lennart Poettering [Fri, 13 Nov 2015 17:47:02 +0000 (18:47 +0100)]
logind: don't assert if the slice is missing

After all, we don't actually really need the slice to work, it's just
nice to have it.

2 years agoconf-parser: use extract_first_word
David Reynolds [Tue, 10 Nov 2015 07:45:26 +0000 (23:45 -0800)]
conf-parser: use extract_first_word

2 years agovirt: make sure that we detect unknown container managers as VIRTUALIZATION_CONTAINER...
Lennart Poettering [Mon, 9 Nov 2015 22:47:29 +0000 (23:47 +0100)]
virt: make sure that we detect unknown container managers as VIRTUALIZATION_CONTAINER_OTHER

If we don't know a container manager, we should consider it as "other"
rather than as no container manager at all, to provide a somwhat useful
upgrade path.

2 years agolog: whitespace style fix
Michal Schmidt [Thu, 5 Nov 2015 12:44:03 +0000 (13:44 +0100)]
log: whitespace style fix

2 years agodetect-virt: detect in best-heuristic order
Andrew Jones [Tue, 3 Nov 2015 20:49:38 +0000 (14:49 -0600)]
detect-virt: detect in best-heuristic order

afaict, this will fix a regression caused by commit 75f86906c5.
Where we used to report "kvm" before that patch, without this patch,
we would only report "qemu". The reason is because cpuid detection
must come before dmi detection. Also, both can safely come before
other xen heuristics. Untested.

2 years agodetect-virt: dmi: look for KVM
Andrew Jones [Tue, 3 Nov 2015 19:31:03 +0000 (13:31 -0600)]
detect-virt: dmi: look for KVM

Some guests (ARM, AArch64, x86-RHEL) have 'KVM' in the product name.
Look for that first in order to more precisely report "kvm" when
detecting a QEMU/KVM guest. Without this patch we report "qemu",
even if KVM acceleration is in use on ARM/AArch64 guests.

I've only tested a backported version of this and the previous
patch on an AArch64 guest (which worked). Of course it would be
nice to get regression testing on all guest types that depend on
dmi done.

2 years agoarm/aarch64: detect-virt: check dmi
Andrew Jones [Tue, 3 Nov 2015 18:10:13 +0000 (12:10 -0600)]
arm/aarch64: detect-virt: check dmi

ARM/AArch64 guests now have SMBIOS tables populated (when boot
with a late enough QEMU and a late enough AAVMF is used as the
bootloader). Furthermore, when booting ARM/AArch64 guests with
ACPI, the DT detection obviously no longer works, so we need
dmi detection.

2 years agosd-daemon: explicitly filter out -1 when parsing watchdog timeout
Lennart Poettering [Tue, 3 Nov 2015 11:27:12 +0000 (12:27 +0100)]
sd-daemon: explicitly filter out -1 when parsing watchdog timeout

We already filter out 0, and as -1 is usually special (meaning infinity,
as in USEC_INFINITY) we should better not accept it either. Better safe
than sorry...

2 years agosd-daemon: fix potential LISTEN_FDS overflow in sd_listen_fds()
Vito Caputo [Tue, 3 Nov 2015 07:05:44 +0000 (23:05 -0800)]
sd-daemon: fix potential LISTEN_FDS overflow in sd_listen_fds()

2 years agoman: Drop "internally," which is misleading
David Strauss [Tue, 3 Nov 2015 01:19:26 +0000 (17:19 -0800)]
man: Drop "internally," which is misleading

The existing text misleads readers into thinking how the notify socket protocol is "internals" and that they can only use the functions. However, the socket is part of the Interface Stability Promise. So, we should drop "internally" from the description so the man page both indicates both how the functions work and how one would talk to the socket directly.

2 years agosd-daemon: verify NOTIFY_SOCKET path length
Lennart Poettering [Sun, 1 Nov 2015 20:49:19 +0000 (21:49 +0100)]
sd-daemon: verify NOTIFY_SOCKET path length

2 years agoprocess-util: make some minor corrections to PID live detection
Lennart Poettering [Tue, 27 Oct 2015 13:02:45 +0000 (14:02 +0100)]
process-util: make some minor corrections to PID live detection

2 years agopath-util: minor coding style fix
Lennart Poettering [Sun, 25 Oct 2015 23:46:40 +0000 (00:46 +0100)]
path-util: minor coding style fix

We usually avoid relying on C's degrade-to-boolean functionality when
comparing numerical variables with 0. We use it only for pointers and
actual booleans.

2 years agoutil-lib: move formats-util.h from shared/ to basic/
Lennart Poettering [Sun, 25 Oct 2015 12:16:10 +0000 (13:16 +0100)]
util-lib: move formats-util.h from shared/ to basic/

It's only a header file, definining format strings for basic system
types, hence it should be in src/basic/, not src/shared/.

2 years agologind: minor clean-ups
Lennart Poettering [Wed, 21 Oct 2015 17:36:22 +0000 (19:36 +0200)]
logind: minor clean-ups

2 years agobasic: parse_timestamp UTC and fractional seconds support
Hristo Venev [Wed, 14 Oct 2015 23:57:57 +0000 (02:57 +0300)]
basic: parse_timestamp UTC and fractional seconds support

2 years agologin: suspend - be a bit more explicit when logging
Tom Gundersen [Wed, 14 Oct 2015 20:22:17 +0000 (22:22 +0200)]
login: suspend - be a bit more explicit when logging

When the Suspend method is called, the only log message we write
(unless debugging is enabled) is "Operation finished.". This is
not very helpful when trying to figure out what is going on, so
add what operation we are talking about to the message:
"Operation 'sleep' finished.".

Hat tip to Daniel Aleksandersen for pointing this out.

2 years agosd-daemon: wipe out memory before using CMSG_NXTHDR()
Daniel Mack [Mon, 12 Oct 2015 12:44:26 +0000 (14:44 +0200)]
sd-daemon: wipe out memory before using CMSG_NXTHDR()

CMSG_NXTHDR() checks for cmsg->cmsg_len *after* it increased the pointer.
While this makes sense for parsing received messages, that's a pitfall
for code crafting messages with this macro.

Wipe out the allocated memory to fix this.

2 years agosd-daemon: simply code simplification
Lennart Poettering [Fri, 9 Oct 2015 15:17:28 +0000 (17:17 +0200)]
sd-daemon: simply code simplification

No change in behaviour, just make the code more obvious.

2 years agoutil: minor modernization of vt_disallocate()
Lennart Poettering [Thu, 8 Oct 2015 12:36:47 +0000 (14:36 +0200)]
util: minor modernization of vt_disallocate()

2 years agoutil: always enforce O_NOCTTY and O_CLOEXEC in openpt_in_namespace()
Lennart Poettering [Wed, 7 Oct 2015 18:08:49 +0000 (20:08 +0200)]
util: always enforce O_NOCTTY and O_CLOEXEC in openpt_in_namespace()

The child process is shortliving, hence always set O_NOCTTY so that the
tty doesn't quickly become controlling TTY and then gives it up again.
Also set O_CLOEXEC, because it's cleaner, and doesn't affect the parent

2 years agologin: fix re-use of users
David Herrmann [Tue, 29 Sep 2015 09:36:18 +0000 (11:36 +0200)]
login: fix re-use of users

If the last reference to a user is released, we queue stop-jobs for the
user-service and slice. Only once those are finished, we drop the
user-object. However, if a new session is opened before the user object is
fully dropped, we currently incorrectly re-use the object. This has the
effect, that we get stale sessions without a valid "elogind --user"

Fix this by properly allowing user_start() to be called, even if
user->stopping is true.

2 years agoVersion 227.4 v227.4
Sven Eden [Wed, 26 Apr 2017 10:52:55 +0000 (12:52 +0200)]
Version 227.4

2 years agoMerge pull request #9 from Gottox/fix-musl-ro-stdout
Sven Eden [Wed, 26 Apr 2017 10:47:42 +0000 (11:47 +0100)]
Merge pull request #9 from Gottox/fix-musl-ro-stdout

fix musl-libc for 227.2/227.3: do not change stderr/stdout variables.

2 years agodo not change stderr/stdout variables.
Enno Boland [Wed, 26 Apr 2017 09:02:13 +0000 (11:02 +0200)]
do not change stderr/stdout variables.

musl for example marks those variables as const and therefore
fails while building at this file.

2 years agoVersion 227.3 v227.3
Sven Eden [Wed, 26 Apr 2017 06:38:52 +0000 (08:38 +0200)]
Version 227.3

2 years Make -flto optimization optional
Sven Eden [Wed, 26 Apr 2017 06:38:14 +0000 (08:38 +0200)] Make -flto optimization optional

2 years agoMerge pull request #5 from elogind/dev_v227 v227.2
Sven Eden [Mon, 24 Apr 2017 07:57:58 +0000 (08:57 +0100)]
Merge pull request #5 from elogind/dev_v227

Candidate for next Version v227

2 years agoVersion 227.2
Sven Eden [Wed, 12 Apr 2017 10:43:44 +0000 (12:43 +0200)]
Version 227.2

2 years agoPrep v227: Add missing Makefile symlinks
Sven Eden [Wed, 12 Apr 2017 10:17:45 +0000 (12:17 +0200)]
Prep v227: Add missing Makefile symlinks

2 years agoPrep v227: Fix man page index building.
Sven Eden [Wed, 12 Apr 2017 06:25:04 +0000 (08:25 +0200)]
Prep v227: Fix man page index building.

2 years agoPrep v227: Removed src/shared/cgroup-show.[hc], it is not needed.
Sven Eden [Mon, 10 Apr 2017 09:25:07 +0000 (11:25 +0200)]
Prep v227: Removed src/shared/cgroup-show.[hc], it is not needed.

2 years agoPrep v227: Clean up some headers in src/systemd
Sven Eden [Sun, 9 Apr 2017 18:56:14 +0000 (20:56 +0200)]
Prep v227: Clean up some headers in src/systemd

- src/systemd/sd-bus.h
- src/systemd/sd-daemon.h
- src/systemd/sd-event.h

2 years agoPrep v227: Clean up various *-util.[hc] files
Sven Eden [Sun, 9 Apr 2017 12:14:36 +0000 (14:14 +0200)]
Prep v227: Clean up various *-util.[hc] files

- src/basic/cgroup-util.[hc]
- src/basic/memfd-util.[hc]
- src/basic/path-util.[hc]
- src/basic/process-util.[hc]
- src/basic/smack-util.[hc]

2 years agoAdd Code::Blocks project file
Sven Eden [Sun, 9 Apr 2017 12:04:20 +0000 (14:04 +0200)]
Add Code::Blocks project file

2 years agoFix assertion failure when resuming from sleep/suspend
Sven Eden [Tue, 4 Apr 2017 06:51:33 +0000 (08:51 +0200)]
Fix assertion failure when resuming from sleep/suspend

2 years agoUpdate Build files
Sven Eden [Tue, 21 Mar 2017 17:05:54 +0000 (18:05 +0100)]
Update Build files

2 years ago[5/5] Apply missing fixes from upstream
Sven Eden [Wed, 29 Mar 2017 08:06:43 +0000 (10:06 +0200)]
[5/5] Apply missing fixes from upstream

2 years ago[4/5] Apply missing fixes from upstream
Sven Eden [Wed, 29 Mar 2017 08:06:29 +0000 (10:06 +0200)]
[4/5] Apply missing fixes from upstream

2 years ago[3/5] Apply missing fixes from upstream
Sven Eden [Wed, 29 Mar 2017 08:06:16 +0000 (10:06 +0200)]
[3/5] Apply missing fixes from upstream

2 years ago[2/5] Apply missing fixes from upstream
Sven Eden [Wed, 29 Mar 2017 08:05:50 +0000 (10:05 +0200)]
[2/5] Apply missing fixes from upstream

2 years ago[1/5] Apply missing fixes from upstream
Sven Eden [Wed, 29 Mar 2017 08:05:39 +0000 (10:05 +0200)]
[1/5] Apply missing fixes from upstream

2 years agopo files: Update to upstream and some cleanup.
Марко М. Костић (Marko M. Kostić) [Sat, 3 Oct 2015 20:07:29 +0000 (22:07 +0200)]
po files: Update to upstream and some cleanup.

2 years agomissing.h : add bridge params
Susant Sahani [Mon, 5 Oct 2015 04:05:36 +0000 (09:35 +0530)]
missing.h : add bridge params

2 years agosiphash24: expose the internal helper functions
Tom Gundersen [Sat, 3 Oct 2015 22:23:25 +0000 (00:23 +0200)]
siphash24: expose the internal helper functions

2 years agosiphash24: make siphash24_compress decomposable
Tom Gundersen [Sat, 3 Oct 2015 20:21:44 +0000 (22:21 +0200)]
siphash24: make siphash24_compress decomposable

This allows the input to siphash24_compress to be decomposed into
smaller chunks and the function to be called on each individual

2 years agosiphash24: move last compression iteration from compression step to finalization...
Tom Gundersen [Sat, 3 Oct 2015 19:27:25 +0000 (21:27 +0200)]
siphash24: move last compression iteration from compression step to finalization step

The last compression is special as it deals with the length byte, and padding. Move
it to the finalization step in preparation for making compression decomposable.

2 years agosiphash24: split out the compression step
Tom Gundersen [Sat, 3 Oct 2015 18:21:01 +0000 (20:21 +0200)]
siphash24: split out the compression step

2 years agosiphash24: split out the finalization step
Tom Gundersen [Sat, 3 Oct 2015 18:14:18 +0000 (20:14 +0200)]
siphash24: split out the finalization step

2 years agosiphash24: introduce state struct
Tom Gundersen [Sat, 3 Oct 2015 18:09:43 +0000 (20:09 +0200)]
siphash24: introduce state struct

Encapsulate the four state variables in a struct so we can more easily pass
them around.

2 years agolog: properly return -EINVAL from log_set_max_level_from_string()
Lennart Poettering [Wed, 30 Sep 2015 12:16:40 +0000 (14:16 +0200)]
log: properly return -EINVAL from log_set_max_level_from_string()

If we just return the value we got from log_level_from_string() on
failure we'll return -1, which is not a proper error code.

log_set_target_from_string() did get this right already, hence let's fix
this here too.

2 years agosd-event: don't provide priority stability
David Herrmann [Tue, 29 Sep 2015 18:56:17 +0000 (20:56 +0200)]
sd-event: don't provide priority stability

Currently, we guarantee that if two event-sources with the same priority
fire at the same time, they're always dispatched in the same order. While
this might sound nice in theory, there's is little benefit in providing
stability on that level. We have no control over the order the events are
reported, hence, we cannot guarantee that we get notified about both at
the same time.

By dropping the stability guarantee, we loose roughly 10% Heap swaps in
the prioq on a desktop cold-boot. Krzysztof Kotlenga even reported up to
20% on his tests. This sounds worth optimizing, so drop the stability

2 years agoprioq: never shuffle identical entries
David Herrmann [Tue, 29 Sep 2015 18:41:29 +0000 (20:41 +0200)]
prioq: never shuffle identical entries

Skip shuffling identical entries in shuffle_up(), just like we already do
in shuffle_down().

2 years agosd-event: fix prepare priority queue comparison function
Krzysztof Kotlenga [Wed, 23 Sep 2015 22:34:51 +0000 (00:34 +0200)]
sd-event: fix prepare priority queue comparison function

Otherwise a disabled event source can get swapped with an enabled one
and cause a severe sd-event malfunction.

2 years agomising: add __NR_memfd_create syscall number for s390
Hendrik Brueckner [Wed, 23 Sep 2015 11:42:56 +0000 (13:42 +0200)]
mising: add __NR_memfd_create syscall number for s390

2 years agobuild-sys: properly quote m4 macro arguments in CC_CHECK_FLAGS_APPEND
Filipe Brandenburger [Tue, 22 Sep 2015 16:41:32 +0000 (09:41 -0700)]
build-sys: properly quote m4 macro arguments in CC_CHECK_FLAGS_APPEND

The variables should be quoted inside [...] to avoid double macro
expansion.  This is currently not an issue, since the values (-W...) are
not really macros, but we might as well just fix that issue now.

Tested by re-running and comparing the value of OUR_CFLAGS in
the generated Makefile.  Ran a full build from a clean tree to confirm
no other issues were introduced.

2 years agomount: propagate error codes correctly
David Herrmann [Mon, 21 Sep 2015 17:59:07 +0000 (19:59 +0200)]
mount: propagate error codes correctly

Make sure to propagate error codes from mount-loops correctly. Right now,
we return the return-code of the first mount that did _something_. This is
not what we want. Make sure we return an error if _any_ mount fails (and
then make sure to return the first error to not hide proper errors due to
consequential errors like -ENOTDIR).

Reported by cee1 <>.

2 years agoutil: clean-ups to enum parsers
Lennart Poettering [Fri, 18 Sep 2015 22:50:34 +0000 (00:50 +0200)]
util: clean-ups to enum parsers

Never log when we fail due to OOM when translating enums, let the caller
do that. Translating basic types like enums should be something where
the caller logs, not the translatior functions.

Return -1 when NULL is passed to all enum parser functions.

The non-fallback versions of the enum translator calls already handle
NULL as failure, instead of hitting an assert, and we should do this
here, too.

2 years agoutil: minor cleanups for loop_read() and friends
Lennart Poettering [Fri, 18 Sep 2015 22:47:08 +0000 (00:47 +0200)]
util: minor cleanups for loop_read() and friends

When 0 bytes are to be written, make sure to go into read() at least
once, in order to validate the parameters, such as the passed fd.

Return error on huge values, add a couple of asserts and casts where

2 years agopam: elogind-user - call selinux module
Kay Sievers [Thu, 17 Sep 2015 15:15:28 +0000 (17:15 +0200)]
pam: elogind-user - call selinux module

2 years agosd-id128: make size constraints a bit more obvious
Lennart Poettering [Wed, 16 Sep 2015 23:22:10 +0000 (01:22 +0200)]
sd-id128: make size constraints a bit more obvious

2 years agosd-bus: correct size calculation in DBus fd receive
Michal Schmidt [Wed, 16 Sep 2015 20:55:02 +0000 (22:55 +0200)]
sd-bus: correct size calculation in DBus fd receive

The size of the allocated array for received file descriptors was
incorrectly calculated. This did not matter when a single file
descriptor was received, but for more descriptors the allocation was

2 years agoAdd fallback for kcmp() in case __NR_kcmp is undefined
Mike Gilbert [Mon, 14 Sep 2015 22:55:09 +0000 (18:55 -0400)]
Add fallback for kcmp() in case __NR_kcmp is undefined

IA64 is missing this syscall as of linux-4.2.
This works around it until the necessary kernel patch gets merged.