Fix --no-ask-password

POSIX_ME_HARDER mode is disabled for localectl. It doesn't
make much sense in case of localectl, and there's little reason
for localectl to behave specially.

diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index 7acd77295ddda5c6d73ac6048bf724238093af9d..d108a2489dfee175c3a3e2a747af1c5db763d97c 100644 (file)
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -219,7 +219,7 @@ static int show_status(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_hostname(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_hostname(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t interactive = true;
+        dbus_bool_t interactive = arg_ask_password;

         _cleanup_free_ char *h = NULL;
         const char *hostname = args[1];
         int r;
         _cleanup_free_ char *h = NULL;
         const char *hostname = args[1];
         int r;


@@ -311,7 +311,7 @@ static int set_hostname(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_icon_name(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_icon_name(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t interactive = true;
+        dbus_bool_t interactive = arg_ask_password;

 
         assert(args);
         assert(n == 2);
 
         assert(args);
         assert(n == 2);


@@ -333,7 +333,7 @@ static int set_icon_name(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_chassis(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_chassis(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t interactive = true;
+        dbus_bool_t interactive = arg_ask_password;

 
         assert(args);
         assert(n == 2);
 
         assert(args);
         assert(n == 2);

diff --git a/src/locale/localectl.c b/src/locale/localectl.c
index 3096d060842d440ce9a7112a36dc1ea8a51d5128..b5cd344397c859d5b92555ca26d161898cefd9df 100644 (file)
--- a/src/locale/localectl.c
+++ b/src/locale/localectl.c
@@ -223,7 +223,7 @@ static int show_status(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_locale(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *m = NULL, *reply = NULL;
 
 static int set_locale(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *m = NULL, *reply = NULL;

-        dbus_bool_t interactive = true;
+        dbus_bool_t interactive = arg_ask_password;

         DBusError error;
         DBusMessageIter iter;
         int r;
         DBusError error;
         DBusMessageIter iter;
         int r;


@@ -459,7 +459,7 @@ static int list_locales(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_vconsole_keymap(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_vconsole_keymap(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t interactive = true, b;
+        dbus_bool_t interactive = arg_ask_password, b;

         const char *map, *toggle_map;
 
         assert(bus);
         const char *map, *toggle_map;
 
         assert(bus);


@@ -565,7 +565,7 @@ static int list_vconsole_keymaps(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_x11_keymap(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_x11_keymap(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t interactive = true, b;
+        dbus_bool_t interactive = arg_ask_password, b;

         const char *layout, *model, *variant, *options;
 
         assert(bus);
         const char *layout, *model, *variant, *options;
 
         assert(bus);


@@ -758,7 +758,7 @@ static int parse_argv(int argc, char *argv[]) {
         assert(argc >= 0);
         assert(argv);
 
         assert(argc >= 0);
         assert(argv);
 

-        while ((c = getopt_long(argc, argv, "has:H:P", options, NULL)) >= 0) {
+        while ((c = getopt_long(argc, argv, "hH:P", options, NULL)) >= 0) {

 
                 switch (c) {
 
 
                 switch (c) {
 


@@ -788,6 +788,10 @@ static int parse_argv(int argc, char *argv[]) {
                         arg_no_pager = true;
                         break;
 
                         arg_no_pager = true;
                         break;
 

+                case ARG_NO_ASK_PASSWORD:
+                        arg_ask_password = false;
+                        break;
+

                 case '?':
                         return -EINVAL;
 
                 case '?':
                         return -EINVAL;
 

diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c
index be3b8b4da303290e2398cd99421f9ba3195e47c2..e8bc4529f365620d59cf7c6625a88ddeed4a389b 100644 (file)
--- a/src/timedate/timedatectl.c
+++ b/src/timedate/timedatectl.c
@@ -304,7 +304,7 @@ static int show_status(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_time(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_time(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t relative = false, interactive = true;
+        dbus_bool_t relative = false, interactive = arg_ask_password;

         usec_t t;
         dbus_int64_t u;
         int r;
         usec_t t;
         dbus_int64_t u;
         int r;


@@ -338,7 +338,7 @@ static int set_time(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_timezone(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_timezone(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t interactive = true;
+        dbus_bool_t interactive = arg_ask_password;

 
         assert(args);
         assert(n == 2);
 
         assert(args);
         assert(n == 2);


@@ -360,7 +360,7 @@ static int set_timezone(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_local_rtc(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_local_rtc(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t interactive = true, b, q;
+        dbus_bool_t interactive = arg_ask_password, b, q;

         int r;
 
         assert(args);
         int r;
 
         assert(args);


@@ -393,7 +393,7 @@ static int set_local_rtc(DBusConnection *bus, char **args, unsigned n) {
 
 static int set_ntp(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
 
 static int set_ntp(DBusConnection *bus, char **args, unsigned n) {
         _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;

-        dbus_bool_t interactive = true, b;
+        dbus_bool_t interactive = arg_ask_password, b;

         int r;
 
         assert(args);
         int r;
 
         assert(args);


@@ -541,7 +541,7 @@ static int parse_argv(int argc, char *argv[]) {
         assert(argc >= 0);
         assert(argv);
 
         assert(argc >= 0);
         assert(argv);
 

-        while ((c = getopt_long(argc, argv, "+hH:P", options, NULL)) >= 0) {
+        while ((c = getopt_long(argc, argv, "hH:P", options, NULL)) >= 0) {

 
                 switch (c) {
 
 
                 switch (c) {
 


@@ -563,6 +563,10 @@ static int parse_argv(int argc, char *argv[]) {
                         arg_host = optarg;
                         break;
 
                         arg_host = optarg;
                         break;
 

+                case ARG_NO_ASK_PASSWORD:
+                        arg_ask_password = false;
+                        break;
+

                 case ARG_ADJUST_SYSTEM_CLOCK:
                         arg_adjust_system_clock = true;
                         break;
                 case ARG_ADJUST_SYSTEM_CLOCK:
                         arg_adjust_system_clock = true;
                         break;