chiark / gitweb /
nspawn: reset supplementary and main group id before entering nspawn
authorLennart Poettering <lennart@poettering.net>
Wed, 21 Nov 2012 01:58:55 +0000 (02:58 +0100)
committerLennart Poettering <lennart@poettering.net>
Wed, 21 Nov 2012 23:45:22 +0000 (00:45 +0100)
TODO
src/nspawn/nspawn.c

diff --git a/TODO b/TODO
index 4a49f49..85b6e9b 100644 (file)
--- a/TODO
+++ b/TODO
@@ -180,8 +180,6 @@ Features:
 
 * nspawn: implement personality changes a la linux32(8)
 
-* nspawn: reset all aux groups
-
 * cryptsetup-generator: warn if the password files are world-readable
 
 * cryptsetup-generator: add RequiresMountsFor= to cryptseup service files referencing a file, similar for devices
index 244ebb8..59171ab 100644 (file)
@@ -1327,6 +1327,23 @@ int main(int argc, char *argv[]) {
                                         log_error("setreuid() failed: %m");
                                         goto child_fail;
                                 }
+                        } else {
+                                /* Reset everything fully to 0, just in case */
+
+                                if (setgroups(0, NULL) < 0) {
+                                        log_error("setgroups() failed: %m");
+                                        goto child_fail;
+                                }
+
+                                if (setresgid(0, 0, 0) < 0) {
+                                        log_error("setregid() failed: %m");
+                                        goto child_fail;
+                                }
+
+                                if (setresuid(0, 0, 0) < 0) {
+                                        log_error("setreuid() failed: %m");
+                                        goto child_fail;
+                                }
                         }
 
                         if ((asprintf((char**)(envp + 3), "HOME=%s", home ? home: "/root") < 0) ||