chiark / gitweb /
Note that do_help is used when short messages might be wanted
authormartin f. krafft <madduck@debian.org>
Thu, 20 Nov 2008 14:24:16 +0000 (15:24 +0100)
committermartin f. krafft <madduck@debian.org>
Thu, 20 Nov 2008 14:24:16 +0000 (15:24 +0100)
From http://marc.info/?l=git&m=122718711327376&w=2, by Petr:

  Note that I think these changes are reasonable only as long as do_help
  is just a short two-line usage help; in the event we also implement a
  longer help, it certainly shouldn't be printed in these cases.

This commit adds a comment to the do_help function to remind us.

Signed-off-by: martin f. krafft <madduck@debian.org>
tg.sh

diff --git a/tg.sh b/tg.sh
index 4020527..1fe0115 100644 (file)
--- a/tg.sh
+++ b/tg.sh
@@ -209,6 +209,12 @@ switch_to_base()
 do_help()
 {
        if [ -z "$1" ] ; then
+               # This is currently invoked in all kinds of circumstances,
+               # including when the user made a usage error. Should we end up
+               # providing more than a short help message, then we should
+               # differentiate.
+               # Petr's comment: http://marc.info/?l=git&m=122718711327376&w=2
+
                ## Build available commands list for help output
 
                cmds=