It should return zero on success or -1 on failure, because it's an
operation which attempts to return a value, and so might fail -- as
opposed to a predicate asking a simple boolean question about the world.
No actual harm done, because the code was correct to begin with, but
potentially confusing later.