Ask git about unmerged files

Don't look in the "conflicts" file for that, since it isn't updated. Also
added a test that the check_conflicts() function works.

Signed-off-by: David Kågedal <davidk@lysator.liu.se>
Signed-off-by: Karl Hasselström <kha@treskal.com>

diff --git a/stgit/commands/common.py b/stgit/commands/common.py
index 7cf700e157f29db11959ea986f2d282093ec30ed..1426aca69c6d8c2a77feeaf250f7fbe6cd3fda23 100644 (file)
--- a/stgit/commands/common.py
+++ b/stgit/commands/common.py
@@ -129,7 +129,7 @@ def check_head_top_equal(crt_series):
    more about what to do next.""")
 
 def check_conflicts():
    more about what to do next.""")
 
 def check_conflicts():

-    if os.path.exists(os.path.join(basedir.get(), 'conflicts')):
+    if git.get_conflicts():

         raise CmdException, \
               'Unsolved conflicts. Please resolve them first or\n' \
               '  revert the changes with "status --reset"'
         raise CmdException, \
               'Unsolved conflicts. Please resolve them first or\n' \
               '  revert the changes with "status --reset"'


@@ -164,10 +164,8 @@ def resolved(filename, reset = None):
 
 def resolved_all(reset = None):
     conflicts = git.get_conflicts()
 
 def resolved_all(reset = None):
     conflicts = git.get_conflicts()

-    if conflicts:
-        for filename in conflicts:
-            resolved(filename, reset)
-        os.remove(os.path.join(basedir.get(), 'conflicts'))
+    for filename in conflicts:
+        resolved(filename, reset)

 
 def push_patches(crt_series, patches, check_merged = False):
     """Push multiple patches onto the stack. This function is shared
 
 def push_patches(crt_series, patches, check_merged = False):
     """Push multiple patches onto the stack. This function is shared

diff --git a/stgit/git.py b/stgit/git.py
index 43ac204374dd7f85f380fd99c54c088e2b5fc660..6629e395ab5de48e26e5b50c06b870de2cc255f1 100644 (file)
--- a/stgit/git.py
+++ b/stgit/git.py
@@ -162,14 +162,14 @@ def get_commit(id_hash):
 def get_conflicts():
     """Return the list of file conflicts
     """
 def get_conflicts():
     """Return the list of file conflicts
     """

-    conflicts_file = os.path.join(basedir.get(), 'conflicts')
-    if os.path.isfile(conflicts_file):
-        f = file(conflicts_file)
-        names = [line.strip() for line in f.readlines()]
-        f.close()
-        return names
-    else:
-        return None
+    names = []
+    for line in GRun('ls-files', '-z', '--unmerged'
+                     ).raw_output().split('\0')[:-1]:
+        stat, path = line.split('\t', 1)
+        # Look for entries in stage 2 (could equally well use 3)
+        if stat.endswith(' 2'):
+            names.append(path)
+    return names

 
 def exclude_files():
     files = [os.path.join(basedir.get(), 'info', 'exclude')]
 
 def exclude_files():
     files = [os.path.join(basedir.get(), 'info', 'exclude')]


@@ -234,8 +234,6 @@ def tree_status(files = None, tree_id = 'HEAD', unknown = False,
 
     # conflicted files
     conflicts = get_conflicts()
 
     # conflicted files
     conflicts = get_conflicts()

-    if not conflicts:
-        conflicts = []

     cache_files += [('C', filename) for filename in conflicts
                     if not files or filename in files]
     reported_files = set(conflicts)
     cache_files += [('C', filename) for filename in conflicts
                     if not files or filename in files]
     reported_files = set(conflicts)

diff --git a/t/t0002-status.sh b/t/t0002-status.sh
index 24f42cc98d7ad6c5dfc130fd8566db5cb16edb05..32c01d020ffebe00db2666e610bf20d02e5a2487 100755 (executable)
--- a/t/t0002-status.sh
+++ b/t/t0002-status.sh
@@ -110,7 +110,7 @@ cat > expected.txt <<EOF
 A fie
 C foo/bar
 EOF
 A fie
 C foo/bar
 EOF

-test_expect_failure 'Status after conflicting push' '
+test_expect_success 'Status after conflicting push' '

     ! stg push &&
     stg status > output.txt &&
     diff -u expected.txt output.txt
     ! stg push &&
     stg status > output.txt &&
     diff -u expected.txt output.txt


@@ -119,7 +119,7 @@ test_expect_failure 'Status after conflicting push' '
 cat > expected.txt <<EOF
 C foo/bar
 EOF
 cat > expected.txt <<EOF
 C foo/bar
 EOF

-test_expect_failure 'Status of file' '
+test_expect_success 'Status of file' '

     stg status foo/bar > output.txt &&
     diff -u expected.txt output.txt
 '
     stg status foo/bar > output.txt &&
     diff -u expected.txt output.txt
 '


@@ -127,7 +127,7 @@ test_expect_failure 'Status of file' '
 cat > expected.txt <<EOF
 C foo/bar
 EOF
 cat > expected.txt <<EOF
 C foo/bar
 EOF

-test_expect_failure 'Status of dir' '
+test_expect_success 'Status of dir' '

     stg status foo > output.txt &&
     diff -u expected.txt output.txt
 '
     stg status foo > output.txt &&
     diff -u expected.txt output.txt
 '


@@ -144,7 +144,7 @@ cat > expected.txt <<EOF
 A fie
 M foo/bar
 EOF
 A fie
 M foo/bar
 EOF

-test_expect_success 'Status after resolving the push' '
+test_expect_failure 'Status after resolving the push' '

     stg resolved -a &&
     stg status > output.txt &&
     diff -u expected.txt output.txt
     stg resolved -a &&
     stg status > output.txt &&
     diff -u expected.txt output.txt

diff --git a/t/t1203-push-conflict.sh b/t/t1203-push-conflict.sh
index f9537d9e599d7f4cf122ee0ae50ea4736598d9dc..57119ab0718915dcc05024b55ba4c3cd9924287f 100755 (executable)
--- a/t/t1203-push-conflict.sh
+++ b/t/t1203-push-conflict.sh
@@ -53,6 +53,12 @@ test_expect_success \
        git diff --cached --stat | grep -q -e "^ test2 | *1 "
        '
 
        git diff --cached --stat | grep -q -e "^ test2 | *1 "
        '
 

+test_expect_success \
+       'Check that pop will fail while there are unmerged conflicts' \
+       '
+       ! stg pop
+       '
+

 test_expect_success \
        'Resolve the conflict' \
        '
 test_expect_success \
        'Resolve the conflict' \
        '

diff --git a/t/t1205-push-subdir.sh b/t/t1205-push-subdir.sh
index 88b23c4d0f4caa6ef9e085c93d88f44d30ef4d67..54a5b896e199d8529e99fe994d30d5ee266e63f0 100755 (executable)
--- a/t/t1205-push-subdir.sh
+++ b/t/t1205-push-subdir.sh
@@ -42,7 +42,7 @@ test_expect_success 'Modifying push from a subdir' '
     [ "$(echo $(cat foo/y.txt))" = "y0 y1 y2" ]
 '
 
     [ "$(echo $(cat foo/y.txt))" = "y0 y1 y2" ]
 '
 

-test_expect_failure 'Conflicting push from subdir' '
+test_expect_success 'Conflicting push from subdir' '

     stg pop p1 p2 &&
     [ "$(echo $(cat x.txt))" = "x0" ] &&
     [ "$(echo $(cat foo/y.txt))" = "y0" ] &&
     stg pop p1 p2 &&
     [ "$(echo $(cat x.txt))" = "x0" ] &&
     [ "$(echo $(cat foo/y.txt))" = "y0" ] &&