mop: Implement a class which automatically defines a predicate.

I've found myself typing

  (defgeneric foop (thing)
    (:method (((thing foo)) t))
    (:method (((thing t)) nil)))

too many times.  Now I just put `(:predicate foop)' in the class
definition and forget about it.

diff --git a/mdw-mop.lisp b/mdw-mop.lisp
index dee8ca45b65f7c5f72099adf20fee756d640252d..0766e384cd7968e134a57efc06ffdf23b7d015a7 100644 (file)
--- a/mdw-mop.lisp
+++ b/mdw-mop.lisp
@@ -33,6 +33,7 @@ (defpackage #:mdw.mop
           #:filtered-slot-class-mixin
             #:filtered-direct-slot-definition
             #:filtered-effective-slot-definition
+          #:predicate-class-mixin
           #:abstract-class-mixin #:instantiate-abstract-class
           #:mdw-class #:abstract-class
           #:print-object-with-slots))
@@ -175,6 +176,40 @@ (defmethod (setf slot-value-using-class)
   (call-next-method (funcall (slot-definition-filter slot) value)
                    class object slot))
 
+;;;--------------------------------------------------------------------------
+;;; Predicates.
+
+(defclass predicate-class-mixin (compatible-class)
+  ((predicates :type list :initarg :predicate :initform nil
+              :documentation "Predicate generic function to create."))
+  (:documentation
+   "Class which can automatically generate a predicate generic function.
+    Adds the `:predicate' class option, which takes a single symbol argument
+    FUNC.  If specified, and non-nil, a generic function FUNC with one
+    argument will be defined (if it doesn't already exist) with a default
+    method returning nil, and a method added specialized on this class
+    returning a non-nil value."))
+
+(defmethod shared-initialize :after
+    ((class predicate-class-mixin) slot-names &key &allow-other-keys)
+  (declare (ignore slot-names))
+  (with-slots (predicates) class
+    (dolist (predicate predicates)
+      (let ((lambda-list '(thing)))
+       (let ((gf (if (fboundp predicate)
+                     (fdefinition predicate)
+                     (let ((gf (ensure-generic-function
+                                predicate :lambda-list lambda-list)))
+                       (add-method gf (make-instance
+                                       'standard-method
+                                       :specializers (list (find-class 't))
+                                       :lambda-list lambda-list
+                                       :function (constantly nil)))))))
+         (add-method gf (make-instance 'standard-method
+                                       :specializers (list class)
+                                       :lambda-list lambda-list
+                                       :function (constantly t))))))))
+
 ;;;--------------------------------------------------------------------------
 ;;; Abstract classes.
 
@@ -202,8 +237,14 @@ (defmethod make-instance ((class abstract-class-mixin) &rest whatever)
 ;;; Useful classes.
 
 (defclass mdw-class (filtered-slot-class-mixin
+                    predicate-class-mixin
                     compatible-class)
-  ())
+  ()
+  (:documentation
+   "A generally useful metaclass with handy features.  If I've done the
+    hacking right, there shouldn't be a significant cost to using this
+    metaclass for all your classes if you don't use any of its fancy
+    features."))
 
 (defclass abstract-class (mdw-class abstract-class-mixin) ())