chiark
/
gitweb
/
~mdw
/
catacomb
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cead42f
)
key/key-misc.c: Fix bogus parentheses in macro.
author
Mark Wooding
<mdw@distorted.org.uk>
Wed, 18 Sep 2019 17:35:34 +0000
(18:35 +0100)
committer
Mark Wooding
<mdw@distorted.org.uk>
Wed, 18 Sep 2019 17:35:34 +0000
(18:35 +0100)
The old, bogus behaviour was that it would report `KERR_READONLY' if the
keyring was neither open for writing, /nor/ modified. I think this is
relatively benign, but still well deserving of fixing.
Spotted by Clang.
key/key-misc.c
patch
|
blob
|
blame
|
history
diff --git
a/key/key-misc.c
b/key/key-misc.c
index 80e9597da4e33b81ebea47185c6dad606cbdf967..c3442f281cd86020c78c7c17a1c999a0d234fb70 100644
(file)
--- a/
key/key-misc.c
+++ b/
key/key-misc.c
@@
-42,7
+42,7
@@
/*----- Useful macros -----------------------------------------------------*/
#define KEY_WRITE(f) do { \
- if (!(
f)->f & KF_WRITE)
\
+ if (!(
(f)->f & KF_WRITE))
\
return (KERR_READONLY); \
} while (0)