chiark / gitweb /
polypath: Do not separately log xmit failures
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Thu, 24 Nov 2022 00:02:20 +0000 (00:02 +0000)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Thu, 5 Jan 2023 23:38:32 +0000 (23:38 +0000)
udp_sock_experienced handles the necessary logging.  We don't want a
log message per packet, even if they're errors.

Empirically, using a network speed test web page, over the same
network interface, can cause this to get EAGAIN and produce logspam.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
polypath.c

index 64284a30fa17f29225f4a5273b91853db03f5d1a..adac598b3505784f2a3065ad17e49fcb3a15c06f 100644 (file)
@@ -504,9 +504,6 @@ static void polypath_sendmsg_interf(struct polypath *st,
        }
        if (!(errno==EAFNOSUPPORT || errno==ENETUNREACH))
            reasonable=True;
-       lg_perror(LG,M_DEBUG,errno,"%s [%s] xmit %"PRIu32" bytes to %s",
-                 interf->name,iaddr_to_string(&us->addr),
-                 buf->size,iaddr_to_string(&dest->ia));
     }
     if (!wanted)
        return;