chiark / gitweb /
Increase wiki error detail length limit
authorDaniel Martí <mvdan@mvdan.cc>
Tue, 29 Sep 2015 19:51:11 +0000 (12:51 -0700)
committerDaniel Martí <mvdan@mvdan.cc>
Tue, 29 Sep 2015 19:51:11 +0000 (12:51 -0700)
8k is too small, e.g. when make -jN errors or when there are a lot of scanner
errors and warnings. 16k should be better. Also, use "[...]" to make it
obvious that the output is truncated.

fdroidserver/common.py

index 67885fd6791976db0aab496e2e5f9d3e25d90ccd..1c3ab8e4368e6bd7f41a2d6ed5819aa6d217a820 100644 (file)
@@ -1099,14 +1099,16 @@ class FDroidException(Exception):
         self.value = value
         self.detail = detail
 
+    def limit_size(detail):
+        if len(detail) < 16000:
+            return detail
+        return '[...]\n' + detail[-16000:]
+
     def get_wikitext(self):
         ret = repr(self.value) + "\n"
         if self.detail:
             ret += "=detail=\n"
-            ret += "<pre>\n"
-            txt = self.detail[-8192:] if len(self.detail) > 8192 else self.detail
-            ret += str(txt)
-            ret += "</pre>\n"
+            ret += "<pre>\n" + limit_size(self.detail) + "</pre>\n"
         return ret
 
     def __str__(self):