remove url-unsafe characters from "current version" symlink names

This prevents the URL from having ugly %20 stuff in the app name.

diff --git a/fdroidserver/update.py b/fdroidserver/update.py
index b96d860ef4cc0de06d9fde0c67ed4927af9c1c05..0339f4606fb1c4119d4cc53db3e48bf155be4e9c 100644 (file)
--- a/fdroidserver/update.py
+++ b/fdroidserver/update.py
@@ -868,7 +868,9 @@ def make_index(apps, sortedids, apks, repodir, archive, categories):
         if current_version_file is not None \
                 and config['make_current_version_link'] \
                 and repodir == 'repo':  # only create these
-            apklinkname = app[config['current_version_name_source']] + '.apk'
+            sanitized_name = re.sub('''[ '"&%?+=]''', '',
+                                    app[config['current_version_name_source']])
+            apklinkname = sanitized_name + '.apk'
             current_version_path = os.path.join(repodir, current_version_file)
             if os.path.exists(apklinkname):
                 os.remove(apklinkname)