lint: Improve UCM:Tags warning

If the vercode is higher than CVC, then we're probably only following stable
versions or something like that

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index ec4373dd6e547aae4e15a8b5a2e28902e749501a..90c5221e0896123c09ce96196480c3168111406c 100644 (file)
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -141,7 +141,8 @@ def main():
         # Potentially incorrect UCM
         if (curbuild and curbuild['commit']
                 and app['Update Check Mode'] == 'RepoManifest'
-                and curbuild['commit'] != 'unknown - see disabled'
+                and not curbuild['commit'].startswith('unknown')
+                and curbuild['vercode'] == app['Current Version Code']
                 and any(s in curbuild['commit'] for s in '.,_-/')):
             pwarn("Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % (
                 curbuild['commit'], app['Update Check Mode']))