chiark / gitweb /
makebuildserver: fix join() syntax error, it needs a list/tuple
authorHans-Christoph Steiner <hans@eds.org>
Thu, 7 Dec 2017 10:52:10 +0000 (11:52 +0100)
committerHans-Christoph Steiner <hans@eds.org>
Thu, 7 Dec 2017 10:52:52 +0000 (11:52 +0100)
If only there was a way to test this without taking hours to run...

fixes 964ef996a01ceac8d6735668f2c9fd9119512346

makebuildserver

index 744fef52a9acb18aab3775d279ef09a1d4830b7d..831eede3dc198c42e9d3ff75dddc579092b8fed8 100755 (executable)
@@ -553,12 +553,12 @@ def main():
         for d in ('.m2', '.gradle/caches', '.gradle/wrapper', '.pip_download_cache'):
             fullpath = os.path.join(os.getenv('HOME'), d)
             if os.path.isdir(fullpath):
-                ssh_command = ' '.join('ssh -i {0} -p {1}'.format(key, port),
-                                       '-o StrictHostKeyChecking=no',
-                                       '-o UserKnownHostsFile=/dev/null',
-                                       '-o LogLevel=FATAL',
-                                       '-o IdentitiesOnly=yes',
-                                       '-o PasswordAuthentication=no')
+                ssh_command = ' '.join(('ssh -i {0} -p {1}'.format(key, port),
+                                        '-o StrictHostKeyChecking=no',
+                                        '-o UserKnownHostsFile=/dev/null',
+                                        '-o LogLevel=FATAL',
+                                        '-o IdentitiesOnly=yes',
+                                        '-o PasswordAuthentication=no'))
                 # TODO vagrant 1.5+ provides `vagrant rsync`
                 run_via_vagrant_ssh(v, ['cd ~ && test -d', d, '|| mkdir -p', d])
                 subprocess.call(['rsync', '-axv', '--progress', '--delete', '-e',