chiark / gitweb /
9 years agologind: fix memory leak
Frederic Crozat [Fri, 4 May 2012 14:14:19 +0000 (16:14 +0200)]
logind: fix memory leak

9 years agoupdate TODO
Lennart Poettering [Mon, 7 May 2012 20:20:08 +0000 (22:20 +0200)]
update TODO

9 years agoUpdate TODO
Lennart Poettering [Mon, 7 May 2012 15:16:50 +0000 (17:16 +0200)]
Update TODO

9 years agoutil: split-out conf-file.[ch]
Kay Sievers [Mon, 7 May 2012 16:55:45 +0000 (18:55 +0200)]
util: split-out conf-file.[ch]

9 years agoudev: path_id - skip PCI-only-parents for block devices
Kay Sievers [Mon, 7 May 2012 16:47:58 +0000 (18:47 +0200)]
udev: path_id - skip PCI-only-parents for block devices

9 years agoudev: use conf_files_list() to search rules files
Kay Sievers [Mon, 7 May 2012 11:21:05 +0000 (13:21 +0200)]
udev: use conf_files_list() to search rules files

9 years agoconf_files_list(): split out conf_files_list_strv()
Kay Sievers [Mon, 7 May 2012 11:20:29 +0000 (13:20 +0200)]
conf_files_list(): split out conf_files_list_strv()

9 years agoconf_files_list(): files-add() - do not canonicalize file names
Kay Sievers [Mon, 7 May 2012 11:15:25 +0000 (13:15 +0200)]
conf_files_list(): files-add() - do not canonicalize file names

File names in /etc, /run, /usr/lib are sorted/overridden by basename.
Sorting things like "/dev/null" with the basename "null" in the hash
of config files breaks the ordering and the overriding logic.

9 years agologind: implement delay inhibitor locks in addition to block inhibitor locks
Lennart Poettering [Fri, 4 May 2012 22:34:48 +0000 (00:34 +0200)]
logind: implement delay inhibitor locks in addition to block inhibitor locks

This is useful to allow applications to synchronously save data before
the system is suspended or shut down.

9 years agoupdate TODO
Kay Sievers [Fri, 4 May 2012 17:06:07 +0000 (19:06 +0200)]
update TODO

9 years agoudev: fix the ENV{} blacklist logic
Kay Sievers [Fri, 4 May 2012 00:26:08 +0000 (02:26 +0200)]
udev: fix the ENV{} blacklist logic

9 years agosystemctl: fix typo
Lennart Poettering [Thu, 3 May 2012 23:02:32 +0000 (01:02 +0200)]
systemctl: fix typo

as Sergey Ptashnick pointed out we should write "poweroff" once instead
of "reboot" twice.

9 years agosystemd-analyze: add a --user option to support user instances
Patrick McCarty [Thu, 3 May 2012 20:42:45 +0000 (13:42 -0700)]
systemd-analyze: add a --user option to support user instances

9 years agoman: clarify _TRANSPORT
Shawn Landden [Thu, 3 May 2012 22:19:01 +0000 (15:19 -0700)]
man: clarify _TRANSPORT

"resp." where it was confuses reader that stdout and stderr might go to differn't places

9 years agoupdate TODO
Lennart Poettering [Thu, 3 May 2012 22:43:36 +0000 (00:43 +0200)]
update TODO

9 years agoreadahead: store inode numbers in pack file
Lennart Poettering [Thu, 3 May 2012 22:34:12 +0000 (00:34 +0200)]
readahead: store inode numbers in pack file

If the inode nr for each file is available in the pack file we can
easily detect replaced files (like they result from package upgrades)
which we can then skip to readahead.

9 years agounits: use OOMScoreAdjust= in the unit files to set OOM score adjust
Lennart Poettering [Thu, 3 May 2012 22:15:21 +0000 (00:15 +0200)]
units: use OOMScoreAdjust= in the unit files to set OOM score adjust

9 years agoreadhead: temporarily lower the kernel's read_ahead_kb setting while collecting
Lennart Poettering [Thu, 3 May 2012 22:13:20 +0000 (00:13 +0200)]
readhead: temporarily lower the kernel's read_ahead_kb setting while collecting

While collecting readahead data we want to know exactly what userspace
accesses unblurred by the kernel's read_ahead_kb. Hence lower this
during collection, and raise it afterwards.

This is mostly based on ideas and code by Auke Kok.

9 years agocgroup: fix alloca() misuse in cg_shorten_controllers()
Lennart Poettering [Thu, 3 May 2012 21:23:38 +0000 (23:23 +0200)]
cgroup: fix alloca() misuse in cg_shorten_controllers()

9 years agodbus: handle invalid enum values better
Lennart Poettering [Thu, 3 May 2012 21:06:19 +0000 (23:06 +0200)]
dbus: handle invalid enum values better

9 years agodbus: include unit name in JobNew/JobRemoved signals
Lennart Poettering [Thu, 3 May 2012 20:53:25 +0000 (22:53 +0200)]
dbus: include unit name in JobNew/JobRemoved signals

This breaks D-Bus interface slightly, but since the D-Bus API isn't
covered by the interface stability promise this should be OK.

9 years agoservice: explicitly remove control/ subcgroup after each control command
Lennart Poettering [Thu, 3 May 2012 19:54:44 +0000 (21:54 +0200)]
service: explicitly remove control/ subcgroup after each control command

The kernel will only notify us of cgroups running empty if no subcgroups
exist anymore. Hence make sure we don't leave our own control/ subcgroup
around longer than necessary.

9 years agosystemctl: allow 'systemctl reboot -ff' to succeed even without D-Bus
Lennart Poettering [Thu, 3 May 2012 14:29:15 +0000 (16:29 +0200)]
systemctl: allow 'systemctl reboot -ff' to succeed even without D-Bus

9 years agosystemctl: print a nice error message if an unprivileged user calls systemctl reboot -ff
Lennart Poettering [Thu, 3 May 2012 14:17:58 +0000 (16:17 +0200)]
systemctl: print a nice error message if an unprivileged user calls systemctl reboot -ff

9 years agosystemctl: get rid of arg_immediate and fold it into arg_force
Lennart Poettering [Thu, 3 May 2012 14:17:39 +0000 (16:17 +0200)]
systemctl: get rid of arg_immediate and fold it into arg_force

9 years agorc-local-generator: hook halt-local in based on generator too
Lennart Poettering [Thu, 3 May 2012 13:55:38 +0000 (15:55 +0200)]
rc-local-generator: hook halt-local in based on generator too

9 years agohwclock: add taint flag for non-local hwclock
Lennart Poettering [Thu, 3 May 2012 13:46:04 +0000 (15:46 +0200)]
hwclock: add taint flag for non-local hwclock

9 years agovconsole: fix some error messages
Lennart Poettering [Thu, 3 May 2012 13:10:09 +0000 (15:10 +0200)]
vconsole: fix some error messages

9 years agounits: explicit Type=dbus is now redundant
Lennart Poettering [Thu, 3 May 2012 12:48:35 +0000 (14:48 +0200)]
units: explicit Type=dbus is now redundant

9 years agoservice: default to Type=dbus if BusName= is specified
Lennart Poettering [Thu, 3 May 2012 12:46:29 +0000 (14:46 +0200)]
service: default to Type=dbus if BusName= is specified

9 years agoservice: warn if a dbus name is specified but the service type is not dbus
Lennart Poettering [Thu, 3 May 2012 12:42:49 +0000 (14:42 +0200)]
service: warn if a dbus name is specified but the service type is not dbus

9 years agovconsole: fix error messages
Lennart Poettering [Thu, 3 May 2012 00:28:26 +0000 (02:28 +0200)]
vconsole: fix error messages

9 years agoupdate TODO
Lennart Poettering [Thu, 3 May 2012 00:25:49 +0000 (02:25 +0200)]
update TODO

9 years agoman: fix typo
Kay Sievers [Mon, 30 Apr 2012 13:30:57 +0000 (15:30 +0200)]
man: fix typo

9 years agounits: make sure /var is writable before initializing random seed
Lennart Poettering [Mon, 30 Apr 2012 08:56:46 +0000 (10:56 +0200)]
units: make sure /var is writable before initializing random seed

9 years agoTODO
Lennart Poettering [Mon, 30 Apr 2012 08:49:39 +0000 (10:49 +0200)]

9 years agounit: add new dependency type RequiresMountsFor=
Lennart Poettering [Sun, 29 Apr 2012 12:26:07 +0000 (14:26 +0200)]
unit: add new dependency type RequiresMountsFor=

RequiresMountsFor= is a shortcut for adding requires and after
dependencies to all mount units neeed for the specified paths.

This solves a couple of issues regarding dep loop cycles for encrypted

9 years agoservice: document new Type=idle
Lennart Poettering [Thu, 26 Apr 2012 18:32:26 +0000 (20:32 +0200)]
service: document new Type=idle

9 years agoupdate TODO
Lennart Poettering [Thu, 26 Apr 2012 18:32:07 +0000 (20:32 +0200)]
update TODO

9 years agoupdate TODO
Kay Sievers [Sun, 29 Apr 2012 22:46:38 +0000 (00:46 +0200)]
update TODO

9 years agoudev: use container_of() macro
Lucas De Marchi [Thu, 26 Apr 2012 16:36:02 +0000 (13:36 -0300)]
udev: use container_of() macro

9 years agoutil: introduce container_of() macro
Lucas De Marchi [Thu, 26 Apr 2012 16:36:01 +0000 (13:36 -0300)]
util: introduce container_of() macro

This macro comes from kernel and it's useful for unwrapping structs
inside another one. The generated code is actually the same to the one
where this logic is used in udev, but using this macro is much cleaner
and less error prone.

9 years agolibudev: prefix log macros with 'udev_'
Kay Sievers [Thu, 26 Apr 2012 15:43:48 +0000 (17:43 +0200)]
libudev: prefix log macros with 'udev_'

9 years agoupdate TODO
Kay Sievers [Thu, 26 Apr 2012 00:03:31 +0000 (02:03 +0200)]
update TODO

9 years agoudev: use only oom_score_adj interface
Kay Sievers [Wed, 25 Apr 2012 23:49:15 +0000 (01:49 +0200)]
udev: use only oom_score_adj interface

9 years agoudev: docs - it's 'GUdev'
Kay Sievers [Wed, 25 Apr 2012 23:48:24 +0000 (01:48 +0200)]
udev: docs - it's 'GUdev'

9 years agocore: add NOP jobs, job type collapsing
Michal Schmidt [Wed, 25 Apr 2012 09:58:27 +0000 (11:58 +0200)]
core: add NOP jobs, job type collapsing

Two of our current job types are special:

They differ from other job types by being sensitive to the unit active state.
They perform some action when the unit is active and some other action
otherwise. This raises a question: when exactly should the unit state be
checked to make the decision?

Currently the unit state is checked when the job becomes runnable. It's more
sensible to check the state immediately when the job is added by the user.
When the user types "systemctl try-restart foo.service", he really intends
to restart the service if it's running right now. If it isn't running right
now, the restart is pointless.

Consider the example (from Bugzilla[1]):

sleep.service takes some time to start.
hello.service has After=sleep.service.
Both services get started. Two jobs will appear:
 hello.service/start  waiting
 sleep.service/start  running
Then someone runs "systemctl try-restart hello.service".

Currently the try-restart operation will block and wait for
sleep.service/start to complete.

The correct result is to complete the try-restart operation immediately
with success, because hello.service is not running. The two original
jobs must not be disturbed by this.

To fix this we introduce two new concepts:
- a new job type: JOB_NOP
  A JOB_NOP job does not do anything to the unit. It does not pull in any
  dependencies. It is always immediately runnable. When installed to a unit,
  it sits in a special slot (u->nop_job) where it never conflicts with
  the installed job (u->job) of a different type. It never merges with jobs
  of other types, but it can merge into an already installed JOB_NOP job.

- "collapsing" of job types
  When a job of one of the two special types is added, the state of the unit
  is checked immediately and the job type changes:
  Should a job type JOB_RELOAD_OR_START appear later during job merging, it
  collapses immediately afterwards.
  Collapsing actually makes some things simpler, because there are now fewer
  job types that are allowed in the transaction.

[1] Fixes:

9 years agotimedated: introduce which is controlled by timedated...
Lennart Poettering [Wed, 25 Apr 2012 14:49:02 +0000 (16:49 +0200)]
timedated: introduce which is controlled by timedated's NTP setting

We shouldn't hardcode the name of the NTP implementation in the
timedated mechanism, especially since Fedora currently switched from NTP
to chrony.

This patch introduces a new target that is enabled/disabled instead of
the actual NTP implementation. The various NTP implementations should
then add .wants/ symlinks to their services and BindTo back to the
target, so that their implementations are started/stopped jointly with
the target.

9 years agonspawn: add --read-only switch
Lennart Poettering [Wed, 25 Apr 2012 13:11:20 +0000 (15:11 +0200)]
nspawn: add --read-only switch

9 years agonspawn: bind mount /etc/resolv.conf from the host by default
Lennart Poettering [Wed, 25 Apr 2012 13:08:00 +0000 (15:08 +0200)]
nspawn: bind mount /etc/resolv.conf from the host by default

9 years agoshutdown: don't complain if we cannot lock memory, to make container shutdowns clean
Lennart Poettering [Tue, 24 Apr 2012 14:56:06 +0000 (16:56 +0200)]
shutdown: don't complain if we cannot lock memory, to make container shutdowns clean

9 years agoremount: consolidate remount-api-vfs and remount-rootfs into one
Lennart Poettering [Tue, 24 Apr 2012 14:42:42 +0000 (16:42 +0200)]
remount: consolidate remount-api-vfs and remount-rootfs into one

This has the advantage of removing a confusing warning by mount if the
root directory is not listed in fstab.

9 years agoupdate TODO
Lennart Poettering [Tue, 24 Apr 2012 12:59:49 +0000 (14:59 +0200)]
update TODO

9 years agoservice: introduce Type=idle and use it for gettys
Lennart Poettering [Tue, 24 Apr 2012 12:28:00 +0000 (14:28 +0200)]
service: introduce Type=idle and use it for gettys

Type=idle is much like Type=simple, however between the fork() and the
exec() in the child we wait until PID 1 informs us that no jobs are

This is mostly a cosmetic fix to make gettys appear only after all boot
output is finished and complete.

Note that this does not impact the normal job logic as we do not delay
the completion of any jobs. We just delay the invocation of the actual
binary, and only for services that otherwise would be of Type=simple.

9 years agomanager: drop MountAuto= and SwapAuto= options
Lennart Poettering [Tue, 24 Apr 2012 11:53:31 +0000 (13:53 +0200)]
manager: drop MountAuto= and SwapAuto= options

The ability to set MountAuto=no and SwapAuto=no was useful during the
adoption phase of systemd, so that distributions could stick to their
classic mount scripts a bit longer. It is about time to get rid of it

9 years agoman: rework nspawn man page to suggest yum --installroot instead of mock
Lennart Poettering [Tue, 24 Apr 2012 11:14:27 +0000 (13:14 +0200)]
man: rework nspawn man page to suggest yum --installroot instead of mock

9 years agoreadahead: rather than checking for virtualization in the C code, use ConditionVirtua...
Lennart Poettering [Tue, 24 Apr 2012 11:12:29 +0000 (13:12 +0200)]
readahead: rather than checking for virtualization in the C code, use ConditionVirtualization= in the unit

9 years agotransaction: cancel jobs non-recursively on isolate
Michal Schmidt [Tue, 24 Apr 2012 09:21:03 +0000 (11:21 +0200)]
transaction: cancel jobs non-recursively on isolate

Recursive cancellation of jobs would trigger OnFailure actions of
dependent jobs. This is not desirable when isolating.


9 years agojob: serialize jobs properly
Michal Schmidt [Sun, 22 Apr 2012 23:24:04 +0000 (01:24 +0200)]
job: serialize jobs properly

Jobs were not preserved correctly over a daemon-reload operation.
A systemctl process waiting for a job completion received a job removal
signal. The job itself changed its id. The job timeout started ticking all
over again.

This fixes the deficiencies.

9 years agotransaction: abort does not need to use recursive deletion
Michal Schmidt [Sun, 22 Apr 2012 08:54:58 +0000 (10:54 +0200)]
transaction: abort does not need to use recursive deletion

Recursion is unnecessary, because we're deleting all transaction jobs
anyway. And the recursive deletion produces debug messages that are
pointless in transaction abort.

9 years agotransaction: fix detection of cycles involving installed jobs
Michal Schmidt [Sun, 22 Apr 2012 00:09:04 +0000 (02:09 +0200)]
transaction: fix detection of cycles involving installed jobs

A transaction can be acyclic, but when it's added to installed jobs,
a cycle may result.

transaction_verify_order_one() attempts to detect these cases, but it
fails because the installed jobs often have the exact generation number
that makes them look as if they were walked already.

Fix it by resetting the generation numbers of all installed jobs before
detecting cycles.

An alternative fix could be to add the generation counter to the
Manager and use it instead of starting always from 1 in
transaction_activate(). But I prefer not having to worry about it
wrapping around.

9 years agotransaction: improve readability
Michal Schmidt [Sat, 21 Apr 2012 19:40:40 +0000 (21:40 +0200)]
transaction: improve readability

The functions looked complicated with the nested loops with breaks,
continues, and "while (again)".
Here using goto actually makes them easier to understand.

Also correcting the comment about redundant jobs.

9 years agoshutdown: don't try to shut down DM devices in a container
Lennart Poettering [Sun, 22 Apr 2012 13:50:52 +0000 (15:50 +0200)]
shutdown: don't try to shut down DM devices in a container

9 years agohostname: if there's already a hostname set when PID 1 is invoked, don't complain
Lennart Poettering [Sun, 22 Apr 2012 13:47:38 +0000 (15:47 +0200)]
hostname: if there's already a hostname set when PID 1 is invoked, don't complain

9 years agojob: the status messages are proper sentences, hence end them with a full stop
Lennart Poettering [Sun, 22 Apr 2012 13:39:26 +0000 (15:39 +0200)]
job: the status messages are proper sentences, hence end them with a full stop

9 years agounits: remount file systems only if /etc/fstab actually exists
Lennart Poettering [Sun, 22 Apr 2012 13:35:35 +0000 (15:35 +0200)]
units: remount file systems only if /etc/fstab actually exists

9 years agomount: don't fail if fstab doesn't exist
Lennart Poettering [Sun, 22 Apr 2012 13:33:43 +0000 (15:33 +0200)]
mount: don't fail if fstab doesn't exist

9 years agotransaction: downgrade warnings about masked units
Lennart Poettering [Sun, 22 Apr 2012 13:22:52 +0000 (15:22 +0200)]
transaction: downgrade warnings about masked units

9 years agotransaction: add missing emacs and license headers
Lennart Poettering [Sun, 22 Apr 2012 13:22:27 +0000 (15:22 +0200)]
transaction: add missing emacs and license headers

9 years agomachine-id: fix spelling
Lennart Poettering [Sun, 22 Apr 2012 13:07:35 +0000 (15:07 +0200)]
machine-id: fix spelling

9 years agoutil: unify getenv() logic for other PID
Lennart Poettering [Sun, 22 Apr 2012 12:48:46 +0000 (14:48 +0200)]
util: unify getenv() logic for other PID

9 years agonspawn: add --uuid= switch to allow setting the machine id for the container
Lennart Poettering [Sun, 22 Apr 2012 12:48:21 +0000 (14:48 +0200)]
nspawn: add --uuid= switch to allow setting the machine id for the container

9 years agounits: don't try to load kernel modules if CAP_SYS_MODULE is missing
Lennart Poettering [Sun, 22 Apr 2012 11:39:18 +0000 (13:39 +0200)]
units: don't try to load kernel modules if CAP_SYS_MODULE is missing

9 years agounits: skip root fsck if the root directory is writable
Lennart Poettering [Sun, 22 Apr 2012 11:38:46 +0000 (13:38 +0200)]
units: skip root fsck if the root directory is writable

9 years agonspawn: add -b switch to automatically look for an init binary
Lennart Poettering [Sun, 22 Apr 2012 11:37:24 +0000 (13:37 +0200)]
nspawn: add -b switch to automatically look for an init binary

9 years agodefault to v102 everywhere, instead of vt100, to synchronize with agetty
Lennart Poettering [Sun, 22 Apr 2012 00:45:39 +0000 (02:45 +0200)]
default to v102 everywhere, instead of vt100, to synchronize with agetty

9 years agologin: assing /dev/console logins to seat0
Lennart Poettering [Sun, 22 Apr 2012 00:30:13 +0000 (02:30 +0200)]
login: assing /dev/console logins to seat0

9 years agocontainer: spawn a getty instead of a sulogin in a container
Lennart Poettering [Sun, 22 Apr 2012 00:15:22 +0000 (02:15 +0200)]
container: spawn a getty instead of a sulogin in a container

9 years agologinctl: avoid segfault for kill-session and kill-user commands
Lennart Poettering [Sun, 22 Apr 2012 00:03:08 +0000 (02:03 +0200)]
loginctl: avoid segfault for kill-session and kill-user commands

As reported by Mantas Mikul─Śnas.

9 years agoutil: fix tty_is_vc_resolve() in a container where /sys/class/tty/console/active...
Lennart Poettering [Sat, 21 Apr 2012 23:59:11 +0000 (01:59 +0200)]
util: fix tty_is_vc_resolve() in a container where /sys/class/tty/console/active is misleading

9 years agolog: include syslog identifier in default log properties, to avoid comm truncation
Lennart Poettering [Sat, 21 Apr 2012 23:01:54 +0000 (01:01 +0200)]
log: include syslog identifier in default log properties, to avoid comm truncation

9 years agonspawn: be more careful when initializing the hostname from the directory name
Lennart Poettering [Sat, 21 Apr 2012 23:01:22 +0000 (01:01 +0200)]
nspawn: be more careful when initializing the hostname from the directory name

9 years agomount-setup: ignore common container bind mounts
Lennart Poettering [Sat, 21 Apr 2012 23:00:57 +0000 (01:00 +0200)]
mount-setup: ignore common container bind mounts

9 years agoupdate TODO
Lennart Poettering [Sat, 21 Apr 2012 22:32:27 +0000 (00:32 +0200)]
update TODO

9 years agonspawn: make /dev/kmsg unavailable in the container, but allow access to /proc/kmsg
Lennart Poettering [Sat, 21 Apr 2012 22:32:13 +0000 (00:32 +0200)]
nspawn: make /dev/kmsg unavailable in the container, but allow access to /proc/kmsg

9 years agowatchdog: fix default configuration fragment for watchdog
Lennart Poettering [Sat, 21 Apr 2012 13:47:38 +0000 (15:47 +0200)]
watchdog: fix default configuration fragment for watchdog

9 years agoman: doc-sync - properly delete no longer existing stuff on remote server
Kay Sievers [Fri, 20 Apr 2012 22:28:02 +0000 (00:28 +0200)]
man: doc-sync - properly delete no longer existing stuff on remote server

9 years agotransaction: add starting requirements for JOB_RESTART
Michal Schmidt [Fri, 20 Apr 2012 12:44:00 +0000 (14:44 +0200)]
transaction: add starting requirements for JOB_RESTART

While having a Requires= dependency between units, the dependency is started
automatically on "systemctl start", but it's not started on "systemctl

JOB_RESTART jobs did not pull the dependencies for starting into the

Note that the other bug noted in comment #2 has been fixed already by avoiding
the deletion of anchor jobs.

9 years agodbus-job: allow multiple bus clients
Michal Schmidt [Fri, 20 Apr 2012 10:28:31 +0000 (12:28 +0200)]
dbus-job: allow multiple bus clients

Merging of jobs can result in more than one client being interested in a job.

9 years agotransaction: remove checks for installed
Michal Schmidt [Fri, 20 Apr 2012 08:02:05 +0000 (10:02 +0200)]
transaction: remove checks for installed

Transactions cannot contain installed jobs anymore. Remove the now pointless

9 years agotransaction: rework merging with installed jobs
Michal Schmidt [Fri, 20 Apr 2012 07:38:43 +0000 (09:38 +0200)]
transaction: rework merging with installed jobs

Previously transactions could reference installed jobs. It made some issues
difficult to fix.

This sets new rules for jobs:
A job cannot be both a member of a transaction and installed. When jobs are
created, they are linked to a transaction. The whole transaction is constructed
(with merging of jobs within, etc.). When it's complete, all the jobs are
unlinked from it one by one and let to install themselves. It is during the
installation when merging with previously installed jobs (from older
transactions) is contemplated.

Merging with installed jobs has different rules than merging within a
 - An installed conflicting job gets cancelled. It cannot be simply deleted,
   because someone might be waiting for its completion on DBus.
 - An installed, but still waiting, job can be safely merged into.
 - An installed and running job can be tricky. For some job types it is safe to
   just merge. For the other types we merge anyway, but put the job back into
   JOB_WAITING to allow it to run again. This may be suboptimal, but it is not
   currently possible to have more than one installed job for a unit.

Note this also fixes a bug where the anchor job could be deleted during merging
within the transaction.

9 years agojob: separate job_install()
Michal Schmidt [Fri, 20 Apr 2012 00:04:01 +0000 (02:04 +0200)]
job: separate job_install()

Let the jobs install themselves.

9 years agotransaction: remove a couple of asserts
Michal Schmidt [Thu, 19 Apr 2012 21:56:26 +0000 (23:56 +0200)]
transaction: remove a couple of asserts

We already asserted these facts in the previous loop.

9 years agotransaction: remove the anchor link
Michal Schmidt [Fri, 20 Apr 2012 00:11:14 +0000 (02:11 +0200)]
transaction: remove the anchor link

tr->anchor_job is sufficient.

9 years agotransaction: avoid garbage collecting the anchor job
Michal Schmidt [Fri, 20 Apr 2012 00:48:24 +0000 (02:48 +0200)]
transaction: avoid garbage collecting the anchor job

Make sure the anchor job is never considered garbage, even if it has no links
leading to it (this will be allowed in the next patch).

9 years agotransaction: simplify transaction_find_jobs_that_matter_to_anchor()
Michal Schmidt [Thu, 19 Apr 2012 23:20:14 +0000 (01:20 +0200)]
transaction: simplify transaction_find_jobs_that_matter_to_anchor()

9 years agotransaction: change the linking of isolate jobs to the anchor
Michal Schmidt [Fri, 20 Apr 2012 08:33:37 +0000 (10:33 +0200)]
transaction: change the linking of isolate jobs to the anchor

When isolating, the JOB_STOP jobs have no parent job, so they are all peers
of the real anchor job. This is a bit odd.

Link them from the anchor job.

9 years agotransaction: maintain anchor_job
Michal Schmidt [Thu, 19 Apr 2012 22:33:26 +0000 (00:33 +0200)]
transaction: maintain anchor_job

Track which job is the anchor in the transaction.

9 years agotransaction: do not add installed jobs to the transaction
Michal Schmidt [Wed, 18 Apr 2012 16:15:49 +0000 (18:15 +0200)]
transaction: do not add installed jobs to the transaction

Do not attempt to optimize away the job creation by refering to installed jobs.
We do not want to disturb installed jobs until commiting the transaction.

(A later patch to job merging will make the separation of transaction jobs and
installed jobs complete.)

9 years agojob: jobs shouldn't need to know about transaction anchors
Michal Schmidt [Wed, 18 Apr 2012 13:21:24 +0000 (15:21 +0200)]
job: jobs shouldn't need to know about transaction anchors

Let the transactions maintain their own anchor links.