chiark / gitweb /
9 years agoshared: inline trivial auto-cleanup functions
Michal Schmidt [Wed, 6 Mar 2013 13:44:51 +0000 (14:44 +0100)]
shared: inline trivial auto-cleanup functions

9 years agoshared: remove pointless checks in auto-cleanup functions
Michal Schmidt [Wed, 6 Mar 2013 13:17:59 +0000 (14:17 +0100)]
shared: remove pointless checks in auto-cleanup functions

The argument given to the __attribute__((cleanup)) functions is the
address of the variable that's going out of scope. It cannot be NULL.
The "if (!s)" check in set_freep() is pointless.

Perhaps "if (!*s)" was intented. But that's pointless too, because
set_free()/set_free_free() are OK to call with a NULL argument (just
like free()).

Setting "*s = NULL" is pointless, because the variable that s points
to is about to go out of scope.

The same holds for strv_freep().

9 years agoupdate TODO
Lennart Poettering [Thu, 7 Mar 2013 12:39:57 +0000 (13:39 +0100)]
update TODO

9 years agotest-util: add more tests
Thomas Hindoe Paaboel Andersen [Thu, 7 Mar 2013 21:45:22 +0000 (22:45 +0100)]
test-util: add more tests

Improve test coverage a bit with tests for
  strappend (to cover all ways through strnappend)

9 years agocore: if we cannot JOB_ISOLATE the default target JOB_REPLACE it instead v198
Lennart Poettering [Thu, 7 Mar 2013 21:18:34 +0000 (22:18 +0100)]
core: if we cannot JOB_ISOLATE the default target JOB_REPLACE it instead

In order to maintain compatibility with older initrds which do not have
AllowIsolate=yes set for their target units, fallback to JOB_REPLACE if
JOB_ISOLATE doesn't work, but complain about it.

9 years agobuild-sys: bump release and sonames
Lennart Poettering [Thu, 7 Mar 2013 20:53:53 +0000 (21:53 +0100)]
build-sys: bump release and sonames

9 years agojournalctl: imply -n1000 when -e is used
Lennart Poettering [Thu, 7 Mar 2013 20:49:12 +0000 (21:49 +0100)]
journalctl: imply -n1000 when -e is used

Make sure the pager does not have to buffer an unbounded number of log
messages, by default.

9 years agoupdate TODO
Lennart Poettering [Thu, 7 Mar 2013 20:48:17 +0000 (21:48 +0100)]
update TODO

9 years agopager: add -M to $LESS to make the bottom line nicer
Lennart Poettering [Thu, 7 Mar 2013 20:42:25 +0000 (21:42 +0100)]
pager: add -M to $LESS to make the bottom line nicer

9 years agoRevert "bootchart: use _cleanup_close_"
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 20:28:03 +0000 (15:28 -0500)]
Revert "bootchart: use _cleanup_close_"

This reverts commit 0ea9530d401827e299c6e04a433e69a7a2a89d80.

attribute(cleanup) can only be used inside functions (*of, sysfd
are leaked).

Cleanup functions are only called once when exiting scope (*f
is leaked twice).

9 years agosystemd-python: fix segfault on double close
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 20:32:33 +0000 (15:32 -0500)]
systemd-python: fix segfault on double close

9 years agosystemd-python: fix typos
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 20:27:30 +0000 (15:27 -0500)]
systemd-python: fix typos

9 years agoman/*.html: link to directives, python, guvev, libudev in headers
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 18:13:44 +0000 (13:13 -0500)]
man/*.html: link to directives, python, guvev, libudev in headers

Since the HTML files are in different directories during build
and on fd.o, links are broken in the build directory. This could
be fixed by moving stuff around, or by modifying the files during
upload, but I think that people do not usually create HTML files
for local browsing, and this is not necessary.

9 years agobuild-sys: move sphinx output to docs/python-systemd
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 19:42:27 +0000 (14:42 -0500)]
build-sys: move sphinx output to docs/python-systemd

And on fd.o it goes into a dir parallel to man/.

9 years agopager: always override LESS
Lennart Poettering [Thu, 7 Mar 2013 20:28:09 +0000 (21:28 +0100)]
pager: always override LESS

Primary reason to do this is to ensure "-e" works as intended, and is
not ignored because the user set his own LESS variable.

9 years agoUpdate NEWS
Lennart Poettering [Thu, 7 Mar 2013 20:28:05 +0000 (21:28 +0100)]
Update NEWS

9 years agopager: introduce "jump to end" option
Harald Hoyer [Thu, 7 Mar 2013 19:44:35 +0000 (20:44 +0100)]
pager: introduce "jump to end" option

$ journalctl -be

is what you want :)

9 years agoupdate NEWS
Lennart Poettering [Thu, 7 Mar 2013 20:08:04 +0000 (21:08 +0100)]
update NEWS

9 years agoNEWS: update
Kay Sievers [Thu, 7 Mar 2013 20:07:52 +0000 (21:07 +0100)]
NEWS: update

<mbiebl> "this allows resetting" <- I was told this is not correct English, too: "this allows one to reset"
<notting> "adds the ability to reset"?

9 years ago<mbiebl> poettering: small typo in the NEWS file: directory systems looks for <-...
Kay Sievers [Thu, 7 Mar 2013 20:04:30 +0000 (21:04 +0100)]
<mbiebl> poettering: small typo in the NEWS file: directory systems looks for <- systemd
<mbiebl> the sentence reads a bit strange "looks for units in"
<mbiebl> " by assigning the empty strings to them" <- an empty string or the empty string
<mbiebl> "this allows resetting" <- I was told this is not correct English, too: "this allows one to reset"

9 years agoupdate TODO
Lennart Poettering [Thu, 7 Mar 2013 19:46:35 +0000 (20:46 +0100)]
update TODO

9 years agoupdate NEWS
Lennart Poettering [Thu, 7 Mar 2013 19:46:27 +0000 (20:46 +0100)]
update NEWS

9 years agobootchart: use _cleanup_close_
Nathaniel Chen [Thu, 7 Mar 2013 19:09:16 +0000 (11:09 -0800)]
bootchart: use _cleanup_close_

use _cleanup_{close_,fclose_} to close streams and file descriptors

9 years agocore: mount and initialize Smack
Nathaniel Chen [Thu, 7 Mar 2013 19:06:58 +0000 (11:06 -0800)]
core: mount and initialize Smack

SMACK is the Simple Mandatory Access Control Kernel, a minimal
approach to Access Control implemented as a kernel LSM.

The kernel exposes the smackfs filesystem API through which access
rules can be loaded. At boot time, we want to load the access rules
as early as possible to ensure all early boot steps are checked by Smack.

This patch mounts smackfs at the new location at /sys/fs/smackfs for
kernels 3.8 and above. The /smack mountpoint is not supported.
After mounting smackfs, rules are loaded from the usual location.

For more information about Smack see:

9 years agocore: move mount_setup_early() to main.c
Nathaniel Chen [Thu, 7 Mar 2013 19:06:57 +0000 (11:06 -0800)]
core: move mount_setup_early() to main.c

move mount_setup_early() call to main.c, before security module setup,
so there are no more repeat calls.

9 years agoNEWS: update
Kay Sievers [Thu, 7 Mar 2013 19:44:26 +0000 (20:44 +0100)]
NEWS: update

9 years agoTODO: update
Kay Sievers [Thu, 7 Mar 2013 19:39:12 +0000 (20:39 +0100)]
TODO: update

9 years agoupdate NEWS
Lennart Poettering [Thu, 7 Mar 2013 19:25:12 +0000 (20:25 +0100)]
update NEWS

9 years agohwdb: update
Kay Sievers [Thu, 7 Mar 2013 18:42:51 +0000 (19:42 +0100)]
hwdb: update

9 years agobuild-sys: check if manpage ids match file names
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 18:04:17 +0000 (13:04 -0500)]
build-sys: check if manpage ids match file names

Commit ed1553a fixed current errors, but this error is easy to
make. A wrong id messes up the indexes and linking, so it is
better to catch this automatically.

9 years agoTODO: python stuff and freeze and standby
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 17:41:22 +0000 (12:41 -0500)]
TODO: python stuff and freeze and standby

9 years agocore: don't complain about kernel command line arguments in...
Lennart Poettering [Thu, 7 Mar 2013 17:39:06 +0000 (18:39 +0100)]
core: don't complain about kernel command line arguments in PID 1

9 years agosystemd-python: update documentation for new systemd-journal group
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 16:29:01 +0000 (11:29 -0500)]
systemd-python: update documentation for new systemd-journal group

9 years agosystemd-python: refuse path and flags together in __init__
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 16:28:44 +0000 (11:28 -0500)]
systemd-python: refuse path and flags together in __init__

It's better to explictly check, instead of just documenting it.

The return value from init is changed from 1 to -1 on error.
Python seems to ignore 1 every second time. Looks like a bug
in Python, but the return value doesn't seem to be documented
anywhere, and -1 works as expected... so let's just use that.

9 years agobuild-sys: force creation of symlink
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 15:15:20 +0000 (10:15 -0500)]
build-sys: force creation of symlink

For some reason make sometimes wants to rerun this, and
ln would refuse to recreate the link.

9 years agologind: don't hit an assert if an close() on an input device fd fails with ENODEV...
Lennart Poettering [Thu, 7 Mar 2013 15:48:14 +0000 (16:48 +0100)]
logind: don't hit an assert if an close() on an input device fd fails with ENODEV because the device is gone

9 years agosystemctl: mangle unit name in is-enabled
Lukas Nykryn [Thu, 7 Mar 2013 15:09:20 +0000 (16:09 +0100)]
systemctl: mangle unit name in is-enabled

9 years agobootchart: document -C, --cmdline parameter
Harald Hoyer [Thu, 7 Mar 2013 15:19:38 +0000 (16:19 +0100)]
bootchart: document -C, --cmdline parameter

9 years agobootchart: use _cleanup_fclose_
Harald Hoyer [Thu, 7 Mar 2013 07:52:56 +0000 (08:52 +0100)]
bootchart: use _cleanup_fclose_

9 years agobootchart: rename global len to samples_len
Harald Hoyer [Thu, 7 Mar 2013 07:52:55 +0000 (08:52 +0100)]
bootchart: rename global len to samples_len

9 years agobootchart: add parameter "-C" to expand process names to the full cmdline
Harald Hoyer [Thu, 7 Mar 2013 07:52:54 +0000 (08:52 +0100)]
bootchart: add parameter "-C" to expand process names to the full cmdline

9 years agoutil: Fix grammar in comment
Jan Janssen [Thu, 7 Mar 2013 14:12:46 +0000 (15:12 +0100)]
util: Fix grammar in comment

9 years agoman: Unify title for configuration files
Jan Janssen [Thu, 7 Mar 2013 14:12:45 +0000 (15:12 +0100)]
man: Unify title for configuration files

9 years agoman: Fix id attributes
Jan Janssen [Thu, 7 Mar 2013 14:12:44 +0000 (15:12 +0100)]
man: Fix id attributes

9 years agovirt: check for /sys/hypervisor/type for detecting xen PV
Lennart Poettering [Thu, 7 Mar 2013 14:59:26 +0000 (15:59 +0100)]
virt: check for /sys/hypervisor/type for detecting xen PV

9 years agonspawn: create a separate devpts namespace for nspawn containers
Lennart Poettering [Thu, 7 Mar 2013 12:34:07 +0000 (13:34 +0100)]
nspawn: create a separate devpts namespace for nspawn containers

9 years agoman/kernel-install.xml: fix paths to reflect actual behaviour
Harald Hoyer [Thu, 7 Mar 2013 08:27:59 +0000 (09:27 +0100)]
man/kernel-install.xml: fix paths to reflect actual behaviour

9 years agolibsystemd-journal: return 0 on success in get_data()
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 05:40:30 +0000 (00:40 -0500)]
libsystemd-journal: return 0 on success in get_data()

The man page says so. Right now 0 would be returned if the data was encrypted,
1 otherwise.

9 years agosystemd-python: export sd_j_get_fd, sd_j_reliable_fd, sd_j_close
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 05:35:28 +0000 (00:35 -0500)]
systemd-python: export sd_j_get_fd, sd_j_reliable_fd, sd_j_close

sd_journal_get_fd(j) is called j.fileno(), for compatiblity with
Python conventions for file-like objects.

More importantly, those new .seek_head() and .seek_tail() do not
call .get_next(). This is better, if one wants to skip before
retrieving an entry.

9 years agosystemd-python: split .seek() into .seek_head() and .seek_tail()
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 05:26:24 +0000 (00:26 -0500)]
systemd-python: split .seek() into .seek_head() and .seek_tail()

This way python code follows the original interface more closely.
Also, .seek(0, journal.SEEK_END) was just to much to type.

9 years agosystemd-python: catch only ValueErrors in conversion code
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 03:15:46 +0000 (22:15 -0500)]
systemd-python: catch only ValueErrors in conversion code

First of all, 'try: ... except: ...' (with no exception specified) is
always a no-no, since it catches all BaseExceptions, which includes ^C
and other stuff which should almost never be caught.

Now the conversion is stricter, and only one conversion is attempted,
and only a ValueEror is caught. It seems reasonable to catch ValueErrors,
since the entries in the journal are not verified, and any erroneous
application might log a field which cannot be converted. The consumer
of events must only check if a field is an instance of bytes and can
otherwise assume that the conversion was performed correctly.

Order of arguments in Reader.__init__ has been changed to match order
in _Reader.__init__.

Conversions have been updated to work under Python 2 and 3.

9 years agoman: fix compilation of example
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 22:07:42 +0000 (17:07 -0500)]
man: fix compilation of example

9 years agoservice: sysv - properly handle init scripts with .sh suffix
Michael Biebl [Wed, 6 Mar 2013 22:24:31 +0000 (23:24 +0100)]
service: sysv - properly handle init scripts with .sh suffix

Dropping the distribution specific #ifdefs in
88516c0c952b9502e8ef1d6a1481af61b0fb422d broke the .sh suffix stripping
since we now always used the else clause of the rc. check.

We eventually want to drop the rc. prefix stripping, but for now we
assume that no sysv init script uses both an rc. prefix and .sh suffix,
so make the check for the .sh suffix and rc. prefix mutually exclusive.

9 years agolibsystemd-journal: export new function, increase library version
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 18:19:45 +0000 (13:19 -0500)]
libsystemd-journal: export new function, increase library version

Since sd_journal_reliable_fd wasn't exported before, it is as if
it was added now. Library "current" number must be bumped.

michich> Someone links with the fixed version and produces a RPM with
         his program. The RPM will happily install on a system with an
         old systemd version (the deps will appear fine), but the
         program will fail to run.

9 years agoREADME: more CONFIG_* updates
Kay Sievers [Wed, 6 Mar 2013 19:01:45 +0000 (20:01 +0100)]
README: more CONFIG_* updates

9 years agoREADME: remove CONFIG_HOTPLUG, add CONFIG_NET
Kay Sievers [Wed, 6 Mar 2013 18:51:52 +0000 (19:51 +0100)]

9 years agoREADME: add kernel config options
Kay Sievers [Wed, 6 Mar 2013 18:36:39 +0000 (19:36 +0100)]
README: add kernel config options

9 years agojournal: properly advertise sd_journal_reliable_fd
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 17:17:37 +0000 (12:17 -0500)]
journal: properly advertise sd_journal_reliable_fd

sd_journal_reliable_fd was added in 85210bffd836, but it was
exported under the wrong name. Not too many users I guess.

9 years agobuild-sys: add missing $
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 17:01:59 +0000 (12:01 -0500)]
build-sys: add missing $

Fixup for 25ee45f99.

9 years agocore: add missing comma for NonewPrivileges=
Lennart Poettering [Wed, 6 Mar 2013 16:48:42 +0000 (17:48 +0100)]
core: add missing comma for NonewPrivileges=

9 years agobus: Escape environment-based D-Bus addresses properly
Simon McVittie [Thu, 7 Feb 2013 21:14:56 +0000 (21:14 +0000)]
bus: Escape environment-based D-Bus addresses properly

If XDG_RUNTIME_DIR contains a character like ":" (for instance if it's
formed from an X11 display name), then it isn't valid to substitute
it into a D-Bus address without escaping.

9 years agomanager: remove timer fd explicitly from epoll
Enrico Scholz [Sat, 2 Mar 2013 16:31:53 +0000 (17:31 +0100)]
manager: remove timer fd explicitly from epoll

Forked processes can keep the old fd alive triggering epoll over and
over again else.

9 years agomain: ISOLATE rather than REPLACE
Tom Gundersen [Tue, 5 Mar 2013 06:56:47 +0000 (15:56 +0900)]
main: ISOLATE rather than REPLACE

This allows switch-root to work correctly if a unit is active both before and
after the switch-root, but its dependencies change. Before the patch, any
dependencies added to active units by switch-root will not be pulled, in
particular filesystems configured in /etc/fstab would not be activated if was active in the initrd.

It is not clear to me if there is a bug in the REPLACE handling, or if it is
working as expected and that we really want to use ISOLATE instead as this patch

9 years agoupdate TODO
Lennart Poettering [Wed, 6 Mar 2013 14:39:27 +0000 (15:39 +0100)]
update TODO

9 years agotimedated: add CanNTP property
Ryan Lortie [Mon, 4 Mar 2013 21:35:02 +0000 (16:35 -0500)]
timedated: add CanNTP property

If we can't successfully query any ntpd units, set CanNTP to false.

GNOME wants to use this to grey out the NTP switch in the UI.

9 years agounits: run systemd-ask-password-console.service after systemd-vconsole-setup.service
Harald Hoyer [Thu, 14 Feb 2013 11:52:24 +0000 (12:52 +0100)]
units: run systemd-ask-password-console.service after systemd-vconsole-setup.service

9 years agoinitrd-parse-etc.servic: force start
Harald Hoyer [Wed, 6 Mar 2013 10:02:35 +0000 (11:02 +0100)]
initrd-parse-etc.servic: force start

9 years agoRevert "add and"
Harald Hoyer [Tue, 5 Mar 2013 07:16:15 +0000 (08:16 +0100)]
Revert "add and"

This reverts commit 39b83cdab37623a546344622db9bbbc784c15df5.

9 years agoRevert "units/initrd-*: require rather than"
Harald Hoyer [Tue, 5 Mar 2013 07:16:06 +0000 (08:16 +0100)]
Revert "units/initrd-*: require rather than"

This reverts commit 7d89ce303fb59743a4392eeb3110c00f100172ca.

9 years agosystemd-python: fix error check in _Reader.wait()
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 04:23:09 +0000 (23:23 -0500)]
systemd-python: fix error check in _Reader.wait()

9 years agojournal/tests: free allocated memory in test
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 02:43:06 +0000 (21:43 -0500)]
journal/tests: free allocated memory in test

9 years agozsh-completion: journalctl query by binary and device
Daniel Wallace [Tue, 5 Mar 2013 19:32:09 +0000 (14:32 -0500)]
zsh-completion: journalctl query by binary and device

implement 1883552c3d8 from bash completion in zsh-completion

9 years agohostnamed: allow more special characters in pretty hostname
Nathaniel Chen [Tue, 5 Mar 2013 19:46:34 +0000 (11:46 -0800)]
hostnamed: allow more special characters in pretty hostname

this addresses the bug at:

hostnamectl is supposed to allow a range of special characters for
the 'pretty' hostname:
  $ hostnamectl set-hostname --pretty "Nathaniels Desktop !@#$%"
..however, it rejects apostrophes, double quotes, and backslashes.
The manual for hostnamectl suggests that this should be allowed.

It makes sense to reject \0, \n, etc. pretty_string_is_safe() is
the same as string_is_safe(), but allows more special characters.

9 years agoutil: properly escape corner cases in bus_path_escape(), too
Lennart Poettering [Tue, 5 Mar 2013 18:58:32 +0000 (19:58 +0100)]
util: properly escape corner cases in bus_path_escape(), too

This follows the suggestions from:

9 years agoinhibit: print --list if no argument is given
Kay Sievers [Tue, 5 Mar 2013 18:32:36 +0000 (19:32 +0100)]
inhibit: print --list if no argument is given

9 years agoFix typos
Michael Biebl [Tue, 5 Mar 2013 18:19:26 +0000 (19:19 +0100)]
Fix typos

9 years agojournal: make gatewayd run under its own user ID
Lennart Poettering [Tue, 5 Mar 2013 18:15:31 +0000 (19:15 +0100)]
journal: make gatewayd run under its own user ID

9 years agoREADME: add udev goups
Kay Sievers [Tue, 5 Mar 2013 18:04:48 +0000 (19:04 +0100)]
README: add udev goups

9 years agoupdate TODO
Lennart Poettering [Tue, 5 Mar 2013 17:59:14 +0000 (18:59 +0100)]
update TODO

9 years agojournald: introduce new "systemd-journal" group and make it own the journal files
Lennart Poettering [Tue, 5 Mar 2013 17:53:21 +0000 (18:53 +0100)]
journald: introduce new "systemd-journal" group and make it own the journal files

Previously all journal files were owned by "adm". In order to allow
specific users to read the journal files without granting it access to
the full "adm" powers, introduce a new specific group for this.

"systemd-journal" has to be created by the packaging scripts manually at
installation time. It's a good idea to assign a static UID/GID to this
group, since /var/log/journal might be shared across machines via NFS.

This commit also grants read access to the journal files by default to
members of the "wheel" and "adm" groups via file system ACLs, since
these "almost-root" groups should be able to see what's going on on the
system. These ACLs are created by "make install". Packagers probably
need to duplicate this logic in their postinst scripts.

This also adds documentation how to grant access to the journal to
additional users or groups via fs ACLs.

9 years agojournald: stpcpy() + mempcpy() are awesome
Lennart Poettering [Tue, 5 Mar 2013 14:02:38 +0000 (15:02 +0100)]
journald: stpcpy() + mempcpy() are awesome

9 years agojournald: drop splitting-by-audit entirely
Lennart Poettering [Tue, 5 Mar 2013 13:36:57 +0000 (14:36 +0100)]
journald: drop splitting-by-audit entirely

Thinking about it we should probably not hide bugs by falling back to
audit when we have our own session information anyway.

9 years agojournald: be a bit more careful when spitting up journals by user id
Lennart Poettering [Tue, 5 Mar 2013 13:27:34 +0000 (14:27 +0100)]
journald: be a bit more careful when spitting up journals by user id

9 years agojournald: check session owner UID rather then audit ID when splitting up journal...
Lennart Poettering [Tue, 5 Mar 2013 13:23:22 +0000 (14:23 +0100)]
journald: check session owner UID rather then audit ID when splitting up journal files

We should always go by our own cgroup hierarchy before using foreign
schemes such as audit, so let's do that for the split out logic too.

9 years agoRevert "fstab-generator: place initrd /sysroot mounts in"
Harald Hoyer [Tue, 5 Mar 2013 05:45:06 +0000 (06:45 +0100)]
Revert "fstab-generator: place initrd /sysroot mounts in"

This reverts commit 8330847e949fc0c26b16910e5240eef1fe2c330a.


9 years agoupdate TODO
Lennart Poettering [Tue, 5 Mar 2013 03:10:19 +0000 (04:10 +0100)]
update TODO

9 years agologind: when registering a new session always use previous session info from cgroup...
Lennart Poettering [Tue, 5 Mar 2013 02:29:54 +0000 (03:29 +0100)]
logind: when registering a new session always use previous session info from cgroup path rather than audit

Previously for cases like "su" or "sudo" where a session is attempted to
be created from within an existing one we used the audit session ID to
detect this and in such a case we simple returned the session data of
the original session a second time.

With this change we will now use the cgroup path of the calling path to
determine the old session, i.e. we only rely on our own session
identification scheme, instead of audits.

We will continue to keep the audit session ID and ours in sync however,
to avoid unnecessary confusion.

9 years agobuild-sys: build and install systemd-coredumpctl conditionally
Michael Biebl [Mon, 4 Mar 2013 22:20:16 +0000 (23:20 +0100)]
build-sys: build and install systemd-coredumpctl conditionally

If coredump support is disabled via --disable-coredump, do not build and
install the systemd-coredumpctl binary and man page.

9 years agofstab-generator: only handle block devices with root= kernel command line parameter
Harald Hoyer [Mon, 4 Mar 2013 20:00:56 +0000 (21:00 +0100)]
fstab-generator: only handle block devices with root= kernel command line parameter

skip like root=nfs:... root=iscsi:... root=nbd:...

9 years agofstab-generator: place initrd /sysroot mounts in
Harald Hoyer [Mon, 4 Mar 2013 18:04:32 +0000 (19:04 +0100)]
fstab-generator: place initrd /sysroot mounts in

also do not overwrite /sysroot*.mount units already generated from fstab

9 years agounits/initrd-*: require rather than
Harald Hoyer [Mon, 4 Mar 2013 18:03:05 +0000 (19:03 +0100)]
units/initrd-*: require rather than

9 years agoadd and
Harald Hoyer [Mon, 4 Mar 2013 18:01:05 +0000 (19:01 +0100)]
add and

9 years agobuild-sys: do not install pam_systemd(8) without PAM
Zbigniew Jędrzejewski-Szmek [Mon, 4 Mar 2013 18:16:38 +0000 (13:16 -0500)]
build-sys: do not install pam_systemd(8) without PAM

9 years agobuild-sys: do not install logind manpages when disabled
Zbigniew Jędrzejewski-Szmek [Mon, 4 Mar 2013 17:57:12 +0000 (12:57 -0500)]
build-sys: do not install logind manpages when disabled

The condition was wrong: HAVE_PAM -> ENABLE_LOGIND.

9 years agoProFUSION got bought by Intel
Kay Sievers [Mon, 4 Mar 2013 15:13:19 +0000 (16:13 +0100)]
ProFUSION got bought by Intel

9 years agojournal: split journal uid only when audit uid data is valid
Kay Sievers [Mon, 4 Mar 2013 14:17:45 +0000 (15:17 +0100)]
journal: split journal uid only when audit uid data is valid

9 years agocore/manager: fix conditions to start and stop watching running jobs
Michal Schmidt [Mon, 4 Mar 2013 13:38:51 +0000 (14:38 +0100)]
core/manager: fix conditions to start and stop watching running jobs

Harald encountered division by zero in manager_print_jobs_in_progress.
Clearly we had the watch enabled when we shouldn't - there were no
running jobs in m->jobs, only waiting ones. This is either a deadlock,
or maybe some of them would be detected as runnable in the next dispatch
of the run queue. In any case we mustn't crash.

Fix it by starting and stopping the watch based on n_running_jobs
instead of the number of all jobs.

9 years agotmpfiles: use cleanup func. to save a few lines
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 23:42:52 +0000 (18:42 -0500)]
tmpfiles: use cleanup func. to save a few lines

9 years agotmpfiles: move exclamation mark into right place
Lukas Nykryn [Fri, 1 Mar 2013 17:29:59 +0000 (18:29 +0100)]
tmpfiles: move exclamation mark into right place

Unary not has higher precedence than comparisons,
so the condition was bogus.

9 years agocore/path: install inotify watches top-down instead of bottom-up
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 06:32:34 +0000 (01:32 -0500)]
core/path: install inotify watches top-down instead of bottom-up

When watches are installed from the bottom, it is always possible
to race, and miss a file creation event. The race can be avoided
if a watch is first established for a parent directory, and then for
the file in the directory. If the file is created in the time between,
the watch on the parent directory will fire.

Some messages (mostly at debug level) are added to help diagnose
pidfile issues.

Should fix