chiark / gitweb /
core/manager: fix conditions to start and stop watching running jobs
authorMichal Schmidt <mschmidt@redhat.com>
Mon, 4 Mar 2013 13:38:51 +0000 (14:38 +0100)
committerHarald Hoyer <harald@redhat.com>
Mon, 4 Mar 2013 13:51:32 +0000 (14:51 +0100)
commita0b6422689e37ffee37742d027f91af8bacfa78d
tree0171f82a315cfee81788b29e462c23beaefd0134
parent19fbec19192998fa7fc0c24a58038b98cf989802
core/manager: fix conditions to start and stop watching running jobs

Harald encountered division by zero in manager_print_jobs_in_progress.
Clearly we had the watch enabled when we shouldn't - there were no
running jobs in m->jobs, only waiting ones. This is either a deadlock,
or maybe some of them would be detected as runnable in the next dispatch
of the run queue. In any case we mustn't crash.

Fix it by starting and stopping the watch based on n_running_jobs
instead of the number of all jobs.
src/core/manager.c