chiark / gitweb /
7 years agobus: when watching bus names, we always need to add a change match
Lennart Poettering [Sat, 21 Dec 2013 00:02:23 +0000 (01:02 +0100)]
bus: when watching bus names, we always need to add a change match

Since for the kernel change of ownership of a name between starter and
real client is a change and for userspace thats addition/removal, we
need to unconditionally subscribe to these change events.

7 years agocore: pass notify fd across reexecs
Lennart Poettering [Fri, 20 Dec 2013 23:19:37 +0000 (00:19 +0100)]
core: pass notify fd across reexecs

That way we the random socket name stays stable across reexec and we
won't lose client messages.

7 years agoupdate TODO
Lennart Poettering [Fri, 20 Dec 2013 23:19:30 +0000 (00:19 +0100)]
update TODO

7 years agobus: wrap KDBUS_CMD_BYEBYE with a high-level call sd_bus_try_close()
Lennart Poettering [Fri, 20 Dec 2013 22:25:43 +0000 (23:25 +0100)]
bus: wrap KDBUS_CMD_BYEBYE with a high-level call sd_bus_try_close()

7 years agolibsystemd-bus: match on any connection ID unless specified
Daniel Mack [Fri, 20 Dec 2013 22:12:42 +0000 (23:12 +0100)]
libsystemd-bus: match on any connection ID unless specified

7 years agolibsystemd-bus: follow changes in kdbus
Daniel Mack [Fri, 20 Dec 2013 19:57:20 +0000 (20:57 +0100)]
libsystemd-bus: follow changes in kdbus

In particular, the match interface has seen a major overhaul.

7 years agodef: lower exit-on-idle time
Lennart Poettering [Thu, 19 Dec 2013 21:12:53 +0000 (22:12 +0100)]
def: lower exit-on-idle time

7 years agosd-event: return 1 in sd_event_run() when we hit EINTR
Lennart Poettering [Thu, 19 Dec 2013 20:38:52 +0000 (21:38 +0100)]
sd-event: return 1 in sd_event_run() when we hit EINTR

That way we can distuingish timeouts from EINTR

7 years agoservice: don't send out PropertiesChanged message for each watchdog notification
Lennart Poettering [Thu, 19 Dec 2013 20:34:09 +0000 (21:34 +0100)]
service: don't send out PropertiesChanged message for each watchdog notification

7 years agomachined: implement exit-on-idle
Lennart Poettering [Thu, 19 Dec 2013 20:15:08 +0000 (21:15 +0100)]
machined: implement exit-on-idle

7 years agobus: fix exit-on-idle for driverd
Lennart Poettering [Thu, 19 Dec 2013 20:14:52 +0000 (21:14 +0100)]
bus: fix exit-on-idle for driverd

7 years agobus: reenable id change subscriptions
Lennart Poettering [Thu, 19 Dec 2013 20:13:01 +0000 (21:13 +0100)]
bus: reenable id change subscriptions

7 years agoremove unused variable
Thomas Hindoe Paaboel Andersen [Thu, 19 Dec 2013 21:06:47 +0000 (22:06 +0100)]
remove unused variable

7 years agortnl: correctly get the size of data to be appended
Tom Gundersen [Thu, 19 Dec 2013 20:28:50 +0000 (21:28 +0100)]
rtnl: correctly get the size of data to be appended

This fixes:
  systemd[1]: Failed to configure loopback device: Numerical result out of range

7 years agoloopback-setup: correctly set flags and scope for ipv6 address
Tom Gundersen [Thu, 19 Dec 2013 19:11:34 +0000 (20:11 +0100)]
loopback-setup: correctly set flags and scope for ipv6 address

7 years agokeymap: Refactor Acer tables
Martin Pitt [Thu, 19 Dec 2013 07:33:32 +0000 (08:33 +0100)]
keymap: Refactor Acer tables

Move common keys into generic Acer table, and factorize the model specific

7 years agobus: do not add empty strings, size should be 0
Kay Sievers [Thu, 19 Dec 2013 05:55:44 +0000 (06:55 +0100)]
bus: do not add empty strings, size should be 0

7 years agosystemct: add empty line between units in cat
Zbigniew Jędrzejewski-Szmek [Thu, 19 Dec 2013 03:10:17 +0000 (22:10 -0500)]
systemct: add empty line between units in cat

7 years agologinctl: improve print_{session|user|seat}_status_info() functions
Djalal Harouni [Tue, 17 Dec 2013 18:42:03 +0000 (19:42 +0100)]
loginctl: improve print_{session|user|seat}_status_info() functions

1) Instead of checking if we need to print a new line on each iteration,
pass the "new_line" as a pointer to those functions, so they can use
it to check if a new line is needed. This makes the code more consistent
as it is done in other places: machinectl, systemctl...

2) Move the error messages from show_{session|user|seat}() to their
appropriate print_{session|user|seat}_status_info() functions, this will
prevent from logging an error message twice in case show_properties()
fails and it will improve code readability.

3) Also do not ignore error codes on these functions.

7 years agologinctl: use show_properties() to get login1 properties
Djalal Harouni [Tue, 17 Dec 2013 18:42:01 +0000 (19:42 +0100)]
loginctl: use show_properties() to get login1 properties

Commit f8f14b3654bcd introduced a regression that makes loginctl ignore
the "--property" option.

This patch fixes the bug, it uses a new show_properties() function to
query and filter properties.

7 years agologinctl: replace strv_append() by strv_extend()
Djalal Harouni [Tue, 17 Dec 2013 18:42:00 +0000 (19:42 +0100)]
loginctl: replace strv_append() by strv_extend()

7 years agojournalctl,zsh-completion: fix several issues in --help message text
Jason St. John [Wed, 18 Dec 2013 02:36:27 +0000 (21:36 -0500)]
journalctl,zsh-completion: fix several issues in --help message text

-- fix grammar and reword some descriptions for clarity
-- add a useful description of what --follow does
-- fix the description for --after-cursor
-- properly introduce the FSS acronym for "Forward Secure Sealing" in
both sections
-- clarify the --disk-usage command

[zj: perform similar changes to zsh completions]

squash! journalctl: fix several issues in --help message text

7 years agoman: add DOI for refereed article on Forward Secure Sealing to journald.conf(5)
Jason St. John [Wed, 18 Dec 2013 00:40:02 +0000 (19:40 -0500)]
man: add DOI for refereed article on Forward Secure Sealing to journald.conf(5)

In journalctl(1), be more explicit about the reference to "Seal=" in
journald.conf(5) and what information can be found there.

7 years agoman: be more explicit about option arguments that take 128-bit IDs in journalctl(1)
Jason St. John [Tue, 17 Dec 2013 23:48:43 +0000 (18:48 -0500)]
man: be more explicit about option arguments that take 128-bit IDs in journalctl(1)

It may not be immediately obvious to the reader what "ID128" is, so replace the
example option argument "ID128" with "128-bit-ID".

7 years agoman: fix grammar issues in journalctl(1)
Jason St. John [Tue, 17 Dec 2013 23:48:42 +0000 (18:48 -0500)]
man: fix grammar issues in journalctl(1)

And add a missing <option> tag around "--setup-keys" under "--force".

7 years agomachinectl: show_properties() already logs the error
Djalal Harouni [Tue, 17 Dec 2013 22:40:15 +0000 (23:40 +0100)]
machinectl: show_properties() already logs the error

7 years agoudevadm: modernization
Zbigniew Jędrzejewski-Szmek [Wed, 18 Dec 2013 02:49:07 +0000 (21:49 -0500)]
udevadm: modernization

7 years agoudevadm,scsi_id: add short options to help strings and to the man page
Zbigniew Jędrzejewski-Szmek [Wed, 18 Dec 2013 02:48:14 +0000 (21:48 -0500)]
udevadm,scsi_id: add short options to help strings and to the man page

Also clean things up a bit here and there.

7 years agoscsi_id: cleanup
Zbigniew Jędrzejewski-Szmek [Sun, 15 Dec 2013 22:15:54 +0000 (17:15 -0500)]
scsi_id: cleanup

Remove -i option which would case exit(1) to happen.
Remove some unused code.
Convert to bool where appropriate.
Simplify things a bit.
Always free everything.

7 years agodriverd: implement AddMatch/RemoveMatch logic
Lennart Poettering [Thu, 19 Dec 2013 02:02:45 +0000 (03:02 +0100)]
driverd: implement AddMatch/RemoveMatch logic

7 years agodo not run kmod-setup in a container
Kay Sievers [Thu, 19 Dec 2013 00:32:55 +0000 (01:32 +0100)]
do not run kmod-setup in a container

7 years agotemporarily support "kdbus" keyword on the kernel commandline to load the module
Kay Sievers [Wed, 18 Dec 2013 22:56:35 +0000 (23:56 +0100)]
temporarily support "kdbus" keyword on the kernel commandline to load the module

7 years agolibudev: monitor - only disallow "udev" type events
Kay Sievers [Wed, 18 Dec 2013 21:30:26 +0000 (22:30 +0100)]
libudev: monitor - only disallow "udev" type events

7 years agolibudev: disable monitor inside a container
Kay Sievers [Wed, 18 Dec 2013 21:01:31 +0000 (22:01 +0100)]
libudev: disable monitor inside a container

Uevents are events of the host, which should not leak into a container.
Containers do not support hotplug at the moment, and devices and uevents
are not namespace aware.

7 years agobus: catch up with kdbus changes
Kay Sievers [Wed, 18 Dec 2013 20:16:35 +0000 (21:16 +0100)]
bus: catch up with kdbus changes

7 years agobus-driverd: fix flags translation in driver_request_name
Lukasz Skalski [Wed, 18 Dec 2013 12:32:13 +0000 (13:32 +0100)]
bus-driverd: fix flags translation in driver_request_name

Flags for a name entry (KDBUS_NAME_*) should be set for
cmd_name->flags (not conn_flags)

7 years agoRevert "ptyfwd: make master terminal attributes raw, too"
Lennart Poettering [Wed, 18 Dec 2013 18:24:00 +0000 (19:24 +0100)]
Revert "ptyfwd: make master terminal attributes raw, too"

This reverts commit e7d43b3cc30764138c90eaaf95d3d8f49e448890.

This broke the console terminal when booting up a container, so let's
not do this.

7 years agobus: reduce calls to KDBUS_CMD_MEMFD_SIZE_SET ioctl
Lennart Poettering [Wed, 18 Dec 2013 17:46:23 +0000 (18:46 +0100)]
bus: reduce calls to KDBUS_CMD_MEMFD_SIZE_SET ioctl

Instead of calling it for each buffer append, increase allocation
exponentially and set the real value only at the end, when sealing off
the memfd.

This should drastically reduce the number of times we invoke the

7 years agoptyfwd: make master terminal attributes raw, too
Lennart Poettering [Wed, 18 Dec 2013 17:14:10 +0000 (18:14 +0100)]
ptyfwd: make master terminal attributes raw, too

7 years agounits: when spawning a getty configure TERM explicitly
Lennart Poettering [Wed, 18 Dec 2013 16:48:31 +0000 (17:48 +0100)]
units: when spawning a getty configure TERM explicitly

This way we can make use of our logic to automatically determine an
appropriate TERM for a specific tty.

7 years agoexecute: set TERM even if we don't open the tty on our own
Lennart Poettering [Wed, 18 Dec 2013 16:41:16 +0000 (17:41 +0100)]
execute: set TERM even if we don't open the tty on our own

This way, when a tty path is configured TERM is set, which is nice to
set a useful term for gettys.

7 years agologinctl: when showing device tree of seats with no devices show something useful
Lennart Poettering [Wed, 18 Dec 2013 16:16:33 +0000 (17:16 +0100)]
loginctl: when showing device tree of seats with no devices show something useful

7 years agocore,logind: libudev usage modernizations
Lennart Poettering [Wed, 18 Dec 2013 16:13:42 +0000 (17:13 +0100)]
core,logind: libudev usage modernizations

Always use cleanup logic and don't eat up errors returned by libudev

7 years agocore,logind,networkd: check for udev device initialization via enumeration matches
Lennart Poettering [Wed, 18 Dec 2013 16:12:15 +0000 (17:12 +0100)]
core,logind,networkd: check for udev device initialization via enumeration matches

Instead of checking each device after we got it, check wuth an
enumeration filter instead, to make it more efficient.

7 years agocore: priorize notification fd processing over notification fd process via sd-event...
Lennart Poettering [Wed, 18 Dec 2013 02:46:53 +0000 (03:46 +0100)]
core: priorize notification fd processing over notification fd process via sd-event's logic

7 years agolog: when we log to /dev/console and got disconnected (maybe due to vhangup) reconnect
Lennart Poettering [Wed, 18 Dec 2013 15:49:15 +0000 (16:49 +0100)]
log: when we log to /dev/console and got disconnected (maybe due to vhangup) reconnect

7 years agounits: run systemd-networkd.service only if CAP_NET_ADMIN capability is around
Lennart Poettering [Wed, 18 Dec 2013 15:45:20 +0000 (16:45 +0100)]
units: run systemd-networkd.service only if CAP_NET_ADMIN capability is around

This has the effect that systemd-networkd won't run in containers
without network namespacing wher CAP_NET_ADMIN is (usually) not
available. It will still run in containers with network namespacing on
(where CAP_NET_ADMIN is usually avilable).

We might remove this condition check again if networkd provides services
to apps that also are useful in containers lacking network namespacing,
however, as long as it doesn't it should be handled like udevd and be
excluded in such containers.

7 years agocore: in a container log to /dev/console if "debug" is specified
Lennart Poettering [Wed, 18 Dec 2013 04:09:53 +0000 (05:09 +0100)]
core: in a container log to /dev/console if "debug" is specified

7 years agolog: don't reopen /dev/console each time we call log_open()
Lennart Poettering [Wed, 18 Dec 2013 04:07:34 +0000 (05:07 +0100)]
log: don't reopen /dev/console each time we call log_open()

Instead, force reopen it only if we really really have to.

7 years agoservice: watch main pid even in final states
Lennart Poettering [Wed, 18 Dec 2013 03:19:20 +0000 (04:19 +0100)]
service: watch main pid even in final states

In some circumstances, for example when start-up times out we
immediately jump into the final state, at which point we still should
try to watch the main pid so that the SIGCHLD allows us to quickly
move into dead state.

7 years agolibudev: devices received from udev are always initialized
Kay Sievers [Wed, 18 Dec 2013 15:49:19 +0000 (16:49 +0100)]
libudev: devices received from udev are always initialized

7 years agologin: Don't stop a running user manager from garbage-collecting the user.
Thomas Bächler [Sun, 15 Dec 2013 11:06:37 +0000 (12:06 +0100)]
login: Don't stop a running user manager from garbage-collecting the user.

With the current logic, a user will never be garbage-collected, since its
manager will always be around. Change the logic such that a user is
garbage-collected when it has no sessions and linger is disabled.

7 years agocomment out udev's is_initialized call until the problem is sorted out
Kay Sievers [Wed, 18 Dec 2013 04:06:32 +0000 (05:06 +0100)]
comment out udev's is_initialized call until the problem is sorted out

7 years agocore,logind,networkd: don't pick up devices from udev before they finished udev initi...
Lennart Poettering [Wed, 18 Dec 2013 02:37:26 +0000 (03:37 +0100)]
core,logind,networkd: don't pick up devices from udev before they finished udev initialization

Managers shouldn't pick up the devices the manage before udev finished
initialization, hence check explicitly for that.

7 years agobusctl: output a single sorted list of names, including activatable and activated
Lennart Poettering [Wed, 18 Dec 2013 01:49:03 +0000 (02:49 +0100)]
busctl: output a single sorted list of names, including activatable and activated

7 years agobus: beef up driverd
Lennart Poettering [Wed, 18 Dec 2013 01:25:19 +0000 (02:25 +0100)]
bus: beef up driverd

Add validity checks for all parameters passed in.

Implement ReleaseName and StartServiceByName().

Fix access control in vtable.

7 years agobus: when releasing, taking, listing bus names check if they are valid
Lennart Poettering [Wed, 18 Dec 2013 01:23:07 +0000 (02:23 +0100)]
bus: when releasing, taking, listing bus names check if they are valid

Given that the kernel does not validate bus names we have to when using

7 years agotests: fix build
Lennart Poettering [Wed, 18 Dec 2013 01:22:16 +0000 (02:22 +0100)]
tests: fix build

7 years agobus: sync with kdbus
Daniel Mack [Tue, 17 Dec 2013 23:20:55 +0000 (00:20 +0100)]
bus: sync with kdbus

Two new things here:

a) struct kdbus_notify_name_change now carries two struct

b) a new KDBUS_CMD_BYEBYE ioctl that has no user yet in systemd

7 years agonetworkd: bridge - fix state machine
Tom Gundersen [Tue, 17 Dec 2013 18:56:09 +0000 (19:56 +0100)]
networkd: bridge - fix state machine


7 years agonetworkd: link - remove useless states
Tom Gundersen [Sat, 14 Dec 2013 18:09:04 +0000 (23:39 +0530)]
networkd: link - remove useless states

Rework the state-machine a bit.

7 years agonetworkd: rename link_update_flags to link_update
Tom Gundersen [Tue, 17 Dec 2013 17:36:09 +0000 (18:36 +0100)]
networkd: rename link_update_flags to link_update

We are likely to track more than the flags in the future.

7 years agobus-util: return errors when encountered
Thomas Hindoe Paaboel Andersen [Fri, 13 Dec 2013 20:34:04 +0000 (21:34 +0100)]
bus-util: return errors when encountered

Introduced in:

7 years ago_noreturn_ --> noreturn for C11 compat
Shawn Landden [Mon, 16 Dec 2013 16:53:53 +0000 (08:53 -0800)]
_noreturn_ --> noreturn for C11 compat

also define noreturn w/o <stdnoreturn.h>

7 years agoutil: no need for in_initrd() cache to be thread-local
Shawn Landden [Mon, 16 Dec 2013 00:56:21 +0000 (16:56 -0800)]
util: no need for in_initrd() cache to be thread-local

the process only has one working directory, and a race is

7 years ago__thread --> thread_local for C11 compat
Shawn Landden [Mon, 16 Dec 2013 00:24:14 +0000 (16:24 -0800)]
__thread --> thread_local for C11 compat

Also make thread_local available w/o including <threads.h>.
(as the latter hasn't been implemented, but this part is trivial)

7 years agoupdate TODO
Lennart Poettering [Tue, 17 Dec 2013 20:36:54 +0000 (21:36 +0100)]
update TODO

7 years agolibsystemd-bus: true/false instead of yes/no in msg dump
Lukasz Skalski [Tue, 17 Dec 2013 09:55:28 +0000 (10:55 +0100)]
libsystemd-bus: true/false instead of yes/no in msg dump

Due to this patch, message dump (for message which includes boolean
type) is more consistent with dbus-send (which display true/false
instead of yes/no for boolean). It's only simple 'cosmetics change'.

** For dbus-send **

dbus-send --system --dest=org.freedesktop.DBus --type=method_call --print-reply / org.freedesktop.DBus.NameHasOwner string:org.freedesktop.login1

method return sender=org.freedesktop.DBus -> dest=:1.97 reply_serial=2
   boolean true

** For libsystemd-bus (without this patch) **

‣ Type=method_call  Endian=l  Flags=0  Version=2 Serial=8
  Destination=org.freedesktop.DBus  Path=/org/freedesktop/DBus  Interface=org.freedesktop.DBus  Member=NameHasOwner
  MESSAGE "s" {
   STRING "org.freedesktop.login1";

‣ Type=method_return  Endian=l  Flags=1  Version=2 Serial=51  ReplySerial=8
  Sender=:1.59  Destination=:1.67
  UniqueName=:1.59  WellKnownNames={org.freedesktop.DBus}
  MESSAGE "b" {
   BOOLEAN yes;

For me true/false seems to be better readable than yes/no for BOOLEAN.

7 years agojournal-file.c: remove redundant assignment of variable
Thomas Hindoe Paaboel Andersen [Tue, 17 Dec 2013 19:15:45 +0000 (20:15 +0100)]
journal-file.c: remove redundant assignment of variable

we also do 'last_index = (uint64_t) -1;' at the end of the while
loop so there is no reason to also do it here.

7 years agobus: properly return an error code when release_name fails abnormally
Lennart Poettering [Tue, 17 Dec 2013 19:39:15 +0000 (20:39 +0100)]
bus: properly return an error code when release_name fails abnormally

7 years agobus-driverd: Fix return code in driver_request_name
Lukasz Skalski [Tue, 17 Dec 2013 16:31:46 +0000 (17:31 +0100)]
bus-driverd: Fix return code in driver_request_name

RequestName return codes should be consistent with Dbus Specification.

1-The caller is now the primary owner of the name, replacing any previous owner,
2-The name already had an owner (QUEUE flag was not specified),
3-The name already has an owner (QUEUE flag was specified),
4-Application trying to request ownership of a name is already the owner of it.

7 years agojournald: before closing /dev/kmsg let's unregister the event source
Lennart Poettering [Tue, 17 Dec 2013 19:02:21 +0000 (20:02 +0100)]
journald: before closing /dev/kmsg let's unregister the event source

7 years agojournald: close /dev/kmsg again if we cannot make use of it
Lennart Poettering [Tue, 17 Dec 2013 18:57:13 +0000 (19:57 +0100)]
journald: close /dev/kmsg again if we cannot make use of it

7 years agojournald: downgrade warning message when /dev/kmsg does not exist
Lennart Poettering [Tue, 17 Dec 2013 18:56:06 +0000 (19:56 +0100)]
journald: downgrade warning message when /dev/kmsg does not exist

7 years agodhcp: Properly handle unsuccessful cases for DHCP Ack
Patrik Flykt [Tue, 17 Dec 2013 15:24:16 +0000 (16:24 +0100)]
dhcp: Properly handle unsuccessful cases for DHCP Ack

Ignore DHCP Ack packets if they are found to be erroneous or have
an unexpected xid by setting the result to zero instead of propagating
an error. Also remember to report a DHCP Nak and stop the DHCP client.

7 years agoudev link-config: add asserts to silence scan-build
Thomas Hindoe Paaboel Andersen [Tue, 17 Dec 2013 15:09:52 +0000 (16:09 +0100)]
udev link-config: add asserts to silence scan-build

7 years agobus: removed unused variable in driverd
Thomas Hindoe Paaboel Andersen [Tue, 17 Dec 2013 15:07:00 +0000 (16:07 +0100)]
bus: removed unused variable in driverd

acked by Daniel Mack

7 years agobus: make driverd code more similar to other daemons, and make it exit on idle among...
Lennart Poettering [Tue, 17 Dec 2013 14:44:05 +0000 (15:44 +0100)]
bus: make driverd code more similar to other daemons, and make it exit on idle among other things

7 years agobusctl: on kdbus the bus driver is a service like any other, hence don't skip it
Lennart Poettering [Tue, 17 Dec 2013 02:55:59 +0000 (03:55 +0100)]
busctl: on kdbus the bus driver is a service like any other, hence don't skip it

7 years agobus: remarshal messages when necessary before sending
Lennart Poettering [Tue, 17 Dec 2013 01:43:45 +0000 (02:43 +0100)]
bus: remarshal messages when necessary before sending

7 years agoactivate: fix error checking on epoll_ctl()
Lennart Poettering [Tue, 17 Dec 2013 02:14:20 +0000 (03:14 +0100)]
activate: fix error checking on epoll_ctl()

7 years agobus: install unit files for new driver service
Lennart Poettering [Tue, 17 Dec 2013 01:43:38 +0000 (02:43 +0100)]
bus: install unit files for new driver service

7 years agobus: sync with kdbus
Daniel Mack [Tue, 17 Dec 2013 12:45:02 +0000 (13:45 +0100)]
bus: sync with kdbus

kdbus_cmd_{ep,ns,bus}_make are now consolidated, and bloom_size has
become an item of the dynamically sized list.

7 years agobus: sync up with kdbus
Daniel Mack [Tue, 17 Dec 2013 11:25:20 +0000 (12:25 +0100)]
bus: sync up with kdbus

7 years agobus-driverd: Fix unique name return in driver_get_name_owner
Lukasz Skalski [Tue, 17 Dec 2013 08:50:16 +0000 (09:50 +0100)]
bus-driverd: Fix unique name return in driver_get_name_owner

7 years agoman: networkd - clarify Address/Gateway keys in [Network] section
Tom Gundersen [Sat, 7 Dec 2013 22:23:18 +0000 (23:23 +0100)]
man: networkd - clarify Address/Gateway keys in [Network] section

7 years agonetworkd: add support for Route sections
Tom Gundersen [Sat, 7 Dec 2013 22:03:19 +0000 (23:03 +0100)]
networkd: add support for Route sections

7 years agonetworkd: correct logging message
Tom Gundersen [Wed, 4 Dec 2013 15:21:36 +0000 (16:21 +0100)]
networkd: correct logging message

7 years agortnl: fix for 32bits
Marc-Antoine Perennou [Tue, 17 Dec 2013 05:13:57 +0000 (14:13 +0900)]
rtnl: fix for 32bits

Commit 0a0dc69b655cfb10cab39133f5d521e7b35ce3d5 broke tests for 32 bits

7 years agobuild-sys: fix distcheck
Zbigniew Jędrzejewski-Szmek [Tue, 17 Dec 2013 04:58:51 +0000 (23:58 -0500)]
build-sys: fix distcheck

7 years agojournal: fix against (theoretical) undefined behavior
Shawn Landden [Mon, 16 Dec 2013 23:41:00 +0000 (15:41 -0800)]
journal: fix against (theoretical) undefined behavior

While all the libc implementations I know return NULL when memchr's size
parameter is 0, without accessing any memory, passing NULL to memchr is
still invalid:

C11 7.24.1p2: Where an argument declared as "size_t n" specifies the length
of the array for a function, n can have the value zero on a call to that
function. Unless explicitly stated otherwise in the description of a
particular function in this subclause, pointer arguments on such a call
shall still have valid values, as described in 7.1.4. On such a call, a
function that locates a character finds no occurrence, a function that
compares two character sequences returns zero, and a function that copies
characters copies zero characters.


7 years agoman: describe journalctl --show-cursor
Zbigniew Jędrzejewski-Szmek [Tue, 17 Dec 2013 04:40:00 +0000 (23:40 -0500)]
man: describe journalctl --show-cursor

7 years agobus-driverd: actually add --version
Zbigniew Jędrzejewski-Szmek [Tue, 17 Dec 2013 03:40:09 +0000 (22:40 -0500)]
bus-driverd: actually add --version

7 years agosystemctl: highlight filenames in cat
Zbigniew Jędrzejewski-Szmek [Tue, 17 Dec 2013 03:34:07 +0000 (22:34 -0500)]
systemctl: highlight filenames in cat

7 years agosystemctl: fix return value from cat
Zbigniew Jędrzejewski-Szmek [Tue, 17 Dec 2013 03:33:45 +0000 (22:33 -0500)]
systemctl: fix return value from cat

7 years agoman: reword awkward phrase
Zbigniew Jędrzejewski-Szmek [Tue, 17 Dec 2013 03:10:21 +0000 (22:10 -0500)]
man: reword awkward phrase

7 years agobus: use gperf to map error string to errno
Zbigniew Jędrzejewski-Szmek [Mon, 16 Dec 2013 01:35:22 +0000 (20:35 -0500)]
bus: use gperf to map error string to errno

7 years agobus: update kdbus.h
Kay Sievers [Tue, 17 Dec 2013 01:50:19 +0000 (02:50 +0100)]
bus: update kdbus.h

7 years agobus: when connecting to a container's system bus, double fork after joining the conta...
Lennart Poettering [Tue, 17 Dec 2013 00:57:27 +0000 (01:57 +0100)]
bus: when connecting to a container's system bus, double fork after joining the container's namespace

setns(CLONE_NEWPID) only applies to child processes, hence let's fork
once after joining the container's namespace.

7 years agobuild-sys: build bus-driverd if kdbus support is enabled
Lennart Poettering [Tue, 17 Dec 2013 00:36:59 +0000 (01:36 +0100)]
build-sys: build bus-driverd if kdbus support is enabled