smack: never follow symlinks when relabelling

previously mac_smack_apply(path, NULL) would operate on the symlink
itself while mac_smack_apply(path, "foo") would follow the symlink.
Let's clean this up an always operate on the symlink, which appears to
be the safer option.

diff --git a/src/shared/smack-util.c b/src/shared/smack-util.c
index 4a94922a4309e8e33a5db744dae09838a222c735..c345488d2ed99f89afa6b5f01207514e76c59ca2 100644 (file)
--- a/src/shared/smack-util.c
+++ b/src/shared/smack-util.c
@@ -50,7 +50,7 @@ int mac_smack_apply(const char *path, const char *label) {
                 return 0;
 
         if (label)
                 return 0;
 
         if (label)

-                r = setxattr(path, "security.SMACK64", label, strlen(label), 0);
+                r = lsetxattr(path, "security.SMACK64", label, strlen(label), 0);

         else
                 r = lremovexattr(path, "security.SMACK64");
         if (r < 0)
         else
                 r = lremovexattr(path, "security.SMACK64");
         if (r < 0)