logind: order all scopes after both systemd-logind.service and

systemd-user-sessions.service

This way at shutdown we can be sure that the sessions go away before the
network.

diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c
index 28b5cd49a7a07bd497e522808814a704c0c1f9c3..30476f3ea4455a8f9d9ed7d376e066768d775b8f 100644 (file)
--- a/src/login/logind-dbus.c
+++ b/src/login/logind-dbus.c
@@ -2178,7 +2178,7 @@ int manager_start_scope(
                 pid_t pid,
                 const char *slice,
                 const char *description,
                 pid_t pid,
                 const char *slice,
                 const char *description,

-                const char *after,
+                const char *after, const char *after2,

                 sd_bus_error *error,
                 char **job) {
 
                 sd_bus_error *error,
                 char **job) {
 


@@ -2219,12 +2219,18 @@ int manager_start_scope(
                         return r;
         }
 
                         return r;
         }
 

-        if (!isempty(description)) {
+        if (!isempty(after)) {

                 r = sd_bus_message_append(m, "(sv)", "After", "as", 1, after);
                 if (r < 0)
                         return r;
         }
 
                 r = sd_bus_message_append(m, "(sv)", "After", "as", 1, after);
                 if (r < 0)
                         return r;
         }
 

+        if (!isempty(after2)) {
+                r = sd_bus_message_append(m, "(sv)", "After", "as", 1, after2);
+                if (r < 0)
+                        return r;
+        }
+

         /* cgroup empty notification is not available in containers
          * currently. To make this less problematic, let's shorten the
          * stop timeout for sessions, so that we don't wait
         /* cgroup empty notification is not available in containers
          * currently. To make this less problematic, let's shorten the
          * stop timeout for sessions, so that we don't wait

diff --git a/src/login/logind-session.c b/src/login/logind-session.c
index 95105e5325810a3c976a23022f54207f15fdc0a4..f661cc8b8d2aa1720b70bf6b349348b93b9b8239 100644 (file)
--- a/src/login/logind-session.c
+++ b/src/login/logind-session.c
@@ -490,7 +490,7 @@ static int session_start_scope(Session *s) {
                 if (!scope)
                         return log_oom();
 
                 if (!scope)
                         return log_oom();
 

-                r = manager_start_scope(s->manager, scope, s->leader, s->user->slice, description, "systemd-logind.service", &error, &job);
+                r = manager_start_scope(s->manager, scope, s->leader, s->user->slice, description, "systemd-logind.service", "systemd-user-session.service", &error, &job);

                 if (r < 0) {
                         log_error("Failed to start session scope %s: %s %s",
                                   scope, bus_error_message(&error, r), error.name);
                 if (r < 0) {
                         log_error("Failed to start session scope %s: %s %s",
                                   scope, bus_error_message(&error, r), error.name);

diff --git a/src/login/logind.h b/src/login/logind.h
index c1a5b6a80f901d384306d0be75bbd60c50673562..0bf52daeb1a21cd100405ecaae3f35e40ec5d290 100644 (file)
--- a/src/login/logind.h
+++ b/src/login/logind.h
@@ -162,7 +162,7 @@ int manager_send_changed(Manager *manager, const char *property, ...) _sentinel_
 
 int manager_dispatch_delayed(Manager *manager);
 
 
 int manager_dispatch_delayed(Manager *manager);
 

-int manager_start_scope(Manager *manager, const char *scope, pid_t pid, const char *slice, const char *description, const char *after, sd_bus_error *error, char **job);
+int manager_start_scope(Manager *manager, const char *scope, pid_t pid, const char *slice, const char *description, const char *after, const char *after2, sd_bus_error *error, char **job);

 int manager_start_unit(Manager *manager, const char *unit, sd_bus_error *error, char **job);
 int manager_stop_unit(Manager *manager, const char *unit, sd_bus_error *error, char **job);
 int manager_abandon_scope(Manager *manager, const char *scope, sd_bus_error *error);
 int manager_start_unit(Manager *manager, const char *unit, sd_bus_error *error, char **job);
 int manager_stop_unit(Manager *manager, const char *unit, sd_bus_error *error, char **job);
 int manager_abandon_scope(Manager *manager, const char *scope, sd_bus_error *error);