logind: write rules files atomically

diff --git a/TODO b/TODO
index f494b05059b923922a2c86a207d280ffbd062746..3908311cd272f1391df021716334c12ee9b3ee8f 100644 (file)
--- a/TODO
+++ b/TODO
@@ -25,19 +25,14 @@ Features:
 
 * kernel: add /proc/sys file exposing CAP_LAST_CAP?
 
-* understand https://bugzilla.redhat.com/show_bug.cgi?id=672194
-
-* possibly set timezone offset from systemd at init instead
-  of calling hwclock
-
 * kernel: add device_type = "fb", "fbcon" to class "graphics"
 
+* understand https://bugzilla.redhat.com/show_bug.cgi?id=672194
+
 * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG ioctl, with START_IO
 
 * readahead: check whether a btrfs volume includes ssd by checking mount flag "ssd"
 
-* hostnamed: make file updates atomic
-
 * support sd_notify() style notificatio when reload is finished (RELOADED=1)
 
 * verify that the AF_UNIX sockets of a service in the fs still exist

diff --git a/src/logind-dbus.c b/src/logind-dbus.c
index 96216e43a358eaf81374d72664e3d7f624939ca8..95bb07a432e733f0a475269898e1764bf6f87ec6 100644 (file)
--- a/src/logind-dbus.c
+++ b/src/logind-dbus.c
@@ -634,7 +634,7 @@ static int attach_device(Manager *m, const char *seat, const char *sysfs) {
         }
 
         mkdir_p("/etc/udev/rules.d", 0755);
-        r = write_one_line_file(file, rule);
+        r = write_one_line_file_atomic(file, rule);
         if (r < 0)
                 goto finish;