chiark / gitweb /
udev-builtin-keyboard: Fix large scan codes on 32 bit architectures
authorMartin Pitt <martinpitt@gnome.org>
Mon, 4 Nov 2013 06:25:45 +0000 (07:25 +0100)
committerMartin Pitt <martinpitt@gnome.org>
Mon, 4 Nov 2013 06:25:45 +0000 (07:25 +0100)
Use strtoul(), as scan codes are always positive. On 32 bit architectures
strtol gives wrong results:

  strtol("fffffff0", &endptr, 16)

returns 2147483647 instead of 4294967280.

https://launchpad.net/bugs/1247676

src/udev/udev-builtin-keyboard.c

index ddd853594e96cd3792805fe7c35282143fb60e05..8f457ab4a297af1f7effb1b0b47e285830f47531 100644 (file)
@@ -88,7 +88,7 @@ static int builtin_keyboard(struct udev_device *dev, int argc, char *argv[], boo
                         continue;
 
                 /* KEYBOARD_KEY_<hex scan code>=<key identifier string> */
-                scancode = strtol(key + 13, &endptr, 16);
+                scancode = strtoul(key + 13, &endptr, 16);
                 if (endptr[0] != '\0') {
                         log_error("Error, unable to parse scan code from '%s'\n", key);
                         continue;