systemctl: don't show cgroup field for a unit if cgroup is empty

diff --git a/src/shared/cgroup-show.c b/src/shared/cgroup-show.c
index 437d09711b947ff92219b84e50f7658310379e4d..2b79f370f92f27e003bc09ec85e469b5b5e2dff8 100644 (file)
--- a/src/shared/cgroup-show.c
+++ b/src/shared/cgroup-show.c
@@ -335,7 +335,7 @@ int show_cgroup_and_extra(const char *controller, const char *path, const char *
 
 int show_cgroup_and_extra_by_spec(const char *spec, const char *prefix, unsigned n_columns, bool kernel_threads, bool all, const pid_t extra_pids[], unsigned n_extra_pids) {
         int r;
 
 int show_cgroup_and_extra_by_spec(const char *spec, const char *prefix, unsigned n_columns, bool kernel_threads, bool all, const pid_t extra_pids[], unsigned n_extra_pids) {
         int r;

-        char *controller, *path;
+        _cleanup_free_ char *controller = NULL, *path = NULL;

 
         assert(spec);
 
 
         assert(spec);
 


@@ -343,9 +343,5 @@ int show_cgroup_and_extra_by_spec(const char *spec, const char *prefix, unsigned
         if (r < 0)
                 return r;
 
         if (r < 0)
                 return r;
 

-        r = show_cgroup_and_extra(controller, path, prefix, n_columns, kernel_threads, all, extra_pids, n_extra_pids);
-        free(controller);
-        free(path);
-
-        return r;
+        return show_cgroup_and_extra(controller, path, prefix, n_columns, kernel_threads, all, extra_pids, n_extra_pids);

 }
 }

diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c
index b0d378de5ade1e577a0c7f86cd7b294b3e0ec709..18cbf0412ab823ec5d9045c1b0ef2f8238857e71 100644 (file)
--- a/src/shared/cgroup-util.c
+++ b/src/shared/cgroup-util.c
@@ -934,6 +934,20 @@ int cg_is_empty(const char *controller, const char *path, bool ignore_self) {
         return !found;
 }
 
         return !found;
 }
 

+int cg_is_empty_by_spec(const char *spec, bool ignore_self) {
+        int r;
+        _cleanup_free_ char *controller = NULL, *path = NULL;
+
+        assert(spec);
+
+        r = cg_split_spec(spec, &controller, &path);
+        if (r < 0)
+                return r;
+
+        return cg_is_empty(controller, path, ignore_self);
+}
+
+

 int cg_is_empty_recursive(const char *controller, const char *path, bool ignore_self) {
         int r;
         DIR *d = NULL;
 int cg_is_empty_recursive(const char *controller, const char *path, bool ignore_self) {
         int r;
         DIR *d = NULL;

diff --git a/src/shared/cgroup-util.h b/src/shared/cgroup-util.h
index 697669deba2065fd24faa401d5157106d8c8f15b..af2efc39b438b37eed28496dbc3b5194575900ee 100644 (file)
--- a/src/shared/cgroup-util.h
+++ b/src/shared/cgroup-util.h
@@ -65,6 +65,7 @@ int cg_set_task_access(const char *controller, const char *path, mode_t mode, ui
 int cg_install_release_agent(const char *controller, const char *agent);
 
 int cg_is_empty(const char *controller, const char *path, bool ignore_self);
 int cg_install_release_agent(const char *controller, const char *agent);
 
 int cg_is_empty(const char *controller, const char *path, bool ignore_self);

+int cg_is_empty_by_spec(const char *spec, bool ignore_self);

 int cg_is_empty_recursive(const char *controller, const char *path, bool ignore_self);
 
 int cg_get_user_path(char **path);
 int cg_is_empty_recursive(const char *controller, const char *path, bool ignore_self);
 
 int cg_get_user_path(char **path);

diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index 3abd7dc2e16c5ec80494d998ec08c13a0861dfc8..876e782e7dc83b886df0ebde27a8b26633f73d5c 100644 (file)
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -2265,7 +2265,8 @@ static void print_status_info(UnitStatusInfo *i) {
         if (i->status_text)
                 printf("\t  Status: \"%s\"\n", i->status_text);
 
         if (i->status_text)
                 printf("\t  Status: \"%s\"\n", i->status_text);
 

-        if (i->default_control_group) {
+        if (i->default_control_group &&
+            (i->main_pid > 0 || i->control_pid > 0 || cg_is_empty_by_spec(i->default_control_group, false) == 0)) {

                 unsigned c;
 
                 printf("\t  CGroup: %s\n", i->default_control_group);
                 unsigned c;
 
                 printf("\t  CGroup: %s\n", i->default_control_group);