chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
dbfd41e
)
CODING_STYLE: don't clobber arguments on failure
author
Lennart Poettering
<lennart@poettering.net>
Mon, 27 Oct 2014 17:09:07 +0000
(18:09 +0100)
committer
Lennart Poettering
<lennart@poettering.net>
Mon, 27 Oct 2014 17:09:26 +0000
(18:09 +0100)
CODING_STYLE
patch
|
blob
|
history
diff --git
a/CODING_STYLE
b/CODING_STYLE
index 598d241b2baa048c1bc18644ade20ea9dcfb3d49..4439ee6099abb707a4114a8b32b7e94608a75cea 100644
(file)
--- a/
CODING_STYLE
+++ b/
CODING_STYLE
@@
-182,7
+182,11
@@
is_main_thread() to detect whether the calling thread is the main
thread.
is_main_thread() to detect whether the calling thread is the main
thread.
--
O
ption parsing:
+-
Command line o
ption parsing:
- Do not print full help() on error, be specific about the error.
- Do not print messages to stdout on error.
- Do not POSIX_ME_HARDER unless necessary, i.e. avoid "+" in option string.
- Do not print full help() on error, be specific about the error.
- Do not print messages to stdout on error.
- Do not POSIX_ME_HARDER unless necessary, i.e. avoid "+" in option string.
+
+- Do not write functions that clobber call-by-reference variables on
+ failure. Use temporary variables for these cases and change the
+ passed in variables only on success.