chiark / gitweb /
journal: fix Inappropriate ioctl for device on ext4
authorCristian Rodríguez <crrodriguez@opensuse.org>
Mon, 2 Mar 2015 00:13:10 +0000 (21:13 -0300)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 2 Mar 2015 15:54:19 +0000 (10:54 -0500)
Logs constantly show

systemd-journald[395]: Failed to set file attributes: Inappropriate ioctl for device

This is because ext4 does not support FS_NOCOW_FL.

[zj: fold into one conditional as suggested on the ML and
     fix (preexisting) r/errno confusion in error message.]

src/journal/journal-file.c

index 9c9a5483be550b84cf6095bc0850e40dbe283be5..0e33a0fd873e7562a640d50246bb0c9e9e169603 100644 (file)
@@ -2609,8 +2609,8 @@ int journal_file_open(
                  * shouldn't be too bad, given that we do our own
                  * checksumming). */
                 r = chattr_fd(f->fd, true, FS_NOCOW_FL);
-                if (r < 0)
-                        log_warning_errno(errno, "Failed to set file attributes: %m");
+                if (r < 0 && r != -ENOTTY)
+                        log_warning_errno(r, "Failed to set file attributes: %m");
 
                 /* Let's attach the creation time to the journal file,
                  * so that the vacuuming code knows the age of this