chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (from parent 1:
03785ad
)
CODING_STYLE: clarify that single-line if blocks should not be enclosed in {}
author
Lennart Poettering
<lennart@poettering.net>
Wed, 22 Oct 2014 09:09:00 +0000
(11:09 +0200)
committer
Lennart Poettering
<lennart@poettering.net>
Wed, 22 Oct 2014 09:45:12 +0000
(11:45 +0200)
CODING_STYLE
patch
|
blob
|
history
diff --git
a/CODING_STYLE
b/CODING_STYLE
index 05b5ecf89f32835e0ed1b6ee3463c035b5a8e4aa..598d241b2baa048c1bc18644ade20ea9dcfb3d49 100644
(file)
--- a/
CODING_STYLE
+++ b/
CODING_STYLE
@@
-18,7
+18,7
@@
- For robustness reasons, destructors should be able to destruct
half-initialized objects, too
- For robustness reasons, destructors should be able to destruct
half-initialized objects, too
-- Error codes are returned as negative Exxx.
i.e
. return -EINVAL. There
+- Error codes are returned as negative Exxx.
e.g
. return -EINVAL. There
are some exceptions: for constructors, it is OK to return NULL on
OOM. For lookup functions, NULL is fine too for "not found".
are some exceptions: for constructors, it is OK to return NULL on
OOM. For lookup functions, NULL is fine too for "not found".
@@
-57,7
+57,7
@@
doing something wrong!
- Stay uniform. For example, always use "usec_t" for time
doing something wrong!
- Stay uniform. For example, always use "usec_t" for time
- values. Do not
usec mix
msec, and usec and whatnot.
+ values. Do not
mix usec and
msec, and usec and whatnot.
- Make use of _cleanup_free_ and friends. It makes your code much
nicer to read!
- Make use of _cleanup_free_ and friends. It makes your code much
nicer to read!
@@
-79,6
+79,17
@@
But it is OK if you do not.
But it is OK if you do not.
+- Single-line "if" blocks should not be enclosed in {}. Use this:
+
+ if (foobar)
+ waldo();
+
+ instead of this:
+
+ if (foobar) {
+ waldo();
+ }
+
- Do not write "foo ()", write "foo()".
- Please use streq() and strneq() instead of strcmp(), strncmp() where applicable.
- Do not write "foo ()", write "foo()".
- Please use streq() and strneq() instead of strcmp(), strncmp() where applicable.