Revert some uses of xsprintf

This reverts some changes introduced in d054f0a4d4.
xsprintf should be used in cases where we calculated the right buffer
size by hand (using DECIMAL_STRING_MAX and such), and never in cases where
we are printing externally specified strings of arbitrary length.

Fixes #4534.

diff --git a/src/basic/log.c b/src/basic/log.c
index 321c1bd20ee62ee1f79021651bc1671fa1c12e45..d84c9bf116b43c88d239079663e4e9f3ed235385 100644 (file)
--- a/src/basic/log.c
+++ b/src/basic/log.c
@@ -798,7 +798,7 @@ static void log_assert(
                 return;
 
         DISABLE_WARNING_FORMAT_NONLITERAL;
-        xsprintf(buffer, format, text, file, line, func);
+        snprintf(buffer, sizeof buffer, format, text, file, line, func);
         REENABLE_WARNING;
 
         log_abort_msg = buffer;