chiark / gitweb /
test-compress: make sure asserts with side effects use assert_se()
authorFilipe Brandenburger <filbranden@google.com>
Tue, 26 Aug 2014 05:05:02 +0000 (22:05 -0700)
committerLennart Poettering <lennart@poettering.net>
Tue, 26 Aug 2014 18:31:27 +0000 (20:31 +0200)
Otherwise the test fails when built with CPPFLAGS='-DNDEBUG' which disables
assertions.

Tested:
- make check TESTS='test-compress' CPPFLAGS='-DNDEBUG'

src/journal/test-compress.c

index f5f5f8df39022008a0129f204f7e4d10390a3a8d..026d630ac2a851d5cae400eaf89c9b3a4c99446a 100644 (file)
@@ -145,11 +145,11 @@ static void test_compress_stream(int compression,
 
         assert_se((dst = mkostemp_safe(pattern, O_RDWR|O_CLOEXEC)) >= 0);
 
-        assert(compress(src, dst, -1) == 0);
+        assert_se(compress(src, dst, -1) == 0);
 
         if (cat) {
                 assert_se(asprintf(&cmd, "%s %s | diff %s -", cat, pattern, srcfile) > 0);
-                assert(system(cmd) == 0);
+                assert_se(system(cmd) == 0);
         }
 
         log_debug("/* test decompression */");