git-debpush: use -m rather than -F- <<EOF

This means that a run with set -x shows the tag data that is being
signed.  The user can even then try it again.  It will make it easier
to do some kind of dry run, too, if we want to.

We are really not in danger of hitting a command line length limit.

(It also involves fewer syscalls, less use of /tmp etc., although that
is really irrelevant here.)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Acked-by: Sean Whitton <spwhitton@spwhitton.name>

diff --git a/git-debpush b/git-debpush
index 5b99e72abaad4e4880ba613c796554420513aad3..744212af17cd0dae568caab5d9ff44784f48a32c 100755 (executable)
--- a/git-debpush
+++ b/git-debpush
@@ -393,12 +393,13 @@ if [ "$format" = "3.0 (quilt)" ]; then
     fi
 fi
 
-git tag "${git_tag_opts[@]}" -s -F- "$debian_tag" "$branch" <<EOF
-$source release $version for $target
+tagmessage="$source release $version for $target
 
 [dgit distro=$distro split$quilt_mode_text]
 [dgit please-upload$upstream_info]
-EOF
+"
+
+git tag "${git_tag_opts[@]}" -s -m "$tagmessage" "$debian_tag" "$branch"
 
 # **** Do a git push ****