test suite: protocol-compat: Even more solid checks

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

diff --git a/tests/tests/protocol-compat b/tests/tests/protocol-compat
index b1b902549fa9238a6a5a53c8ef432600dceee080..fc3960a8f9db5b467770b7908eb79e3af77f8809 100755 (executable)
--- a/tests/tests/protocol-compat
+++ b/tests/tests/protocol-compat
@@ -11,14 +11,14 @@ prep () {
 }
 
 check () {
-       rm -rf $p.cloned
+       pd=$p.$suite
        t-refs-same-start
 
        t-archive-none $p
        t-archive-query $suite
 
-       t-dgit clone $p $suite $p.cloned
-       cd $p.cloned
+       t-dgit clone $p $suite $pd
+       cd $pd
        t-ref-head
 
        $1
@@ -30,9 +30,9 @@ check () {
 
 reset () {
        cd ..
-       rm -rf $p.cloned
-       mkdir $p.cloned
-       cd $p.cloned
+       rm -rf $pd
+       mkdir $pd
+       cd $pd
        git init
 }
 
@@ -54,7 +54,7 @@ prep
 
 perl -i~ -pe 's/^(Dgit: \w+ \S+ \S+) (.*)/$1\n $2 EXTRA/' $dscf
 
-check
+check reset
 
 : ---------- older ----------
 
@@ -68,4 +68,14 @@ t-git-config dgit.default.old-dsc-distro test-dummy
 
 check
 
+: ---------- expect fail ----------
+
+pd=$p.fail
+
+t-git-config dgit.default.old-dsc-distro downstream
+
+t-expect-fail 'no configured url and .dsc provides no hint' \
+t-dgit clone $p $suite $pd
+
+
 t-ok